This release will not be complete as long as the cordova-ios-4.x board
has issues. The only major issue is the plugin building stuff plus
docs.
The removal was projected for some time - you might not have
remembered the discussions in JIRA. NSData+Base64 are "Categories" in
Objective-C parlance. T
Where are we with this release?
Alexander Sorokin did some analysis on plugin build failures because of this
ios-4.0-dev and there are quite a few.
This spreadsheet summarizes the build failures with the build log in a comment:
https://docs.google.com/spreadsheets/d/1sm8ioXY21z3RdyqT7J9n1Q_hmm9
Github user conx2share commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/30#issuecomment-149753080
Wow, this is pretty old.
You can see what the changes were, how about just adding them as a new
feature?
---
If your project is set up for it, yo
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/397#issuecomment-149752013
Merged. Thanks for the PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/397
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/393#issuecomment-149751811
Merged. Thanks for the PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/393
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
It got checked in earlier this morning.
-Nikhil
-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com]
Sent: Tuesday, October 20, 2015 2:34 PM
To: dev
Subject: Re: [Discuss] Cordova-common release
So, when did the PlatformAPI change land in Android?
On Tue, Oct 20, 2015 at 2:3
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/115
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/381#issuecomment-149746239
Friendly ping @bgashler1. Please close the PR when you have a moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/379#issuecomment-149746069
Friendly ping @csantanapr. Please close the PR when you have a moment.
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/369#issuecomment-149745437
Friendly ping @AnabellaGenuitec. Please close this PR when you have a
moment.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user dblotsky closed the pull request at:
https://github.com/apache/cordova-docs/pull/394
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dblotsky closed the pull request at:
https://github.com/apache/cordova-docs/pull/396
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/102#issuecomment-149738253
*bump*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/327#issuecomment-149737583
Thanks for taking a look, @vladimir-kotikov.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/113
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/138
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/140
CB-9331 getFreeDiskSpace iOS.
Close #125 Close #138
Fixes iOS native only implementation. And clean up PRs
You can merge this pull request into a Git repository by running:
Github user mleoking commented on the pull request:
https://github.com/apache/cordova-android/pull/219#issuecomment-149733109
@nikhilkh I created this patch because the ionic framework by default
download this branch (Android 4.1.x) of cordova when adding the android
platform.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/327#issuecomment-149728218
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42565419
--- Diff: cordova-serve/src/browser.js ---
@@ -95,16 +105,93 @@ function getBrowser(target, dataDir) {
'firefox': 'firefox',
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42565322
--- Diff: cordova-serve/src/browser.js ---
@@ -95,16 +105,93 @@ function getBrowser(target, dataDir) {
'firefox': 'firefox',
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42564896
--- Diff: cordova-serve/src/browser.js ---
@@ -95,16 +105,93 @@ function getBrowser(target, dataDir) {
'firefox': 'firefox',
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42564428
--- Diff: cordova-serve/src/browser.js ---
@@ -95,16 +105,93 @@ function getBrowser(target, dataDir) {
'firefox': 'firefox',
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/395
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42562761
--- Diff: cordova-serve/src/browser.js ---
@@ -17,9 +17,15 @@
under the License.
*/
-var exec = require('./exec'),
+var child_
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42561832
--- Diff: cordova-serve/src/browser.js ---
@@ -72,7 +79,10 @@ module.exports = function (opts) {
args.push(url);
}
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/327#discussion_r42561198
--- Diff: cordova-serve/src/browser.js ---
@@ -17,9 +17,15 @@
under the License.
*/
-var exec = require('./exec'),
+var
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/327
On Windows, verify browsers installed before launching.
Do this to avoid dialog that pops up on Windows if browser is not
installed, and provide more meaningful error messages.
You can merge
So, when did the PlatformAPI change land in Android?
On Tue, Oct 20, 2015 at 2:32 PM, Parashuram N
wrote:
> +1 - YES please. Requiring cordoba-common for my
> react-native-cordova-plugin adapter was a nightmare !!
>
>
>
>
> On 10/20/15, 2:23 PM, "Nikhil Khandelwal" wrote:
>
> >+1 to publishing
+1 - YES please. Requiring cordoba-common for my react-native-cordova-plugin
adapter was a nightmare !!
On 10/20/15, 2:23 PM, "Nikhil Khandelwal" wrote:
>+1 to publishing cordova-common to npm.
>
>-Nikhil
>
>-Original Message-
>From: Steven Gill [mailto:stevengil...@gmail.com]
>Se
+1 to publishing cordova-common to npm.
-Nikhil
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Tuesday, October 20, 2015 2:20 PM
To: dev@cordova.apache.org
Subject: Re: [Discuss] Cordova-common release
I want to revisit this.
So cordova-android has a depend
I want to revisit this.
So cordova-android has a dependency now on cordova-common. It is a
bundledDependency so when we generate a tar to release cordova-android, it
will be included. It will also be in the cordova-android package that gets
downloaded with cordova platform add.
This is fine for r
Joe, do you have a small example of what could break with this change. What
is a usecase for someone to reference CordovaWebView
On Tue, Oct 20, 2015 at 1:38 PM, Joe Bowser wrote:
> I'll pull this in at the end of the day. This small change may break stuff
> further down the road, so people sho
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/310
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
I'll pull this in at the end of the day. This small change may break stuff
further down the road, so people should comment on it now.
On Tue, Oct 20, 2015 at 1:37 PM, Joe Bowser wrote:
> OK, Going to pull this in.
>
> On Tue, Oct 20, 2015 at 10:02 AM, Simon MacDonald <
> simon.macdon...@gmail.c
OK, Going to pull this in.
On Tue, Oct 20, 2015 at 10:02 AM, Simon MacDonald wrote:
> +1 from me as I'm the one that initiated the PR.
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
> On Tue, Oct 20, 2015 at 12:23 PM, Darryl Pogue wrote:
>
> > +1 for doing this with the major version bump
Github user vksee closed the pull request at:
https://github.com/apache/cordova-android/pull/210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chaffeqa commented on the pull request:
https://github.com/apache/cordova-android/pull/223#issuecomment-149679498
:+1: thanks a ton @infil00p !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user shazron commented on the pull request:
https://github.com/apache/cordova-coho/pull/97#issuecomment-149657297
Thanks Nikhil for writing the doc.
I'm still not too sure what the difference between Blocker and Critical is,
and I'm sure most ppl triaging will have that
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/123#issuecomment-149647416
@rakatyal Can you please take a look at this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/208#issuecomment-149642770
@vladimir-kotikov Can you please review - as we look to do a new release -
does this change need to be included?
---
If your project is set up for it, you can
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/219#issuecomment-149642614
We do not plan to make a release to Android 4.1.x. I do not see much point
in merging this.
---
If your project is set up for it, you can reply to this email
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/210#issuecomment-149642249
@vladimir-kotikov Looks like your refactor made this PR irrevelant. Does
your new code handle this correctly?
---
If your project is set up for it, you can re
+1 from me as I'm the one that initiated the PR.
Simon Mac Donald
http://hi.im/simonmacdonald
On Tue, Oct 20, 2015 at 12:23 PM, Darryl Pogue wrote:
> +1 for doing this with the major version bump
>
> On 20 October 2015 at 09:15, Joe Bowser wrote:
>
> > Hey
> >
> > We're close to getting 5.0.x
Hey
I would like to release Cordova-Android 5.0.x soon so that I can then move
on to releasing each of the plugins that depend on it so we can get ready
to release a CLI version by the end of the year. Is there anything that's
currently blocking us from doing this other than minor class name chan
I've added my feedback at the pull request. I do think that 2 days is too
soon to close something, since I can close almost all the current issues on
JIRA if that was the case.
On Tue, Oct 20, 2015 at 9:12 AM, Nikhil Khandelwal
wrote:
> I am fine with all these recommendations. The key is to be
+1 for doing this with the major version bump
On 20 October 2015 at 09:15, Joe Bowser wrote:
> Hey
>
> We're close to getting 5.0.x ready for release, but I want to add one more
> pull request:
>
> https://github.com/apache/cordova-android/pull/227
>
> This is a trivial pull request, but I want
Hey
We're close to getting 5.0.x ready for release, but I want to add one more
pull request:
https://github.com/apache/cordova-android/pull/227
This is a trivial pull request, but I want to get buy-in from the list for
doing the rename for CordovaWebView class to be changed before we start
depre
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/223#issuecomment-149619074
I rebased this into the repository, closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
I am fine with all these recommendations. The key is to be consistent. I have
documented this and more details here:
https://github.com/apache/cordova-coho/pull/97
Let's continue discussion on the PR or this thread. I don't want the process to
be heavy-weight - though my goal is to address few
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-android/pull/223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-coho/pull/97#issuecomment-149618878
@shazron @infil00p Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/97#discussion_r42516427
--- Diff: docs/jira-triage.md ---
@@ -0,0 +1,34 @@
+#JIRA Issue Triage Process
+
+##Goal
+Every issue needs to be triaged. A triaged iss
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-coho/pull/97
Adding docs around JIRA issue triage
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-coho jira-triage
Alternatively yo
GitHub user KSCooke opened a pull request:
https://github.com/apache/cordova-docs/pull/397
Small typo on line 100.
Line 100 read "The plugin commands are a mirror of the plugin commands" and
I think the second plugin commands was intended to be platform commands. Either
way it's tr
Github user alsorokin closed the pull request at:
https://github.com/apache/cordova-android/pull/229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-android/pull/229
CB-9831 Fixed test-build script not to remove symlinked 'cordova-commâ¦
â¦on' contents
This is a fix for https://issues.apache.org/jira/browse/CB-9831
You can merge this pull r
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Hey, guys.
After ios refactoring the handling definitely will be a part of
platform. As for tag, I guess it make sense to keep this logic in LIB
and let cordova itself check availability of cocoapods/nuget.
-
Best regards, Vladimir
-Original Message-
From: Steven Gill [mailto:steveng
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/226#issuecomment-149491153
@nikhilkh, those failures fixed in
https://github.com/apache/cordova-android/commit/789c505a88a6bd2c7c5be596908c85681e457132
and
https://github.com/MS
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/226
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-coho/pull/96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/228#issuecomment-149484583
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/320
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-android/pull/228
CB-9826 Fixed 'test-build' script on windows
https://issues.apache.org/jira/browse/CB-9826
You can merge this pull request into a Git repository by running:
$ git pull https://github
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/324
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user juspriet commented on the pull request:
https://github.com/apache/cordova-docs/pull/386#issuecomment-149459462
Hello ! Actually, i did ! But the two actions are uncorrelated, with two
different tickets. Sorry for that !
---
If your project is set up for it, you can reply
75 matches
Mail list logo