Re: [DISCUSS] cordova-ios 4.0.0 release

2015-10-20 Thread Shazron
This release will not be complete as long as the cordova-ios-4.x board has issues. The only major issue is the plugin building stuff plus docs. The removal was projected for some time - you might not have remembered the discussions in JIRA. NSData+Base64 are "Categories" in Objective-C parlance. T

RE: [DISCUSS] cordova-ios 4.0.0 release

2015-10-20 Thread Nikhil Khandelwal
Where are we with this release? Alexander Sorokin did some analysis on plugin build failures because of this ios-4.0-dev and there are quite a few. This spreadsheet summarizes the build failures with the build log in a comment: https://docs.google.com/spreadsheets/d/1sm8ioXY21z3RdyqT7J9n1Q_hmm9

[GitHub] cordova-plugin-dialogs pull request: Added option to specify the i...

2015-10-20 Thread conx2share
Github user conx2share commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/30#issuecomment-149753080 Wow, this is pretty old. You can see what the changes were, how about just adding them as a new feature? --- If your project is set up for it, yo

[GitHub] cordova-docs pull request: Small typo on line 100.

2015-10-20 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/397#issuecomment-149752013 Merged. Thanks for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cordova-docs pull request: Small typo on line 100.

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/397 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: updated Intel XDK image

2015-10-20 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/393#issuecomment-149751811 Merged. Thanks for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cordova-docs pull request: updated Intel XDK image

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/393 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

RE: [Discuss] Cordova-common release

2015-10-20 Thread Nikhil Khandelwal
It got checked in earlier this morning. -Nikhil -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Tuesday, October 20, 2015 2:34 PM To: dev Subject: Re: [Discuss] Cordova-common release So, when did the PlatformAPI change land in Android? On Tue, Oct 20, 2015 at 2:3

[GitHub] cordova-plugin-file pull request: CB-8968 fix readAsArrayBuffer by...

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-file pull request: Fixed bug with installation

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-file pull request: fix(ios): always use setters to ...

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-docs pull request: New

2015-10-20 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/381#issuecomment-149746239 Friendly ping @bgashler1. Please close the PR when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-docs pull request: Add ReactEurope App to Showcase

2015-10-20 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/379#issuecomment-149746069 Friendly ping @csantanapr. Please close the PR when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] cordova-docs pull request: GapDebug

2015-10-20 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/369#issuecomment-149745437 Friendly ping @AnabellaGenuitec. Please close this PR when you have a moment. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cordova-docs pull request: New Cordova Website and Docs - Merged

2015-10-20 Thread dblotsky
Github user dblotsky closed the pull request at: https://github.com/apache/cordova-docs/pull/394 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: New Cordova Website and Docs - Rebased

2015-10-20 Thread dblotsky
Github user dblotsky closed the pull request at: https://github.com/apache/cordova-docs/pull/396 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file pull request: CB-8554 Updated source to pass F...

2015-10-20 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/102#issuecomment-149738253 *bump* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: On Windows, verify browsers installed be...

2015-10-20 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/327#issuecomment-149737583 Thanks for taking a look, @vladimir-kotikov. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cordova-plugin-file pull request: fix install on amazon-fireos

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-file pull request: CB-9331 getFreeDiskSpace iOS.

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-file pull request: Fix for getFreeDiskSpace returni...

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-file pull request: CB-9331 cordova-plugin-file

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/125 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-file pull request: CB-9331 getFreeDiskSpace iOS.

2015-10-20 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-file/pull/140 CB-9331 getFreeDiskSpace iOS. Close #125 Close #138 Fixes iOS native only implementation. And clean up PRs You can merge this pull request into a Git repository by running:

[GitHub] cordova-android pull request: Fixed CB-9697 Cordova emulate for An...

2015-10-20 Thread mleoking
Github user mleoking commented on the pull request: https://github.com/apache/cordova-android/pull/219#issuecomment-149733109 @nikhilkh I created this patch because the ionic framework by default download this branch (Android 4.1.x) of cordova when adding the android platform.

[GitHub] cordova-plugin-file pull request: add JIRA issue tracker link

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-lib pull request: On Windows, verify browsers installed be...

2015-10-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/327#issuecomment-149728218 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cordova-lib pull request: On Windows, verify browsers installed be...

2015-10-20 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/327#discussion_r42565419 --- Diff: cordova-serve/src/browser.js --- @@ -95,16 +105,93 @@ function getBrowser(target, dataDir) { 'firefox': 'firefox',

[GitHub] cordova-lib pull request: On Windows, verify browsers installed be...

2015-10-20 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/327#discussion_r42565322 --- Diff: cordova-serve/src/browser.js --- @@ -95,16 +105,93 @@ function getBrowser(target, dataDir) { 'firefox': 'firefox',

[GitHub] cordova-lib pull request: On Windows, verify browsers installed be...

2015-10-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/327#discussion_r42564896 --- Diff: cordova-serve/src/browser.js --- @@ -95,16 +105,93 @@ function getBrowser(target, dataDir) { 'firefox': 'firefox',

[GitHub] cordova-lib pull request: On Windows, verify browsers installed be...

2015-10-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/327#discussion_r42564428 --- Diff: cordova-serve/src/browser.js --- @@ -95,16 +105,93 @@ function getBrowser(target, dataDir) { 'firefox': 'firefox',

[GitHub] cordova-docs pull request: New Cordova Website and Docs - Rewritte...

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/395 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-lib pull request: On Windows, verify browsers installed be...

2015-10-20 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/327#discussion_r42562761 --- Diff: cordova-serve/src/browser.js --- @@ -17,9 +17,15 @@ under the License. */ -var exec = require('./exec'), +var child_

[GitHub] cordova-lib pull request: On Windows, verify browsers installed be...

2015-10-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/327#discussion_r42561832 --- Diff: cordova-serve/src/browser.js --- @@ -72,7 +79,10 @@ module.exports = function (opts) { args.push(url); }

[GitHub] cordova-lib pull request: On Windows, verify browsers installed be...

2015-10-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/327#discussion_r42561198 --- Diff: cordova-serve/src/browser.js --- @@ -17,9 +17,15 @@ under the License. */ -var exec = require('./exec'), +var

[GitHub] cordova-lib pull request: On Windows, verify browsers installed be...

2015-10-20 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/327 On Windows, verify browsers installed before launching. Do this to avoid dialog that pops up on Windows if browser is not installed, and provide more meaningful error messages. You can merge

Re: [Discuss] Cordova-common release

2015-10-20 Thread Joe Bowser
So, when did the PlatformAPI change land in Android? On Tue, Oct 20, 2015 at 2:32 PM, Parashuram N wrote: > +1 - YES please. Requiring cordoba-common for my > react-native-cordova-plugin adapter was a nightmare !! > > > > > On 10/20/15, 2:23 PM, "Nikhil Khandelwal" wrote: > > >+1 to publishing

Re: [Discuss] Cordova-common release

2015-10-20 Thread Parashuram N
+1 - YES please. Requiring cordoba-common for my react-native-cordova-plugin adapter was a nightmare !! On 10/20/15, 2:23 PM, "Nikhil Khandelwal" wrote: >+1 to publishing cordova-common to npm. > >-Nikhil > >-Original Message- >From: Steven Gill [mailto:stevengil...@gmail.com] >Se

RE: [Discuss] Cordova-common release

2015-10-20 Thread Nikhil Khandelwal
+1 to publishing cordova-common to npm. -Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, October 20, 2015 2:20 PM To: dev@cordova.apache.org Subject: Re: [Discuss] Cordova-common release I want to revisit this. So cordova-android has a depend

Re: [Discuss] Cordova-common release

2015-10-20 Thread Steven Gill
I want to revisit this. So cordova-android has a dependency now on cordova-common. It is a bundledDependency so when we generate a tar to release cordova-android, it will be included. It will also be in the cordova-android package that gets downloaded with cordova platform add. This is fine for r

Re: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface

2015-10-20 Thread Steven Gill
Joe, do you have a small example of what could break with this change. What is a usecase for someone to reference CordovaWebView On Tue, Oct 20, 2015 at 1:38 PM, Joe Bowser wrote: > I'll pull this in at the end of the day. This small change may break stuff > further down the road, so people sho

[GitHub] cordova-lib pull request: CB-9675 OSX App Icons are not properly c...

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/310 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface

2015-10-20 Thread Joe Bowser
I'll pull this in at the end of the day. This small change may break stuff further down the road, so people should comment on it now. On Tue, Oct 20, 2015 at 1:37 PM, Joe Bowser wrote: > OK, Going to pull this in. > > On Tue, Oct 20, 2015 at 10:02 AM, Simon MacDonald < > simon.macdon...@gmail.c

Re: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface

2015-10-20 Thread Joe Bowser
OK, Going to pull this in. On Tue, Oct 20, 2015 at 10:02 AM, Simon MacDonald wrote: > +1 from me as I'm the one that initiated the PR. > > Simon Mac Donald > http://hi.im/simonmacdonald > > On Tue, Oct 20, 2015 at 12:23 PM, Darryl Pogue wrote: > > > +1 for doing this with the major version bump

[GitHub] cordova-android pull request: CB-9577 Quoted specific device name ...

2015-10-20 Thread vksee
Github user vksee closed the pull request at: https://github.com/apache/cordova-android/pull/210 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-android pull request: Cordova-Android 5.0/Marshmallow Upda...

2015-10-20 Thread chaffeqa
Github user chaffeqa commented on the pull request: https://github.com/apache/cordova-android/pull/223#issuecomment-149679498 :+1: thanks a ton @infil00p ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-coho pull request: Adding docs around JIRA issue triage

2015-10-20 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-coho/pull/97#issuecomment-149657297 Thanks Nikhil for writing the doc. I'm still not too sure what the difference between Blocker and Critical is, and I'm sure most ppl triaging will have that

[GitHub] cordova-windows pull request: CB-9565: Build failure for Windows 1...

2015-10-20 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/123#issuecomment-149647416 @rakatyal Can you please take a look at this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cordova-android pull request: CB-9519 Fix the engine destruction b...

2015-10-20 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/208#issuecomment-149642770 @vladimir-kotikov Can you please review - as we look to do a new release - does this change need to be included? --- If your project is set up for it, you can

[GitHub] cordova-android pull request: Fixed CB-9697 Cordova emulate for An...

2015-10-20 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/219#issuecomment-149642614 We do not plan to make a release to Android 4.1.x. I do not see much point in merging this. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-android pull request: CB-9577 Quoted specific device name ...

2015-10-20 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/210#issuecomment-149642249 @vladimir-kotikov Looks like your refactor made this PR irrevelant. Does your new code handle this correctly? --- If your project is set up for it, you can re

Re: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface

2015-10-20 Thread Simon MacDonald
+1 from me as I'm the one that initiated the PR. Simon Mac Donald http://hi.im/simonmacdonald On Tue, Oct 20, 2015 at 12:23 PM, Darryl Pogue wrote: > +1 for doing this with the major version bump > > On 20 October 2015 at 09:15, Joe Bowser wrote: > > > Hey > > > > We're close to getting 5.0.x

[DISCUSS] Cordova-Android 5.0.x

2015-10-20 Thread Joe Bowser
Hey I would like to release Cordova-Android 5.0.x soon so that I can then move on to releasing each of the plugins that depend on it so we can get ready to release a CLI version by the end of the year. Is there anything that's currently blocking us from doing this other than minor class name chan

Re: [DISCUSS] Jira triage

2015-10-20 Thread Joe Bowser
I've added my feedback at the pull request. I do think that 2 days is too soon to close something, since I can close almost all the current issues on JIRA if that was the case. On Tue, Oct 20, 2015 at 9:12 AM, Nikhil Khandelwal wrote: > I am fine with all these recommendations. The key is to be

Re: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface

2015-10-20 Thread Darryl Pogue
+1 for doing this with the major version bump On 20 October 2015 at 09:15, Joe Bowser wrote: > Hey > > We're close to getting 5.0.x ready for release, but I want to add one more > pull request: > > https://github.com/apache/cordova-android/pull/227 > > This is a trivial pull request, but I want

[Android][Discuss] Change name of CordovaWebView to CordovaWebInterface

2015-10-20 Thread Joe Bowser
Hey We're close to getting 5.0.x ready for release, but I want to add one more pull request: https://github.com/apache/cordova-android/pull/227 This is a trivial pull request, but I want to get buy-in from the list for doing the rename for CordovaWebView class to be changed before we start depre

[GitHub] cordova-android pull request: Cordova-Android 5.0/Marshmallow Upda...

2015-10-20 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/223#issuecomment-149619074 I rebased this into the repository, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

RE: [DISCUSS] Jira triage

2015-10-20 Thread Nikhil Khandelwal
I am fine with all these recommendations. The key is to be consistent. I have documented this and more details here: https://github.com/apache/cordova-coho/pull/97 Let's continue discussion on the PR or this thread. I don't want the process to be heavy-weight - though my goal is to address few

[GitHub] cordova-android pull request: Cordova-Android 5.0/Marshmallow Upda...

2015-10-20 Thread infil00p
Github user infil00p closed the pull request at: https://github.com/apache/cordova-android/pull/223 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cordova-coho pull request: Adding docs around JIRA issue triage

2015-10-20 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-coho/pull/97#issuecomment-149618878 @shazron @infil00p Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cordova-coho pull request: Adding docs around JIRA issue triage

2015-10-20 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/97#discussion_r42516427 --- Diff: docs/jira-triage.md --- @@ -0,0 +1,34 @@ +#JIRA Issue Triage Process + +##Goal +Every issue needs to be triaged. A triaged iss

[GitHub] cordova-coho pull request: Adding docs around JIRA issue triage

2015-10-20 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-coho/pull/97 Adding docs around JIRA issue triage You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-coho jira-triage Alternatively yo

[GitHub] cordova-docs pull request: Small typo on line 100.

2015-10-20 Thread KSCooke
GitHub user KSCooke opened a pull request: https://github.com/apache/cordova-docs/pull/397 Small typo on line 100. Line 100 read "The plugin commands are a mirror of the plugin commands" and I think the second plugin commands was intended to be platform commands. Either way it's tr

[GitHub] cordova-android pull request: CB-9831 Fixed test-build script not ...

2015-10-20 Thread alsorokin
Github user alsorokin closed the pull request at: https://github.com/apache/cordova-android/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cordova-android pull request: CB-9831 Fixed test-build script not ...

2015-10-20 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-android/pull/229 CB-9831 Fixed test-build script not to remove symlinked 'cordova-comm… …on' contents This is a fix for https://issues.apache.org/jira/browse/CB-9831 You can merge this pull r

[GitHub] cordova-lib pull request: CB-9758 Mobilespec crashes adding plugin...

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/318 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

RE: [DISCUSS] CocoaPods dependencies for iOS plugins

2015-10-20 Thread Vladimir Kotikov (Akvelon)
Hey, guys. After ios refactoring the handling definitely will be a part of platform. As for tag, I guess it make sense to keep this logic in LIB and let cordova itself check availability of cocoapods/nuget. - Best regards, Vladimir -Original Message- From: Steven Gill [mailto:steveng

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

2015-10-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/226#issuecomment-149491153 @nikhilkh, those failures fixed in https://github.com/apache/cordova-android/commit/789c505a88a6bd2c7c5be596908c85681e457132 and https://github.com/MS

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-coho pull request: CB-9782 Adds npm-link support for cordo...

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/96 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-android pull request: CB-9826 Fixed 'test-build' script on...

2015-10-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/228#issuecomment-149484583 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: CB-9782 Update create/update signatures ...

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/320 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-android pull request: CB-9826 Fixed 'test-build' script on...

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-android pull request: CB-9826 Fixed 'test-build' script on...

2015-10-20 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-android/pull/228 CB-9826 Fixed 'test-build' script on windows https://issues.apache.org/jira/browse/CB-9826 You can merge this pull request into a Git repository by running: $ git pull https://github

[GitHub] cordova-lib pull request: CB-9815 Engine name="cordova" should che...

2015-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/324 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-docs pull request: Ajout de popvox.png

2015-10-20 Thread juspriet
Github user juspriet commented on the pull request: https://github.com/apache/cordova-docs/pull/386#issuecomment-149459462 Hello ! Actually, i did ! But the two actions are uncorrelated, with two different tickets. Sorry for that ! --- If your project is set up for it, you can reply