Any more iOS experts can review my pull request?
2015-11-11 6:59 GMT+01:00 Steven Gill :
> Going to move forward with this tomorrow. Any holdups, let me know. Here or
> #plugins on slack.
>
> On Fri, Nov 6, 2015 at 2:51 PM, Richard Knoll
> wrote:
>
> > I plan on merging in
> > https://github.com
Github user daserge commented on the pull request:
https://github.com/apache/cordova-labs/pull/8#issuecomment-155693323
@shazron, could you please take a look?
This is required for
https://github.com/apache/cordova-plugin-file-transfer/pull/108
---
If your project is set up for
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155692488
Is this sufficient in the wkwebview plugin?
```
if(window.webkit && window.webkit.messageHandler) {
module.exports = iOSExec;
}
else {
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155689767
I'll fix that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user daserge closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/109#issuecomment-155681390
Moved the Windows code to #108, so closing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Sounds great
On Tue, Nov 10, 2015 at 10:04 PM, Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:
> Actionable items here IMO are:
> 1. Discuss initial list of error codes
> 2. Revisit code:
> a) Replace plain strings w/ CordovaError instance when we report
> failure
> b) Specify e
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/416
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Actionable items here IMO are:
1. Discuss initial list of error codes
2. Revisit code:
a) Replace plain strings w/ CordovaError instance when we report failure
b) Specify error codes according to list above when creating CordovaError
instances
Thx!
Sergey
-Original Message-
From:
Oh, ok. Glad that I didn’t step on anyone’s work. :) I’ll still make a point to
aim for an hour’s notice in the future.
Kindly,
Dmitry
> On Nov 10, 2015, at 9:54 PM, Steven Gill wrote:
>
> oh no worries. I think it was fine :). I don't think we generally need a
> lot of notice unless we are in
Going to move forward with this tomorrow. Any holdups, let me know. Here or
#plugins on slack.
On Fri, Nov 6, 2015 at 2:51 PM, Richard Knoll wrote:
> I plan on merging in
> https://github.com/apache/cordova-plugin-camera/pull/135 for the camera
> plugin if there are no objections.
>
> Thanks,
>
Cordova.raw which is used by CLI and other tools use promises which are
rejected w/ CordovaError [1] or just a string in case of error. So technically
we support error codes but I don't think we specify them in many places.
As per particular error codes,, the following list could be a good star
Put them up last night and made some fixes today.
http://cordova.apache.org/docs/en/5.4.0/index.html
oh no worries. I think it was fine :). I don't think we generally need a
lot of notice unless we are in the middle of releasing. Especially when it
is down for small periods of time.
On Tue, Nov 10, 2015 at 9:46 PM, Dmitry Blotsky
wrote:
> They’re back up now. Sorry that the notice was so short.
Hey folks,
Does the Cordova CLI have a meaningful status code and error description it
returns when various errors happen? Or do we only return 0/1 for
success/failure and then just print out some hopefully decipherable information
on stderr?
I know we have some effort in improving logging in
They’re back up now. Sorry that the notice was so short. :/ What’s a good
minimum notice?
Kindly,
Dmitry
> On Nov 10, 2015, at 9:42 PM, Steven Gill wrote:
>
> Sweet. Thanks for the notice.
>
> On Tue, Nov 10, 2015 at 7:04 PM, Dmitry Blotsky
> wrote:
>
>> Hey folks,
>>
>> I’m updating the b
Sweet. Thanks for the notice.
On Tue, Nov 10, 2015 at 7:04 PM, Dmitry Blotsky
wrote:
> Hey folks,
>
> I’m updating the build machines. They’ll be back up within the next two
> hours.
>
> Kindly,
> Dmitry
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/416#issuecomment-155662482
LGTM. Let's get this in asap
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
The Buildbot working for 'ASF Buildbot'
has noticed that the buildslave named cordova-osx-slave went away
It last disconnected at Wed Nov 11 03:03:46 2015 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The Buildbot
http://
The Buildbot working for 'ASF Buildbot'
has noticed that the buildslave named cordova-windows-slave went away
It last disconnected at Wed Nov 11 03:02:25 2015 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The Buildbot
htt
Hey folks,
I’m updating the build machines. They’ll be back up within the next two hours.
Kindly,
Dmitry
This mailing list is not for general support questions, but rather the
development of Cordova itself. Please see the PhoneGap Google group or
StackOverflow.
On Tue, Nov 10, 2015 at 2:51 AM, 杨恒 wrote:
>
> Hi,sorry to trobule you,but I has a urgent problem when I play local video on
> ios8+.
> the
Oh absolutely - sorry - I didn't mean to mess up the original request
- let's focus. :)
On Tue, Nov 10, 2015 at 6:55 PM, Carlos Santana wrote:
> Ray,
> I agree it would be useful, only to you but useful :-p
>
> Kidding aside it should not be difficult to override defaults.
>
> I would say let's
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-155621633
I am closing this PR and have submitted a new proposal that incorporates
feedback in #239
---
If your project is set up for it, you can reply to this email an
Github user riknoll closed the pull request at:
https://github.com/apache/cordova-android/pull/236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-155621243
@infil00p @purplecabbage @jasongin please review. This incorporates
feedback received on the first PR. Example plugin and application code are
linked at bottom
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-android/pull/239
CB-8917: Added pending plugin callbacks to resume event payload
This is a redo of #236 after receiving some feedback. This relates to
CB-8917 and CB-9189.
### Background
The is
Ray,
I agree it would be useful, only to you but useful :-p
Kidding aside it should not be difficult to override defaults.
I would say let's get --template out as MVP and then work on override
defaults
I think overriding defaults might be an idea that can be globally applied
to other commands.
Parashuram
I would say that if they have "platforms" and "plugins" it's not consider a
template, its consider a cordova project ready to be use no need to run
create on it.
As far as cp-from, it's doesn't copy much only www and config.xml, I didn't
want to change it's behavior for backwards compa
Hi,sorry to trobule you,but I has a urgent problem when I play local video on
ios8+.
the development is cordova@5.3.1 and the version of ios simulator is 8.4.
now I want to play local a video using html tag "video" after download and
unzip ,but the result is just a gray play button and can't pl
This is handled by this:
https://github.com/apache/cordova-ios/tree/master/CordovaLib/Classes/Private/Plugins/CDVSystemSchemes
Doc:
https://github.com/apache/cordova-docs/commit/80906ac23c77f4ce7a5d330b28fba803736c7253
On Tue, Nov 10, 2015 at 7:41 AM, julio cesar sanchez
wrote:
> What about url
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155613091
Good point, didn't think of that scenario. Ideally each WebView engine,
when activated, should inject its own bridge. This would solve this scenario.
We co
Github user chaffeqa commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155608082
I don't know if this was the path intended, but the new changes break the
falling back to UIWebView since simply including the WKWebview clobbers
`cordova.exec` (a
Yes, they would. However, there could be cases where folks would like to have
templates that have changes stuff in platforms, or added custom plugins or
hooks. I think that instead of adding extra code to prevent all these things,
we keep things simple, and copy over everything. The templates ca
If the plugins and platforms are listed in config.xml, wouldn't they just
get fetched on prepare?
On Tue, Nov 10, 2015 at 2:09 PM, Parashuram N
wrote:
> I think it should copy platform and plugins folders, if those are a part
> of the template. I think the guidance should be that most templates
I think it should copy platform and plugins folders, if those are a part of the
template. I think the guidance should be that most templates should not include
a platform or a plugin folder, but if they do - for reasons like custom
plugins, etc, then we should let that happen. The only enhanceme
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/147
CB-8497: Fix handling of file paths with # character
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jasongin/cordova-plugin-file
Github user robertbaker closed the pull request at:
https://github.com/apache/cordova-plugin-whitelist/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/15#issuecomment-155576148
I also tried it locally and I was able to update to android 5.0 with the
whitelist plugin installed. No problems.
`cordova platform add/upd
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/15#issuecomment-155575774
I don't think that should stop you from install cordova-android@5.
Go to http://semver.npmjs.com/ and enter `cordova-android` in the package
GitHub user robertbaker opened a pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/15
Updated cordova-android and ios semver
This is forcing cordova-android 4.1.1 instead of allowing cordova-android@5
You can merge this pull request into a Git repository by runni
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/136#issuecomment-155574157
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Parashuram
The template doesn't any special structure, the current hello app in npm is
already a template
Will add comment in PR about having fixtures in tests for different uses
cases with different type of templates
The code copies everything except plugins and platforms directories, maybe
it
One more thing... in TACO, we allow users to provide a template that provides
either (a) the full Cordova project or (b) only the contents of the WWW folder.
Might we want to implement a similar approach for Cordova?
rjs
Ryan J. Salva | Principal Program Manager Lead
Visual Studio Tools for
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-docs/pull/417#issuecomment-155561153
@riknoll - Updated, thank you Richard!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
I agree with keeping it out of core. I think it's similar to livereload
plugin. It could be really useful to developers, but it's not necessary for
building a Cordova app.
On Tue, Nov 10, 2015 at 3:29 PM, Parashuram N
wrote:
> I personally think that this is super useful. Maybe it does not make
I personally think that this is super useful. Maybe it does not make sense in
the code, but I would love to use this as a node module in my build process. It
would be a good start to put get a node module that does it. If Cordova
developers use it, it would then be a matter of simply consuming t
+1 to the proposal.
Is there a structure of a sample template ? Also, the code seems to copy
everything from npm or the gitURL, though in the proposal you say that dot file
and hooks/platforms should not be copies. Should we talk about that in the
proposal too ?
-Original Message-
Fr
Useful or not, I don’t think uploading binaries belongs in core. There are
plenty of third-party offerings that work well, and they shoulder the support
as well. Bringing uploading into core is just one more thing that Cordova devs
would then need to support.
So although it’s useful and time-sa
Yay, the audit happened! :-) So very cool. Not sure I agree with a couple of
the choices, but haven’t had the brain power to think through everything yet.
If the keyboard plugin is going to remain managed by ionic, then I’d keep it
out of core, honestly. To me, “core” implies Apache-managed. Ins
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/136#issuecomment-11071
This doesn't fix CB-9169, but it documents the quirk on Android. @infil00p
please review.
---
If your project is set up for it, you can reply to this em
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/136
CB-9169 android: Fixed filetype for uncompressed images and added quirk
When trying to get uncompressed images on Android using camera options like
these:
``` javascript
{
Yeah, nothing to add here but +1.
Oh, the only thing I'd add is that I wish there was a way to
*permanently* set a template. I hate the default Cordova template
(sorry ;) and would love to make the CLI always use my own particular
template.
On Tue, Nov 10, 2015 at 1:52 PM, Ryan J. Salva wrote:
>
I love it!
rjs
Ryan J. Salva | Principal Program Manager Lead
Visual Studio Tools for Apache Cordova
rsa...@microsoft.com
206 612 5079 mobile
-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com]
Sent: Tuesday, November 10, 2015 7:49 PM
To: dev@cordova.apache.org
Su
>From the Face2Face meeting updating the cordova cli to work with templates
sounded like a good feature to add to the CLI
I finally got around to this and created the proposal and got James Dubee
from our team to take a stab at implementation.
CLI-Template proposal [1]
[1]:
https://github.com/co
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-155520309
@charlesverge Yeah, and it was slated to be "deprecated" for some reason,
which is why I forgot about it. I added it back in since we can't use the
Res
Github user charlesverge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-155517946
@infil00p The method comes from a previous version of the plugin which was
working for some devices.
https://github.com/apache/cordova-plugin-ca
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/417#discussion_r44439140
--- Diff: www/_posts/2015-11-11-cordova-windows-4.2.0.md ---
@@ -0,0 +1,44 @@
+---
+layout: post
+author:
+name: Sergey Grebnov
+
Not directly related to this issue, but should we move towards having similar
defaults for all platforms ?
e.g: Android, iOS, Windows all have their orientation default be ‘all’ (both
portrait and landscape).
Thanks,
Mefire
> On Nov 10, 2015, at 8:59 AM, Raymond Camden wrote:
>
> Bug report:
I agree with Raymond on the ability to use native dialogs. I think I would like
to extend it beyond dialogs, and see if it is possible to use other native
controls too - like Sidebar, etc. I think they may not make sense as core
plugins though. Supporting them for multiple platforms is hard. May
Nice work! Couldn't resist checking out the results of the
thought-it-would-never-happen audit :).
On Tue, Nov 10, 2015 at 9:25 AM, Raymond Camden
wrote:
> "Globalization (make sync"
>
> YES, YES, YES!
>
> (Sorry, but that makes me *very* happy to hear!)
>
> "Dialogs (Should use HTML/CS/JS dialo
Bug report: https://issues.apache.org/jira/browse/CB-9975
On Tue, Nov 10, 2015 at 10:56 AM, Vladimir Kotikov (Akvelon)
wrote:
> The orientation is still handled by LIB (except cordova-android), so this is
> probably tools-related.
>
> -
> Best regards, Vladimir.
>
> -Original Message-
>
The orientation is still handled by LIB (except cordova-android), so this is
probably tools-related.
-
Best regards, Vladimir.
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Tuesday, November 10, 2015 7:51 PM
To: dev@cordova.apache.org
Subject: Re: CLI broke
The only diff between yesterday and today is the CLI, so I'm assuming
that. Reporting the bug now.
On Tue, Nov 10, 2015 at 10:50 AM, Steven Gill wrote:
> File a bug! Sounds like a regression and worth a patch. Is it tools related
> or ios 3.9.2 related?
>
> On Tue, Nov 10, 2015 at 7:20 AM, Raymon
File a bug! Sounds like a regression and worth a patch. Is it tools related
or ios 3.9.2 related?
On Tue, Nov 10, 2015 at 7:20 AM, Raymond Camden
wrote:
> I can file a Jira on this but would like someone to confirm. Yesterday
> I blogged about iOS and orientation
> (
> http://www.raymondcamden.c
Yeah, I messaged Dimitry about it last night. Couldn't figure out how to
update that link last night.
On Tue, Nov 10, 2015 at 7:45 AM, julio cesar sanchez wrote:
> It's loading 5.1.1 for me, but latest is 5.4.0
>
> 2015-11-10 16:21 GMT+01:00 Raymond Camden :
>
> > Going to http://cordova.apache.
It's loading 5.1.1 for me, but latest is 5.4.0
2015-11-10 16:21 GMT+01:00 Raymond Camden :
> Going to http://cordova.apache.org/docs/en/latest/index.html gives an
> outdated message even though it is the latest.
>
> --
> ===
Github user dieppe commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-155457722
Very disappointed to see that our efforts have been completely overlooked.
This PR actually fixes a bunch of bugs that have since been fixed, and
What about url schemes? I suppose they won't work unless we allow them
using the CSP, but, do we have code to handle them?
I've been looking on the source code and *CDVUIWebViewNavigationDelegate.m,
*on *shouldStartLoadWithRequest* ask *CDVViewController.m* for*
shouldOpenExternalURL *that queries
I can file a Jira on this but would like someone to confirm. Yesterday
I blogged about iOS and orientation
(http://www.raymondcamden.com/2015/11/09/cordova-ios-and-orientation-wondering-why-it-is-locked).
Today on Twitter someone noticed that when they set orientation now,
they get an error in the
Going to http://cordova.apache.org/docs/en/latest/index.html gives an
outdated message even though it is the latest.
--
===
Raymond Camden, Developer Advocate for MobileFirst at IBM
Email : raymondcam...@gmail.com
Blog : www
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/77#issuecomment-155436002
Hi @vincipop, before merging could you please sign the Apache CLA? Also it
would be great if you filed an issue in
[JIRA](https://issues.apache
"Globalization (make sync"
YES, YES, YES!
(Sorry, but that makes me *very* happy to hear!)
"Dialogs (Should use HTML/CS/JS dialogs instead)"
Strongly no, but I'm assuming there is a good reason for this beyond
just what is listed in the parenthesis. Yes, UI frameworks normally
have their own di
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/80
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/119
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/82
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Please review blog post draft
https://github.com/apache/cordova-docs/pull/417
Thx!
Sergey
-Original Message-
From: Sergey Grebnov (Akvelon)
Sent: Saturday, November 7, 2015 2:55 PM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Cordova-Windows Release
Empty commit did the trick :) Tha
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-docs/pull/417
CB-9961 blogpost for Windows 4.2.0 release
Generated page looks like below
![blogpost-win-4 2
0](https://cloud.githubusercontent.com/assets/981580/11061936/ba66e7ae-87bb-11e5-8d0f-f36a6e5
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/238#issuecomment-155388076
LGTM.
IMO it might be better to use promises in `projectActions` to reduce
'pyramids of doom' in
[update.spec.js](https://github.com/apache/co
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/238#discussion_r44392722
--- Diff: spec/e2e/update.spec.js ---
@@ -0,0 +1,96 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more
I get your point, still think though that it would be a useful feature for
many developers because it saves lots of time when you have your apps
already set up. Cordova could later work on making Continuous Integration
an easy step.
Talking about documenting the process of adding one app to the st
84 matches
Mail list logo