Any more iOS experts can review my pull request? 2015-11-11 6:59 GMT+01:00 Steven Gill <stevengil...@gmail.com>:
> Going to move forward with this tomorrow. Any holdups, let me know. Here or > #plugins on slack. > > On Fri, Nov 6, 2015 at 2:51 PM, Richard Knoll <rikn...@microsoft.com> > wrote: > > > I plan on merging in > > https://github.com/apache/cordova-plugin-camera/pull/135 for the camera > > plugin if there are no objections. > > > > Thanks, > > Richard > > > > -----Original Message----- > > From: Steven Gill [mailto:stevengil...@gmail.com] > > Sent: Friday, November 6, 2015 11:38 AM > > To: dev@cordova.apache.org > > Subject: Re: [DISCUSS] Plugins release > > > > With plugin changes, it is always nice to get reviews since it could > > affect every platform. > > > > file:146 is merged > > file: 119 LGTM > > Statusbar: 38 could use a review by iOS experts > > > > Keep em coming in! > > > > -Steve > > > > On Fri, Nov 6, 2015 at 5:53 AM, Simon MacDonald < > simon.macdon...@gmail.com > > > > > wrote: > > > > > I agree with Jason, > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu > > > b.com > > %2fapache%2fcordova-plugin-file%2fpull%2f146&data=01%7c01%7cRIKNOLL% > > 40exchange.microsoft.com > %7c1e652e1ff1074570a66908d2e6e1e10f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=HU0E%2fMPc3C2cD%2fNEtQlLGStzqfDX4Sm%2f3OdrdACiHb8%3d > > should be merged. > > > > > > Simon Mac Donald > > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im% > > > 2fsimonmacdonald&data=01%7c01%7cRIKNOLL%40exchange.microsoft.com%7c1e6 > > > 52e1ff1074570a66908d2e6e1e10f%7c72f988bf86f141af91ab2d7cd011db47%7c1&s > > > data=MXNVR%2bXGeH703bFkFHohHk6EwL8amOj4btn2kNuUPiU%3d > > > > > > On Thu, Nov 5, 2015 at 8:07 PM, Jason Ginchereau > > > <jason...@microsoft.com> > > > wrote: > > > > I think this PR should get in the release: > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu > > > b.com%2fapache%2fcordova-plugin-file%2fpull%2f146&data=01%7c01%7cRIKNO > > > LL%40exchange.microsoft.com%7c1e652e1ff1074570a66908d2e6e1e10f%7c72f98 > > > 8bf86f141af91ab2d7cd011db47%7c1&sdata=HU0E%2fMPc3C2cD%2fNEtQlLGStzqfDX > > > 4Sm%2f3OdrdACiHb8%3d > > > > It might be considered a blocker, because it is a regression that > > > > could > > > cause loss of data when upgrading apps which relied on the default > > > AndroidPersistentFileLocation value. > > > > > > > > This would be a good one also, as it fixes a significant failure > > > > working > > > with some kinds of files on Android 5.0: > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu > > > b.com%2fapache%2fcordova-plugin-file%2fpull%2f119&data=01%7c01%7cRIKNO > > > LL%40exchange.microsoft.com%7c1e652e1ff1074570a66908d2e6e1e10f%7c72f98 > > > 8bf86f141af91ab2d7cd011db47%7c1&sdata=TxHgwQq3dyT4Qlo7PM%2fQ0iU3KhtoMP > > > J5uU3UqGcY6yA%3d > > > > > > > > Jason > > > > > > > > -----Original Message----- > > > > From: Steven Gill [mailto:stevengil...@gmail.com] > > > > Sent: Thursday, November 5, 2015 3:09 PM > > > > To: dev@cordova.apache.org > > > > Subject: [DISCUSS] Plugins release > > > > > > > > I plan on starting a plugins release on Monday. It is going to be a > > > > big > > > one. > > > > > > > > Please review and close as many PRs as you can before than. > > > > > > > > If you have PR that is ready and needs someone to look at + merge, > > > please share it in this thread and we will try to get to it before the > > > release. > > > > You could also share it on slack[1] in the #plugins channel. > > > > > > > > Let me know if we have any blockers. > > > > > > > > Cheers, > > > > -Steve > > > > > > > > > > > > [1] > > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fslack. > > > cordova.io&data=01%7c01%7cjasongin%40microsoft.com%7c6bb15854633242978 > > > d6208d2e636167f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=QY3Nj3rIJ > > > VCSOuncqfAqTul2GKH9L0Z7FQ3oaln4vg4%3d > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > >
