[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-07 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/10#discussion_r46923612 --- Diff: server.js --- @@ -78,6 +90,17 @@ http.createServer(function (req, res) { res.end("\n"); }); }

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-07 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/10#discussion_r46923583 --- Diff: server.js --- @@ -6,6 +6,11 @@ var formidable = require('formidable'), var DIRECT_UPLOAD_LIMIT = 32; // bytes +// convert f

[GitHub] cordova-plugin-file-transfer pull request: CB-10044 FileTransfer p...

2015-12-07 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-162800441 Ping @maortega... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-contacts pull request: CB-10053 Documents ContactFi...

2015-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/93 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-contacts pull request: CB-10053 Documents ContactFi...

2015-12-07 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/93#issuecomment-162797273 @dblotsky, IMO it would be easier for us, but not for the users, as they will have to look into sources. --- If your project is set up for it,

[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...

2015-12-07 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-ios/pull/182 CB-10162 correct the paths for iOS icon and splashscreen resources You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-ios CB

Re: [DISCUSS] CLI Templates

2015-12-07 Thread Dmitry Blotsky
Thanks for the summary, Carlos! Sorry, I hadn’t read the whole thread when I sent my question. I read up after your email, and I have a better grasp on it now. My new questions are below. 1. What is the `cordova create` command then doing if it’s copying (potentially) the whole app it’s trying

Re: Buildbot: buildslave cordova-windows-slave was lost

2015-12-07 Thread Dmitry Blotsky
Something crashed on the machine. I don’t know what it was, but I also didn’t investigate very deeply. Will look more if it happens again. It’s back up now. Kindly, Dmitry > On Dec 6, 2015, at 4:32 AM, build...@apache.org wrote: > > The Buildbot working for 'ASF Buildbot' > has noticed that the

[GitHub] cordova-docs pull request: Adding Search Button

2015-12-07 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/435#issuecomment-162741151 @riknoll I've incorporated your feedback. Please give it a look when you have a moment. --- If your project is set up for it, you can reply to this email and hav

Re: [VOTE] cordova-plugin-wkwebview-engine 1.0.0 release

2015-12-07 Thread Carlos Santana
+1 - Created hello world app - coho verify-tag - coho verify-archive - coho create-archive and compare with dist On Mon, Dec 7, 2015 at 6:45 PM Steven Gill wrote: > +1 > > * Built a hello world app with it > * Ran coho verify-archive > * Ran audit-license-headers > > On Fri, Dec 4, 2015 at 6:1

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-07 Thread Carlos Santana
Currently finding a discrepancy when recreating the archive The tgz dist/ [1] is missing 3 node modules, they are located in git [2] Running the command coho create-archive --tag 4.0.0 -r ios --dest test-ios4/ I ran with npm@2.11.3 and npm@3.3.12 and was able to get all three in expected location

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-07 Thread Carlos Santana
Currently working on it... - Carlos @csantanapr > On Dec 7, 2015, at 6:50 PM, Steven Gill wrote: > > both ios@4 and cordova-plugin-wkwebviewengine need 1 more vote. Someone > step up so Shaz can wrap up the vote threads and publish these! > >> On Fri, Dec 4, 2015 at 2:07 PM, Carlos Santana wr

[GitHub] cordova-plugin-file pull request: CB-10023 Fix "proxy not found er...

2015-12-07 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162708869 Moved `isChrome` to be browser specific (we only ever call it either from browser specific code, or after verifying we're running on browser platform).

[GitHub] cordova-plugin-file pull request: CB-10023 Fix "proxy not found er...

2015-12-07 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162708771 @omefire - no, I don't think so. I think feature detection is more appropriate for the intent of this code. Also, my goal wasn't to change the existing l

Re: [VOTE] 4.0.0 iOS Release

2015-12-07 Thread Steven Gill
+1 * Ran mobile-spec. only file-transfer failed which was expected * Ran coho verify-archive * Ran coho audit-license-headers On Fri, Dec 4, 2015 at 5:33 PM, Shazron wrote: > Please review and vote on this 4.0.0 iOS Release > by replying to this email (and keep discussion on the DISCUSS thread)

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-07 Thread Steven Gill
both ios@4 and cordova-plugin-wkwebviewengine need 1 more vote. Someone step up so Shaz can wrap up the vote threads and publish these! On Fri, Dec 4, 2015 at 2:07 PM, Carlos Santana wrote: > +1 > > On Fri, Dec 4, 2015 at 3:07 PM Shazron wrote: > > > After working out some bridge improvements a

Re: [VOTE] cordova-plugin-wkwebview-engine 1.0.0 release

2015-12-07 Thread Steven Gill
+1 * Built a hello world app with it * Ran coho verify-archive * Ran audit-license-headers On Fri, Dec 4, 2015 at 6:11 PM, Shazron wrote: > Please review and vote on the release of this cordova-plugin-wkwebview > release > by replying to this email (and keep discussion on the DISCUSS thread) >

RE: [DISCUSS] New Information Architecture for Cordova Website

2015-12-07 Thread Raghav Katyal
Looks like something is messing up with the formatting. Kindly refer to the discuss PR in the mail. -Raghav From: Raghav Katyal Sent: Monday, December 7, 2015 3:19 PM To: 'dev@cordova.apache.org' Subject: [DISCUSS] New Information Architecture for Cordova Website Hi everyone! As a part of the

[DISCUSS] New Information Architecture for Cordova Website

2015-12-07 Thread Raghav Katyal
Hi everyone! As a part of the task of improving the Cordova documentation, we came up with a new Information Architecture for the website. The current architecture was not very comprehensive and lacked a well-defined structure which made the documentation difficult to follow and find for people

[GitHub] cordova-plugin-contacts pull request: CB-10159 android: Adding res...

2015-12-07 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/97 CB-10159 android: Adding restore callback to handle Activity destruction Implementing the new plugin save/restore API to fix a crash that happened when the OS killed the Cordova Acti

[GitHub] cordova-plugin-contacts pull request: CB-10148: Added READ_CONTACT...

2015-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/96 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-07 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/10#discussion_r46873919 --- Diff: server.js --- @@ -78,6 +90,17 @@ http.createServer(function (req, res) { res.end("\n"); });

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-07 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/10#discussion_r46872038 --- Diff: server.js --- @@ -6,6 +6,11 @@ var formidable = require('formidable'), var DIRECT_UPLOAD_LIMIT = 32; // bytes +// convert

[GitHub] cordova-plugin-contacts pull request: CB-10148: Added READ_CONTACT...

2015-12-07 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/96 CB-10148: Added READ_CONTACTS permission request when picking contacts We currently don't request the permission and get a SecurityException when the Activity returns on Marshmallow.

Application is always uninstalled, clears localstorage and databases

2015-12-07 Thread Zeph Davies
Hi Devs, Since a change made to fix issue CB-9557 (https://issues.apache.org/jira/browse/CB-9557), the application is always uninstalled before being installed. This means that the application's localStorage and any databases are CLEARED every time the application is installed (with 'ionic run

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-07 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-labs/pull/10#issuecomment-162630500 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed how checks access ...

2015-12-07 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/146#issuecomment-162626908 @m-revetria Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed how checks access ...

2015-12-07 Thread m-revetria
Github user m-revetria commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/146#issuecomment-162626440 I just sent ICLA signed by email, I'll let you know when I have response from secret...@apache.org --- If your project is set up for it, you can rep

[GitHub] cordova-plugin-file pull request: CB-10023 Fix "proxy not found er...

2015-12-07 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162621624 Would it not be better to use the useragent to detect if the browser we're dealing with is chrome ? --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-battery-status pull request: Add battery temperatur...

2015-12-07 Thread petervojtek
GitHub user petervojtek opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/28 Add battery temperature to Android You can merge this pull request into a Git repository by running: $ git pull https://github.com/petervojtek/cordova-plugin-battery-

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed how checks access ...

2015-12-07 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/146#issuecomment-162601009 Thanks for making this into a PR! The JIRA is here: [CB-10128](https://issues.apache.org/jira/browse/CB-10128) @m-revetria, I don't se your name

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed authorization erro...

2015-12-07 Thread m-revetria
Github user m-revetria commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/144#issuecomment-162599738 Hi, @riknoll: I just made a PR for this change: https://github.com/apache/cordova-plugin-camera/pull/146: --- If your project is set up for it,

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed how checks access ...

2015-12-07 Thread m-revetria
GitHub user m-revetria opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/146 [iOS] Fixed how checks access authorization to camera & library You can merge this pull request into a Git repository by running: $ git pull https://github.com/m-revetria/cor

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2015-12-07 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-162598821 @ochakov thanks for doing that! Can you add your name to your GitHub profile so that we can verify? --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-device pull request: CB-9923 Update `device.platfor...

2015-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/45 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-device pull request: CB-9923 Update `device.platfor...

2015-12-07 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-device/pull/45 CB-9923 Update `device.platform` documentation for browser platform See the [CB-9923](https://issues.apache.org/jira/browse/CB-9923) and #25 for details You can merge this pu

[GitHub] cordova-plugin-file pull request: CB-10023 Fix "proxy not found er...

2015-12-07 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/152#discussion_r46821107 --- Diff: www/isChrome.js --- @@ -0,0 +1,26 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-07 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-labs/pull/10#issuecomment-162485970 @dblotsky, @stevengill, I would like to merge this in tomorrow if there are no objections. --- If your project is set up for it, you can reply to this email and ha

[GitHub] cordova-plugin-file-transfer pull request: CB-9600 FileUploadOptio...

2015-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file-transfer pull request: CB-9600 FileUploadOptio...

2015-12-07 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/121 CB-9600 FileUploadOptions params not posted on iOS Documents supported params key/value type [Jira issue](https://issues.apache.org/jira/browse/CB-9600) You can merge

[GitHub] cordova-lib pull request: Adds copying of blackberry10 splashscree...

2015-12-07 Thread kdubuc
Github user kdubuc commented on the pull request: https://github.com/apache/cordova-lib/pull/342#issuecomment-162453543 Thanks :wink: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea