Re: [DISCUSS] Deprecate cordova-wp8

2015-12-08 Thread julio cesar sanchez
+1 to Jesse, deprecation doesn't mean they won't be able to use it. Parashuram, can you get stats about the number of devices or percentaje of devices that still use WP8? like windows store device access stats or something like that Sergio, you got an answer on cordova's slack general channel. vl

[GitHub] cordova-android pull request: Include native libraries from armeab...

2015-12-08 Thread mbektchiev
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-android/pull/243 Include native libraries from armeabi directory when producing armv7 apk If a Cordova Android project contains `.so` files located in the `lib/armeabi` directory, they will not be includ

[GitHub] cordova-plugin-splashscreen pull request: Fixed installation instr...

2015-12-08 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/40#issuecomment-163135095 Ping @gtczap, could you please close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-camera pull request: major bugs when user picture

2015-12-08 Thread roysG
GitHub user roysG opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/147 major bugs when user picture I am sorry if this is not the right place for bug, but i can't find the issue category, and this is very major bugs and important to fix them. I go

[GitHub] cordova-plugin-file pull request: CB-10023 Fix "proxy not found er...

2015-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/152 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

Re: [DISCUSS] CLI Templates

2015-12-08 Thread Steven Gill
The thread was proposed Nov 10th and PR was merged Dec 3rd. I think that is ample time to give feedback. If people don't give feedback, apache way is consider it as lazy consensus. We do not vote on feature requests and I hope we never do as it is a terrible practice. Good luck trying to get anyth

[GitHub] cordova-plugin-splashscreen pull request: CB-3562 Disable screen r...

2015-12-08 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-163120168 @emarashliev, looks like the issue has been fixed in #47 - could you please close this PR? --- If your project is set up for it, you can reply to t

Re: [DISCUSS] CLI Templates

2015-12-08 Thread Dmitry Blotsky
The `--template` flag currently there is the one that was added as per this discussion. I think in the future we should refrain from adding code before a discussion completes, especially if there is contention. At the very least, we should probably hold a vote. I’m definitely not a fan of addin

[GitHub] cordova-docs pull request: Adding Search Button

2015-12-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/435#issuecomment-163110477 @riknoll and I've again updated the PR. Please give it a look when you have a chance. In particular, on `md` screens the search field disappears, and the search b

[GitHub] cordova-ios pull request: CB-9311 CB-10162 fixes app icon 87x87 an...

2015-12-08 Thread csantanapr
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-ios/pull/183 CB-9311 CB-10162 fixes app icon 87x87 and copy errors You can merge this pull request into a Git repository by running: $ git pull https://github.com/csantanapr/cordova-ios CB-9311 A

[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...

2015-12-08 Thread csantanapr
Github user csantanapr commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/182#discussion_r47048171 --- Diff: bin/templates/scripts/cordova/lib/prepare.js --- @@ -257,10 +257,11 @@ function handleBuildSettings(platformConfig, locations) { re

[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...

2015-12-08 Thread csantanapr
Github user csantanapr commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/182#discussion_r47048069 --- Diff: bin/templates/scripts/cordova/lib/prepare.js --- @@ -47,8 +47,8 @@ module.exports.prepare = function (cordovaProject) { return u

[GitHub] cordova-lib pull request: CB-8455 added --nohooks option

2015-12-08 Thread bso-intel
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-lib/pull/353#issuecomment-163090076 Hi Jesse, The CI failures actually were caused by not checking the existence of the opts parameter. In the spec unit tests, update_project() was invok

[GitHub] cordova-docs pull request: Add plugins release blog post for cordo...

2015-12-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-docs/pull/437#issuecomment-163067085 LGTM! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cordova-lib pull request: CB-8455 added --nohooks option

2015-12-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/353#issuecomment-163066579 This feature has much deeper and far reaching requirements, as the CI has pointed out. The individual platforms are all keeping their own parsers, and beca

[GitHub] cordova-lib pull request: CB-9311 Add support for 87x87 icon, fix ...

2015-12-08 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/354#issuecomment-163065575 iOS parser code does not go into cordova-lib anymore. It goes in cordova-ios (Platform API) --- If your project is set up for it, you can reply to this email and h

[GitHub] cordova-lib pull request: CB-9311 Add support for 87x87 icon, fix ...

2015-12-08 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/354#issuecomment-163065696 It's possible all the work that has gone into cordova-lib for iOS has not been integrated into the Platform API for iOS: https://github.com/apache/cordova-ios/pull/

Re: [DISCUSS] Deprecate cordova-wp8

2015-12-08 Thread Sergio Nader
Thanks, but I tried a couple of times to ask about it (and other stuff) and got no answer. Weil, will not change the subject of this conversation. If anyone can help me or have any other suggestion, please email directly. Regards, Sérgio Nader Skype: sergio.nader.br Tel: 55 11 9 9101 4590 ​w

RE: [DISCUSS] Deprecate cordova-wp8

2015-12-08 Thread Parashuram N
The Cordova Slack at http://cordova.slack.com/ would be a good place to start. -Original Message- From: Sergio Nader [mailto:sergio.na...@brasilisdigital.com.br] Sent: Tuesday, December 8, 2015 3:41 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Deprecate cordova-wp8 Hello, I hav

Re: [DISCUSS] Deprecate cordova-wp8

2015-12-08 Thread Sergio Nader
Hello, I have several questions about the diferences and uses of wp8, windows (universal). I tried hard to find some objective readings about them, but could not found anything concise. Where is the right place to ask for orientation? Best regards, Sergio Sérgio Nader Skype: sergio.nader.br T

[GitHub] cordova-lib pull request: CB-9311 Add support for 87x87 icon, fix ...

2015-12-08 Thread tony--
GitHub user tony-- opened a pull request: https://github.com/apache/cordova-lib/pull/354 CB-9311 Add support for 87x87 icon, fix reference url You can merge this pull request into a Git repository by running: $ git pull https://github.com/tony--/cordova-lib CB-9311 Alternativ

Re: [DISCUSS] Deprecate cordova-wp8

2015-12-08 Thread Jesse
The deprecation window is a 'minimum' of 6 months. Waiting 3 months to maybe wait 6 more months seems less efficient than deprecating now and deciding in 6 months time if we want to move on it. Deprecation is not the end, just the beginning of it. Also, we need to nudge people to move forwards, th

RE: [DISCUSS] CLI Templates

2015-12-08 Thread Mefire O .
We already have support for the --template flag in Cordova. However, it currently only supports NPM packages and GIT URLs, no local folder. The local folder scenario is currently being handled by --copy-from (only www and config.xml are copied) and --link-to. We also have a way of specifying d

[ANNOUNCE] Cordova ios@4.0.0 and cordova-plugin-wkwebview-engine plugin released!

2015-12-08 Thread Steven Gill
Blog: http://cordova.apache.org/announcements/2015/12/08/cordova-ios-4.0.0.html Tweet: https://twitter.com/apachecordova/status/674352882108391424 cordova-plugin-wkwebview-engine blog: http://cordova.apache.org/news/2015/12/08/wkwebview-engine-plugin-release.html Thanks to everyone who helped get

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/10#discussion_r47014925 --- Diff: server.js --- @@ -6,6 +6,11 @@ var formidable = require('formidable'), var DIRECT_UPLOAD_LIMIT = 32; // bytes +// convert

Re: [DISCUSS] CLI Templates

2015-12-08 Thread Dmitry Blotsky
1. The `--copy-from` flag is a valid use case, and it is definitely still used. If we do implement the `--template` flag, we should keep `--copy-from` as well. 2. Doing proper re-creation of files is harder than it seems: the template might have broken platforms that need regenerating, and that w

RE: [DISCUSS] Deprecate cordova-wp8

2015-12-08 Thread Parashuram N
I pinged the folks here on VS team to get an idea of number of people building for WP8. Looks like this is still a significant number (more than 10%) and almost 2000 unique users building for WP8 per month. Can we delay the deprecation for 3 more months to see if this number can go down ?

Re: Buildbot: buildslave cordova-windows-slave was lost

2015-12-08 Thread Dmitry Blotsky
Somebody kicked the switch by my desk and it knocked both machines off the network. Back now. Kindly, Dmitry > On Dec 8, 2015, at 12:36 PM, build...@apache.org wrote: > > The Buildbot working for 'ASF Buildbot' > has noticed that the buildslave named cordova-windows-slave went away > > It last

Buildbot: buildslave cordova-windows-slave was lost

2015-12-08 Thread buildbot
The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Tue Dec 8 20:31:48 2015 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot htt

Buildbot: buildslave cordova-osx-slave was lost

2015-12-08 Thread buildbot
The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-osx-slave went away It last disconnected at Tue Dec 8 20:14:49 2015 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot http://

[GitHub] cordova-docs pull request: Add plugins release blog post for cordo...

2015-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/437 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

2015-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/436 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: [DISCUSS] CLI Templates

2015-12-08 Thread Carlos Santana
Hi Dmitry 1. It was discuss in the mailing list, that use case #1 was not need it, and to be replace by --template, user don't have to have config.xml and other cordova specific files they will be created. So the reason to deprecate --copy-from 2. yes it's similar to a cp or git clone, but also a

[GitHub] cordova-lib pull request: CB-8455 added --nohooks option

2015-12-08 Thread bso-intel
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-lib/pull/353 CB-8455 added --nohooks option implemented --nohooks noption as described in CB-8455 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-i

[GitHub] cordova-cli pull request: CB-8455 added --nohooks option

2015-12-08 Thread bso-intel
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-cli/pull/230 CB-8455 added --nohooks option implemented --nohooks option described in CB-8455 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bso-intel

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

2015-12-08 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/436#issuecomment-162974919 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

2015-12-08 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-docs/pull/436#issuecomment-162935928 Ok all changes integrated, for those latecomers here is the link to view all PR changes: https://github.com/shazron/cordova-docs/blob/cordova-ios-4-release/www/_po

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

2015-12-08 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/436#issuecomment-162934923 ok, I went over the wholes changes, that's it I didn't find anything else --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

2015-12-08 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-docs/pull/436#issuecomment-162934725 @csantanapr whitelist stuff is already mentioned. Deployment target change -- yes. Too many other changes to list in one blog post, that's why there is a "

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

2015-12-08 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/436#issuecomment-162934402 What about AppDelegate changes/moving? What about minimum Deployment Target to iOS 8.0? What does this means for humans :-), no ios 7? --- If your pro

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

2015-12-08 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/436#issuecomment-162933618 @shazron ah ok, maybe I was thinking oh what about whitelist stuff? Any other high level feature? --- If your project is set up for it, you c

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

2015-12-08 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-docs/pull/436#issuecomment-162931682 @csantanapr good points, I'll add those in. Not sure about point 4 though, xcconfig stuff is build artifacts, and we don't have the `` tag yet for this --- If yo

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

2015-12-08 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/436#issuecomment-162930851 What about mentioning other some high level features: 1. Support Asset Catalog 2. ios-sim (will use internal version, no need to npm i -g ios-sim)

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

2015-12-08 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-docs/pull/436#issuecomment-162928849 @dpogue Good idea, will add that in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

Re: [REVIEW] plugins release blog post for cordova-plugin-wkwebview

2015-12-08 Thread Carlos Santana
LGTM On Tue, Dec 8, 2015 at 11:01 AM Shazron wrote: > Please review and comment: > https://github.com/apache/cordova-docs/pull/437 > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-m

[REVIEW] plugins release blog post for cordova-plugin-wkwebview

2015-12-08 Thread Shazron
Please review and comment: https://github.com/apache/cordova-docs/pull/437 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add plugins release blog post for cordo...

2015-12-08 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/437 Add plugins release blog post for cordova-plugin-wkwebview-engine You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-docs wk

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

2015-12-08 Thread dpogue
Github user dpogue commented on the pull request: https://github.com/apache/cordova-docs/pull/436#issuecomment-162914587 Might be good to include a line like "This is a major release, and deprecated APIs have been removed. Some 3rd party plugins might require updates before they are c

[REVIEW] cordova-ios 4.0.0 blog post

2015-12-08 Thread Shazron
Please review and comment: https://github.com/apache/cordova-docs/pull/436 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] cordova-plugin-wkwebview-engine 1.0.0 release

2015-12-08 Thread Shazron
The vote has now closed. The results are: Positive Binding Votes: 3 Shazron Abdullah Steve Gill Carlos Santana Negative Binding Votes: 0 The vote has passed. I will now publish to dist and npm. On Mon, Dec 7, 2015 at 6:33 PM, Carlos Santana wrote: > +1 > > - Created hello world app > - coho

Re: [VOTE] 4.0.0 iOS Release

2015-12-08 Thread Shazron
The vote has now closed. The results are: Positive Binding Votes: 3 Shazron Abdullah Steve Gill Carlos Santana Negative Binding Votes: 0 The vote has passed. I will now publish to dist and npm. On Tue, Dec 8, 2015 at 5:29 AM, Carlos Santana wrote: > +1 > > Ran mobile-spec > Ran coho verify-a

[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...

2015-12-08 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/436 Add cordova-ios-4.0.0 release blog post announcement You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-docs cordova-ios-4-re

Re: [VOTE] 4.0.0 iOS Release

2015-12-08 Thread Carlos Santana
+1 Ran mobile-spec Ran coho verify-archive Ran coho create-archive and compare contents with dist tgz Ran coho verify-tags Created hello world app On Mon, Dec 7, 2015 at 6:52 PM Steven Gill wrote: > +1 > > * Ran mobile-spec. only file-transfer failed which was expected > * Ran coho verify-arc

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-08 Thread Shazron
I removed the root node_modules in cordova-ios, and re-created the archive. They are re-published at: https://dist.apache.org/repos/dist/dev/cordova/CB-10147 On Tue, Dec 8, 2015 at 5:12 AM, Carlos Santana wrote: > Wow good find ! > > I some times do a rm -r node_modules then npm install before r

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-08 Thread Carlos Santana
Wow good find ! I some times do a rm -r node_modules then npm install before running coho create-archive, but not all the time. So I can see this happening I agree we should automate this in coho. The coho create-archive should clean node_modules for repo ios only, or also do rm and then an

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-08 Thread Shazron
Mystery solved. cordova-ios has devDependencies in the root package.josn. This will install a "node_modules" in the root, which npm pack will ignore and git will as well (since it is in the .gitignore). However, even though it is not packed, it will affect 'npm pack', as I will explain... I hadn'

[GitHub] cordova-windows pull request: CB-9828 Implements PlatformApi contr...

2015-12-08 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-windows/pull/132#issuecomment-162867249 Generally looks fine to me apart from some misplaced "Android" references I mention inline. Also, it concerns me that `ConsoleLogger` is duplicated across eac

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-08 Thread Carlos Santana
Thanks for the update Did you said you tried a new directory via clone What about updating to latest npm@2.x ? On Tue, Dec 8, 2015 at 7:16 AM Shazron wrote: > A regular `tar -cvzf` the missing folders are included, it's just `npm > pack` not liking my local repo for some reason. > > On Tue, Dec

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-08 Thread Shazron
A regular `tar -cvzf` the missing folders are included, it's just `npm pack` not liking my local repo for some reason. On Tue, Dec 8, 2015 at 3:51 AM, Shazron wrote: > This is certainly bizarre. > > I've verified that my local repo copy of the cordova-ios 4.0.x branch > does have those modules, t

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-08 Thread Shazron
This is certainly bizarre. I've verified that my local repo copy of the cordova-ios 4.0.x branch does have those modules, then ran "npm pack" on the repo folder (which coho create-archive calls): [cordova-ios (4.0.x)]$ npm pack --verbose npm info it worked if it ends with ok npm verb cli [ '

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-labs/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is