[GitHub] cordova-ios pull request: Use "cdv_" prefixed scrollView for UIVie...

2015-12-23 Thread tualatrix
GitHub user tualatrix opened a pull request: https://github.com/apache/cordova-ios/pull/187 Use "cdv_" prefixed scrollView for UIView to avoid conflicts After upgrading cordova-ios from 3.9.x to 4.0.x, I found there's a conflict for my custom UIView and cordova. It is caused by the

[GitHub] cordova-plugin-inappbrowser pull request: inappbrower plugin has b...

2015-12-23 Thread gaoyuan123
GitHub user gaoyuan123 opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/131 inappbrower plugin has build error in android studio 2.0: Error:Error: Expected resource of type id [ResourceType] You can merge this pull request into a Git repository by ru

[GitHub] cordova-lib pull request: Add cli_variables to plugman before_plug...

2015-12-23 Thread mattdsteele
GitHub user mattdsteele opened a pull request: https://github.com/apache/cordova-lib/pull/358 Add cli_variables to plugman before_plugin_install hook params Currently the context provided to the `before_plugin_install` hook does not include plugin variables/parameters. This is probl

[GitHub] cordova-osx pull request: CB-10085 Implement and expose PlatformAp...

2015-12-23 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-osx/pull/28#issuecomment-166979598 @tripodsan will look at this after the holidays --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...

2015-12-23 Thread TheBosZ
Github user TheBosZ commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r48373738 --- Diff: src/android/SplashScreen.java --- @@ -255,6 +259,10 @@ public void run() { } splashDia

[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...

2015-12-23 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166976789 :+1: thanks, @TheBosZ! I will merge this tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...

2015-12-23 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r48373317 --- Diff: src/android/SplashScreen.java --- @@ -255,6 +259,10 @@ public void run() { } splashDia

[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...

2015-12-23 Thread TheBosZ
Github user TheBosZ commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166975687 Okay, it was messy but I squished it into one commit and changed it to just be a single preference to force full screen. --- If your project is set

[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...

2015-12-23 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166968629 Yeah, this is a good idea, kills two birds with one stone. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options

2015-12-23 Thread TheBosZ
Github user TheBosZ commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166966495 If we do the workaround, there's no sense in having 2 separate preferences. What about rolling them into a "SplashFullScreen" preference? --- If yo

[GitHub] cordova-plugin-splashscreen pull request: CB-9538 - Implementing F...

2015-12-23 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-166959203 @trancee, could you please update this to be consistent with the current documented format [`FadeSplashScreenDuration (float, defaults to 3000)`](ht

[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options

2015-12-23 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166947682 Workaround for the 4.3 issue: ```java if(isHideNavigationBar() && isHideStatusBar()) { splashDialog.getWindow().setFlags(WindowManage

[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options

2015-12-23 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166941739 Added a Jira issue: [CB-10255 Add options to hide splashscreen navigation and status bars on Android](https://issues.apache.org/jira/browse/CB-10255)

[GitHub] cordova-docs pull request: Update index.md

2015-12-23 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-docs/pull/443#issuecomment-166924126 А перевод правится напрямую через PR или через [Crowdin](https://crowdin.com/translate/cordova/3599/en-ru)? --- If your proje

[GitHub] cordova-docs pull request: Update index.md

2015-12-23 Thread kant2002
Github user kant2002 commented on the pull request: https://github.com/apache/cordova-docs/pull/443#issuecomment-166919161 @Kalyanova как вы думаете, "общий для всех платформ" кажется вам верным? --- If your project is set up for it, yo

[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options

2015-12-23 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166910285 @TheBosZ, I would just document that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-ios pull request: CB-10233: Support different config.xml f...

2015-12-23 Thread mirkoluchi
Github user mirkoluchi commented on the pull request: https://github.com/apache/cordova-ios/pull/186#issuecomment-166891897 Hi, I added some tests to assert that the correct config file is loaded. If you this other regression tests are needed, please tell me and I'll try to figure