Running tests

2015-12-28 Thread Sean Kelly
I'm interested in contributing to cordova-plugin-inappbrowser I read in the contributor guidelines: When we say "run the test suites" this includes: - All automated tests in cordova-mobilespec - Manual tests in cordova-mobilespec that might be affected by the change - npm test for JS li

Introduction

2015-12-28 Thread Sean Kelly
Hi, My name is Sean Kelly and I have been a professional developer for over 32 years. Still love it, wouldn't do anything different. I've been playing with mobile since before the days of WML when SkyTel had a pager that would let you send email messages by laboriously tapping them out using only

[GitHub] cordova-plugin-statusbar pull request: CB-10118 Fixes error plugin...

2015-12-28 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/43 CB-10118 Fixes error plugin loading error in browser platform Fix for https://issues.apache.org/jira/browse/CB-10118 You can merge this pull request into a Git repository b

[GitHub] cordova-plugin-statusbar pull request: CB-9513 Allow to show/hide ...

2015-12-28 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/42 CB-9513 Allow to show/hide status bar in fullscreen mode Fix for https://issues.apache.org/jira/browse/CB-9513 You can merge this pull request into a Git repository by runn

[GitHub] cordova-plugin-geolocation pull request: CB-8443 Android: nothing ...

2015-12-28 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/61 CB-8443 Android: nothing happens if GPS is turned off https://issues.apache.org/jira/browse/CB-8443 * Documented native Android behavior when location service is turned o

[GitHub] cordova-plugin-splashscreen pull request: Set scale type to CENTER...

2015-12-28 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/52#issuecomment-167639086 dev-list discussion thread: http://callback.markmail.org/thread/n42b7xoawqyn2vpv --- If your project is set up for it, you can reply to this email

CB-10222 Add scaletype preference for Android splashscreen

2015-12-28 Thread Sergey Shakhnazarov (Akvelon)
Hi guys, I wanted to discuss the SplashScreen plugin PR for Android adding ability to customize splash image scale type[1] to avoid its cutting. Proposed solution is to make this an Android-preference like this: Is there any suggestions on implementation or objections? [1]: https://github

RE: writing a binary file

2015-12-28 Thread Sergey Grebnov (Akvelon)
I would recommend to see how this is done in cordova-plugin-file unit tests, for example file.spec.104 should be able to write binary data from an ArrayBuffer https://github.com/apache/cordova-plugin-file/blob/master/tests/tests.js#L2659 Thx! Sergey -Original Message- From: Allan Edward

writing a binary file

2015-12-28 Thread Allan Edwards
Does anyone out there have a recommendation on the best approach for writing a binary file in cordova? Thanks!!! Allan -- W Allan Edwards 214-289-2959

[GitHub] cordova-plugin-geolocation pull request: CB-10204 Fix getCurrentPo...

2015-12-28 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/60 CB-10204 Fix getCurrentPosition options on Android https://issues.apache.org/jira/browse/CB-10204 Args is an object, not array, and should be passed as-is. You can merge

[GitHub] cordova-plugin-geolocation pull request: CB-7146 Remove built-in W...

2015-12-28 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/59 CB-7146 Remove built-in WebView navigator.geolocation manual tests Those tests add additional complexity while testing as you need to scroll over those tests to see results and c

[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...

2015-12-28 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-167622467 @TheBosZ, I've tested this once more and found a bug reproducing on 4.0.3 and 5.0.1 that there is a small content movement to the bottom (in case of

[GitHub] cordova-labs pull request: CB-10080 Rewrite file-transfer server n...

2015-12-28 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-labs/pull/12#issuecomment-167609548 @dblotsky Did you get the server back up after you got the VM rebuilt? --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-labs pull request: CB-10080 Rewrite file-transfer server n...

2015-12-28 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-labs/pull/12#issuecomment-167609442 @dblotsky, did we get the server back up? On Mon, Dec 21, 2015 at 2:07 AM, Sergey Shakhnazarov < notificati...@github.com> wrote: > Merged. @

[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...

2015-12-28 Thread TheBosZ
Github user TheBosZ commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-167591082 Sounds good to me :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cordova-docs pull request: Update index.md

2015-12-28 Thread h2ospace
GitHub user h2ospace opened a pull request: https://github.com/apache/cordova-docs/pull/448 Update index.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/h2ospace/cordova-docs patch-3 Alternatively you can review and apply the

[GitHub] cordova-plugin-splashscreen pull request: CB-10263 Fix splashscree...

2015-12-28 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/69#issuecomment-167555343 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cordova-plugin-geolocation pull request: CB-2845 PositionError con...

2015-12-28 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/58#issuecomment-167549986 OK, I'll give it a shot when I get to geolocation tests. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-plugin-geolocation pull request: CB-2845 PositionError con...

2015-12-28 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/58#issuecomment-167549762 @alsorokin please see if you can extend one of the tests you are currently working on to cover this test as well (PositionError can't be instantiated

[GitHub] cordova-plugin-geolocation pull request: CB-2845 PositionError con...

2015-12-28 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/58 CB-2845 PositionError constants not attached to prototype as per W3C https://issues.apache.org/jira/browse/CB-2845 You can merge this pull request into a Git repository by runnin

[GitHub] cordova-plugin-network-information pull request: Adding cell type ...

2015-12-28 Thread edparsons
GitHub user edparsons opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/36 Adding cell type to iOS7 and greater Using CoreTelephony and currentRadioAccessTechnology, this add the ability to iOS developer to see the radio type (2g,3g,4g) so they

[GitHub] cordova-plugin-splashscreen pull request: CB-10263 Fix splashscree...

2015-12-28 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/69#issuecomment-167517585 @jcesarmobile, thanks for reviewing, I've addressed the notes. Looks like these prefixes mean iOS version and I believe it's not documented.