[GitHub] cordova-weinre pull request: Allow CORS

2015-12-30 Thread pmuellr
Github user pmuellr commented on the pull request: https://github.com/apache/cordova-weinre/pull/10#issuecomment-168134161 conversation for this PR happening on the issue - https://issues.apache.org/jira/browse/CB-10281 --- If your project is set up for it, you can reply to this

CB-7786 add mediaPlaybackRequiresUserAction for android JellyBean and beyond

2015-12-30 Thread Sean Kelly
Steve or another InAppBrowser Plugin committer, Could you please look at my first pull request https://github.com/apache/cordova-plugin-inappbrowser/pull/132 I have already received confirmation from Craig L Russell that my ICLA is approved and on file. Go Carefully, Sean Kelly P.S. I hope I

[GitHub] cordova-lib pull request: [CB-10274] Make www directory the defaul...

2015-12-30 Thread bradleyjames
GitHub user bradleyjames opened a pull request: https://github.com/apache/cordova-lib/pull/360 [CB-10274] Make www directory the default for plugman. New patch that addresses comments made here: https://github.com/apache/cordova-lib/pull/359. You can merge this pull request into a

[GitHub] cordova-lib pull request: [CB-10274] Make www directory the defaul...

2015-12-30 Thread bradleyjames
Github user bradleyjames commented on the pull request: https://github.com/apache/cordova-lib/pull/360#issuecomment-168031644 Noticed that uninstall suffers from the same issue. I'll address that at some point in the future (if I find the time and need). --- If your project is set

[GitHub] cordova-plugin-splashscreen pull request: CB-9538 - Implementing F...

2015-12-30 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-168023487 @trancee, I've updated this PR in #73 - please take a look. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-splashscreen pull request: CB-9538 Implementing Fad...

2015-12-30 Thread trancee
Github user trancee commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/73#issuecomment-168099920 Looks good, thank you for updating and cleaning this up :) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-weinre pull request: Allow CORS

2015-12-30 Thread appfeel
GitHub user appfeel opened a pull request: https://github.com/apache/cordova-weinre/pull/10 Allow CORS You can merge this pull request into a Git repository by running: $ git pull https://github.com/appfeel/cordova-weinre patch-1 Alternatively you can review and apply these

[GitHub] cordova-ios pull request: Stay attached to LLDB when running app

2015-12-30 Thread saghul
GitHub user saghul opened a pull request: https://github.com/apache/cordova-ios/pull/188 Stay attached to LLDB when running app https://github.com/apache/cordova-ios/commit/ba7bafdbd8d4dab29899a7a804a6bf8ad6893e51 added the `justlaunch` flag to `ios-deploy`, which conflicts with

[GitHub] cordova-plugin-geolocation pull request: CB-10277 Android: error c...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/62#discussion_r48596423 --- Diff: www/android/geolocation.js --- @@ -52,7 +62,20 @@ module.exports = { var geo =

[GitHub] cordova-plugin-geolocation pull request: CB-10278 geolocation watc...

2015-12-30 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/63#discussion_r48600376 --- Diff: www/android/geolocation.js --- @@ -38,21 +39,29 @@ module.exports = { }, watchPosition:

[GitHub] cordova-plugin-geolocation pull request: CB-10277 Android: error c...

2015-12-30 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/62#discussion_r48600533 --- Diff: www/android/geolocation.js --- @@ -52,7 +62,20 @@ module.exports = { var geo =

[GitHub] cordova-lib pull request: CB-10274 Honor --www parameter in plugma...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/359#discussion_r48599256 --- Diff: cordova-lib/src/plugman/install.js --- @@ -596,11 +596,14 @@ function handleInstall(actions, pluginInfo, platform, project_dir,

[GitHub] cordova-lib pull request: CB-10274 Honor --www parameter in plugma...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/359#issuecomment-167983975 IMO, better fix this by moving 'usePlatformWww' option setup to cordova-cli area of responsibility - somewhere around

[GitHub] cordova-plugin-geolocation pull request: CB-10278 geolocation watc...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/63#issuecomment-167969937 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-geolocation pull request: CB-2845 PositionError con...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/58#issuecomment-167972137 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-geolocation pull request: CB-7146 Remove built-in W...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/59#issuecomment-167973201 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-geolocation pull request: CB-10278 geolocation watc...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/63#discussion_r48596899 --- Diff: www/android/geolocation.js --- @@ -38,21 +39,29 @@ module.exports = { }, watchPosition:

[GitHub] cordova-plugin-splashscreen pull request: CB-9240 Cordova splash s...

2015-12-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-geolocation pull request: CB-8443 Android: nothing ...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/61#issuecomment-167972921 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request: CB-10274 Honor --www parameter in plugma...

2015-12-30 Thread bradleyjames
Github user bradleyjames commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/359#discussion_r48605088 --- Diff: cordova-lib/src/plugman/install.js --- @@ -596,11 +596,14 @@ function handleInstall(actions, pluginInfo, platform, project_dir,

[GitHub] cordova-lib pull request: CB-10274 Honor --www parameter in plugma...

2015-12-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/359#discussion_r48605174 --- Diff: cordova-lib/src/plugman/install.js --- @@ -596,11 +596,14 @@ function handleInstall(actions, pluginInfo, platform, project_dir,

[GitHub] cordova-lib pull request: CB-10274 Honor --www parameter in plugma...

2015-12-30 Thread bradleyjames
Github user bradleyjames commented on the pull request: https://github.com/apache/cordova-lib/pull/359#issuecomment-168009298 Seems like that will change the default install location for plugman (when not called from the cordova CLI) from platform_www to www. Is that what you're

[GitHub] cordova-plugin-statusbar pull request: CB-10118 Fixes error plugin...

2015-12-30 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/43#issuecomment-167989868 lgtm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-statusbar pull request: CB-8720 Fix status bar posi...

2015-12-30 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/44 CB-8720 Fix status bar position when app started upside down on iOS 7 https://issues.apache.org/jira/browse/CB-8720 You can merge this pull request into a Git repository

[GitHub] cordova-plugin-statusbar pull request: CB-9513 Allow to show/hide ...

2015-12-30 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/42#issuecomment-167990042 lgtm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-splashscreen pull request: CB-9538 Implementing Fad...

2015-12-30 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/73 CB-9538 Implementing FadeSplashScreen feature for Android FadeSplashScreen is supported by using AlphaAnimation to fade out the ImageView. Based on #71 [Jira