[DISCUSS] Cordova 6.0.0 Release!

2016-01-22 Thread Steven Gill
any objections or concerns? Some PRs or issues that need to get fixed before I do this? I want to try to get the vote out either later today or Monday. -Steve

[GitHub] cordova-docs pull request: added android 5.1.0 release blog post

2016-01-22 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/462#issuecomment-174035183 @stevengill great, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [Vote] 5.1.0 Android Release

2016-01-22 Thread Carlos Santana
+1 ran coho create-archive --tag 5.1.0 -r android --dest test-android/ compare pacakge and only minor differences in node_modules some extra test folders ran coho verify-archive vote-android51/ ran coho verify-tags -r android --tag 5.1.0 created hello-world app On Thu, Jan 21, 2016 at 10:08 AM

[GitHub] cordova-docs pull request: added android 5.1.0 release blog post

2016-01-22 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/462#issuecomment-174034814 Added it to the blog post! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

RE: Where is the link to dist/download from the site?

2016-01-22 Thread Dmitry Blotsky
Thanks for catching that! I'll find that link a home. Kindly, Dmitry -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Friday, January 22, 2016 11:28 AM To: Apache Cordova Dev Mailing List Subject: Where is the link to dist/download

[GitHub] cordova-docs pull request: CB-8917: Improving Android lifecycle do...

2016-01-22 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/461#issuecomment-174058199 @nikhilkh I added a much more detailed example and incorporated your other feedback --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-docs pull request: added android 5.1.0 release blog post

2016-01-22 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-docs/pull/462#issuecomment-174059584 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: CB-10389: Turning the config.xml doc pa...

2016-01-22 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-docs/pull/463 CB-10389: Turning the config.xml doc page into a reference XML doc Work In Progress You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

2016-01-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file pull request: Add the option to the installati...

2016-01-22 Thread rjsteinert
GitHub user rjsteinert opened a pull request: https://github.com/apache/cordova-plugin-file/pull/156 Add the option to the installation command so proper entries are written to config.xml You can merge this pull request into a Git repository by running: $ git pull

Where is the link to dist/download from the site?

2016-01-22 Thread Carlos Santana
I went to http://cordova.apache.org I search for download releases link https://dist.apache.org/repos/dist/release/cordova/ But I was not able to find it. Can we add this someone where if it's not there already? Maybe in the footer? I know people can use npm, but this particular use case I

[GitHub] cordova-plugin-file pull request: Add the option to the installati...

2016-01-22 Thread rjsteinert
Github user rjsteinert commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/156#issuecomment-174015064 Hi there - I'm relatively new to Cordova and still finding my way around. After reading the help docs for the `cordova plugin add` command, it became

RE: [DISCUSS] Old platforms support deprecation

2016-01-22 Thread Vladimir Kotikov (Akvelon)
Agree about 6 months. I suggested next Cordova major version as a deadline due to two reasons: this definitely will be a breaking change, so we'll need for major bump anyway; also the Cordova 5.0 lives for about 8 months (since Apr 2015), so I think Cordova 6 will live for approximately the

RE: [DISCUSS] Improving core plugins automated test coverage

2016-01-22 Thread Alexander Sorokin (Akvelon)
Thanks for suggesting saucelabs! I'll take a look at it. -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Thursday, January 21, 2016 4:25 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Improving core plugins automated test coverage Wow this is great! not

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

2016-01-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-android pull request: CB-10406 Fixes an exception, thrown ...

2016-01-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/250 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request: CB-10157 Uninstall app from device/e...

2016-01-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/251 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

2016-01-22 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-173872452 Tested and merged, thanks, @dpolivy! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2016-01-22 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-174067562 As @nikhilkh mentioned, the new fix requires both `cordova-plugin-camera@2.1.0` and `cordova-android@5.1.0`. Updating to both of those won't

Re: CB-7786 add mediaPlaybackRequiresUserAction for android JellyBean and beyond

2016-01-22 Thread Sean Kelly
Is there a reason a committer has not merged this yet? If there is something else I need to do please let me know. as far as I can figure I have crossed every t and dotted every i. Go Carefully, SeanK On Wed, Dec 30, 2015 at 11:24 AM, Sean Kelly wrote: > Steve or another

[GitHub] cordova-plugin-splashscreen pull request: CB-9516 Android SplashSc...

2016-01-22 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/75#issuecomment-173888951 Changed the ProgressDialog to custom only-spinner mode (on transparent background, without title/message and dimming) as per discussion in Slack.

[GitHub] cordova-plugin-splashscreen pull request: make android support Aut...

2016-01-22 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/71#issuecomment-173916348 @njleonzhang, what if `AutoHideSplashScreen` is `true` but we have a 10 seconds delay? In this case the app pausing (by pressing Home for

[GitHub] cordova-docs pull request: Multi-level ToC Implementation

2016-01-22 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/464 Multi-level ToC Implementation - Added support for nested ToCs using the `children` attribute - Retroactively made past ToC files use relative links - Made all dev ToCs use the new

[GitHub] cordova-ios pull request: Disable ios-deploy wifi mode when deploy...

2016-01-22 Thread bitjson
Github user bitjson commented on the pull request: https://github.com/apache/cordova-ios/pull/190#issuecomment-173967530 I was just looking for a solution to this, thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...

2016-01-22 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/136#issuecomment-173940439 @falkobuttler it has been reported https://issues.apache.org/jira/browse/CB-10407 For now you can keep using the old version of the plugin

[DISCUSS] Old platforms support deprecation

2016-01-22 Thread Vladimir Kotikov (Akvelon)
Hi guys. Starting from upcoming cordova release (6.0.0) we have PlatformApi implemented and used by three major platforms (Android, iOS and Windows). This means that we now have a lot of code in cordova-lib which exists there only for maintaining compatibility with previous platforms versions.

[GitHub] cordova-docs pull request: CB-8917: Improving Android lifecycle do...

2016-01-22 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/461#discussion_r50564887 --- Diff: www/docs/en/dev/guide/platforms/android/lifecycle.md --- @@ -80,14 +150,20 @@ The payload for the `resume` event adheres to the following

[GitHub] cordova-docs pull request: CB-8917: Improving Android lifecycle do...

2016-01-22 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/461#discussion_r50565637 --- Diff: www/docs/en/dev/guide/platforms/android/lifecycle.md --- @@ -80,14 +150,20 @@ The payload for the `resume` event adheres to the following

[GitHub] cordova-docs pull request: CB-8917: Improving Android lifecycle do...

2016-01-22 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/461#discussion_r50565878 --- Diff: www/docs/en/dev/guide/platforms/android/lifecycle.md --- @@ -80,14 +150,20 @@ The payload for the `resume` event adheres to the following

Re: [DISCUSS] Old platforms support deprecation

2016-01-22 Thread Steven Gill
I think depreciation should be our usual 6 months instead of cordova 7. Who knows how fast or slow cordova 7 will come out. Doing this, it would mean we would drop support for the platforms that don't update to PlatformAPI. We have already started the process for deprecating amazon-fireos and

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2016-01-22 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-173988746 @riknoll Can you please provide details of your solution for this. We have fixed this in cordova-android and cordova-plugin-camera. It will require

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

2016-01-22 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-173989565 I don't completely understand why you are packaging '.dll' as a resource file? Can you explain your scenario? --- If your project is set up for it, you can

[GitHub] cordova-docs pull request: Multi-level ToC Implementation

2016-01-22 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/464#discussion_r50610703 --- Diff: www/_data/toc/de-dev-manual.yml --- @@ -1,19 +1,70 @@ -- {name: "Reisef\xFChrer", url: !!python/unicode '/docs/de/dev/'} -- {name:

[GitHub] cordova-lib pull request: New plugin version selection implementat...

2016-01-22 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-lib/pull/363 New plugin version selection implementation @stevengill @dblotsky please review. This is an implementation for the plugin version selection scheme that Dmitry and I proposed in [this discuss