[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-docs/pull/479#issuecomment-178764725 @riknoll Fixed the spacing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/463#issuecomment-178799405 I'm fine with using "Required" instead of "Required: true", as long as other docs get updated to use this convention. --- If your project is set up for it, you

[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...

GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-docs/pull/479 CB-10503: Documentation link points to 'latest' version even in latest buils Fixed the link to point to dev version of the docs in development @dblotsky @riknoll @rakatyal

[GitHub] cordova-lib pull request: CB-10459: cordova platform list should m...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-lib/pull/368#issuecomment-178758457 @riknoll Can you merge this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: CB-10459: cordova platform list should m...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-lib/pull/368#issuecomment-178759702 @vladimir-kotikov Can you please review and merge this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

Github user riknoll commented on the pull request: https://github.com/apache/cordova-medic/pull/73#issuecomment-178801188 @dblotsky I don't think there is an easy way to get the running simulator, so instead I am going to move the simulator choosing logic from `cordova run` to medic

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/463#issuecomment-178829332 @omefire I noticed you merged this without squashing - please do that in the future it helps with maintaining a meaningful history on git.

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51643532 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51637838 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51637888 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51642241 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51642666 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`,

[GitHub] cordova-plugin-device pull request: chore: edit package.json licen...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51642289 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51643217 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/74#discussion_r51643160 --- Diff: lib/testcheck.js --- @@ -21,22 +21,40 @@ "use strict"; -module.exports = function (sha, dbHost) { +module.exports

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-lib/pull/370#issuecomment-178861517 Is this a part of our external API? If not, then why should there be a way to get them without the debugger if it's an internal feature? --- If your project is

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/480#discussion_r51646371 --- Diff: www/docs/en/dev/cordova/events/events.md --- @@ -22,29 +22,561 @@ title: Events # Events -> Cordova lifecycle events.

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51631675 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -45,207 +45,356 @@ passively copied into various `platforms/` subdirectories, for example:

[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/147#issuecomment-178816734 +1 Windows 8.0 has been deprecated since Apr 13, 2015, let's cleanup so we can provide better focus. --- If your project is set up for it, you can

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-medic/pull/74#issuecomment-178850170 @dblotsky Yes. We have seen the timeouts 4 times last week. I was able to connect to the VM (and get the same results) right at the same time it was failing in

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-docs/pull/480#issuecomment-178857041 @riknoll Added link to Android Life Cycle Guide --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51631119 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -45,207 +45,356 @@ passively copied into various `platforms/` subdirectories, for example:

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51638474 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-docs/pull/480 CB-10351: Make Events page a reference Made the Events page a reference @nikhilkh @dblotsky @rakatyal @riknoll @omefire Can you please review and merge this PR? You can merge

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51642981 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -45,207 +45,356 @@ passively copied into various `platforms/` subdirectories, for example:

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51643080 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/480#discussion_r51646137 --- Diff: www/docs/en/dev/cordova/events/events.md --- @@ -22,29 +22,561 @@ title: Events # Events -> Cordova lifecycle events.

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51630990 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -45,207 +45,356 @@ passively copied into various `platforms/` subdirectories, for example:

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51630971 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -22,8 +22,8 @@ title: The config.xml File # The config.xml File --- End diff --

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51638042 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51638568 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/480#issuecomment-178844879 Resume event should add an Android quirk that points to this page: http://cordova.apache.org/docs/en/dev/guide/platforms/android/lifecycle.html --- If your

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51642563 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/480#discussion_r51646921 --- Diff: www/docs/en/dev/cordova/events/events.md --- @@ -22,29 +22,561 @@ title: Events # Events -> Cordova lifecycle events.

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/480#discussion_r51648033 --- Diff: www/docs/en/dev/cordova/events/events.md --- @@ -22,29 +22,561 @@ title: Events # Events -> Cordova lifecycle events.

[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/479#issuecomment-178871753 We have another variable, `latest_docs_version`, whose name sounds like this one. Please rename this variable to something more explicit (like

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/480#discussion_r51649541 --- Diff: www/static/js/docs.js --- @@ -40,7 +40,7 @@ $(document).ready(function () { // Table of Contents $('#page-toc').toc({

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51648894 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`,

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/480#issuecomment-178870956 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/479#issuecomment-178872081 +1 to @dblotsky's comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/480#discussion_r51649012 --- Diff: www/docs/en/dev/cordova/events/events.md --- @@ -22,29 +22,560 @@ title: Events # Events -> Cordova lifecycle events.

[GitHub] cordova-docs pull request: CB-10516: Remove h3-h6 from showing up ...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/481#issuecomment-178882554 I'm still a bit unconvinced that all H3 - H6 headings should be excluded from ToC across the board. This is specific to the reference pages, isn't it? --- If

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/480#issuecomment-178872563 +1 to Richard's previous comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request: CB-10516: Remove h3-h6 from showing up ...

GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-docs/pull/481 CB-10516: Remove h3-h6 from showing up in docs ToC Removing h3-h6 from showing up in docs ToC @dblotsky @riknoll @nikhilkh Can you please review and merge this PR? You can merge

[GitHub] cordova-docs pull request: CB-10516: Remove h3-h6 from showing up ...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/481#issuecomment-178880580 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/73#issuecomment-178865169 Yep, that sounds fine. I would even say not to worry about it if you want to leave it as it is: on the CI environment we have only one simulator/device anyway.

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/480#discussion_r51650131 --- Diff: www/static/js/docs.js --- @@ -40,7 +40,7 @@ $(document).ready(function () { // Table of Contents $('#page-toc').toc({

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/480#discussion_r51652071 --- Diff: www/docs/en/dev/cordova/events/events.md --- @@ -22,29 +22,386 @@ title: Events # Events -> Cordova lifecycle events.

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/74#issuecomment-178869407 Oh, I think I'm mistaking this for `testwait`. `testcheck` does *not* poll and yes, this is necessary. My mistake! Do you think this can be factored out to be in

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-medic/pull/74#issuecomment-178870049 @dblotsky I think both of them use slightly different libs (request and http). So, for now, I am leaving it as is. But, I am marking this for further changes

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51648833 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`,

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/480#issuecomment-178871869 I mentioned this offline, but do we want to include the full example for each event? Adds a lot of length to the document and all of the examples are the same

[GitHub] cordova-osx pull request: CB-10085 Implement and expose PlatformAp...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/480#discussion_r51650887 --- Diff: www/static/js/docs.js --- @@ -40,7 +40,7 @@ $(document).ready(function () { // Table of Contents $('#page-toc').toc({

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-docs/pull/480#issuecomment-178875194 @riknoll @rakatyal @dblotsky Removed the full examples for all except required. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/480#discussion_r51651551 --- Diff: www/static/js/docs.js --- @@ -40,7 +40,7 @@ $(document).ready(function () { // Table of Contents

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/480#discussion_r51651548 --- Diff: www/static/js/docs.js --- @@ -40,7 +40,7 @@ $(document).ready(function () { // Table of Contents $('#page-toc').toc({

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/480#discussion_r51651676 --- Diff: www/static/js/docs.js --- @@ -40,7 +40,7 @@ $(document).ready(function () { // Table of Contents

[GitHub] cordova-docs pull request: CB-10516: Remove h3-h6 from showing up ...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/481#issuecomment-178884046 No, I don't think it is. What special meaning does H3+ have in the TOC? All of our TOC entries for a page are presented without hierarchy in the sidebar; H3+ lose

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-lib/pull/369#issuecomment-178885626 Yep, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51664527 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -39,222 +39,357 @@ Note that before version 3.3.1-0.2.0, the file existed at `app/www/config.xml`,

[GitHub] cordova-docs pull request: CB-10516: Remove h3-h6 from showing up ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/481 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-medic/pull/74#issuecomment-178945513 @dblotsky is this good to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51665030 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -45,207 +45,356 @@ passively copied into various `platforms/` subdirectories, for example:

[GitHub] cordova-docs pull request: CB-10503: Documentation link points to ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/479 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

Github user riknoll commented on the pull request: https://github.com/apache/cordova-medic/pull/73#issuecomment-178919636 Alright I'm going to leave it as is and I'll change it if it becomes an issue. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/463#discussion_r51664771 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -45,207 +45,356 @@ passively copied into various `platforms/` subdirectories, for example:

[GitHub] cordova-ios pull request: generates a workspace instead of subproj...

Github user yjukaku commented on the pull request: https://github.com/apache/cordova-ios/pull/104#issuecomment-178796116 @edewit Can you please clarify what you mean? To be able to use CocoaPods, we still need a workspace to be generated instead of a project with a sub-project. ---

[GitHub] cordova-docs pull request: CB-10351: Make Events page a reference

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/480#issuecomment-179025411 I'm assuming your grep'd for any incoming links to the files that you are deleting. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-inappbrowser pull request: CB-7786 android: add new...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/132#issuecomment-179030795 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

RE: [VOTE] InAppBrowser Plugin Release

Hi Sean, such discussion should happen in [Discuss] thread, before vote is started. CB-7786 introduces new functionality so this should be in minor or major release anyway. I've reviewed your PR and it looks good, I'll merge it later today. Thx! -Sergey -Original Message- From: Steven

[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/147#issuecomment-179031723 Reviewed changes, :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...

Github user chrigi commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-178437613 @daserge I tried it on Windows Mobile 10 (windows engine) Lumia 950 XL. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-lib pull request: CB-10497 Prefer .bat over .cmd on window...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/371#issuecomment-178623860 Tested this, and it seems to work fine. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-lib pull request: CB-10497 Prefer .bat over .cmd on window...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/371 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: Can you help me test/review this commit? ( ios statusbar plugin iPad multitask )

Thanks for testing. Did you try with my index.html? do the red boxes always appeared on the app corners? CB-10288 is about webview not resizing correctly in multitasking screens (Split View - Slide Over) 2016-02-02 3:15 GMT+01:00 Carlos Santana : > Julio I tested on my iPad

[GitHub] cordova-plugin-device pull request: chore: edit package.json licen...

Github user t1st3 commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/48#issuecomment-178503196 just read CONTRIBUTING.md (after the contribution, sorry for that), and signed the ICLA. --- If your project is set up for it, you can reply to this email

RE: [Discuss] Deprecate platform Windows 8.0

Hi guys, Please review the PR [1] removing Windows 8.0 project, specific code, references and adding a deprecation message: "windows8 platform is deprecated. To use windows-target-version=8.0 you may downgrade to cordova-windows@4." The target version for this is cordova-windows@5 as this will

[GitHub] cordova-plugin-device pull request: chore: edit package.json licen...

GitHub user t1st3 opened a pull request: https://github.com/apache/cordova-plugin-device/pull/48 chore: edit package.json license to match SPDX id See [NPM package.json spec for licenses](https://docs.npmjs.com/files/package.json#license) and [SPDX license

[GitHub] cordova-docs pull request: Execute jekyll in the context of the bu...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/477#issuecomment-178520738 @zhangkaizhao before we merge, please also add this to the Makefile. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/369#issuecomment-178520650 @dblotsky, it seems that didn't really understand your idea. Could you please clarify, where do you propose to return `stdout` and `stderr` from? --- If

Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

Is this basically just adding a UI then? Kindly, Dmitry > On Feb 1, 2016, at 11:48 PM, Vladimir Kotikov (Akvelon) > wrote: > >> What is the impact to our workflow? are we just adding a node dependency, or >> are there other config/integration parts that we need to do?

[VOTE] InAppBrowser Plugin Release

Please review and vote on the InAppBrowser plugin release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10505 The plugin has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10505/ The

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-lib/pull/369#issuecomment-178512699 @vladimir-kotikov you still need to subscribe a callback, just using `progress` instead of `on("data")`. However using `progress` creates a *new* API, while using

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-lib/pull/369#issuecomment-178526013 Ah, it seems like I'm the one that's confused. I didn't know that `progress` was a standard promise function. Returning `child` is what I meant, but that would

[GitHub] cordova-docs pull request: Execute jekyll in the context of the bu...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/477#issuecomment-178520326 This is a great feature that I had no idea about. Thank you, @zhangkaizhao, for contributing this piece of Ruby/Bundle knowledge! --- If your project is set up

[GitHub] cordova-plugin-camera pull request: Chrome , Uncaught TypeError: l...

Github user davetayls commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/154#issuecomment-178571365 Thanks Tim, looks good. Are you able to close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-docs pull request: CB-10481 Update the docs according to w...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/478 CB-10481 Update the docs according to windows8 deprecation [Jira issue](https://issues.apache.org/jira/browse/CB-10481) You can merge this pull request into a Git repository by running:

[GitHub] cordova-docs pull request: CB-10389: Turning config.xml documentat...

Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/463#issuecomment-178958029 Additional review comments handled and committed. Thanks ! --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: [VOTE] InAppBrowser Plugin Release

I'd vote no. I'd really like to see CB-7786 get in before the next release. SeanK On Tue, Feb 2, 2016 at 4:17 AM, Sergey Grebnov (Akvelon) < v-seg...@microsoft.com> wrote: > Please review and vote on the InAppBrowser plugin release > by replying to this email (and keep discussion on the DISCUSS

Re: [VOTE] InAppBrowser Plugin Release

Hey Sean, We only -1 if it is a regression or major bug found. I would say CB-7786 doesn't qualify as either of those. According to ASF policies, only PMC members can vote. I know you have been trying to get someone to review your PR. I'll bug some people tomorrow to see if we can get it

Re: Can you help me test/review this commit? ( ios statusbar plugin iPad multitask )

yes I tried it your index.html, red boxes some time disappear but they also disappear on simulator so didn't know what you were looking for. ping me tomorrow on slack, maybe I can screen share and do a live session. On Tue, Feb 2, 2016 at 9:18 AM julio cesar sanchez

RE: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

This is not only about visualization. Codecov also stores previous result and performs an analysis, how coverage has changed. Take a look at the comment, made by codecov bot at the PR: https://github.com/vladimir-kotikov/cordova-lib/pull/2 - Best regards, Vladimir -Original Message-

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-lib/pull/370#issuecomment-178555686 @vladimir-kotikov I guess my point is: why is it necessary for internal `cordova-common` events to reach platform code? --- If your project is set up for it, you

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/369#issuecomment-178564407 @dblotsky, is this good to go? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

RE: [VOTE] Cordova windows 4.3.1 release

I vote +1. * Verified archives via `coho verify-archive` * Verified tag manually * Verified that blank app creates correctly with platform * Verified that blank app can be successfully built and ran * Verified that platform can be updated from previous version * Verified compatibility with core

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/370#issuecomment-178554295 @dblotsky, @purplecabbage, thanks for feedback. Agree, this probably smells fishy. However, the only one option i see apart from this one is to setup a

[GitHub] cordova-docs pull request: Multi-level ToC Implementation

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/464#issuecomment-178554331 @nikhilkh Fixed. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-docs pull request: Multi-level ToC Implementation

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/464 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

  1   2   >