I vote +1
* Run auto-tests for core plugins with browserify option on iOS 8.1.1 device.
Log available at [1]
* Reviewed release notes
[1] https://gist.github.com/sgrebnov/8f0e59f010dac7d4cfa9
-Sergey Grebnov
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Tu
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/265#discussion_r54531747
--- Diff: bin/templates/cordova/lib/pluginHandlers.js ---
@@ -31,7 +31,7 @@ var handlers = {
if (!obj.src) throw new Cordova
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/38
CB-10636 Add JSHint for plugins
[Jira issue](https://issues.apache.org/jira/browse/CB-10636)
You can merge this pull request into a Git repository by running:
$ git p
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-windows/pull/153#issuecomment-190586588
@jerroydmoore, @purplecabbage is right: that was my mistake. The ICLA is
not required, but if you plan to contribute more it would be awesome to get it
out of
Martin, a quick question. To encourage people to contribute to documentation,
we added an "EDIT" button at the top right corner, which links you directly to
the github repo and page.
Looks like you wanted to help with documentation, but were having trouble with
it. Was the "EDIT" button confusi
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/526#issuecomment-190585760
@riknoll @nikhilkh please review when you have a moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-docs/pull/526
CB-10744 Fixing fragment link handling
Adding support for name-based fragment anchors and anchors to IDs with
special characters.
You can merge this pull request into a Git repository by run
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/403
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/57
CB-10636 Add JSHint for plugins
Added cordova-plugin-media dependency for manual tests
[Jira issue](https://issues.apache.org/jira/browse/CB-10636)
You can merge this p
GitHub user ThillaiganeshChan opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/183
Fix for CB-10050 : Plugin Camera : Inconsistent saveToPhotoAlbum behaâ¦
â¦vior on PHOTOLIBRARY images
If sourceType == UIImagePickerControllerSourceTypePhotoLibrar
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/392#issuecomment-190575330
We need to add this to the docs. @andorman - Could you submit a PR to this
page?
https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/config_ref/imag
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-190569199
@TimBarham @vladimir-kotikov Can you please take a look in the next couple
of days? It will be good to get this committed and do a release.
---
If your project is
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/153#issuecomment-190568771
To be clear, an ICLA is not required, but it is prefered.
This was a one liner, and should not get any ICLA scrutiny.
The failed CI tests however me
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/264#issuecomment-190564383
@vladimir-kotikov to review. Is there a test case that we can add? PR #265
has a good framework for testing something like this.
---
If your project is set up
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/265#issuecomment-190563854
LGTM - though one test is failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/265#discussion_r54526677
--- Diff: bin/templates/cordova/lib/pluginHandlers.js ---
@@ -31,7 +31,7 @@ var handlers = {
if (!obj.src) throw new CordovaError('
I think pinning plugins in the CLI is causing a bunch of confusion (see
CB-10677) as cordova plugin add might not get you the latest released plugin.
This is a change in behavior - perhaps - we should log when the plugin is
different from the latest released version. Also, there is an issue with
I vote +1
* Manually verified platform could be added, built and run (blank app)
* Run auto-tests for core plugins on Android 6.0 device (paramedic)
-Sergey Grebnov
-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com]
Sent: Tuesday, March 1, 2016 1:24 AM
To: dev
Subject: Re: [
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/525#issuecomment-190548530
@nikhilkh you might find this relevant too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/525#issuecomment-190548462
@sarangan12 @rakatyal please review when you have a moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-docs/pull/525
CB-10737 Fetching now errors out on invalid entries and non-200 responses.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cor
Just bumped the ios vote thread
On Mon, Feb 29, 2016 at 7:06 PM, Carlos Santana
wrote:
> Sorry that I have being MIA, was at IBM conference at Vegas, and what
> happened stayed there :-)
>
> Where we are with iOS release?
>
> I guess I was late to the Android 5.1.1 party that vote is done.
>
>
>
bump
On Fri, Feb 26, 2016 at 3:46 PM, Steven Gill wrote:
> Please review and vote on this 4.1.0 iOS Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-10693
>
> The archive has been published to
> dist/dev:
GitHub user weexpectedTHIS opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/88
Update README
Fixed mispelling
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/weexpectedTHIS/cordova-plugin-splashscr
Github user njleonzhang closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user njleonzhang commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/71#issuecomment-190519470
create new PR [ [android] stop hide splash when pause
#87](https://github.com/apache/cordova-plugin-splashscreen/pull/87) and close
this one.
GitHub user njleonzhang opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/87
[android] stop hide splash when pause
according to discuss in [make android support
AutoHideSplashScreen](https://github.com/apache/cordova-plugin-splashscreen/pull/71)
Michael
Glad that you took the step forward to contribute to open source, we
appreciate any help you can provide.
On Mon, Feb 29, 2016 at 4:48 PM Steven Gill wrote:
> Welcome Michael!
>
> Join us on slack too! slack.cordova.io
>
> On Mon, Feb 29, 2016 at 1:45 PM, julio cesar sanchez <
> jcesa
Hi Martin
There file is located in the cordova-docs
https://github.com/apache/cordova-docs/blob/master/www/docs/en/6.x/guide/platforms/android/index.md
Go ahead and send a PR
On Mon, Feb 29, 2016 at 8:54 PM Martin Wheeler
wrote:
> Hi List,
>
> I'm not really sure if this should be sent in her
Sorry that I have being MIA, was at IBM conference at Vegas, and what
happened stayed there :-)
Where we are with iOS release?
I guess I was late to the Android 5.1.1 party that vote is done.
On Thu, Feb 25, 2016 at 9:26 PM Steven Gill wrote:
> I sent a PR with the bug fix.
> https://github.c
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-windows/pull/153#issuecomment-190507979
@jerroydmoore ping. Sorry, the code fails the CI tests and has been
reverted. Please revise and resubmit the PR, and please submit an ICLA
(guidelines [here][c
Hi List,
I'm not really sure if this should be sent in here but if someone could
point me in the right place that would be great too.
I found a spelling mistake on the Documentation page for the Android
Platform Guide.
https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-190482871
Alright, this should be ready for review. The changes I just pushed
included a few fixes to edge cases, better handling of malformed
input/whitespace, and a lot mor
GitHub user alin1771 opened a pull request:
https://github.com/apache/cordova-android/pull/266
Update SystemWebViewEngine
There is no point of having font size under 1px (which is default minimum
size) BUT when we use EM and REM units there might be some UI issues when the
equivale
I vote +1
* Verified archives via `coho verify-archive`
* Verified tags manually
* Verified that blank app creates correctly with platform
* Verified that blank app can be successfully ran and built
* Ran mobilespec for master versions
Side Note: I like what Alexander did for this one, and I trus
Welcome Michael!
Join us on slack too! slack.cordova.io
On Mon, Feb 29, 2016 at 1:45 PM, julio cesar sanchez wrote:
> Welcome Michael.
>
> Make sure you read the contributor guidelines
> https://cordova.apache.org/contribute/contribute_guidelines.html
>
> Easyfix issues are a good starting poin
Welcome Michael.
Make sure you read the contributor guidelines
https://cordova.apache.org/contribute/contribute_guidelines.html
Easyfix issues are a good starting point.
2016-02-29 21:49 GMT+01:00 Michael Baldwin :
> Hey everyone, I'm Michael Baldwin and I'm a Computer Science student at
> Ar
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-190409102
just started reviewing this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Hey everyone, I'm Michael Baldwin and I'm a Computer Science student at
Arizona State University. I'm currently finishing up my Junior year and
looking to get some real world experience in development. So I'm here to
get some bugs fixed, receive criticism, and hopefully learn a ton! Cordova
is t
Github user EddyVerbruggen commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/66#issuecomment-190339317
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-190331301
I have significant changes to push in response to some feedback, so don't
review yet. I'll comment when they're in.
---
If your project is set up for it, you can r
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-190330639
@vladimir-kotikov to also take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/403#issuecomment-190322633
LGTM. Ideally, we need test cases for this - but I can understand this
might be tricky to test.
---
If your project is set up for it, you can reply to this email
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/180#issuecomment-190322533
@daserge: Thanks for pointing out. Making the needed changes.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user Sinistralis commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-190311984
When I created this, it was meant to be used as a proof of concept for
something at my place of employment. We recently dropped this path so I h
Github user lamuertepeluda commented on the pull request:
https://github.com/apache/cordova-plugin-device-orientation/pull/19#issuecomment-190303075
Why is this still not being merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-android/pull/265
CB-10729 Move plugin handlers tests for into platform's repo
JIRA: https://issues.apache.org/jira/browse/CB-10729
You can merge this pull request into a Git repository by running:
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/155
CB-10730 Move plugin handlers tests for into platform's repo
JIRA: https://issues.apache.org/jira/browse/CB-10730
You can merge this pull request into a Git repository by running:
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/180#issuecomment-190258578
@rakatyal, looks like JSHint has discovered some
[issues](https://travis-ci.org/apache/cordova-plugin-camera/builds/112161028)
with the code.
---
If yo
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/83
CB-10636 Add JSHint for plugins
[Jira issue](https://issues.apache.org/jira/browse/CB-10636)
You can merge this pull request into a Git repository by running:
$ git pull https://gi
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/66#issuecomment-190252239
Thanks
That shows the NSUIInteger to int conversion warning
To show the 'action' is shadowing an already declared variable I had to
change th
Github user EddyVerbruggen commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/66#issuecomment-190249697
Thanks for checking it so quickly.
What gets reported as warnings depends on how strict your Xcode project is
set up. In this case fi. tha
Github user Taewa commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-190242215
My streaming player got much faster. Thank you.
But I had to install this version through
`sudo cordova plugin add cordova-plugin-media@2.2`
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/66#issuecomment-190240106
Changes look good to me, but how did you get those error messages? If I
open CDVNotification.m on Xcode 7.2.1 I don't get them.
---
If your project
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-globalization/pull/45
CB-10636 Add JSHint for plugins
[Jira issue](https://issues.apache.org/jira/browse/CB-10636)
You can merge this pull request into a Git repository by running:
$ git pull ht
GitHub user kovacs-tamas opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/182
Blackberry camera fix
Fixes:
- Rotate the picture to the proper position (it was always rotated with 90
degrees)
- Resize the picture to the configured size (the origin
GitHub user EddyVerbruggen opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/66
CB-10727 Dialogs plugin has warnings on iOS
Should fix https://issues.apache.org/jira/browse/CB-10727
You can merge this pull request into a Git repository by running:
$ g
I vote +1:
* Verified archives via `coho verify-archive`
* Verified tags manually
* Verified that blank app creates correctly with platform
* Verified that blank app can be successfully ran and built
* Verified that platform can be updated from previous version
* Verified compatibility with core p
Github user adamscybot commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-190153265
With a project as popular as cordova is -- its so disappointing to see most
of the "official" plugins are bug ridden and feel abandoned.
---
If your
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/403
CB-10708 Install/uninstall plugins correctly into CLI project using plugman
JIRA: https://issues.apache.org/jira/browse/CB-10708
This forces plugman to install plugin's www fil
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/127#issuecomment-190111236
Addressed, thanks @vladimir-kotikov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/105
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/105#issuecomment-190093511
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user josergcatmisatravelcom commented on the pull request:
https://github.com/apache/cordova-browser/pull/10#issuecomment-190085378
I had to patch my project to use the latest version. Remove the platform
with "cordova platform remove firefoxos", then add it back with "cordova
67 matches
Mail list logo
