[GitHub] cordova-docs pull request: Cb 10637

2016-03-14 Thread dhams
Github user dhams commented on the pull request: https://github.com/apache/cordova-docs/pull/504#issuecomment-196665529 closing this PR as that changes has already been covered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-docs pull request: Cb 10637

2016-03-14 Thread dhams
Github user dhams closed the pull request at: https://github.com/apache/cordova-docs/pull/504 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

2016-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-cli pull request: Simplify cordova CLI readme

2016-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/240 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: Simplify cordova CLI readme

2016-03-14 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-cli/pull/240#issuecomment-196664292 I'm sorry - I don't fully follow your intent. This doc has complete details of the `create` command: http://cordova.apache.org/docs/en/latest/cordova-cli/index.htm

[GitHub] cordova-docs pull request: CB-10819 Adding snapshotting and improv...

2016-03-14 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/553#issuecomment-196658453 You'll need re-directs for all the links that you changed. Also, the docs have lots of references to them and they need to be changed. --- If your project is set

[GitHub] cordova-docs pull request: Blog post for Plugin release 03 12

2016-03-14 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/550#issuecomment-196652922 @csantanapr Can you please close this PR? Since this has already been merged and published. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-docs pull request: CB-10861 Add an example for apk signing...

2016-03-14 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/557#issuecomment-196652230 @riknoll to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

2016-03-14 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/548#issuecomment-196650847 Plugin publishing guide needed the same content as well - and most of the content was out-of-date. --- If your project is set up for it, you can reply to this em

[GitHub] cordova-plugin-contacts pull request: Disable 'calendar permission...

2016-03-14 Thread omefire
Github user omefire closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] cordova-medic pull request: Disabling ios 'contacts permissions pr...

2016-03-14 Thread omefire
Github user omefire closed the pull request at: https://github.com/apache/cordova-medic/pull/84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Correct translation errors

2016-03-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/556#issuecomment-196620750 @hoyajigi thank you for the PR! We use a translation system called Crowdin to translate our docs. Sorry, we didn't have a link on the page to explain this. Could

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

2016-03-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/548#issuecomment-196619953 Why did we decide to stop having this as a page of its own? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-docs pull request: Fix splashscreen typo in latest blogpos...

2016-03-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/503#issuecomment-196617482 @BBosman thank you for the PR! Sorry that it took us so long to get to it. I've applied your fix and also fixed another occurrence of `spashscreen` in the file.

[ANNOUNCE] Cordova Browser 4.1.0 release

2016-03-14 Thread Steven Gill
Tweet: https://twitter.com/apachecordova/status/709565655524048896 blog: http://cordova.apache.org/announcements/2016/03/04/cordova-browser-4.1.0.html

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

2016-03-14 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/548#discussion_r56107342 --- Diff: www/static/plugins/app.js --- @@ -458,7 +458,7 @@ var App = React.createClass({

Re: [ANNOUNCE] Plugin Release

2016-03-14 Thread Steven Gill
https://twitter.com/apachecordova/status/709563734931275777 On Mon, Mar 14, 2016 at 5:59 AM, Carlos Santana wrote: > bump, can someone send out tweet? > > > On Sat, Mar 12, 2016 at 8:28 PM Carlos Santana > wrote: > > > Blog: http://cordova.apache.org/news/2016/03/12/plugin-release.html > > > >

[GitHub] cordova-docs pull request: Update index.md

2016-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/541 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links

2016-03-14 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/551#issuecomment-196618485 @dblotsky I vote for using links #555 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cordova-docs pull request: Fix splashscreen typo in latest blogpos...

2016-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/503 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Update index.md

2016-03-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/541#issuecomment-196618479 @rachnac thanks for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cordova-docs pull request: Update about easing of Apple IOS restri...

2016-03-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/501#issuecomment-196615233 @shazron @stevengill please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cordova-docs pull request: Update index.md

2016-03-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/500#issuecomment-196614727 @ozeranskiy thank you for the PR! Sorry that it took us so long to get to it. I've also applied this page in [Crowdin]. [Crowdin]: https://crowdin.com/tra

[GitHub] cordova-docs pull request: Update index.md

2016-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/500 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Instructions about signing and releasin...

2016-03-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/212#issuecomment-196609045 @manuganji is this change still applicable? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cordova-docs pull request: CB-7949 Added docs for cordova-local ut...

2016-03-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/259#issuecomment-196605825 @stacic is this proposal still active? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cordova-docs pull request: Corrected preference name in example

2016-03-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/299#issuecomment-196603625 @vikash thanks for the PR! Sorry that it took us so long to get to it. There have been some major changes to the docs since this PR, and this error may have been

[GitHub] cordova-docs pull request: CB-7015 Support copying a lib-file from...

2016-03-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/314#issuecomment-196601849 @mbektchiev thanks for the PR! Sorry that it took so long to get to it. Given that apache/cordova-lib#290 is closed, is this change still valid? --- If your proj

RE: [ANNOUNCE] Cordova Crosswalk Plugin Release

2016-03-14 Thread Yu, Zhiqiang
Glad to know this.. :-) Thanks, Zhiqiang "Simplicity is beauty ..." -Original Message- From: Fu, Junwei [mailto:junwei...@intel.com] Sent: Tuesday, March 15, 2016 8:49 AM To: dev@cordova.apache.org Subject: [ANNOUNCE] Cordova Crosswalk Plugin Release We are happy to announce that Cor

[GitHub] cordova-docs pull request: Add "Linux" to "blackberry10"

2016-03-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/475#issuecomment-196600123 @Wesley-Chan thanks for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cordova-docs pull request: Add "Linux" to "blackberry10"

2016-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/475 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: CB-10819 Adding snapshotting and improv...

2016-03-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/553#issuecomment-196590609 @sarangan12 @nikhilkh please review when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-camera pull request: CB-10120 android: Camera permi...

2016-03-14 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-196590433 Alright, I resolved the conflicts but after looking at the code I want to do another round of testing before I merge this in. This will be the first thin

[GitHub] cordova-docs pull request: Making dropdowns preserve /latest/ in t...

2016-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/545 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[ANNOUNCE] Cordova Crosswalk Plugin Release

2016-03-14 Thread Fu, Junwei
We are happy to announce that Cordova Crosswalk plugin 1.6.0 has been released. It used the latest Crosswalk-17 stable version which was based on Chromium 46 and supported the feature of packaging apps for 64-bit devices. It also worked finely in latest Cordova 6.0 version. It's possible to sp

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

2016-03-14 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r5602 --- Diff: appium-tests/helpers/contactsHelper.js --- @@ -0,0 +1,222 @@ +/* jshint node: true */ +/* + * + * Licensed to the

Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-14 Thread Jesse
Yeah, the simple approach is probably the best! Move to strike --kill or any variation of it, and let developers delete what they want to. If it proves to be an issue, then we will address it. @purplecabbage risingj.com On Mon, Mar 14, 2016 at 3:58 PM, Parashuram N wrote: > Instead of adding

Re: Simplifying cordova-cli README

2016-03-14 Thread Tommy Williams
Commented on the PR > On 12 Mar 2016, at 9:58 AM, Nikhil Khandelwal wrote: > > I don't fully follow what about --template I should add? Could you elaborate? > Feel free to comment on the PR and we can have more follow up conversations > on github. > > -Nikhil > > -Original Message-

[GitHub] cordova-cli pull request: Simplify cordova CLI readme

2016-03-14 Thread devgeeks
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-cli/pull/240#issuecomment-196574142 The help from the CLI itself only says: ``` --template= ... use a custom template located locally, in NPM, or GitHub. ``` Maybe a small bi

Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-14 Thread Parashuram N
Instead of adding an entire flag to remove previous versions, does it make sense to have cordova platform android@oldVersion. Alternatively, users could simple use the terminal to delete older versions from the command line inside the platform folders. If we have users asking for a way to “remo

Re: Buildbot: buildslave cordova-windows-slave was lost

2016-03-14 Thread Jesse
Thanks again Dmitry for keeping all of this going! @purplecabbage risingj.com On Mon, Mar 14, 2016 at 3:01 PM, Dmitry Blotsky wrote: > We had a power outage over the weekend and the machines aren’t configured > to reboot and restart buildbot automatically. Sorry! Both are back up now. > > Kind

[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x

2016-03-14 Thread stevengill
Github user stevengill closed the pull request at: https://github.com/apache/cordova-docs/pull/499 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links

2016-03-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/551#issuecomment-196540941 @csantanapr which of the two implementations do you think we should go for? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: Remove plugin pinning

2016-03-14 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/409#issuecomment-196541926 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

Re: Buildbot: buildslave cordova-windows-slave was lost

2016-03-14 Thread Dmitry Blotsky
We had a power outage over the weekend and the machines aren’t configured to reboot and restart buildbot automatically. Sorry! Both are back up now. Kindly, Dmitry > On Mar 13, 2016, at 3:12 PM, build...@apache.org wrote: > > The Buildbot working for '' > has noticed that the buildslave named c

Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-14 Thread Shazron
Note: I prefer `--remove-previous-versions` to `--kill` so as to be unambiguous and explicit. On Mon, Mar 14, 2016 at 2:01 PM, Shazron wrote: > +1 I like it (esp reasons in #2) > > I agree that platform rm+add is not there yet, case in point all the > related issues in the "Issue Links" in this i

Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-14 Thread Shazron
+1 I like it (esp reasons in #2) I agree that platform rm+add is not there yet, case in point all the related issues in the "Issue Links" in this issue: https://issues.apache.org/jira/browse/CB-10775 Some comments: `cordova platform ls` should list these previous versions as well. `cordova plat

Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-14 Thread Parashuram N
+1 to Jesse’s new proposal. Looks like a nice idea and we don’t break existing tooling. We could symlink /platforms/ios to always point to latest, but that would not work on Windows. This is a better approach. On 3/14/16, 1:29 PM, "Jesse" wrote: >Considering all of the points previously menti

Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-14 Thread Jesse
Considering all of the points previously mentioned, I would like to make a supplementary proposal. We seem to all agree that platform rm+add is ideal in a world where we can truly consider platforms as artifacts, but we are really not there yet. The zipped snapshot of the platform before the updat

[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links

2016-03-14 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/551#issuecomment-196488029 @dblotsky LGTM ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-contacts pull request: Disable 'calendar permission...

2016-03-14 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/108#issuecomment-196487772 I've tried yet another approach: create a 'mobilespec.enlistments', which lives in the same folder as 'mobilespec-Info.plist', with the following conten

[GitHub] cordova-medic pull request: Disabling ios 'contacts permissions pr...

2016-03-14 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-medic/pull/84#issuecomment-196486901 This approach turns out not to work either, just as the first approach: https://github.com/apache/cordova-plugin-contacts/pull/108 --- If your project is set up f

[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links

2016-03-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/551#issuecomment-196486471 @csantanapr please take a look at #555. It has the links implementation and a screenshot of what it looks like on mobile. --- If your project is set up for it, y

[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links (Altern...

2016-03-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/555#issuecomment-196486216 Mobile ![capture](https://cloud.githubusercontent.com/assets/405489/13757101/24e3ff14-e9e0-11e5-9ae7-6125e3a7b6de.PNG) --- If your project is set

[GitHub] cordova-plugin-whitelist pull request: CB-10866: Adding engine inf...

2016-03-14 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-whitelist/pull/18 CB-10866: Adding engine info to package.json Putting the version constraint at 0.0.0 because the whitelist used to be part of the platform You can merge this pull request into a Gi

[GitHub] cordova-plugin-statusbar pull request: CB-10866: Adding engine inf...

2016-03-14 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/52 CB-10866: Adding engine info to package.json Checked Github to see when the constraint was added (earliest was 0.1.0 512a1388c65fc099b56c0a40e6c63458b2d029eb) You can merge this pu

[GitHub] cordova-plugin-dialogs pull request: add support for html message ...

2016-03-14 Thread swaheed2
GitHub user swaheed2 opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/68 add support for html message in alert By using android.text.Html, the message of the AlertDialog can support html which is a very useful feature. I hope this can be added to all type

[GitHub] cordova-plugin-splashscreen pull request: CB-10866: Adding engine ...

2016-03-14 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/94 CB-10866: Adding engine info to package.json Checked Github to see when the constraint was added (seems like version 0.3.6 ddec7008cbab13865ff1321696bfeacd577e716) You can merge

[GitHub] cordova-plugin-inappbrowser pull request: CB-10866: Adding engine ...

2016-03-14 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/155 CB-10866: Adding engine requirements to package.json You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plu

[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...

2016-03-14 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-196450607 You can use cordova-paramedic like this: https://github.com/daserge/cordova-plugin-device/commits/paramedic --- If your project is set up for it, you can

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

2016-03-14 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-android/pull/273#issuecomment-196445988 I've tested this way: - `created project, added master android platform` - `λ cordova run android --release` -> ``` Built the following apk(s):

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

2016-03-14 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/558#discussion_r56042466 --- Diff: www/docs/en/6.x/config_ref/images.md --- @@ -135,6 +136,22 @@ different screen resolutions. ``` + +For Wi

[GitHub] cordova-plugin-camera pull request: Adding DATA_URL warnings to RE...

2016-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

2016-03-14 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/558#discussion_r56042785 --- Diff: www/docs/en/6.x/config_ref/images.md --- @@ -41,6 +41,7 @@ platform | *Optional* Target platform width | *Optional* Icon w

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

2016-03-14 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/558#discussion_r56042624 --- Diff: www/docs/en/6.x/config_ref/images.md --- @@ -135,6 +136,22 @@ different screen resolutions. ``` + +For Wi

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

2016-03-14 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/558#discussion_r56042402 --- Diff: www/docs/en/6.x/config_ref/images.md --- @@ -135,6 +136,22 @@ different screen resolutions. ``` + --- End

[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...

2016-03-14 Thread gaelenh
Github user gaelenh commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-196428478 I agree with the need for a test case, however I am at a loss on where to start. After doing ```npm install``` and ```npm test```, nothing appears to happ

[GitHub] cordova-windows pull request: CB-10622 Support any MRT qualifiers ...

2016-03-14 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/159#issuecomment-196426787 do we need to add scale 200/400 here: https://github.com/apache/cordova-windows/pull/159/files#diff-32bff2189ca335a5581636fff314a504R315 --- If your project i

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

2016-03-14 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-android/pull/273#issuecomment-196426128 @daserge Thanks for looking at this. What's the exact cmd line you're using that generates that error? Is that due to the change I made? It seems like in that c

[GitHub] cordova-plugin-camera pull request: CB-10865 Run ios native tests ...

2016-03-14 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/195 CB-10865 Run ios native tests on Travis Fixed tests project build failure. Updated cordova-ios tests dependency version to latest published. [Jira issue](https://issues.ap

[GitHub] cordova-plugin-splashscreen pull request: CB-10864 Run ios native ...

2016-03-14 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/93 CB-10864 Run ios native tests on Travis Updated cordova-ios tests dependency version to latest published [Jira issue](https://issues.apache.org/jira/browse/CB-10864) You

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

2016-03-14 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/558#discussion_r56040443 --- Diff: www/docs/en/6.x/config_ref/images.md --- @@ -135,6 +136,22 @@ different screen resolutions. ``` + +For Win

[GitHub] cordova-plugin-camera pull request: CB-10120 android: Camera permi...

2016-03-14 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-196421118 Right, thanks @ochakov as well! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cordova-plugin-camera pull request: CB-10120 android: Camera permi...

2016-03-14 Thread MatthewBooth
Github user MatthewBooth commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-196420729 @ochakov mainly! :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-camera pull request: CB-10120 android: Camera permi...

2016-03-14 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-196420235 I will merge this today, need to resolve some merge conflicts. Thanks @MatthewBooth! --- If your project is set up for it, you can reply to this email a

[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...

2016-03-14 Thread SunboX
Github user SunboX commented on the pull request: https://github.com/apache/cordova-windows/pull/149#issuecomment-196412080 Oh, thanks for the hint! This is great! :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit...

2016-03-14 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/410#issuecomment-196399690 @stevengill @vladimir-kotikov could you review this when you have chance. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: CB-10808 **CLI** Should handle templates...

2016-03-14 Thread csantanapr
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-lib/pull/410 CB-10808 **CLI** Should handle templates with files located in sub directory Refer to [CB-1080](https://issues.apache.org/jira/browse/CB-10808) for more info You can merge this pull reques

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

2016-03-14 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/558 CB-10178 Added `target` attribute docs to windows icons reference JIRA [CB-10178](https://issues.apache.org/jira/browse/CB-10178) You can merge this pull request into a Git repository

[GitHub] cordova-windows pull request: CB-10622 Support any MRT qualifiers ...

2016-03-14 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/159 CB-10622 Support any MRT qualifiers for Windows icons JIRA [CB-10622](https://issues.apache.org/jira/browse/CB-10622) This PR fixes copying MRT images with qualifiers other

[GitHub] cordova-docs pull request: CB-10861 Add an example for apk signing...

2016-03-14 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/557 CB-10861 Add an example for apk signing to Android platform docs Fixed slashes in sample buildConfig.json [Jira issue](https://issues.apache.org/jira/browse/CB-10861) You can merge th

Re: [DISCUSS] Tools Release

2016-03-14 Thread Carlos Santana
Sounds good. I'm working on this [1] it should be done by then to pick it up [1]: https://issues.apache.org/jira/browse/CB-10808 On Sun, Mar 13, 2016 at 6:09 PM Steven Gill wrote: > I'm planning on starting a tools release on Wed. Let me know if you need me > to look at anything. > > -Steve >

Re: [ANNOUNCE] Plugin Release

2016-03-14 Thread Carlos Santana
bump, can someone send out tweet? On Sat, Mar 12, 2016 at 8:28 PM Carlos Santana wrote: > Blog: http://cordova.apache.org/news/2016/03/12/plugin-release.html > > Can someone send the tweet out? > >

[GitHub] cordova-android pull request: [CB-10689] fix issue with app_name c...

2016-03-14 Thread akofman
Github user akofman commented on the pull request: https://github.com/apache/cordova-android/pull/272#issuecomment-196298323 I think you should perform a global replacement instead of just the first occurence : `name.replace(/\'/g,'\\\'');` --- If your project is set up for it, you c

[GitHub] cordova-android pull request: Merge pull request #1 from apache/ma...

2016-03-14 Thread vionescu
GitHub user vionescu opened a pull request: https://github.com/apache/cordova-android/pull/275 Merge pull request #1 from apache/master getting updates from apache master You can merge this pull request into a Git repository by running: $ git pull https://github.com/temenostech

[GitHub] cordova-ios pull request: CB-10840 Use cordova-common.CordovaLogge...

2016-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/205 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-splashscreen pull request: Transaction bugfix

2016-03-14 Thread jeroenv
GitHub user jeroenv opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/92 Transaction bugfix When you move the app to the background when the fade animation is done, then the splashscreen view isn't destroyed. Which causes that no touch events are pas

[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...

2016-03-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/149#issuecomment-196243570 This is not yet documented, but we're in process of adding docs and examples for `target` attribute --- If your project is set up for it, you can repl

[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...

2016-03-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/149#issuecomment-196243378 @SunboX, for adding icons with scale factors other than `scale-100` and `scale-240` you need to use `target` attribute as following: ```xml

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

2016-03-14 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-196242692 I'm going to merge it in soon. @dblotsky @riknoll @nikhilkh --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

2016-03-14 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55976166 --- Diff: appium-tests/helpers/contactsHelper.js --- @@ -0,0 +1,222 @@ +/* jshint node: true */ +/* + * + * Licensed to the

[GitHub] cordova-plugin-camera pull request: CB-10120 android: Camera permi...

2016-03-14 Thread MatthewBooth
Github user MatthewBooth commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-196225403 ICLA was filled out. Sorry for the delay, I hadn't been tracking these comments unfortunately. It's done now, though. --- If your project is

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

2016-03-14 Thread MatthewBooth
Github user MatthewBooth commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-196224537 ```Dear Matt Booth, This message acknowledges receipt of your ICLA, which has been filed in the Apache Software Foundation records.

[GitHub] cordova-plugin-file-transfer pull request: CB-9839 Add gzip suppor...

2016-03-14 Thread sviluppatoribk
Github user sviluppatoribk commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/85#issuecomment-196215249 Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cordova-ios pull request: CB-10840 Use cordova-common.CordovaLogge...

2016-03-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-ios/pull/205#issuecomment-196207197 LGTM apart from one comment. @daserge, feel free to merge once that comment is addressed. --- If your project is set up for it, you can reply to this emai

[GitHub] cordova-ios pull request: CB-10840 Use cordova-common.CordovaLogge...

2016-03-14 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/205#discussion_r55968611 --- Diff: bin/templates/scripts/cordova/Api.js --- @@ -202,7 +217,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) { */

[GitHub] cordova-docs pull request: Correct translation errors

2016-03-14 Thread hoyajigi
GitHub user hoyajigi opened a pull request: https://github.com/apache/cordova-docs/pull/556 Correct translation errors You can merge this pull request into a Git repository by running: $ git pull https://github.com/hoyajigi/cordova-docs patch-1 Alternatively you can review an