[GitHub] cordova-plugin-contacts pull request: CB-8115 incorrect birthday s...

2016-04-01 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/113#discussion_r58285822 --- Diff: www/convertUtils.js --- @@ -0,0 +1,61 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] cordova-cli pull request: CB-10062 Error: EACCES: permission denie...

2016-04-01 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/242#discussion_r58285316 --- Diff: src/cli.js --- @@ -60,13 +60,23 @@ function init() { } function checkForUpdates() { -// Checks for available update and

[GitHub] cordova-plugin-contacts pull request: Changes to stop using global...

2016-04-01 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/115#issuecomment-204604763 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

2016-04-01 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r58279713 --- Diff: README.md --- @@ -315,3 +315,237 @@ If you are upgrading to a new (1.0.0 or newer) version of File, and you have pre

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

2016-04-01 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r58279204 --- Diff: README.md --- @@ -315,3 +315,237 @@ If you are upgrading to a new (1.0.0 or newer) version of File, and you have pre

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

2016-04-01 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-204598390 I think that we should eventually fix it to be consistent (and figure out the meaning of NATIVE_URI and FILE_URI for that matter). Also, we should defini

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

2016-04-01 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-204596592 Tested that the images are correctly displayed if used on an img tag, and can be uploaded to a server using file-transfer. @riknoll, you are

[GitHub] cordova-plugin-file pull request: adding sample section to readme

2016-04-01 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58276468 --- Diff: README.md --- @@ -538,3 +540,263 @@ Android also supports a special filesystem named "documents", which represents a * `root`: The

[GitHub] cordova-plugin-file pull request: readme updates with samples

2016-04-01 Thread RobPosener
Github user RobPosener commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/175#issuecomment-204592324 You have inserted an additional reference to HTML5 Rocks that should be removed. The HTML5 Rocks web page contains incorrect examples and currently t

[GitHub] cordova-plugin-file pull request: adding sample section to readme

2016-04-01 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58275738 --- Diff: README.md --- @@ -538,3 +540,263 @@ Android also supports a special filesystem named "documents", which represents a * `root`: The

[GitHub] cordova-plugin-file pull request: adding sample section to readme

2016-04-01 Thread Mikejo5000
GitHub user Mikejo5000 opened a pull request: https://github.com/apache/cordova-plugin-file/pull/176 adding sample section to readme removed link to current complete sample, related edits You can merge this pull request into a Git repository by running: $ git pull https://githu

[GitHub] cordova-plugin-inappbrowser pull request: New PR for Geo sample - ...

2016-04-01 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/161#discussion_r58268931 --- Diff: README.md --- @@ -217,6 +217,79 @@ The object returned from a call to `cordova.InAppBrowser.open`. - __callback__:

[GitHub] cordova-plugin-file pull request: readme updates with samples

2016-04-01 Thread Mikejo5000
Github user Mikejo5000 closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/175 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

RE: [VOTE] Tools release attempt 2

2016-04-01 Thread Vladimir Kotikov (Akvelon)
The vote has now closed. The results are: Positive Binding Votes: 3 Vladimir Kotikov Carlos Santana Edna Morales The vote has passed. - Best regards, Vladimir -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Thursday, March 31, 2016 6:11 PM To: dev@cordova.a

[GitHub] cordova-plugin-inappbrowser pull request: New PR for Geo sample - ...

2016-04-01 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/161#discussion_r58267690 --- Diff: README.md --- @@ -394,3 +467,163 @@ Due to [MSDN docs](https://msdn.microsoft.com/en-us/library/windows.ui.xaml.cont

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

2016-04-01 Thread Mikejo5000
GitHub user Mikejo5000 opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/136 adding sample section to readme You can merge this pull request into a Git repository by running: $ git pull https://github.com/Mikejo5000/cordova-plugin-file-transfer

[GitHub] cordova-plugin-geolocation pull request: New PR for sample content...

2016-04-01 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/75#discussion_r58266872 --- Diff: README.md --- @@ -296,3 +311,436 @@ callback function when an error occurs with navigator.geolocation. - Returned when t

[GitHub] cordova-plugin-geolocation pull request: New PR for sample content...

2016-04-01 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/75#issuecomment-204563680 Also I know this is not completely on you, but would you mind adding a list (index) at the starting of the README with links to the major headings? T

[GitHub] cordova-plugin-geolocation pull request: New PR for sample content...

2016-04-01 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/75#discussion_r58266173 --- Diff: README.md --- @@ -296,3 +311,436 @@ callback function when an error occurs with navigator.geolocation. - Returned when t

[GitHub] cordova-osx pull request: CB-11002 Enable hidden accelerated rende...

2016-04-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-osx pull request: CB-11002 Enable hidden accelerated rende...

2016-04-01 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/34 CB-11002 Enable hidden accelerated rendering settings by default You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-osx CB-

[GitHub] cordova-plugin-statusbar pull request: CB-10884 Inappbrowser break...

2016-04-01 Thread jacobweber
Github user jacobweber commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/53#issuecomment-204442987 There is still a similar [portrait-to-landscape bug](https://issues.apache.org/jira/browse/CB-10884?focusedCommentId=15221859&page=com.atlassian.jira

Re: [DISCUSS] Tools Release CLI/LIB 6.1.1

2016-04-01 Thread Carlos Santana
can we close the vote and release? On Fri, Apr 1, 2016 at 9:38 AM Carlos Santana wrote: > bump > > On Thu, Mar 31, 2016 at 1:27 PM Carlos Santana > wrote: > >> +1 >> >> - Carlos >> @csantanapr >> >> > On Mar 31, 2016, at 1:17 PM, Vladimir Kotikov (Akvelon) < >> v-vlk...@microsoft.com> wrote: >>

Re: [DISCUSS] Tools Release CLI/LIB 6.1.1

2016-04-01 Thread Carlos Santana
bump On Thu, Mar 31, 2016 at 1:27 PM Carlos Santana wrote: > +1 > > - Carlos > @csantanapr > > > On Mar 31, 2016, at 1:17 PM, Vladimir Kotikov (Akvelon) < > v-vlk...@microsoft.com> wrote: > > > > Just cherry-picked releasenotes to master > > - > > Best regards, Vladimir > > > > -Original Mes

[GitHub] cordova-cli pull request: CB-10062 Error: EACCES: permission denie...

2016-04-01 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-cli/pull/242 CB-10062 Error: EACCES: permission denied - update-notifier-cordova.json Catch permissions error and print a workaround [Jira issue](https://issues.apache.org/jira/browse/CB-10062) You