[GitHub] cordova-plugin-file-transfer pull request: Removing flaky test ass...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/137#issuecomment-205583342 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-file-transfer pull request: Removing flaky test ass...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/137#issuecomment-205565973 Now with fewer CI failures! I think this is [CB-10536](https://issues.apache.org/jira/browse/CB-10536). --- If your project is set up for it,

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-205564464 If we can get the real image name, we should do that. However, since we are modifying it, we should also mark it as such and put `-modified` at the end

[GitHub] cordova-ios pull request: CB-10942 - Cannot

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/211 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file-transfer pull request: Removing flaky test ass...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/137 Removing flaky test assertions about abort callback latency @nikhilkh @sarangan12 please review You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58472035 --- Diff: lib/paramedic.js --- @@ -0,0 +1,205 @@ +#!/usr/bin/env node + +var exec = require('./utils').exec, +shell =

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-205559047 Hmmm, interesting --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

Github user akofman commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-20255 XCode 7.2 is using lldb-340.4.119.1 while XCode 7.3 is using lldb-350.0.21.3. --- If your project is set up for it, you can reply to this email and have your

Re: Plugin Dev Issues

This StackOverflow issue? http://stackoverflow.com/questions/36366915/cordova-plugin-development-how-to-include-so-libs-correctly-unsatisfiedlin @purplecabbage risingj.com On Mon, Apr 4, 2016 at 1:51 PM, Michael Lapinski wrote: > Hello, > I am trying to find the

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

Github user akofman commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-205528749 I think it's more than possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-205527895 Could it be XCode update(from 7.2 to 7.3) that is causing this issue ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

Github user akofman commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-205517434 h indeed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-205510819 I tested the following PR: https://github.com/phonegap/ios-deploy/pull/218 and unfortunately, it didn't fix the issue for me. --- If your project is set up for

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-205507533 I'm using XCode Version 7.3 (7D175) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

Github user akofman commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-205506966 Maybe it's related to the last XCode updates. What version are you using ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-205502326 Ok, so we should change ``` String fileName = realPath != null ? realPath.substring(realPath.lastIndexOf('/') + 1) :

[GitHub] cordova-docs pull request: Adding both Chinese versions.

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/569#discussion_r58451039 --- Diff: www/.htaccess --- @@ -18,29 +18,31 @@ RewriteEngine on # pages to new pages. # 302 (temp): -# docs ->

[GitHub] cordova-docs pull request: Changing docs styling.

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/567#issuecomment-205501906 @nikhilkh @sarangan12 @riknoll @rakatyal: whenever any of you have any time, please give this a look. --- If your project is set up for it, you can reply to

Plugin Dev Issues

Hello, I am trying to find the appropriate forum to get support regarding plugin development, specifically the proper way to include .so shared objects in a plugin. I have posted in the stack overflow community with the cordova tag and had no response. Is there another place that is more

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-205487325 The thing is that this used to work just fine. Some recent changes might have broken it. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-file pull request: adding sample section to readme

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58442897 --- Diff: README.md --- @@ -538,3 +540,263 @@ Android also supports a special filesystem named "documents", which represents a * `root`:

[GitHub] cordova-plugin-file pull request: adding sample section to readme

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58442531 --- Diff: README.md --- @@ -538,3 +540,263 @@ Android also supports a special filesystem named "documents", which represents a * `root`:

[GitHub] cordova-plugin-file pull request: adding sample section to readme

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58442202 --- Diff: README.md --- @@ -538,3 +540,263 @@ Android also supports a special filesystem named "documents", which represents a * `root`:

[GitHub] cordova-plugin-file pull request: adding sample section to readme

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58441628 --- Diff: README.md --- @@ -538,3 +540,263 @@ Android also supports a special filesystem named "documents", which represents a * `root`:

[GitHub] cordova-plugin-file pull request: adding sample section to readme

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58441476 --- Diff: README.md --- @@ -538,3 +540,263 @@ Android also supports a special filesystem named "documents", which represents a * `root`:

[GitHub] cordova-plugin-file pull request: adding sample section to readme

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58440889 --- Diff: README.md --- @@ -538,3 +540,263 @@ Android also supports a special filesystem named "documents", which represents a * `root`:

[GitHub] cordova-plugin-file pull request: adding sample section to readme

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58439895 --- Diff: README.md --- @@ -538,3 +540,263 @@ Android also supports a special filesystem named "documents", which represents a * `root`:

Re: [DISCUSS] Core Plugins and Android API 23

I'm moving forward with 1 as I've requested a new git repo and github mirror from infra: https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-11592 https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-11593 once that is done I'll get on to migrating the core plugins

[GitHub] cordova-plugin-file pull request: adding sample section to readme

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58438965 --- Diff: README.md --- @@ -36,7 +36,9 @@ Although most of the plugin code was written when an earlier spec was current: It also

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r58437200 --- Diff: README.md --- @@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer) version of File, and you have pre

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r58437220 --- Diff: README.md --- @@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer) version of File, and you have pre

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r58437055 --- Diff: README.md --- @@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer) version of File, and you have pre

RE: Apache Cordova CI Build Summary - 03/28/16 - 04/04/16

The iOS has to be 407/419. Sorry for the typo. Regards Sarangan Rajamanickam From: Sarangan Rajamanickam Sent: Monday, April 4, 2016 12:39 PM To: 'dev@cordova.apache.org' Cc: Richard Knoll ; Nikhil Khandelwal Subject:

Apache Cordova CI Build Summary - 03/28/16 - 04/04/16

Build Status (Pass/Total): 428/428 - Android on Mac 428/428 - Android on Windows 419/419 - iOS 419/419 - WP 8.1 419/419 - Windows JIRAs that need attention: - CB-11016: Android Emulator in Windows has some issues in CI Next build sheriff: riknoll Regards Sarangan Rajamanickam

RE: [DISCUSS] cordova-windows patch release

I'll start it tomorrow - Best regards, Vladimir -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Monday, April 4, 2016 10:23 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] cordova-windows patch release bump Do we have a ETA on this Vote? On Thu, Mar 31,

Re: [DISCUSS] cordova-windows patch release

bump Do we have a ETA on this Vote? On Thu, Mar 31, 2016 at 8:09 AM Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > The PR has been merged. I'm going to start Vote thread soon. > - > Best regards, Vladimir > > -Original Message- > From: Carlos Santana

[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/420#issuecomment-205453861 @omefire, ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-contacts pull request: Changes to stop using global...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-205441624 Okay, finally got around to testing this on Jelly bean and I found an issue: content URIs don't always end in a file type (like .jpg). We try and get

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

Github user akofman commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-205441390 Sure I 100% agree with that. That's why I asked to @shazron what he thinks. If we have to wait 6 months more, I think it's better to keep something working instead

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-205438249 I'd prefer this PR be merged into ios-deploy: https://github.com/phonegap/ios-deploy/pull/218 That way, we wouldn't have to fix this issue here. --- If your

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-205437708 This works, but it brings us back to when we used to have to exit lldb manually. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...

Github user bhandaribhumin commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/67#issuecomment-205434835 @guillaumedev please give me full code i'm having issue --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-paramedic pull request: Paramedic improvements

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/3#discussion_r58423149 --- Diff: lib/LocalServer.js --- @@ -0,0 +1,122 @@ +var Q = require('q'), --- End diff -- Apache license needed in comments ---

[GitHub] cordova-plugin-media-capture pull request: Removing global state a...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/59 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

RE: [DISCUSS] cordova-ios release

LGTM! Thanks, Mefire From: Edna Y Morales [mailto:eymor...@us.ibm.com] Sent: Monday, April 4, 2016 10:47 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] cordova-ios release Can someone review the blog post? https://github.com/apache/cordova-docs/pull/571 Thanks, Edna Morales [Inactive

[GitHub] cordova-docs pull request: CB-11006 add ios@4.1.1 release blog pos...

Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/571#issuecomment-205420917 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: [DISCUSS] cordova-ios release

Can someone review the blog post? https://github.com/apache/cordova-docs/pull/571 Thanks, Edna Morales From: Shazron To: "dev@cordova.apache.org" Date: 03/30/2016 08:28 PM Subject:Re: [DISCUSS] cordova-ios release Thanks Edna -

[Vote] 4.1.1 iOS Release

Please review and vote on this 4.1.1 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11006 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-11006/ The package

[GitHub] cordova-plugin-media-capture pull request: Removing global state a...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/59#issuecomment-205411389 I'm going to merge this now and get rid of the excess conditionals later --- If your project is set up for it, you can reply to this email and

RE: [DISCUSS] Core Plugins and Android API 23

That sounds right to me. No major version bumps needed. Richard -Original Message- From: Simon MacDonald [mailto:simon.macdon...@gmail.com] Sent: Monday, April 4, 2016 10:35 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Core Plugins and Android API 23 In cordova-android? No, I

[GitHub] cordova-docs pull request: CB-11006 add ios@4.1.1 release blog pos...

GitHub user eymorale opened a pull request: https://github.com/apache/cordova-docs/pull/571 CB-11006 add ios@4.1.1 release blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-docs CB-11006 Alternatively

Re: [DISCUSS] Core Plugins and Android API 23

In cordova-android? No, I don't think so. For the plugins I'd bump their minor version. Make sense? Simon Mac Donald http://hi.im/simonmacdonald On Mon, Apr 4, 2016 at 1:32 PM, Joe Bowser wrote: > Does this require a major version change? > > On Mon, Apr 4, 2016, 10:30 AM

Re: [DISCUSS] Core Plugins and Android API 23

I will take it upon myself to get it done. Task list: 1) create cordova-plugin-compat repo, populate with code. 2) migrate core plugins to use cordova-plugin-compat 3) kick off plugins release 4) write blog post am I missing anything? Simon Mac Donald http://hi.im/simonmacdonald On Mon, Apr

Re: [DISCUSS] Core Plugins and Android API 23

Does this require a major version change? On Mon, Apr 4, 2016, 10:30 AM Richard Knoll wrote: > Sorry for being late to comment on this. If we were the only ones using > the class, I would say we should just keep copying around. However, since > other plugins are using it

RE: [DISCUSS] Core Plugins and Android API 23

Sorry for being late to comment on this. If we were the only ones using the class, I would say we should just keep copying around. However, since other plugins are using it I think it's a good idea to put it in a common place and a plugin is the best way to do it. LGTM! Should someone write up

[GitHub] cordova-ios pull request: CB-10942 - Cannot

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-ios/pull/211#issuecomment-205393355 lgtm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-cli pull request: CB-10062 Error: EACCES: permission denie...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/242#discussion_r58406360 --- Diff: src/cli.js --- @@ -60,13 +60,23 @@ function init() { } function checkForUpdates() { -// Checks for available update and

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

Github user unbeatableDeepak commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-205367729 @swbradshaw That's great! If you don't have time then I can do the testing of your code and will let you know the result, can you please provide

[GitHub] cordova-medic pull request: Appium runner improvements

Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/85 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...

Github user swbradshaw commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-205285417 @unbeatableDeepak I have a solution coded, but I haven't had a chance to test it yet. --- If your project is set up for it, you can reply to this

[GitHub] cordova-docs pull request: CB-10980 Add tools@6.1.1 release blog p...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: CB-10980 Add tools@6.1.1 release blog p...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-docs/pull/570#issuecomment-205281945 Reviewed by @csantanapr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [DISCUSS] Tools Release CLI/LIB 6.1.1

LGTM - Carlos @csantanapr > On Apr 4, 2016, at 5:09 AM, Vladimir Kotikov (Akvelon) > wrote: > > The permanent release tags have been set and the packages have been published > to npm. > > Could someone please review announcement blog post at >

RE: [DISCUSS] Tools Release CLI/LIB 6.1.1

The permanent release tags have been set and the packages have been published to npm. Could someone please review announcement blog post at https://github.com/apache/cordova-docs/pull/570 - Best regards, Vladimir -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com]

[ANNOUNCE] Tools release

Cordova-cli@6.1.1 & Plugman@1.2.1 has been released! Check out https://www.npmjs.com/package/cordova and https://www.npmjs.com/package/plugman - Best regards, Vladimir - To unsubscribe, e-mail:

[GitHub] cordova-docs pull request: CB-10980 Add tools@6.1.1 release blog p...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/570 CB-10980 Add tools@6.1.1 release blog post JIRA [CB-10980](https://issues.apache.org/jira/browse/CB-10980) You can merge this pull request into a Git repository by running: $

[GitHub] cordova-plugin-contacts pull request: CB-8115 incorrect birthday s...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/113#discussion_r58341876 --- Diff: www/convertUtils.js --- @@ -0,0 +1,61 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-cli pull request: CB-10062 Error: EACCES: permission denie...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/242#discussion_r58332189 --- Diff: src/cli.js --- @@ -60,13 +60,23 @@ function init() { } function checkForUpdates() { -// Checks for available update and