Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59646081
--- Diff: lib/paramedic.js ---
@@ -210,13 +234,29 @@ ParamedicRunner.prototype.waitForConnection =
function() {
};
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59645814
--- Diff: lib/ParamedicLog.js ---
@@ -0,0 +1,154 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+
+"use strict";
+
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59645737
--- Diff: lib/ParamedicLog.js ---
@@ -0,0 +1,154 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+
+"use strict";
+
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59645230
--- Diff: lib/ParamedicLog.js ---
@@ -0,0 +1,154 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+
+"use strict";
+
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59644970
--- Diff: lib/ParamedicPermissions.js ---
@@ -0,0 +1,60 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path=
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59644686
--- Diff: lib/ParamedicPermissions.js ---
@@ -0,0 +1,60 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path=
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59644267
--- Diff: lib/ParamedicPermissions.js ---
@@ -0,0 +1,60 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path=
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-209689870
@silhouettes I don't think @stevengill will reply on this thread but maybe
now that he's been @ messaged. I'm sure there will be a plugins release for
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59644069
--- Diff: lib/ParamedicPermissions.js ---
@@ -0,0 +1,60 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path=
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59643631
--- Diff: lib/ParamedicConfig.js ---
@@ -104,4 +117,44 @@ ParamedicConfig.prototype.getTimeout = function() {
return DEFAULT_TIMEOUT;
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-medic/pull/91#issuecomment-209688315
Also, looks like some config parameters are coming as command line values
and others as config file - it's good to be consistent and have them in one
place.
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59642669
--- Diff: lib/ParamedicConfig.js ---
@@ -104,4 +117,44 @@ ParamedicConfig.prototype.getTimeout = function() {
return DEFAULT_TIMEOUT;
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59641603
--- Diff: lib/ParamedicConfig.js ---
@@ -104,4 +117,44 @@ ParamedicConfig.prototype.getTimeout = function() {
return DEFAULT_TIMEOUT;
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59641411
--- Diff: lib/ParamedicConfig.js ---
@@ -53,7 +58,11 @@ ParamedicConfig.prototype.getReportSavePath = function
() {
return
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59639808
--- Diff: lib/ParamedicLog.js ---
@@ -0,0 +1,154 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+
+"use strict";
+
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/205
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59638892
--- Diff: lib/paramedic.js ---
@@ -105,10 +116,23 @@ ParamedicRunner.prototype.checkPlatformRequirements =
function() {
GitHub user Mikejo5000 opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/40
added code examples
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Mikejo5000/cordova-plugin-network-information
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/288#issuecomment-209673913
This does not work, since all actions on a WebView thread MUST happen on
the UI thread. Also, you don't actually start the thread at all and this patch
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/205#issuecomment-209669073
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59634307
--- Diff: lib/ParamedicPermissions.js ---
@@ -0,0 +1,60 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path=
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59633776
--- Diff: lib/ParamedicPermissions.js ---
@@ -0,0 +1,60 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path=
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59633588
--- Diff: lib/ParamedicPermissions.js ---
@@ -0,0 +1,60 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path=
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59633116
--- Diff: lib/ParamedicKill.js ---
@@ -0,0 +1,95 @@
+#!/usr/bin/env node
+
+"use strict";
+
+var shelljs = require("shelljs");
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59632979
--- Diff: lib/ParamedicConfig.js ---
@@ -37,7 +37,12 @@ ParamedicConfig.parseFromArguments = function (argv) {
endPort:
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/91#issuecomment-209663615
Can these files be `.json` instead of `.js`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59631368
--- Diff: lib/paramedic.js ---
@@ -17,22 +17,30 @@
under the License.
*/
-var exec = require('./utils').exec,
-shell
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59630497
--- Diff: lib/ParamedicPermissions.js ---
@@ -0,0 +1,60 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path=
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-medic/pull/91
Adding configuration files to be used in Jenkins CI
These are the configuration files & permissions DB file that will be used
for the new CI process.
@omefire @riknoll @dblotsky
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59614155
--- Diff: jsdoc2md/TEMPLATE.md ---
@@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of
[web_activities]:
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/423#issuecomment-209620711
Yes, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/423#issuecomment-209607020
@jasongin, i've added tests to cover the new logic. Is this PR ready to go?
---
If your project is set up for it, you can reply to this email and have
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/87#discussion_r59607181
--- Diff: medic/medic-downloadlogs.js ---
@@ -0,0 +1,80 @@
+var path = require('path'),
+fs = require('fs'),
+https =
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/87#discussion_r59607150
--- Diff: medic/medic-downloadlogs.js ---
@@ -0,0 +1,80 @@
+var path = require('path'),
+fs = require('fs'),
+https =
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/87#discussion_r59606984
--- Diff: medic/medic-downloadlogs.js ---
@@ -0,0 +1,80 @@
+var path = require('path'),
+fs = require('fs'),
+https =
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/87#discussion_r59606834
--- Diff: medic/medic-downloadlogs.js ---
@@ -0,0 +1,80 @@
+var path = require('path'),
+fs = require('fs'),
+https =
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/87#discussion_r59606560
--- Diff: medic/medic-downloadlogs.js ---
@@ -0,0 +1,80 @@
+var path = require('path'),
+fs = require('fs'),
+https =
Github user Mikejo5000 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59604648
--- Diff: jsdoc2md/TEMPLATE.md ---
@@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of
[web_activities]:
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59602729
--- Diff: jsdoc2md/TEMPLATE.md ---
@@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of
[web_activities]:
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59602299
--- Diff: jsdoc2md/TEMPLATE.md ---
@@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of
[web_activities]:
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-209586254
No problem, and thanks for testing @dpogue!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/425
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/578#issuecomment-209584856
LGTM. @rakatyal, @omefire for FYI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user Mikejo5000 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59600615
--- Diff: jsdoc2md/TEMPLATE.md ---
@@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of
[web_activities]:
Github user dpogue commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-209579652
:+1: I've tested and this seems to be working properly. Thanks @riknoll!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/244#issuecomment-209579313
ok, now I get it. apparently, the website content will be generated from
this readme.md, so we're fine.
---
If your project is set up for it, you can reply to
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/244#issuecomment-209579344
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/244#discussion_r59599203
--- Diff: doc/readme.md ---
@@ -464,29 +464,31 @@ cordova build [ [...]]
### Synopsis
-Prepares, builds (unless `--nobuild` is
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-cli/pull/244#issuecomment-209578347
We update website content regularly and don't need a JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/244#issuecomment-209578035
@nikhilkh , if that's the case don't we need a JIRA to track updating the
docs website ?
---
If your project is set up for it, you can reply to this email and
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-cli/pull/244#issuecomment-209577843
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/205#discussion_r59598321
--- Diff: src/ios/CDVCamera.m ---
@@ -358,6 +358,7 @@ - (NSData*)processImage:(UIImage*)image
info:(NSDictionary*)info options:(CDVPic
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-cli/pull/244#issuecomment-209576907
Updating docs\readme.md should be sufficient - docs website publishing
should take care of updating the version in cordova-docs.
---
If your project is set up
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/205#issuecomment-209575841
I agree on an appium test to cover this scenario, but I think it should go
further than just making sure no crash happens and also validate that the EXIF
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/244#issuecomment-209572705
It's located elsewhere, in the cordova-docs repo:
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-cli/pull/244#issuecomment-209571650
@omefire Isn't that covered by the update to docs/readme.md in this change?
Or is it duplicated somewhere else?
---
If your project is set up for it, you can
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/19
Add spec started/completed log
This will help in debugging and provides a start/stop marker in native logs.
You can merge this pull request into a Git repository by running:
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-medic/pull/90#issuecomment-209570475
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/90#issuecomment-209569528
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/244#issuecomment-209564718
@jasongin consider also updating the docs:
http://cordova.apache.org/docs/en/latest/reference/cordova-cli/index.html
---
If your project is set up for it, you can
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/426#discussion_r59592544
--- Diff: cordova-lib/src/cordova/run.js ---
@@ -32,8 +32,10 @@ module.exports = function run(options) {
var hooksRunner = new
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-medic/pull/90
Ensure Android adb logs have timestamp
This should help in debugging as it will have timestamps for native logs.
@riknoll, @sarangan12 to take a look. We should do the same with paramedic
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/205#issuecomment-209551757
@alsorokin Is it possible for our appium test cover this scenario? Sounds
like you will have to enable this preference to see this issue.
---
If your
I find the Roadmap emails useful. Perhaps other teams should consider it as
well.
Plugin bugs are definitely a concern. Speaking for myself I have been more
concerned with platform bugs, trying to get the ios platform stable.
> "We would also like to work on things like Plugin compatibility when
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59584301
--- Diff: cordova-lib/src/cordova/plugin_spec_parser.js ---
@@ -0,0 +1,61 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/205#discussion_r59583794
--- Diff: src/ios/CDVCamera.m ---
@@ -358,6 +358,7 @@ - (NSData*)processImage:(UIImage*)image
info:(NSDictionary*)info options:(CDVPic
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/206
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/206#issuecomment-209432618
This is a re-creation of
https://github.com/apache/cordova-plugin-camera/pull/202
---
If your project is set up for it, you can reply to this email
Github user alsorokin closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/202
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/206
CB-11073 Appium tests stability improvements
https://issues.apache.org/jira/browse/CB-11073
You can merge this pull request into a Git repository by running:
$ git pull
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/89
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-medic/pull/89
CB-11075 Appium tests: Exit gracefully on uncaught exception
https://issues.apache.org/jira/browse/CB-11075
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user RRutsche opened a pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/34
be sure to remove listeners before executing start
Hi, thanks for your plugin. Works great for us. Only issue we have that the
initial values for `level` and `isPlugged` were
GitHub user sasoMetakocka opened a pull request:
https://github.com/apache/cordova-android/pull/290
2.9.x
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/cordova-android 2.9.x
Alternatively you can review and apply these
Github user mirko77 commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/121#issuecomment-209383867
@daserge fair enough, I think we will have to simplify that object. It has
always been working on Android so we never faced the issue.
Github user mirko77 commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/121#issuecomment-209334303
I am posting to a Linux server (Ubuntu 14.10), PHP 5.6 backend , from an
Ionic1.2.4 app.
Here is the code, I removed the stuff not
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/121#issuecomment-209347935
`params` should be `A set of optional key/value pairs to pass in the HTTP
request. (Object, key/value - DOMString)` as the documentation says -
GitHub user akofman opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7
Fixes CB-11074: WKWebView configuration is not considered
I updated the configuration before the WKWebView initialisation in order to
consider it.
It implies that the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user oddcb opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/140
CB-11067 - Adds content-length to multipart string if file length
determined as also iOS plugin does
ICLA signed and sent per email.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-209292949
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59503554
--- Diff: cordova-lib/src/cordova/plugin_spec_parser.js ---
@@ -0,0 +1,61 @@
+/**
+Licensed to the Apache Software Foundation (ASF)
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59503458
--- Diff: cordova-lib/src/cordova/plugin_spec_parser.js ---
@@ -0,0 +1,61 @@
+/**
+Licensed to the Apache Software Foundation (ASF)
83 matches
Mail list logo
