Github user robario commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/138#issuecomment-212767374
It had been reported on
[CB-10564](https://issues.apache.org/jira/browse/CB-10564).
---
If your project is set up for it, you can reply to this
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/20#issuecomment-212739167
Not exactly sure about that. I guess the iOS simulator had issues dealing
with so many post calls and other platforms may be handled it in a bette
Github user dblotsky closed the pull request at:
https://github.com/apache/cordova-docs/pull/583
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/575#issuecomment-212685445
@riknoll please give this another look. It's now using the changes from
[CB-11126][1].
[1]: https://issues.apache.org/jira/browse/CB-11126
---
If your p
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/20#issuecomment-212679043
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/20
CB-11124 Fixing cordova-ios build failure due to unnecessary post calâ¦
â¦ls to couchdb and adding handlers to xhr call
You can merge this pull request into a Git repository
Oh great! I have not taken a close look at the implementation itself. Perhaps
you already had some of this in mind.
As for the syntax for changing attributes, I would recommend something like
this:
Also, we should always prioritize config.xml edits over plugin.xml (giving the
end developer t
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/430#issuecomment-212652866
Does this cloning need to happen for other commands too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user cjpearson closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/94
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Sorry, we were debugging what we suspected was a machine-specific issue on the
machine. It's back up now.
-Original Message-
From: build...@apache.org [mailto:build...@apache.org]
Sent: Wednesday, April 20, 2016 3:41 AM
To: dev@cordova.apache.org
Subject: Buildbot: buildslave cordova-win
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/583#issuecomment-212648942
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Tweet: https://twitter.com/apachecordova/status/722909881645203458
Blog: http://cordova.apache.org/news/2016/04/20/plugins-release.html
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/583#discussion_r60496008
--- Diff: tools/bin/toc.js ---
@@ -17,123 +17,57 @@
"use strict";
-var fs = require("fs");
-var path = require("path");
+
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r60495766
--- Diff: lib/utils/utilities.js ---
@@ -0,0 +1,123 @@
+#!/usr/bin/env node
+
+var shelljs = require('shelljs');
+var verbose = undef
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/583#discussion_r60495374
--- Diff: tools/bin/toc.js ---
@@ -17,123 +17,57 @@
"use strict";
-var fs = require("fs");
-var path = require("path");
+v
The Buildbot working for ''
has noticed that the buildslave named cordova-osx-slave went away
It last disconnected at Wed Apr 20 21:47:09 2016 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The Buildbot
https://ci.apache.o
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/94#discussion_r60492470
--- Diff: lib/util.js ---
@@ -74,24 +81,95 @@ module.exports = (function () {
return numDevices;
}
+function getSim
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/582
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60482215
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/94#issuecomment-212592382
Rebased on top of master and ready to be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60481666
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60481370
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r60480780
--- Diff: lib/utils/utilities.js ---
@@ -0,0 +1,123 @@
+#!/usr/bin/env node
+
+var shelljs = require('shelljs');
+var verbose = undefi
Hi,
I made an attempt at the functionality of being able to add attributes with
the config-file tag. It's not completed yet, but I wanted to get some
review before I proceed.
With my changes, you can add an attribute through the config-file tag in
plugin.xml when the plugin is added, and when the
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r60472155
--- Diff: lib/utils/utilities.js ---
@@ -0,0 +1,123 @@
+#!/usr/bin/env node
+
+var shelljs = require('shelljs');
+var verbose = undefi
Github user daserge commented on the pull request:
https://github.com/apache/cordova-android/pull/291#issuecomment-212554803
You are right, thanks.
Filed https://github.com/apache/cordova-lib/pull/430
---
If your project is set up for it, you can reply to this email and have your
Github user daserge closed the pull request at:
https://github.com/apache/cordova-android/pull/291
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-lib/pull/430
CB-11036 'args.slice is not a function' when building windows with otâ¦
â¦her platform
Avoid options obj modification as it's then passed to other platforms
[Jira issue](http
GitHub user andrewgaun opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/143
CB-8: Add support for Array and Object params in iOS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewgaun/cor
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60460847
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60460033
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60459967
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/178#issuecomment-212540628
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/178#issuecomment-212540487
@riknoll LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60459281
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/178#issuecomment-212539984
@infil00p does this change seem reasonable to you? I tried to match the old
behavior.
---
If your project is set up for it, you can reply to this email an
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60458884
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/93
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60452183
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
+1
* Ran coho verify-archive
* Verified tag
* ran npm test
On Wed, Apr 20, 2016 at 2:57 AM, Alexander Sorokin (Akvelon) <
v-als...@microsoft.com> wrote:
> I vote +1.
>
> * Ran coho verify-archive
> * Verified tag
> * Used this cordova-common module in cordova tools to create, build and
> run he
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-medic/pull/93#issuecomment-212523371
Thanks guys. Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/93#issuecomment-212523226
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60450430
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60449617
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60448617
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
My concern with making this the default behavior is that Cordova prepare
doesn't have a corresponding "clean" operation. While there is a "cordova
clean" command, it only does a clean for the native-code project (e.g. gradle
clean), which doesn't affect the files copied during prepare. I guess t
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/168#issuecomment-212513093
Minor comments. Otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60446380
--- Diff: spec/unit/ConfigChanges.spec.js ---
@@ -0,0 +1,77 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60445037
--- Diff: template/cordova/lib/ConfigChanges.js ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60444685
--- Diff: template/cordova/lib/ConfigChanges.js ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60442924
--- Diff: template/cordova/lib/ConfigChanges.js ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-medic/pull/93#issuecomment-212504995
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/93#discussion_r60443408
--- Diff: APPIUM.md ---
@@ -58,7 +71,17 @@ Command sample to run tests on the "iPhone 6" simulator
with iOS 8.4:
> node cordova-medic/medic/medi
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-medic/pull/87#issuecomment-212503004
This was merged with cfe4e828fb392709ee97f4da1df46264e6d0faa7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user nikhilkh closed the pull request at:
https://github.com/apache/cordova-medic/pull/87
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/93#discussion_r60442607
--- Diff: APPIUM.md ---
@@ -58,7 +71,17 @@ Command sample to run tests on the "iPhone 6" simulator
with iOS 8.4:
> node cordova-medic/medic/medic
Thanks for sharing the stats! Looks like a great improvement!
I'm fine with this going in sans flag if we test it bit more first.
Have your tried it with the --browserify flag?
On Apr 20, 2016 7:18 AM, "Victor Sosa" wrote:
> This is an amazing improvement in Cordova performance. Thanks Jason
>
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/95
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-medic/pull/95
CB-11122 Look for Appium tests in the plugins folder
https://issues.apache.org/jira/browse/CB-11122
You can merge this pull request into a Git repository by running:
$ git pull https://
This is an amazing improvement in Cordova performance. Thanks Jason
+1!!
On Wed, Apr 20, 2016 at 9:14 AM Shazron wrote:
> +1 what Jesse said
>
> On Tuesday, April 19, 2016, Jesse wrote:
>
> > This sounds great!
> > Personally, I don't think this belongs behind a flag, why would anyone
> not
> >
+1 what Jesse said
On Tuesday, April 19, 2016, Jesse wrote:
> This sounds great!
> Personally, I don't think this belongs behind a flag, why would anyone not
> want to build faster?
> I think we just need to test more to make sure it functions as expected
> everywhere, and then it should just ma
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60409457
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user daserge commented on the pull request:
https://github.com/apache/cordova-docs/pull/580#issuecomment-212428862
@nikhilkh, I've updated the PR, please take a look once more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60407237
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60406393
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60399853
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60399365
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60398700
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60398288
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60397531
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60397076
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60396872
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60396878
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60396904
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60396886
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
The Buildbot working for ''
has noticed that the buildslave named cordova-windows-slave went away
It last disconnected at Wed Apr 20 10:36:22 2016 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The Buildbot
https://ci.apac
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-medic/pull/93#issuecomment-212375911
@riknoll @rakatyal Addressed review notes, please see
https://github.com/apache/cordova-medic/pull/93/commits/0e7ff36d9a53d72e361eb86574a224f904e535e6
---
If yo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60384873
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
I vote +1.
* Ran coho verify-archive
* Verified tag
* Used this cordova-common module in cordova tools to create, build and run
hello-world app
* Used this cordova-common in cordova-android and cordova-windows platforms to
build and run hello-world app
-Original Message-
From: Vladimir
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/428#discussion_r60380149
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -112,7 +112,10 @@ function installPluginsFromConfigXML(args) {
// assume it
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/428
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/93#discussion_r60378697
--- Diff: APPIUM.md ---
@@ -0,0 +1,64 @@
+Cordova Medic Appium Runner
+===
+
+This document describes a method
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60375540
--- Diff: template/cordova/Api.js ---
@@ -29,7 +29,7 @@ var ActionStack = require('cordova-common').ActionStack;
var CordovaError = requ
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60375328
--- Diff: template/cordova/lib/ConfigChanges.js ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "Lic
Github user beat-at-hartwig commented on the pull request:
https://github.com/apache/cordova-docs/pull/580#issuecomment-212339673
@daserge Thank you for your suggestions. I already implemeted similar code
fitting my needs. Doing a `throw` was a nice hint. Thanks!
---
If your project
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60372887
--- Diff: template/cordova/lib/ConfigChanges.js ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "Lic
Github user daserge commented on the pull request:
https://github.com/apache/cordova-docs/pull/580#issuecomment-212333901
@beat-at-hartwig, you can handle both first page and sub page cases in
`backbutton` event and do `throw` or `history.back();` correspondingly.
This can be used
Github user beat-at-hartwig commented on the pull request:
https://github.com/apache/cordova-docs/pull/580#issuecomment-212302834
It is mandatory to implement this kind of backbutton handling by default
due to [Windows Store
Policies](https://msdn.microsoft.com/en-us/library/windows/
89 matches
Mail list logo
