[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

Github user TanaseButcaru commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62412961 --- Diff: www/convertUtils.js --- @@ -28,10 +28,19 @@ module.exports = { */ toCordovaFormat: function (contact) {

[GitHub] cordova-docs pull request: Removing NewVo from the app showcase

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/591 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Removing NewVo from the app showcase

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/591#issuecomment-217588646 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-docs pull request: CB-11196: Converting mark elements in d...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/593 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

RE: Node 6.x and Cordova CLI

Sounds good. I plan on merging fetch PR for the release too. https://github.com/apache/cordova-lib/pull/407 It is failing on appvoyer but working on my windows machine locally. I can do discuss release along side tool release if you want. Makes sense to do it together On May 6, 2016 3:28 PM, "Vla

[GitHub] cordova-paramedic pull request: Choose Target and use it for loggi...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/5#discussion_r62402348 --- Diff: lib/utils/utilities.js --- @@ -40,6 +40,57 @@ function getSimulatorsFolder() { return simulatorsFolderPath; } +funct

[GitHub] cordova-paramedic pull request: Choose Target and use it for loggi...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/5#discussion_r62402014 --- Diff: lib/utils/utilities.js --- @@ -40,6 +40,57 @@ function getSimulatorsFolder() { return simulatorsFolderPath; } +funct

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/125 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-paramedic pull request: Choose Target and use it for loggi...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/5#discussion_r62401164 --- Diff: lib/ParamedicTargetChooser.js --- @@ -0,0 +1,126 @@ +var Q = require('q'); +var shelljs = require('shelljs'); +var path

[GitHub] cordova-paramedic pull request: Choose Target and use it for loggi...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/5#discussion_r62400361 --- Diff: lib/ParamedicAppUninstall.js --- @@ -0,0 +1,68 @@ +var shelljs = require('shelljs'); +var path= require('path'); +var fs

[GitHub] cordova-paramedic pull request: Choose Target and use it for loggi...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/5#discussion_r62400177 --- Diff: lib/ParamedicAppUninstall.js --- @@ -0,0 +1,68 @@ +var shelljs = require('shelljs'); +var path= require('path'); +var fs

[GitHub] cordova-ios pull request: CB-11200 Bump node-xcode version

Github user codecov-io commented on the pull request: https://github.com/apache/cordova-ios/pull/221#issuecomment-217580068 ## [Current coverage][cc-pull] is **54.57%** > Merging [#221][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@

RE: Node 6.x and Cordova CLI

That'd be great! The PRs are ready: https://github.com/apache/cordova-lib/pull/437 and https://github.com/apache/cordova-ios/pull/221 Although the PR for cordova-lib is still failing w/ Node 6.0, this looks like a setup issue (the failure reason is jshint internals) and I can't reproduce these

[GitHub] cordova-ios pull request: CB-11200 Bump node-xcode version

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-ios/pull/221 CB-11200 Bump node-xcode version You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-ios CB-11200 Alternatively yo

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62398237 --- Diff: www/convertUtils.js --- @@ -28,10 +28,19 @@ module.exports = { */ toCordovaFormat: function (contact) {

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/125#issuecomment-217576715 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62397911 --- Diff: www/convertUtils.js --- @@ -28,10 +28,19 @@ module.exports = { */ toCordovaFormat: function (contact) {

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

Github user TanaseButcaru commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62396902 --- Diff: www/convertUtils.js --- @@ -28,10 +28,19 @@ module.exports = { */ toCordovaFormat: function (contact) {

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

Github user TanaseButcaru commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62396643 --- Diff: www/convertUtils.js --- @@ -28,10 +28,19 @@ module.exports = { */ toCordovaFormat: function (contact) {

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

Github user TanaseButcaru commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62396222 --- Diff: www/convertUtils.js --- @@ -28,10 +28,19 @@ module.exports = { */ toCordovaFormat: function (contact) {

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62395371 --- Diff: www/convertUtils.js --- @@ -28,10 +28,19 @@ module.exports = { */ toCordovaFormat: function (contact) {

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62395046 --- Diff: www/convertUtils.js --- @@ -28,10 +28,19 @@ module.exports = { */ toCordovaFormat: function (contact) {

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/125#issuecomment-217565470 Do you know why is iOS setting an 'Invalid Date' in the first place ? I feel like this fix might end up just masking an issue on the native side. ---

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

Github user TanaseButcaru commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62394372 --- Diff: www/convertUtils.js --- @@ -28,10 +28,19 @@ module.exports = { */ toCordovaFormat: function (contact) {

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62393819 --- Diff: www/convertUtils.js --- @@ -28,10 +28,19 @@ module.exports = { */ toCordovaFormat: function (contact) {

RE: Node 6.x and Cordova CLI

Sweet. Thanks for looking into it! I can start release process for both next week On May 6, 2016 2:13 PM, "Vladimir Kotikov (Akvelon)" wrote: > Hi list > > FYI, we’ve recently performed a sanity check of Cordova CLI against newly > released Node JS 6.0 (credits to Alex Sorokin) and found some iss

[GitHub] cordova-lib pull request: CB-11200 Bump xcode dependency and updat...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/437 CB-11200 Bump xcode dependency and update tests to pass You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-

RE: Node 6.x and Cordova CLI

Hi list FYI, we’ve recently performed a sanity check of Cordova CLI against newly released Node JS 6.0 (credits to Alex Sorokin) and found some issues, caused by new Node JS version. The most critical is a failure of uninstallation of plugins with custom frameworks for iOS platform - JIRA CB-11

[GitHub] cordova-plugin-contacts pull request: [CB-11223] Better check for ...

GitHub user TanaseButcaru opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/125 [CB-11223] Better check for date validity of contact.birthday / Fix: RangeError Invalid Date You can merge this pull request into a Git repository by running: $ git pul

[GitHub] cordova-plugin-dialogs pull request: CB-11218 Convert button list ...

GitHub user adzellman opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/76 CB-11218 Convert button list to appropriate type - If the buttons are passed in as a comma-separated string, then create an array with those values. JIRA: https://iss

[GitHub] cordova-mobile-spec pull request: CB-11050 Removing the flaky XHR ...

Github user omefire commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217527951 Haha, I just realized we should have updated the title to 'Fixing flaky XHR Test' instead of 'Removing ...'. Oh well, ... --- If your project is set u

[GitHub] cordova-mobile-spec pull request: CB-11050 Removing the flaky XHR ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-mobile-spec pull request: CB-11050 Removing the flaky XHR ...

Github user omefire commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217527093 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cordova-plugin-media-capture pull request: CB-10554: Implementing ...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/60#issuecomment-217523808 LGTM - Consider exposing these events on the capture object instead of `document` --- If your project is set up for it, you can reply to this ema

[GitHub] cordova-plugin-dialogs pull request: CB-11218 iOS: Handle single b...

Github user adzellman closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/436#issuecomment-217521367 Ok. I've created an issue to track it here: https://issues.apache.org/jira/browse/CB-11219 --- If your project is set up for it, you can reply to this email and ha

Re: [Android] Ending support for Ice Cream Sandwich?

+1 On Fri, May 6, 2016 at 10:53 AM Nikhil Khandelwal wrote: > +1. Let's do that! > > -Nikhil > > -Original Message- > From: Kerri Shotts [mailto:kerrisho...@gmail.com] > Sent: Friday, May 6, 2016 7:58 AM > To: dev@cordova.apache.org; dev@cordova.apache.org > Subject: Re: [Android] Ending

[GitHub] cordova-mobile-spec pull request: CB-11050 Removing the flaky XHR ...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217516568 Thanks @purplecabbage for the info. @omefire: Yes the flakiness is related to the host. It becomes randomly unavailable. I will update the PR to make get

RE: [Android] Ending support for Ice Cream Sandwich?

+1. Let's do that! -Nikhil -Original Message- From: Kerri Shotts [mailto:kerrisho...@gmail.com] Sent: Friday, May 6, 2016 7:58 AM To: dev@cordova.apache.org; dev@cordova.apache.org Subject: Re: [Android] Ending support for Ice Cream Sandwich? +1 ~Kerri --

[GitHub] cordova-plugin-dialogs pull request: CB-11218 iOS: Handle single b...

GitHub user adzellman opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/75 CB-11218 iOS: Handle single button passed as string - If the buttons are passed in as a string, then create an array with that string as the only value. JIRA:

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/436#issuecomment-217513174 @omefire you are correct. That flag seems to be totally broken --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/436 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-android pull request: CB-11198 Skip android target sdk che...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/303 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/436#issuecomment-217510255 (Though not related to this change) it seems like the ```--force``` flag wouldn't work as advertised ? --- If your project is set up for it, you can reply to this

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/436#issuecomment-217510027 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-mobile-spec pull request: CB-11050 Removing the flaky XHR ...

Github user omefire commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217509068 @rakatyal Is the flakiness related to the host we're XHR'ing to ? Would switching from 'http://cordova-filetransfer.jitsu.com' to something else(e.g: 'http

[GitHub] cordova-mobile-spec pull request: CB-11050 Removing the flaky XHR ...

Github user omefire commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217508257 Thanks @purplecabbage for confirming. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

Github user codecov-io commented on the pull request: https://github.com/apache/cordova-lib/pull/436#issuecomment-217507586 ## [Current coverage][cc-pull] is **80.71%** > Merging [#436][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@

[GitHub] cordova-lib pull request: CB-11134: Removing duplicated warning

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-lib/pull/436 CB-11134: Removing duplicated warning You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-11134 Alternatively you ca

[GitHub] cordova-windows pull request: CB-11117: Optimize prepare for windo...

Github user codecov-io commented on the pull request: https://github.com/apache/cordova-windows/pull/174#issuecomment-217492514 ## [Current coverage][cc-pull] is **71.20%** > Merging [#174][cc-pull] into [master][cc-base-branch] will decrease coverage by **-2.21%** ```diff

Re: [Android] Ending support for Ice Cream Sandwich?

+1 ~Kerri

Re: Buildbot: buildslave cordova-osx-slave was lost

I just restarted the slave, it should be back up. Thanks, Omar Mefire > On May 6, 2016, at 2:50 AM, build...@apache.org wrote: > > The Buildbot working for '' > has noticed that the buildslave named cordova-osx-slave went away > > It last disconnected at Fri May 6 09:45:56 2016 (buildmaster-lo

Re: [Android] Ending support for Ice Cream Sandwich?

Very +1 > On 5 May 2016, at 23:57, Joe Bowser wrote: > > Hey > > So, it's been a while, but it looks like we should really drop support for > ICS, because Crosswalk is dropping support for ICS. > > https://crosswalk-project.org/blog/deprecate-40.html > > So, yeah, I think we should drop suppo

Re: [Android] Ending support for Ice Cream Sandwich?

+1 On Fri, May 6, 2016 at 6:19 AM, Simon MacDonald wrote: > +1 to dropping support for ICS in the next major release of cordova-android. > > Simon Mac Donald > http://hi.im/simonmacdonald > > On Fri, May 6, 2016 at 12:35 AM, julio cesar sanchez > wrote: > >> ICS is on 2% of android devices, even

Re: [Android] Ending support for Ice Cream Sandwich?

+1 to dropping support for ICS in the next major release of cordova-android. Simon Mac Donald http://hi.im/simonmacdonald On Fri, May 6, 2016 at 12:35 AM, julio cesar sanchez wrote: > ICS is on 2% of android devices, even lower than gingerbread (2,2%) > > So +1 to deprecating > > http://develop

Buildbot: buildslave cordova-osx-slave was lost

The Buildbot working for '' has noticed that the buildslave named cordova-osx-slave went away It last disconnected at Fri May 6 09:45:56 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Richard Knoll '. Sincerely, The Buildbot https://ci.apache.or

[GitHub] cordova-android pull request: CB-11198 Skip android target sdk che...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/303#discussion_r62303417 --- Diff: bin/templates/cordova/lib/builders/AntBuilder.js --- @@ -107,7 +107,18 @@ AntBuilder.prototype.build = function(opts) { va

Re: [Android] Ending support for Ice Cream Sandwich?

ICS is on 2% of android devices, even lower than gingerbread (2,2%) So +1 to deprecating http://developer.android.com/about/dashboards/index.html#Platform El 6 may. 2016 8:57 a. m., "Joe Bowser" escribió: > Hey > > So, it's been a while, but it looks like we should really drop support for > ICS

[DICSUSS] Cordova-common release

Hi list We're thinking of cordova-common@1.3.0 release with the following changes included: * CB-11194 Improve cordova load time * CB-11170 Add FileUpdater module to cordova-common * CB-11131 Fix TypeError: message.toUpperCase is not a function in CordovaLogger I wa