Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/439#issuecomment-218672448
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-218664005
ping ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/599
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/390#issuecomment-218649503
Amazon-fireos has actually been deprecated. It is recommended to target the
android platform instead when releasing for amazon
---
If your project is set up for
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/236#issuecomment-218633214
I'd like to revive this PR. Hooks should run when using create scripts +
plugman.
---
If your project is set up for it, you can reply to this email and have yo
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/236#discussion_r62952050
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -283,7 +283,7 @@ function runUninstallPlatform(actions, platform,
project_dir, plugin_dir, plugi
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/53#issuecomment-218631729
Cordova CI Build has one or more failures.
**Dashboard** -
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2/
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-console/pull/14#issuecomment-218630347
Cordova CI Build has one or more failures.
**Dashboard** -
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/84/
**Resu
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/54#issuecomment-218629194
Cordova CI Build has one or more failures.
**Dashboard** -
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/1/
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218628056
Cordova CI Build has one or more failures.
**Dashboard** -
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/83/
**Resu
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/214#issuecomment-218627236
Cordova CI Build has one or more failures.
**Dashboard** -
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera/1/
**Result
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/41#issuecomment-218627178
Cordova CI Build has one or more failures.
**Dashboard** -
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-informa
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-plugin-console/pull/18
Dummy Entry
Testing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarangan12/cordova-plugin-console dummy
Alternatively you
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/439#issuecomment-218624176
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/439#discussion_r62946762
--- Diff: cordova-lib/src/hooks/HooksRunner.js ---
@@ -141,6 +144,23 @@ function runScript(script, context) {
// we assume we should use m
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-218623029
How close is this to being able to merge in? @macdonst
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-android/pull/305
Improving Android build output and verbose logging
Improving grammar, consistency of language, detail, etc. for verbose and
regular output. I'm going to use Android as an example for Window
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/104#issuecomment-218609674
Nitpick: You have a lot of long inline code blocks that span multiple
lines. Might look better to just use non-inline code blocks (i.e. with \`\`\`).
You can incl
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/104#discussion_r62937577
--- Diff: JENKINS.md ---
@@ -0,0 +1,123 @@
+# Jenkins Master Setup
+## Purpose
+The purpose of this document is to provide instructions on
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-medic/pull/104
Adding Instructions for Jenkins setup
@riknoll @rakatyal @nikhilkh @omefire Could you please review and merge
this PR?
You can merge this pull request into a Git repository by running:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/601
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-lib/pull/439
Improving prepare and build output
The purpose of this PR is to improve the quality and clarity of our logging
(including verbose). Some things I tried to improve:
* Consistency of lan
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/601#issuecomment-218600667
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62932451
--- Diff: doc/cordova.txt ---
@@ -5,6 +5,8 @@ Synopsis
Global Commands
create . Create a project
help
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62926584
--- Diff: lib/paramedic.js ---
@@ -175,39 +178,58 @@ ParamedicRunner.prototype.runTests = function() {
reject(new Error('device is di
GitHub user Autre31415 opened a pull request:
https://github.com/apache/cordova-cli/pull/250
fixed spelling error
attribute on line 113 of readme.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Autre31415/cordova-cli patch-1
A
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/437
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Agreed. I'm not even sure why we need this plugin, but I will most likely
ignore it like I do the statusbar plugin, which I also thought wasn't
necessary.
On Wed, May 11, 2016 at 12:36 PM, Darryl Pogue wrote:
> I think this is a good feature to have as a supported core plugin, but I
> also worr
A hangout sounds good. We need to pick a date and time. Should I send out a
doodle?
For me personally, I won't be able to attend until the first week of June
due to PGDAY EU travels.
On Tue, May 10, 2016 at 11:55 AM, Parashuram N
wrote:
> It has been a while since all of us met, so I was wonder
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/76
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
I think this is a good feature to have as a supported core plugin, but I
also worry about feature creep and endless bikeshedding like we see with
the statusbar plugin.
The originally linked plugin acts as a polyfill for the W3C spec[1]. This
new core plugin should do the same, and should ruthlessl
+1; Agree. I've seen many questions about controlling orientation, so
having a core plugin to reply with would be nice to have.
Lets do it!
Thanks Tony for getting it going. Hit me up on slack if you have questions
about infra type stuff.
On Wed, May 11, 2016 at 12:26 PM, Jesse wrote:
> More prior art here:
> https://github.com/purplecabbage/phonegap-plugin-orientation
>
> Windows support in mine.
>
>
> @purplecabba
More prior art here:
https://github.com/purplecabbage/phonegap-plugin-orientation
Windows support in mine.
@purplecabbage
risingj.com
On Wed, May 11, 2016 at 11:23 AM, Raymond Camden
wrote:
> Agreed, +1.
>
> On Wed, May 11, 2016 at 12:22 PM, Nikhil Khandelwal
> wrote:
> > +1. This feels like
Github user FdezRomero commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/51#issuecomment-218562332
@MrARC My bad, I thought it was 4.x because the home button is not a
circle. The code in the PR just reverses the two flags set by the plugin. Maybe
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-docs/pull/601
CB-11253: Fixing sitemap url entries
We were giving relative paths, we need to give full URLs. This should
improve our SEO, hopefully. @nikhilkh take a quick look.
You can merge this pull req
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media-capture/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/601#issuecomment-218561121
Changes entries like this
```
/news/2015/03/02/tools-release.html
```
to look like this:
```
https://cordova.apache.or
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/61#issuecomment-218560464
LGTM. Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-cli/pull/249#issuecomment-21855
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user MrARC commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/51#issuecomment-218557344
Sorry, i forgot to say that the device was running Android 5.1, which is
weird because Lollipop has support for translucent statusbar.
---
If your proje
Github user FdezRomero commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/51#issuecomment-218551168
Pushing this PR from oblivion: Maybe Google Play uses AppCompat and that's
why it has a Material-style translucent status bar? I'm not sure if this i
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62901350
--- Diff: lib/utils/utilities.js ---
@@ -50,10 +50,14 @@ function getSimId() {
if (findSimResult.code > 0) {
logger.err
Agreed, +1.
On Wed, May 11, 2016 at 12:22 PM, Nikhil Khandelwal
wrote:
> +1. This feels like a "core" capability.
>
> -Nikhil
>
> -Original Message-
> From: Suraj Pindoria [mailto:suraj.pindo...@yahoo.com.INVALID]
> Sent: Wednesday, May 11, 2016 9:08 AM
> To: dev@cordova.apache.org
> Subj
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62901242
--- Diff: lib/ParamedicTargetChooser.js ---
@@ -0,0 +1,127 @@
+var Q = require('q');
+var shelljs = require('shelljs');
+var path
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62901268
--- Diff: lib/ParamedicTargetChooser.js ---
@@ -0,0 +1,127 @@
+var Q = require('q');
+var shelljs = require('shelljs');
+var path
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62901339
--- Diff: lib/paramedic.js ---
@@ -175,39 +178,58 @@ ParamedicRunner.prototype.runTests = function() {
reject(new Error('device is
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62901118
--- Diff: lib/ParamedicAppUninstall.js ---
@@ -0,0 +1,66 @@
+var shelljs = require('shelljs');
+var path= require('path');
+var fs
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62901186
--- Diff: lib/ParamedicAppUninstall.js ---
@@ -0,0 +1,66 @@
+var shelljs = require('shelljs');
+var path= require('path');
+var fs
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218547172
Thanks for the feedback! I made some updates based on feedback.
As far as running tests - we're automating that process using Jenkins,
Travis C
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62895769
--- Diff: doc/cordova.txt ---
@@ -21,7 +23,7 @@ Project Commands
run Run project
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#issuecomment-218538540
It would be nice to refactor the specs a bit, because they seem to be 90%
shared code. This looks pretty good! Reading the file and checking the
dimensio
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62894363
--- Diff: src/cli.js ---
@@ -235,41 +317,58 @@ function cli(inputArgs) {
throw new CordovaError(msg);
}
-c
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/141#issuecomment-218534776
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
+1. This feels like a "core" capability.
-Nikhil
-Original Message-
From: Suraj Pindoria [mailto:suraj.pindo...@yahoo.com.INVALID]
Sent: Wednesday, May 11, 2016 9:08 AM
To: dev@cordova.apache.org
Subject: Re: proposal for new core plugin to control screen orientation
+1
I have been look
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62882068
--- Diff: src/cli.js ---
@@ -235,41 +317,58 @@ function cli(inputArgs) {
throw new CordovaError(msg);
}
-c
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62880886
--- Diff: src/cli.js ---
@@ -235,41 +317,58 @@ function cli(inputArgs) {
throw new CordovaError(msg);
}
-c
+1
I have been looking into this plugin for the last few days in order to add it
to the PhoneGap Developer App. I think it would make a great addition to the
core plugins and wouldn't mind volunteering to help bring it up to spec.
Regards,Suraj.
On Tuesday, May 10, 2016 8:56 AM, "Homer, Ton
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-medic/pull/103#issuecomment-218501431
Related PR for camera plugin:
https://github.com/apache/cordova-plugin-camera/pull/214
---
If your project is set up for it, you can reply to this email and ha
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-medic/pull/103#issuecomment-218501201
Some background on this:
Tests were failing because Appium callback couldn't reach the Appium server
from app side due to whitelist restrictions, therefore a
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/214
CB-11232 Appium tests: fixed element tapping on iOS 9
https://issues.apache.org/jira/browse/CB-11232
You can merge this pull request into a Git repository by running:
$ git pul
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62870553
--- Diff: src/cli.js ---
@@ -235,41 +317,58 @@ function cli(inputArgs) {
throw new CordovaError(msg);
}
-c
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-medic/pull/103
CB-11232:
- Adding whitelist rule to config.xml before Appium tests launch
- Fixed tapElementByXPath to correctly tap on elements when their location
has a fractional number
ht
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-cli/pull/249#issuecomment-218479809
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user qkdreyer commented on the pull request:
https://github.com/apache/cordova-lib/commit/0c61fb097d5f6a317560adbb2165ff916642c5c7#commitcomment-17433959
In cordova-lib/src/cordova/restore-util.js:
In cordova-lib/src/cordova/restore-util.js on line 117:
@vladimir-kotikov
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-cli/pull/249
CB-11250 Fix CLI tests verifying the version
[Jira issue](https://issues.apache.org/jira/browse/CB-11250)
`toMatch` expects regexp and the version can contain special symbols so
using
Github user qkdreyer commented on the pull request:
https://github.com/apache/cordova-lib/commit/0c61fb097d5f6a317560adbb2165ff916642c5c7#commitcomment-17433806
In cordova-lib/src/cordova/restore-util.js:
In cordova-lib/src/cordova/restore-util.js on line 117:
If pluginSpec equ
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-docs/pull/600#issuecomment-218391884
I don't think "relies on native SQLite implementation" is so relevant
anymore. The cordova-sqlite-storage version now includes its own sqlite3
implementation. Al
68 matches
Mail list logo
