[GitHub] cordova-cli pull request: CB-11284 Telemetry: Track platforms/plug...

2016-05-20 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/253#discussion_r64108237 --- Diff: src/cli.js --- @@ -143,20 +143,27 @@ module.exports = function (inputArgs, cb) { return cli(inputArgs); }).then(function

[GitHub] cordova-cli pull request: CB-11284 Telemetry: Track platforms/plug...

2016-05-20 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-cli/pull/253#issuecomment-220719536 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-android pull request: CB-11292 fix broken MessageChannel a...

2016-05-20 Thread codecov-io
Github user codecov-io commented on the pull request: https://github.com/apache/cordova-android/pull/307#issuecomment-220714174 ## [Current coverage][cc-pull] is **34.21%** > Merging [#307][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@

[GitHub] cordova-android pull request: CB-11292 fix broken MessageChannel a...

2016-05-20 Thread tony--
GitHub user tony-- opened a pull request: https://github.com/apache/cordova-android/pull/307 CB-11292 fix broken MessageChannel after plugins are recreated also added a new test to prevent regression - probably overkill but the issue was hard to isolate You can merge this pull

[GitHub] cordova-android pull request: CB-10096: Upgrade test project to Gr...

2016-05-20 Thread tony--
GitHub user tony-- opened a pull request: https://github.com/apache/cordova-android/pull/306 CB-10096: Upgrade test project to Gradle Plugin 2.1.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/tony--/cordova-android

[GitHub] cordova-cli pull request: CB-11284 Telemetry: Track platforms/plug...

2016-05-20 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/253#discussion_r64092365 --- Diff: src/cli.js --- @@ -143,20 +143,27 @@ module.exports = function (inputArgs, cb) { return cli(inputArgs); }).then(function

[GitHub] cordova-cli pull request: CB-11284 Telemetry: Track platforms/plug...

2016-05-20 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/253#discussion_r64091935 --- Diff: src/cli.js --- @@ -143,20 +143,27 @@ module.exports = function (inputArgs, cb) { return cli(inputArgs); }).then(function

[GitHub] cordova-cli pull request: CB-11284 Telemetry: Track platforms/plug...

2016-05-20 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-cli/pull/253 CB-11284 Telemetry: Track platforms/plugins subcommands(add/rm/etc...) You can merge this pull request into a Git repository by running: $ git pull https://github.com/omefire/cordova-cli

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

2016-05-20 Thread ktop
Github user ktop commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-220647997 I'd like to clear up some confusion I have on adding attributes. Before, we had decided on going with this syntax where the child elements of config-file tag

[GitHub] cordova-coho pull request: CB-11280 Pin nightly platforms versions

2016-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-camera pull request: CB-11296: Appium: Better eleme...

2016-05-20 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/218#issuecomment-220544861 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-contacts pull request: CB-11296: Appium: Better ele...

2016-05-20 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/127#issuecomment-220544301 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-contacts pull request: CB-11296: Appium: Better ele...

2016-05-20 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/127 CB-11296: Appium: Better element clicking and session error handling ### Platforms affected Android, iOS ### What does this PR do?