[GitHub] cordova-windows pull request: CB-11117: Optimize prepare for windo...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/174#discussion_r64688561 --- Diff: template/cordova/lib/prepare.js --- @@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject) {

[GitHub] cordova-plugin-dialogs pull request: Master

Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/78#issuecomment-221769640 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-dialogs pull request: Master

GitHub user Snyz2016 opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/78 Master 修改进度条为不可取消 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Snyz2016/snyz-plugin-dialogs master

[GitHub] cordova-windows pull request: CB-11117: Optimize prepare for windo...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/174#discussion_r64677748 --- Diff: template/cordova/lib/prepare.js --- @@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject) {

[GitHub] cordova-windows pull request: CB-11117: Optimize prepare for windo...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/174#discussion_r64677389 --- Diff: template/cordova/lib/prepare.js --- @@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject) {

[GitHub] cordova-android pull request: CB-10096: Upgrade test project to Gr...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/306#issuecomment-221718552 OK, this is a pre-req of #307, so I merged them both together. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-android pull request: CB-10096: Upgrade test project to Gr...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/306 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [DISCUSS] Cordova-Android 5.2.0 Release

On Wed, May 25, 2016 at 1:47 PM, Homer, Tony wrote: > +1 > > Would like #307 to be merged in first > > Done! Yay for tests! BTW, We need to re-write those to migrate to the new Android JUnit test framework (It's more deleting code than adding). > On 5/25/16, 3:31 PM,

[GitHub] cordova-android pull request: CB-11292 fix broken MessageChannel a...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/307 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [DISCUSS] Cordova-Android 5.2.0 Release

+1 Would like #307 to be merged in first On 5/25/16, 3:31 PM, "Carlos Santana" wrote: >+1 > >- Carlos >@csantanapr > >> On May 25, 2016, at 3:08 PM, Shazron wrote: >> >> +1 >> >> Release often >> >>> On Wed, May 25, 2016 at 10:33 AM, Joe Bowser

[GitHub] cordova-plugin-media pull request: [R180FLU-4334] Renaming plugin ...

Github user fedhat commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/98#issuecomment-221694323 Apologies for creating this PR in the wrong repo. I have deleted the PR and branch. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-android pull request: CB-11292 fix broken MessageChannel a...

Github user tony-- commented on the pull request: https://github.com/apache/cordova-android/pull/307#issuecomment-221693379 AppVeyor timed out, not a failure related to the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-media pull request: [R180FLU-4334] Renaming plugin ...

Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/98#issuecomment-221693682 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-android pull request: CB-10096: Upgrade test project to Gr...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/306#issuecomment-221691711 This looks completely unrelated to the pull request itself. We should just merge this in. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-android pull request: CB-10096: Upgrade test project to Gr...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/306#issuecomment-221691227 Why did this break travis??? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-media pull request: [R180FLU-4334] Renaming plugin ...

Github user fedhat closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/98 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media pull request: [R180FLU-4334] Renaming plugin ...

GitHub user fedhat opened a pull request: https://github.com/apache/cordova-plugin-media/pull/98 [R180FLU-4334] Renaming plugin and parts Changing the name of the plugin's repo and it's parts, in order to prevent name collision and allow developers to use this plugin along with the

Re: [DISCUSS] Cordova-Android 5.2.0 Release

+1 - Carlos @csantanapr > On May 25, 2016, at 3:08 PM, Shazron wrote: > > +1 > > Release often > >> On Wed, May 25, 2016 at 10:33 AM, Joe Bowser wrote: >> >> Hey >> >> I know that we haven't done a minor release for a few months for Android, >> and I

Re: Yet another Cordova-Android 6.0.x release thread, and another 5.x release soon

Hehe thanks for the clarification it crossed my mind that we were going to ship some type of dynamic cordova runtime to the playstore for Devs to pickup AAR makes more sense :-) - Carlos @csantanapr > On May 25, 2016, at 11:51 AM, Joe Bowser wrote: > > That was a typo.

[GitHub] cordova-cli pull request: Code Refactor & Cleanup

GitHub user omefire opened a pull request: https://github.com/apache/cordova-cli/pull/254 Code Refactor & Cleanup You can merge this pull request into a Git repository by running: $ git pull https://github.com/omefire/cordova-cli CB-11284 Alternatively you can review and

Re: [DISCUSS] Cordova-Android 5.2.0 Release

+1 Release often On Wed, May 25, 2016 at 10:33 AM, Joe Bowser wrote: > Hey > > I know that we haven't done a minor release for a few months for Android, > and I think that we have enough worthwhile changes in Android that we > should probably do a release soon. If possible,

[GitHub] cordova-plugin-file-transfer pull request: CB-11067 - Adds content...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/140#issuecomment-221670591 @oddcb, thanks for the contribution! This is not an issue though as the `Content-Length` header is set by

RE: [DISCUSS] Cordova-Android 5.2.0 Release

+1. It will be great to get this PR merged now that cordova-common has been released: https://github.com/apache/cordova-android/pull/295/files -Nikhil -Original Message- From: Simon MacDonald [mailto:simon.macdon...@gmail.com] Sent: Wednesday, May 25, 2016 10:38 AM To:

Re: [DISCUSS] Cordova-Android 5.2.0 Release

+1 On May 25, 2016 1:33 PM, "Joe Bowser" wrote: > Hey > > I know that we haven't done a minor release for a few months for Android, > and I think that we have enough worthwhile changes in Android that we > should probably do a release soon. If possible, I would like for us to

[DISCUSS] Cordova-Android 5.2.0 Release

Hey I know that we haven't done a minor release for a few months for Android, and I think that we have enough worthwhile changes in Android that we should probably do a release soon. If possible, I would like for us to do a 5.2.0 release with the versioning fix, and the other build script fixes

Re: Yet another Cordova-Android 6.0.x release thread, and another 5.x release soon

kk, just making sure. Simon Mac Donald http://hi.im/simonmacdonald On Wed, May 25, 2016 at 11:51 AM, Joe Bowser wrote: > That was a typo. > > On Wed, May 25, 2016 at 8:50 AM, Simon MacDonald < > simon.macdon...@gmail.com> > wrote: > > > LGTM too. > > > > Although is

Re: Yet another Cordova-Android 6.0.x release thread, and another 5.x release soon

I was going to say something more witty here, but I haven't had coffee yet. :P I think I'm going to start another thread for a 5.2 release at this point, since I want to see that happen before 6.0.x On Wed, May 25, 2016 at 8:51 AM, Joe Bowser wrote: > That was a typo. > > On

Re: Yet another Cordova-Android 6.0.x release thread, and another 5.x release soon

That was a typo. On Wed, May 25, 2016 at 8:50 AM, Simon MacDonald wrote: > LGTM too. > > Although is "Cordova-Android as a distributable APK" supposed to be > "Cordova-Android > as a distributable AAR"? > > > Simon Mac Donald > http://hi.im/simonmacdonald > > On Tue,

Re: Yet another Cordova-Android 6.0.x release thread, and another 5.x release soon

LGTM too. Although is "Cordova-Android as a distributable APK" supposed to be "Cordova-Android as a distributable AAR"? Simon Mac Donald http://hi.im/simonmacdonald On Tue, May 24, 2016 at 4:24 PM, Carlos Santana wrote: > LGTM > I don't think Android N is going to

[GitHub] cordova-plugin-file-transfer pull request: Adds support to PATCH m...

Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/146#issuecomment-221606884 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-file-transfer pull request: Adds support to PATCH m...

GitHub user BugsBunnyBR opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/146 Adds support to PATCH method ### Platforms affected All ### What does this PR do? Adds support to PATCH method ### What testing has been done on

[GitHub] cordova-plugin-vibration pull request: Update plugin.xml

Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/47#issuecomment-221487476 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-vibration pull request: Update plugin.xml

Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/47#issuecomment-221484068 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-vibration pull request: Update plugin.xml

Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/47#issuecomment-221482393 Cordova CI Build has one or more failures. **Commit** -