Re: Introduction

2016-05-26 Thread Jesse
Welcome Caryn! @purplecabbage risingj.com On Thu, May 26, 2016 at 4:17 PM, Caryn Tran wrote: > Hello! My name is Caryn, a UCB senior who is interning with Adobe PhoneGap > this summer. Greatly looking forward to getting involved with the > Cordova/PhoneGap community! >

[GitHub] cordova-ios pull request: CB-11117: Optimize prepare for ios platf...

2016-05-26 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/220#issuecomment-222032258 Squashed the commits, and ran the tests -- all green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-ios pull request: CB-11117: Optimize prepare for ios platf...

2016-05-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/220 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

RE: Introduction

2016-05-26 Thread Ryan J. Salva
Happy interning, Caryn, and welcome to the Cordova project! Ryan J. Salva  |  Principal PM Manager Visual Studio Tools for Apache Cordova rsa...@microsoft.com 425 706 5270 office 206 612 5079 mobile -Original Message- From: Caryn Tran [mailto:ct...@adobe.com] Sent: Thursday, May 26,

Introduction

2016-05-26 Thread Caryn Tran
Hello! My name is Caryn, a UCB senior who is interning with Adobe PhoneGap this summer. Greatly looking forward to getting involved with the Cordova/PhoneGap community!

[GitHub] cordova-plugin-file pull request: CB-11305 Enable cdvfile: assets ...

2016-05-26 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/182#issuecomment-222021395 :shipit: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-file pull request: CB-11305 Enable cdvfile: assets ...

2016-05-26 Thread jasongin
Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/182#discussion_r64836957 --- Diff: tests/tests.js --- @@ -3441,6 +3441,27 @@ exports.defineAutoTests = function () { } });

RE: [DISCUSS] iOS release

2016-05-26 Thread Jason Ginchereau
All right, I pushed a small update. It should be good to go now. This PR for cordova-ios actually hasn't been reviewed by anyone yet, however it is very similar to the PRs for cordova-android and cordova-windows which were reviewed by Nikhil and Vladimir. -Original Message- From:

[GitHub] cordova-plugin-file pull request: CB-11305 Enable cdvfile: assets ...

2016-05-26 Thread jasongin
Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/182#discussion_r64836116 --- Diff: tests/tests.js --- @@ -3441,6 +3441,27 @@ exports.defineAutoTests = function () { } });

[GitHub] cordova-windows pull request: CB-11117: Optimize prepare for windo...

2016-05-26 Thread jasongin
Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/174#discussion_r64834967 --- Diff: template/cordova/lib/prepare.js --- @@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject) {

RE: [DISCUSS] iOS release

2016-05-26 Thread Jason Ginchereau
Hold on just a moment. Nikhil had a comment about the PR that I need to investigate and possibly make a small change. It should be ready later today. -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Thursday, May 26, 2016 3:14 PM To: dev@cordova.apache.org Subject: Re:

Re: [DISCUSS] iOS release

2016-05-26 Thread Shazron
Jason - I'll run the tests again and pull this in On Thu, May 26, 2016 at 2:54 PM, Jason Ginchereau wrote: > I have a PR here that we'd like to get in: > https://github.com/apache/cordova-ios/pull/220 > > It includes bundling of cordova-common 1.3.0. > > > -Original

RE: [DISCUSS] iOS release

2016-05-26 Thread Jason Ginchereau
I have a PR here that we'd like to get in: https://github.com/apache/cordova-ios/pull/220 It includes bundling of cordova-common 1.3.0. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, May 26, 2016 2:48 PM To: dev@cordova.apache.org Subject:

Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-05-26 Thread Joe Bowser
Do we have an N PR yet? I've seen the proposal, but not the PR. On Thu, May 26, 2016 at 2:47 PM, Steven Gill wrote: > Can we merge the android N PR too? > > On Wed, May 25, 2016 at 2:50 PM, Joe Bowser wrote: > > > On Wed, May 25, 2016 at 1:47 PM,

[DISCUSS] iOS release

2016-05-26 Thread Steven Gill
Any blockers? Need to update with latest cordova-common for node 6 support

Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-05-26 Thread Steven Gill
Can we merge the android N PR too? On Wed, May 25, 2016 at 2:50 PM, Joe Bowser wrote: > On Wed, May 25, 2016 at 1:47 PM, Homer, Tony wrote: > > > +1 > > > > Would like #307 to be merged in first > > > > > Done! Yay for tests! > > BTW, We need to

Re: re-write tests for new Android JUnit test framework

2016-05-26 Thread Joe Bowser
On Thu, May 26, 2016 at 11:48 AM, Homer, Tony wrote: > (topic changed to not clutter the 5.2.0 discussion) > > Joe- > > Is there a JIRA for this work? > Not yet. I literally just remembered it. > Do you have more information or a pointer to a reference? >

[GitHub] cordova-coho pull request: add 'platforms' to repo_groups

2016-05-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/125 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-coho pull request: add 'platforms' to repo_groups

2016-05-26 Thread carynbear
GitHub user carynbear opened a pull request: https://github.com/apache/cordova-coho/pull/125 add 'platforms' to repo_groups You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova-coho master Alternatively you can

re-write tests for new Android JUnit test framework

2016-05-26 Thread Homer, Tony
(topic changed to not clutter the 5.2.0 discussion) Joe- Is there a JIRA for this work? Do you have more information or a pointer to a reference? I’ve tweaked a few of the tests and written two but I don’t know what needs to be done for this migration task. I might be interested in taking

[GitHub] cordova-cli pull request: Code Refactor & Cleanup

2016-05-26 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/254#issuecomment-221936305 Opened another PR with these changes here: https://github.com/apache/cordova-cli/pull/255 --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-cli pull request: Code Refactor & Cleanup

2016-05-26 Thread omefire
Github user omefire closed the pull request at: https://github.com/apache/cordova-cli/pull/254 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: CLI Refactor

2016-05-26 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-cli/pull/255 CLI Refactor You can merge this pull request into a Git repository by running: $ git pull https://github.com/omefire/cordova-cli CLI_Refactor Alternatively you can review and apply

[Vote] 4.3.4 Ubuntu Release

2016-05-26 Thread David Barth
Hey, Please review and vote on this 4.3.4 Ubuntu Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11294 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-11294/ The

[GitHub] cordova-plugin-file pull request: CB-11305 Enable cdvfile: assets ...

2016-05-26 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/182#issuecomment-221885746 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-file pull request: CB-11305 Enable cdvfile: assets ...

2016-05-26 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file/pull/182 CB-11305 Enable cdvfile: assets fs root for DOM requests ### Platforms affected Android ### What does this PR do? Added test for `cdvfile`

[GitHub] cordova-docs pull request: Cordova Ubuntu 4.3.4 release announceme...

2016-05-26 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-docs/pull/607 Cordova Ubuntu 4.3.4 release announcement You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-docs

[GitHub] cordova-plugin-file-transfer pull request: CB-11067 - Adds content...

2016-05-26 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/140#issuecomment-221841464 @oddcb, yes, `Content-Length` should be added by `setFixedLengthStreamingMode`. Which Android OS version had the issue? Could you try it

[GitHub] cordova-plugin-file-transfer pull request: CB-11067 - Adds content...

2016-05-26 Thread oddcb
Github user oddcb commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/140#issuecomment-221839381 Thanks for you reply @daserge So I'm not very into how file uploads are done properly, but the problem I fixed for our api here was adding