Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/174#issuecomment-222074009
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Welcome Caryn!
@purplecabbage
risingj.com
On Thu, May 26, 2016 at 4:17 PM, Caryn Tran wrote:
> Hello! My name is Caryn, a UCB senior who is interning with Adobe PhoneGap
> this summer. Greatly looking forward to getting involved with the
> Cordova/PhoneGap community!
>
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/220#issuecomment-222032258
Squashed the commits, and ran the tests -- all green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/220
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Happy interning, Caryn, and welcome to the Cordova project!
Ryan J. Salva | Principal PM Manager
Visual Studio Tools for Apache Cordova
rsa...@microsoft.com
425 706 5270 office
206 612 5079 mobile
-Original Message-
From: Caryn Tran [mailto:ct...@adobe.com]
Sent: Thursday, May 26, 20
Hello! My name is Caryn, a UCB senior who is interning with Adobe PhoneGap this
summer. Greatly looking forward to getting involved with the Cordova/PhoneGap
community!
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/182#issuecomment-222021395
:shipit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/182#discussion_r64836957
--- Diff: tests/tests.js ---
@@ -3441,6 +3441,27 @@ exports.defineAutoTests = function () {
}
});
All right, I pushed a small update. It should be good to go now.
This PR for cordova-ios actually hasn't been reviewed by anyone yet, however it
is very similar to the PRs for cordova-android and cordova-windows which were
reviewed by Nikhil and Vladimir.
-Original Message-
From: Jason
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/182#discussion_r64836116
--- Diff: tests/tests.js ---
@@ -3441,6 +3441,27 @@ exports.defineAutoTests = function () {
}
});
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/174#discussion_r64834967
--- Diff: template/cordova/lib/prepare.js ---
@@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject) {
AppxManifest.purgeC
Hold on just a moment. Nikhil had a comment about the PR that I need to
investigate and possibly make a small change. It should be ready later today.
-Original Message-
From: Shazron [mailto:shaz...@gmail.com]
Sent: Thursday, May 26, 2016 3:14 PM
To: dev@cordova.apache.org
Subject: Re: [
Jason - I'll run the tests again and pull this in
On Thu, May 26, 2016 at 2:54 PM, Jason Ginchereau
wrote:
> I have a PR here that we'd like to get in:
> https://github.com/apache/cordova-ios/pull/220
>
> It includes bundling of cordova-common 1.3.0.
>
>
> -Original Message-
> From: Stev
I have a PR here that we'd like to get in:
https://github.com/apache/cordova-ios/pull/220
It includes bundling of cordova-common 1.3.0.
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Thursday, May 26, 2016 2:48 PM
To: dev@cordova.apache.org
Subject: [DISCUSS]
Do we have an N PR yet? I've seen the proposal, but not the PR.
On Thu, May 26, 2016 at 2:47 PM, Steven Gill wrote:
> Can we merge the android N PR too?
>
> On Wed, May 25, 2016 at 2:50 PM, Joe Bowser wrote:
>
> > On Wed, May 25, 2016 at 1:47 PM, Homer, Tony
> wrote:
> >
> > > +1
> > >
> > > W
Any blockers?
Need to update with latest cordova-common for node 6 support
Can we merge the android N PR too?
On Wed, May 25, 2016 at 2:50 PM, Joe Bowser wrote:
> On Wed, May 25, 2016 at 1:47 PM, Homer, Tony wrote:
>
> > +1
> >
> > Would like #307 to be merged in first
> >
> >
> Done! Yay for tests!
>
> BTW, We need to re-write those to migrate to the new Android JUni
On Thu, May 26, 2016 at 11:48 AM, Homer, Tony wrote:
> (topic changed to not clutter the 5.2.0 discussion)
>
> Joe-
>
> Is there a JIRA for this work?
>
Not yet. I literally just remembered it.
> Do you have more information or a pointer to a reference?
>
https://developer.android.com/studio
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-coho/pull/125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
GitHub user carynbear opened a pull request:
https://github.com/apache/cordova-coho/pull/125
add 'platforms' to repo_groups
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/carynbear/cordova-coho master
Alternatively you can revi
(topic changed to not clutter the 5.2.0 discussion)
Joe-
Is there a JIRA for this work?
Do you have more information or a pointer to a reference?
I’ve tweaked a few of the tests and written two but I don’t know what needs to
be done for this migration task.
I might be interested in taking this
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/254#issuecomment-221936305
Opened another PR with these changes here:
https://github.com/apache/cordova-cli/pull/255
---
If your project is set up for it, you can reply to this email and hav
Github user omefire closed the pull request at:
https://github.com/apache/cordova-cli/pull/254
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-cli/pull/255
CLI Refactor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-cli CLI_Refactor
Alternatively you can review and apply these
Hey,
Please review and vote on this 4.3.4 Ubuntu Release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-11294
The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-11294/
The p
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/182#issuecomment-221885746
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-file/pull/182/commits/5fcd90dbeb711
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/182
CB-11305 Enable cdvfile: assets fs root for DOM requests
### Platforms affected
Android
### What does this PR do?
Added test for `cdvfile` `applicationDirector
GitHub user david-barth-canonical opened a pull request:
https://github.com/apache/cordova-docs/pull/607
Cordova Ubuntu 4.3.4 release announcement
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cordova-ubuntu/cordova-docs
cordo
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/140#issuecomment-221841464
@oddcb, yes, `Content-Length` should be added by
`setFixedLengthStreamingMode`.
Which Android OS version had the issue?
Could you try it ag
Github user oddcb commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/140#issuecomment-221839381
Thanks for you reply @daserge
So I'm not very into how file uploads are done properly, but the problem I
fixed for our api here was adding
30 matches
Mail list logo