Nightly build #44 for cordova has succeeded!

2016-06-17 Thread Apache Jenkins Server
Nightly build #44 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/44/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-camera issue #219: Dont work camera on Android

2016-06-17 Thread cleever
Github user cleever commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/219 Thank you @thedoorbell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: [Discuss] Why was device.name removed from the device-plugin?

2016-06-17 Thread Carlos Santana
I think this belongs in user community plugin maybe a cordova-plugin-device-nickname - Carlos Santana @csantanapr > On Jun 17, 2016, at 10:25 PM, Kerri Shotts wrote: > > -1 to using Bluetooth to get the device name. That would add an additional > permission (AFAICT)

Re: [Discuss] Why was device.name removed from the device-plugin?

2016-06-17 Thread Kerri Shotts
-1 to using Bluetooth to get the device name. That would add an additional permission (AFAICT) that is hard to justify to an end user, and which would be added to a good number of Cordova apps intending only to use the device plugin to implement platform-specific features or workarounds.  I

Re: [Discuss] Why was device.name removed from the device-plugin?

2016-06-17 Thread Joe Bowser
The Bluetooth plugin, or a third party plugin. It does not belong in Device. On Fri, Jun 17, 2016, 5:23 PM Philipp Kursawe wrote: > > that might bring some trouble if the device doesn't have > bluetooth. We should decide what to return in that case, nothing? and >

Re: [Discuss] Why was device.name removed from the device-plugin?

2016-06-17 Thread Philipp Kursawe
> that might bring some trouble if the device doesn't have bluetooth. We should decide what to return in that case, nothing? and document it We return manufactur + model in that case. @Joe: the devices I checked had pretty useful BT sharing names. And it is functionality belonging to the device.

Re: [Discuss] Why was device.name removed from the device-plugin?

2016-06-17 Thread Joe Bowser
-1 This is a new feature and something we never supported. The model feature was the user-readable type of phone on Android (i.e. Nexus 5X) where the name was the in-house codename for it, in this case bullhead. When we switched to device.model, we removed device.name. Getting the Bluetooth

Re: [Discuss] Why was device.name removed from the device-plugin?

2016-06-17 Thread julio cesar sanchez
+1 The only thing I see is the plugin he points get the android name from the bluetooth adapter, that might bring some trouble if the device doesn't have bluetooth. We should decide what to return in that case, nothing? and document it 2016-06-18 0:15 GMT+02:00 Shazron : > I

Re: [Discuss] Why was device.name removed from the device-plugin?

2016-06-17 Thread Jesse
It makes sense as long as it is considered user meta, and nothing else. > On Jun 17, 2016, at 3:15 PM, Shazron wrote: > > I have no objection if the API property is unambiguous, unlike what it was > before (over 4 years ago!), and is supported by all the major platforms >

Re: [Discuss] Why was device.name removed from the device-plugin?

2016-06-17 Thread Shazron
I have no objection if the API property is unambiguous, unlike what it was before (over 4 years ago!), and is supported by all the major platforms (looks like it is, from what you mentioned). Also -- Ubuntu/Linux looks like its just /etc/hostname. We'll just have to bump a minor version. What do

Re: [Discuss] Why was device.name removed from the device-plugin?

2016-06-17 Thread Philipp Kursawe
To further emphasize one point. I fully agree with moving from device.name to device.model + device.manufacturer + device.platform. But I still ask all of you do consider bringing back a proper device.name. As I wrote, on Windows its pretty easy to get the real name of the PC/Phone. On iOS and

Re: [Discuss] Why was device.name removed from the device-plugin?

2016-06-17 Thread Philipp Kursawe
Thanks for pointing this out. However the name is not used to reference the device to the API. Thats what the device.uuid is being used for. The device name is used in the UI where the user can see its API enabled devices. You don't want to show the user the device id there (cause she has no point

Re: Contribution for improve Cordova

2016-06-17 Thread Shazron
Welcome! Check out the contribution guide [1] and let us know if you need any help in this regard. Also, please subscribe to this list by sending an email to dev-subscr...@cordova.apache.org [1] http://cordova.apache.org/contribute/ On Fri, Jun 17, 2016 at 3:43 AM, sanjeewa kumara

Contribution for improve Cordova

2016-06-17 Thread sanjeewa kumara
I'm a under graduate computer student at the Faulty of Engineering, University of Peradeniya. I am interesting to contribute to open source product. I am trying to fix bugs in Cordova. Here, I attache my LinkedIn profile : https://www.linkedin.com/in/sanjeewa-kumara-481a1766?trk=hp-identity-name

Re: [Discuss] Why was device.name removed from the device-plugin?

2016-06-17 Thread Shazron
Hi Philipp, This was the rationale: https://lists.apache.org/thread.html/e3b0e5f87ba3929d5578308b25ee9a6af5b91177b94015878970fa8e@1352248856@%3Cdev.cordova.apache.org%3E On iOS, [UIDevice name] returns the name the user sets in iTunes for their device i.e. "Shazron's iPhone 4", and can change

[GitHub] cordova-docs pull request #612: CB-11412 Added docs for template use and cre...

2016-06-17 Thread carynbear
GitHub user carynbear opened a pull request: https://github.com/apache/cordova-docs/pull/612 CB-11412 Added docs for template use and create You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova-docs CB-11412

[GitHub] cordova-plugin-media pull request #102: CB-11430 Report duration's NaN value...

2016-06-17 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-media/pull/102 CB-11430 Report duration's NaN value to JS properly ### Platforms affected iOS ### What does this PR do? Fixes incorrect duration value reported to

[GitHub] cordova-plugin-dialogs issue #71: Secure prompt text fields for passwords

2016-06-17 Thread pke
Github user pke commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/71 @purplecabbage no, of course one would still support the old signature and emit a deprecation warning. Inspecting the arguments should be pretty easy in that case. If the second argument

[GitHub] cordova-plugin-dialogs issue #71: Secure prompt text fields for passwords

2016-06-17 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/71 True. But all existing code would break. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-dialogs issue #71: Secure prompt text fields for passwords

2016-06-17 Thread pke
Github user pke commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/71 Instead of adding yet another argument one could also opt to support an `option` object instead/alternatively. Especially since all those values are optional anyway the API surface

[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...

2016-06-17 Thread cjpearson
Github user cjpearson commented on the issue: https://github.com/apache/cordova-lib/pull/260 @shazron, could you please take a look at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...

2016-06-17 Thread mattrayner
Github user mattrayner commented on the issue: https://github.com/apache/cordova-lib/pull/260 I'm guessing there's no news on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-media issue #101: CB-11409: (iOS) New method allowing to disa...

2016-06-17 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/101 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/101/commits/eca1d6342cdda64d73235b1ae5658bc87619ba54)

[GitHub] cordova-plugin-media pull request #101: CB-11409: (iOS) New method allowing ...

2016-06-17 Thread tbrebant
GitHub user tbrebant opened a pull request: https://github.com/apache/cordova-plugin-media/pull/101 CB-11409: (iOS) New method allowing to disable automated memory release on memoryWarning ### Platforms affected iOS ### What does this PR do? It is adding

[Discuss] Why was device.name removed from the device-plugin?

2016-06-17 Thread Philipp Kursawe
I wonder why such an important piece of information is not provided anymore in the device plugin? What was the reason to remove the property? The name of the device, especially when users can authorise/revoke API access to apps on different devices, is an important variable to know. There is a

[GitHub] cordova-plugin-media issue #100: CB-7684: (iOS) Fix CDVSound killing all aud...

2016-06-17 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/100 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/100/commits/40a561d87fcebb5114fbdc01e6dafd6c617956fc)

[GitHub] cordova-plugin-media pull request #100: CB-7684: (iOS) Fix CDVSound killing ...

2016-06-17 Thread tbrebant
GitHub user tbrebant opened a pull request: https://github.com/apache/cordova-plugin-media/pull/100 CB-7684: (iOS) Fix CDVSound killing all audio when a single file finishes ### Platforms affected iOS ### What does this PR do? We arrived to the same