[GitHub] cordova-plugin-camera issue #197: [CB-5195][CB-4078]: correctOrientation not...

2016-08-28 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/197 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-camera issue #197: [CB-5195][CB-4078]: correctOrientation not...

2016-08-28 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/197 @swbradshaw don't worry about it! We all make mistakes like that. Really appreciate the PR! I'll test and merge it in tomorrow. Thanks! --- If your project is

[GitHub] cordova-plugin-camera issue #197: [CB-5195][CB-4078]: correctOrientation not...

2016-08-28 Thread swbradshaw
Github user swbradshaw commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/197 @stevengill Man, I'm such an amateur. Removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-camera issue #197: [CB-5195][CB-4078]: correctOrientation not...

2016-08-28 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/197 @swbradshaw looks you included a new file named `CameraLauncherMaster.java` in your commit by mistake --- If your project is set up for it, you can reply to this email and have

Nightly build #115 for cordova has succeeded!

2016-08-28 Thread Apache Jenkins Server
Nightly build #115 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/115/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...

2016-08-28 Thread jonathanli2
Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Hi, Thanks for the quick review, and really appreciate your help. I updated the pull request based on your comment, please let me know if any other changes are

[GitHub] cordova-plugin-statusbar pull request #62: CB:-9161 Support iPad multitaskin...

2016-08-28 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/62#discussion_r76540366 --- Diff: src/ios/CDVStatusBar.m --- @@ -440,8 +442,8 @@ -(void)resizeWebView BOOL isIOS7 = (IsAtLeastiOSVersion(@"7.0"));

[GitHub] cordova-plugin-statusbar pull request #62: CB:-9161 Support iPad multitaskin...

2016-08-28 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/62#discussion_r76540339 --- Diff: src/ios/CDVStatusBar.m --- @@ -472,7 +474,7 @@ -(void)resizeWebView self.webView.frame = frame;

[GitHub] cordova-plugin-statusbar pull request #62: CB:-9161 Support iPad multitaskin...

2016-08-28 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/62#discussion_r76540305 --- Diff: src/ios/CDVStatusBar.m --- @@ -200,8 +202,8 @@ - (void) initializeStatusBarBackgroundView - (CGRect)

[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...

2016-08-28 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Hi, Thanks for the PR, but the id you used isn't right. This doesn't add the multitask support, it fixes the resize problems when using multitask. There is another issue

[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...

2016-08-28 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-statusbar pull request #62: CB:-9161 Support iPad multitaskin...

2016-08-28 Thread jonathanli2
GitHub user jonathanli2 opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/62 CB:-9161 Support iPad multitasking in iOS 9. (statusbar plugin side fix) ### Platforms affected ios ### What does this PR do? With the ipad pro

[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-08-28 Thread dotNetkow
Github user dotNetkow commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 hi @shazron - any way your team could consider this? OAuth is a major reason folks use InAppBrowser, and for years now it's been feasible and "supported" in a sense with

[GitHub] cordova-plugin-media issue #113: CB-11757 (ios) Error out if trying to stop ...

2016-08-28 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/113 Cordova CI Build has completed successfully. **Commit** -