[GitHub] cordova-ios issue #274: CB-12118 - Cordova run ios does not automatically de...

2016-11-07 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/274 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/274?src=pr) is 60.00% (diff: 0.00%) > Merging [#274](https://codecov.io/gh/apache/cordova-ios/pull/274?src=pr) into [m

[GitHub] cordova-plugin-camera issue #239: CB-12005: (android) Fix picture orientatio...

2016-11-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/239 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/239/commits/aab611e3d9a4779c8bf69cb9bd0f7231c127fcb

Nightly build #220 for cordova has succeeded!

2016-11-07 Thread Apache Jenkins Server
Nightly build #220 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/220/consoleFull - Jenkins for Apache Cordova -

Re: Incompatible plugin should reject the build

2016-11-07 Thread Simon MacDonald
I think an engine check should fail the build. If there plugin version they are trying to use will not work with the version of cordova or platform they are currently using in their project it should not build. Folks can screw up their semver in config.xml and end up pulling in a plugin version tha

Incompatible plugin should reject the build

2016-11-07 Thread Shazron
See https://issues.apache.org/jira/browse/CB-12122 Right now if a plugin fails an check, it just warns. Should we make engine checks fail the build?

[GitHub] cordova-ios pull request #274: CB-12118 - Cordova run ios does not automatic...

2016-11-07 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/274 CB-12118 - Cordova run ios does not automatically deploy to device ### Platforms affected self ### What does this PR do? When you have a device connected, "cordova run

[GitHub] cordova-plugin-camera issue #235: CB-11625: Fixes Camera issue w.r.t. conten...

2016-11-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/235 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/235/commits/ee192d94b4b47a8e316caed769888ec4d4835dd6

[GitHub] cordova-plugin-camera pull request #199: Update plugin.xml

2016-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/199 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request #201: CB-11034: Camera.getPicture -Handle...

2016-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/201 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request #228: add CAMERA and READ_EXTERNAL_STORAG...

2016-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera issue #228: add CAMERA and READ_EXTERNAL_STORAGE permi...

2016-11-07 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/228 We don't need these permissions. We are using intents to take the photo and get the files, and we only write temporary files to do Exif manipulation. Also, is someone really

[GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...

2016-11-07 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/238 Cool, this thing doesn't conflict, so this will be interesting. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-camera issue #239: CB-12005: (android) Fix picture orientatio...

2016-11-07 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/239 It may be a small change, but after the changes I made to get this working on Android N, you need to fix what's conflicting. --- If your project is set up for it, you can reply to th

[GitHub] cordova-plugin-camera pull request #241: Make the path support Android N.

2016-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/241 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request #235: CB-11625: Fixes Camera issue w.r.t....

2016-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/235 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera issue #241: Make the path support Android N.

2016-11-07 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/241 Cool, it passes the CI, merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-camera issue #241: Make the path support Android N.

2016-11-07 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/241 Also, you're missing the code that adds the provider in the manifest on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cordova-plugin-camera issue #241: Make the path support Android N.

2016-11-07 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/241 We're actually doing the same thing with #235, so we won't be pulling this one in. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cordova-docs pull request #660: Announcement for Cordova Android 6.0 and Cor...

2016-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/660 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-camera issue #200: CB-9852: cordova-plugin-camera file picker...

2016-11-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/200 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/200/commits/b5f0a0536ace48f139326857ee63ec651436c56

[GitHub] cordova-docs issue #660: Announcement for Cordova Android 6.0 and Cordova An...

2016-11-07 Thread kerrishotts
Github user kerrishotts commented on the issue: https://github.com/apache/cordova-docs/pull/660 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-docs pull request #660: Announcement for Cordova Android 6.0 and Cor...

2016-11-07 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/660#discussion_r86852830 --- Diff: www/_posts/2016-11-07-android-release.md --- @@ -0,0 +1,35 @@ +--- +layout: post +author: +name: Joe Bowser +url: ht

[GitHub] cordova-docs pull request #660: Announcement for Cordova Android 6.0 and Cor...

2016-11-07 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-docs/pull/660 Announcement for Cordova Android 6.0 and Cordova Android 6.1 ### Platforms affected ### What does this PR do? ### What testing has been done on this chang

[GitHub] cordova-plugin-media-capture issue #65: CB-10180: (iOS) implement the 'quali...

2016-11-07 Thread rthomasclearwave
Github user rthomasclearwave commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/65 I'm running into the same quality issue. Will this be updated? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: [VOTE] cordova-android@6.1.0 Release

2016-11-07 Thread Joe Bowser
The vote has now closed. The results are: Positive Binding Votes: 3. Joe Bowser Shazron Abdullah Karen Tran The vote has passed. On Mon, Nov 7, 2016 at 11:08 AM, Karen Tran wrote: > I vote +1: > * Created a new app using the android platform and ran on device > * Import to Android Studio and

[GitHub] cordova-plugin-geolocation issue #85: Android: handle location service is of...

2016-11-07 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/85 Hey @khalidaw! Is there an issue for this? issues.cordova.io --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

Re: [VOTE] cordova-android@6.1.0 Release

2016-11-07 Thread Karen Tran
I vote +1: * Created a new app using the android platform and ran on device * Import to Android Studio and ran from Android Studio * Upgraded an old version to the newest platform version On Fri, Nov 4, 2016 at 6:23 PM, Shazron wrote: > I vote +1: > * Ran coho audit-license-headers over the rele

[GitHub] cordova-plugin-file-transfer issue #166: Don't crash on low memory devices

2016-11-07 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/166 Thanks! Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cordova-plugin-file-transfer pull request #166: Don't crash on low memory de...

2016-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/166 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-geolocation issue #85: Android: handle location service is of...

2016-11-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/85 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-geolocation/pull/85/commits/94174c6edbb074cce11e52910d1e6a0

[GitHub] cordova-plugin-battery-status issue #42: CB-8929 Use PowerManager to get bat...

2016-11-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/42 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-battery-status/pull/42/commits/04339fb875e357ae48460c339

[GitHub] cordova-plugin-geolocation issue #85: Android: handle location service is of...

2016-11-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/85 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-geolocation/pull/85/commits/582abd533a0e3a3bf1f70ea34bee221

Re: [DISCUSS] Cordova-Android 6.1 Release

2016-11-07 Thread Joe Bowser
It would be really great if the community would come through on this one and vote on a release. On Mon, Nov 7, 2016 at 7:45 AM, Shazron wrote: > Android 6.1 needs one more vote! > > On Thursday, November 3, 2016, Joe Bowser wrote: > > > Hey > > > > We're getting some hiccups on the 6.1 Android

Re: [DISCUSS] Cordova-Android 6.1 Release

2016-11-07 Thread Shazron
Android 6.1 needs one more vote! On Thursday, November 3, 2016, Joe Bowser wrote: > Hey > > We're getting some hiccups on the 6.1 Android Release with Travis. I'm not > able to reproduce on the local machine, so we think that it's a travis > error with updating packages, so we're going to go ah

[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap

2016-11-07 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/340 That is a known issue with cordova-android@6.0.0, unrelated to this change. It has been fixed in master, and will be included in cordova-android@6.1.0 which is due to be released this

[GitHub] cordova-plugin-splashscreen issue #105: fix bug CB-11422 ios SplashScreen pl...

2016-11-07 Thread jonathanli2
Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/105 Close the pull request as the change in CB-10895 already handled the case by removing the extra if condition check. Please refer to bug CB-11422 for details. Jonatha

[GitHub] cordova-plugin-splashscreen pull request #105: fix bug CB-11422 ios SplashSc...

2016-11-07 Thread jonathanli2
Github user jonathanli2 closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap

2016-11-07 Thread ghenry22
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-android/pull/340 I have the same problem, after upgrading the platform I now get default cordova icons for my android build, even though with the previous version of the platform all icons and splash screen

[GitHub] cordova-plugin-battery-status issue #42: CB-8929 Use PowerManager to get bat...

2016-11-07 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/42 This PR is an alternative to #41, made using feature detection and new PowerManager API available in Windows 10 @daserge. please take a look when you have a cha

[GitHub] cordova-plugin-battery-status pull request #42: CB-8929 Use PowerManager to ...

2016-11-07 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/42 CB-8929 Use PowerManager to get battery state on Win 10 ### Platforms affected Windows (specifically Windows 10) ### What does this PR do? Ad

[GitHub] cordova-plugin-geolocation pull request #85: Android: handle location servic...

2016-11-07 Thread khalidaw
GitHub user khalidaw opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/85 Android: handle location service is off case and return error ### Platforms affected ### What does this PR do? ### What testing has been done

[GitHub] cordova-plugin-file pull request #193: CB-10706: (windows) fix ENCODING_ERR ...

2016-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-file issue #193: CB-10706: (windows) fix ENCODING_ERR for app...

2016-11-07 Thread ajberry
Github user ajberry commented on the issue: https://github.com/apache/cordova-plugin-file/pull/193 I have used this and confirms it fixes the issues with my windows application. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

RE: [CI STATUS REPORT] - 2 actual failures, 2 known failures

2016-11-07 Thread Vladimir Kotikov (Akvelon)
Upd.: cordova-plugin-device-motion failure on Android is outdated because some time ago we've changed Jenkins configuration to run tests against both KitKat and Lollipop and the links to builds have changed. The badge on cordova-status shows the failure that has happened at Aug, 3 - that was the

[GitHub] cordova-plugin-file-transfer issue #167: Fix log warning

2016-11-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/167 Cordova CI Build has one or more failures. Link: http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/42/ 312 tests run, 26 skipped, 50 failed.

[GitHub] cordova-docs pull request #659: CB-11860 Documented codeSignIdentity usage

2016-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/659 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i