Re: CB-12099 (android) SplashScreen Screen Flicker

2016-12-16 Thread Joe Bowser
OK, I read the PR, and I'll admit that I misunderstood part of the problem. I have a few concerns about this change: 1. Why does Android need to have a PR at all? The splashscreen plugin can use edit-config tag to change the manifest to add the theme, which it really should anyway and the XML

Re: CB-12099 (android) SplashScreen Screen Flicker

2016-12-16 Thread Sergey Shakhnazarov
Hello Joe, Could you please elaborate - is there a Jira item corresponding to that duration issue? Thanks, Sergey. 16 Дек 2016 г. 23:38 пользователь "Joe Bowser" написал: I think we should figure out why the duration of the Splashscreen is messed up before we start messing

[GitHub] cordova-lib issue #511: CB-12261: Fix subdirectories deprecated warning alwa...

2016-12-16 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/511 yes, those are known issues in the CI right now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib issue #511: CB-12261: Fix subdirectories deprecated warning alwa...

2016-12-16 Thread yyfearth
Github user yyfearth commented on the issue: https://github.com/apache/cordova-lib/pull/511 I think the CI has issue for the android sdk. Travis-CI got: `Failed to find 'ANDROID_HOME' environment variable. Try setting setting it manually. Failed to find 'android' command

[GitHub] cordova-lib issue #504: CB-11979 added deprecation warning for subdirectorie...

2016-12-16 Thread yyfearth
Github user yyfearth commented on the issue: https://github.com/apache/cordova-lib/pull/504 I have create RP #511 CB-12261 to fix the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request #511: CB-12261: Fix subdirectories deprecated warni...

2016-12-16 Thread yyfearth
GitHub user yyfearth opened a pull request: https://github.com/apache/cordova-lib/pull/511 CB-12261: Fix subdirectories deprecated warning always shows and stop fetch for… ### Platforms affected All ### What does this PR do? Fix the issue created by CB-11979, the

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-16 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92903756 --- Diff: cordova-lib/spec-plugman/install.spec.js --- @@ -345,13 +344,14 @@ describe('install', function() { it('should not check

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-16 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92901285 --- Diff: cordova-lib/spec-plugman/install.spec.js --- @@ -345,13 +344,14 @@ describe('install', function() { it('should not check

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2016-12-16 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r92901030 --- Diff: cordova-lib/spec-plugman/install.spec.js --- @@ -345,13 +344,14 @@ describe('install', function() { it('should not check

[GitHub] cordova-lib pull request #:

2016-12-16 Thread yyfearth
Github user yyfearth commented on the pull request: https://github.com/apache/cordova-lib/commit/328980c2a91dada8049f1e4f27103df67ba07532#commitcomment-20221128 In cordova-lib/src/plugman/fetch.js: In cordova-lib/src/plugman/fetch.js on line 72: it will always trigger since

[GitHub] cordova-plugin-camera issue #244: Android Appium test tweaks

2016-12-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/244 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-lib issue #504: CB-11979 added deprecation warning for subdirectorie...

2016-12-16 Thread yyfearth
Github user yyfearth commented on the issue: https://github.com/apache/cordova-lib/pull/504 This fix has issue now since ``` options.subdir = options.subdir || '.'; ... if (result[2]) options.subdir = result[2]; // not work if it is empty ... if(options.subdir)

[GitHub] cordova-docs pull request #670: CB-12237 - Blog post for Dec 12 Plugins Rele...

2016-12-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/670 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-camera issue #243: Double exif rotation on android with camer...

2016-12-16 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/243 What device does this happen to? We've seen reports of Samsung devices that have had that problem, and if we're already writing the EXIF with the rest of the data, there's no need to

[GitHub] cordova-plugin-camera issue #178: Create Pictures directory if it doesn't ex...

2016-12-16 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/178 FWIW I had this problem when using an Android emulator but forgot to specify the SD card size in its AVD definition. In that situation, the emulator acts like the SD card is mounted in

[GitHub] cordova-plugin-camera pull request #244: Android Appium test tweaks

2016-12-16 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/244 Android Appium test tweaks ### Platforms affected Android ### What does this PR do? - updated comments on how to run the tests. - extra

Re: [VOTE] Plugins Release (Dec 12th 2016)

2016-12-16 Thread Shazron
The vote has now closed. The results are: Positive Binding Votes: 3 Shazron Abdullah Alex Sorokin Filip Maj The vote has passed. On Thu, Dec 15, 2016 at 4:52 PM, Filip Maj wrote: I vote +1: - successfully created android and ios projects with the plugins - ran

[GitHub] cordova-plugin-inappbrowser pull request #202: Stevemeetswest patch nolocati...

2016-12-16 Thread stevemeetswest
Github user stevemeetswest closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/202 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-inappbrowser pull request #202: Stevemeetswest patch nolocati...

2016-12-16 Thread stevemeetswest
GitHub user stevemeetswest opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/202 Stevemeetswest patch nolocation ### Platforms affected ### What does this PR do? ### What testing has been done on this change?

Re: CB-12099 (android) SplashScreen Screen Flicker

2016-12-16 Thread Joe Bowser
I think we should figure out why the duration of the Splashscreen is messed up before we start messing with the background colour of the application, especially since the last time we did that, we broke Hello World! On Fri, Dec 16, 2016 at 11:32 AM, Sergey Shakhnazarov wrote:

CB-12099 (android) SplashScreen Screen Flicker

2016-12-16 Thread Sergey Shakhnazarov
Hi guys! There’s an issue with Android splashscreen that every app has a black flash on start [1]. I propose to fix this using the android:windowBackground composed as splash image (which we use in splashscreen plugin) laid on top of SplashScreenBackgroundColor [2] (this preference is

[GitHub] cordova-plugin-contacts pull request #144: [Appium] Add support for iOS' XCU...

2016-12-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-camera pull request #243: Double exif rotation on android wit...

2016-12-16 Thread Webpal
GitHub user Webpal opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/243 Double exif rotation on android with camera ### Platforms affected ### What does this PR do? ### What testing has been done on this change?

[GitHub] cordova-docs pull request #668: CB-12239 (windows) Add documentation about b...

2016-12-16 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-docs/pull/668 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-docs issue #668: CB-12239 (windows) Add documentation about build fl...

2016-12-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-docs/pull/668 This has been merged in https://github.com/apache/cordova-docs/commit/bedbcc1f42a57fd1bd5f71c4dba9010faf1aae07 --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...

2016-12-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/217 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows issue #217: CB-12239 Add buildFlag option similar to iOS

2016-12-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/217 Cool! Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-windows issue #217: CB-12239 Add buildFlag option similar to iOS

2016-12-16 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/217 Sure 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-windows issue #217: CB-12239 Add buildFlag option similar to iOS

2016-12-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/217 @daserge, is this good to go? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this