Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/265#discussion_r95522000
--- Diff: spec/cli.spec.js ---
@@ -55,76 +55,76 @@ describe("cordova cli", function () {
});
describe("options", function
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/265#discussion_r95521991
--- Diff: package.json ---
@@ -11,8 +11,8 @@
"cordova": "./bin/cordova"
},
"scripts": {
-"test": "node node_module
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/171
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/171/commits/6380108d65dfaf695239f393d
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/171
Let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Hey Everyone!
Our lovely intern Audrey has been working on upgrading our repos to use
jasmine (>2) instead of jasmine-node (<2).
Other than some minor changes, I think it is ready to merge in for the
6.5.0 release.
Please provide any feedback!
Lib: https://github.com/apache/cordova-lib/pull/510
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500848
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
expect(default
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95501588
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -206,134 +178,136 @@ describe('install', function() {
beforeEach(function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95502237
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -192,34 +203,39 @@ beforeEach(function () {
projectsAdde
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500857
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
expect(default
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500726
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -145,30 +146,36 @@ describe('plugin end-to-end', function() {
expect(errorHandler
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95501387
--- Diff: cordova-lib/spec-plugman/create.spec.js ---
@@ -35,46 +35,42 @@ describe( 'create plugin', function() {
existsSync,
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500893
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -309,10 +341,13 @@ describe('plugin end-to-end', function() {
.then(function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500826
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
expect(default
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500649
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -83,6 +83,7 @@ function removePlugin(id) {
var errorHandler = {
errorCallback: f
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500805
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
expect(default
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95497591
--- Diff: cordova-common/spec/ActionStack.spec.js ---
@@ -59,19 +59,19 @@ describe('action-stack', function() {
stack.push(stack.creat
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95502073
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -192,34 +203,39 @@ beforeEach(function () {
projectsAdde
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500793
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
expect(default
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500754
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -199,11 +209,14 @@ describe('plugin end-to-end', function() {
.then(function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500766
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
expect(default
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95499196
--- Diff: cordova-common/spec/CordovaCheck.spec.js ---
@@ -30,71 +30,62 @@ describe('findProjectRoot method', function() {
process.env.PWD
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500742
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -178,11 +185,14 @@ describe('plugin end-to-end', function() {
.then(function () {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95501615
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -206,134 +178,136 @@ describe('install', function() {
beforeEach(function() {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500695
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -145,30 +146,36 @@ describe('plugin end-to-end', function() {
expect(errorHandler
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95502042
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -121,7 +131,8 @@ beforeEach(function () {
});
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500869
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
expect(default
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/265#discussion_r95493028
--- Diff: spec/cli.spec.js ---
@@ -55,76 +55,76 @@ describe("cordova cli", function () {
});
describe("options", function () {
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/265#discussion_r95493138
--- Diff: spec/cli.spec.js ---
@@ -134,11 +134,11 @@ describe("cordova cli", function () {
describe("create", function () {
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/22
Ugh, now it fails, but the failure is not apparent in the logs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/22
Yay, that worked! Squashing and integrating.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/350
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user bgaillard commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/143
Hi, I think this Pull Request is very important, for now we cannot propose
to the user of our applications to pick a picture.
Is the Cordova team planning to merge this PR s
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/171
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/171/commits/82fe494ffbf41fca442ba09847
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/171
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/171/commits/9093e68de8f27b70af8418b351
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-globalization/pull/54
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-globalization/pull/54/commits/24a7eb4faa363a82d5f73c8441d
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/171
CB-12336 (android) Do not call win callback if aborted
### Platforms affected
Android
### What does this PR do?
Fixes a rare condition on Android when win cal
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-globalization/pull/54
CB-11154 (Windows) Return IANA timezone as an empty string instead ofâ¦
⦠undefined
### Platforms affected
Windows
### What does this PR do?
Adds a
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/248
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-camera/pull/248/commits/79f15feeb4c2156dcd939db9b7f59058db733aa
GitHub user mhanke opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/248
Fix number for sdk comparison.
Older sdk versions can't be built, because they don't know the constant.
### Platforms affected
Android
### What does this
39 matches
Mail list logo
