[GitHub] cordova-lib issue #517: CB- 12017: update npm dependencies

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/517 merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib issue #487: CB-11777: Restore plugins before preparing

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/487 I'm thinking we move forward with this as I'm feeling hesitant removing restore from prepare. --- If your project is set up for it, you can reply to this email and have your reply appear

Re: [DISCUSS] App display/short name support

Merged On Thu, Mar 9, 2017 at 1:24 PM, Shazron wrote: > +1 > has been baking for a long time > > On Thu, Mar 9, 2017 at 1:06 PM, Jesse wrote: > > > Yes, I would like to see this merged in the upcoming cordova@7 > > > > > > @purplecabbage > >

[GitHub] cordova-lib pull request #453: Support a display name via config.xml

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/453 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #260: CB-9371: Fix prepare deleting orientation pre...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/260 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #315: CB-9747 Fix Android Parser

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/315 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #390: CB-10621 fix for amazon-fireos

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/390 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #358: Add cli_variables to plugman before_plugin_in...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/358 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #261: Cb-8789

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #51: CB-7067 run jasmine tests individually

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/522#discussion_r107831849 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -255,13 +235,7 @@ function checkID(expectedIdAndVersion, pinfo) { if

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/522#discussion_r107829266 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -255,13 +235,7 @@ function checkID(expectedIdAndVersion, pinfo) { if

Nightly build #291 for cordova has succeeded!

Nightly build #291 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/291/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-docs issue #443: Update index.md

Github user dblotsky commented on the issue: https://github.com/apache/cordova-docs/pull/443 @purplecabbage that indeed was what I said in Russian. :) Thanks for cleaning up the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-docs issue #688: Remove misleading reference to "publisherId" cause ...

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-docs/pull/688 This pr was a replacement for #402 which I closed prematurely. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-docs pull request #688: Remove misleading reference to "publisherId"...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/688 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request #688: Remove misleading reference to "publisherId"...

GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-docs/pull/688 Remove misleading reference to "publisherId" cause it is ignored The only way to override the `Publisher` value in the generated `AppxManifest.xml` is to provide a custom signing

Re: [DISCUSS] Update iOS Embedded WebView docs for Carthage

Yes for plugins we have to use plugman. Why Carthage and not CocoaPods? Firstly I like that Carthage is not opinionated like CocoaPods -- you have to have a Podfile, podspec, etc, and it creates a workspace that you *have* to use. I was working on the goal for users to "easily add Cordova to an

[GitHub] cordova-docs issue #402: Remove misleading reference to "publisherId" cause ...

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-docs/pull/402 No, I closed it. Sorry, I didn't think it was still valid. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [DISCUSS] Update iOS Embedded WebView docs for Carthage

No objection, but why Carthage and not CocoaPods? For the plugins we have to use plugman, right? 2017-03-23 22:07 GMT+01:00 Shazron : > I'm going to leave this open for the rest of this week, and if no concerns > I will take that as lazy consensus and file an issue for

[GitHub] cordova-docs issue #402: Remove misleading reference to "publisherId" cause ...

Github user pke commented on the issue: https://github.com/apache/cordova-docs/pull/402 Whats going on here? Is @asfgit a failing bot? My PR is still valid --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs issue #402: Remove misleading reference to "publisherId" cause ...

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-docs/pull/402 One commit, a merge and a close ... unrelated. Much like 25485819612937251bb521a9b68f73cae54065c3 --- If your project is set up for it, you can reply to this email and have your

Re: [DISCUSS] Update iOS Embedded WebView docs for Carthage

I'm going to leave this open for the rest of this week, and if no concerns I will take that as lazy consensus and file an issue for changing this. On Tue, Mar 21, 2017 at 2:41 PM, Shazron wrote: > ## DESCRIPTION > > Carthage is supported for embedding Cordova into existing

Re: [DISCUSS] Plugin search is broken

I'm going to assume by lazy consensus that moving off npmsearch is a 'go'. Filed: https://issues.apache.org/jira/browse/CB-12602 Currently our plugin search works after I filed those two issues in their repo and they were was fixed, thus fixing our search. On Sun, Mar 19, 2017 at 4:36 PM,

[GitHub] cordova-docs issue #402: Remove misleading reference to "publisherId" cause ...

Github user pke commented on the issue: https://github.com/apache/cordova-docs/pull/402 This PR has nothing to do with Windows but mentions Android --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-docs pull request #314: Document lib-file for Android

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/314 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request #402: Remove misleading reference to "publisherId"...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/402 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-android issue #370: CB-12595: Fix Android Studio Detection (may need...

Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/370 Got it, sounds good then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-android issue #370: CB-12595: Fix Android Studio Detection (may need...

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/370 @filmaj I don't think it matters since we're overwriting whatever gradle-wrapper specifies with our own version of Gradle location anyway because we can't guarantee the version of Gradle

Re: [NIGHTLY BUILDS] Missing

yay! @purplecabbage risingj.com On Wed, Mar 22, 2017 at 11:18 PM, Filip Maj wrote: > yay! that seemed to have fixed it! > > On Tue, Mar 21, 2017 at 10:51 PM, Filip Maj wrote: > > Just added apachebuilds as owner to both cordova-android and cordova-ios. >

[GitHub] cordova-android issue #370: CB-12595: Fix Android Studio Detection (may need...

Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/370 Thanks for cleaning up the logging. However, this point still stands: > So, it doesn't pick the preview version, just the regular Android Studio version - unlike on Mac.

[GitHub] cordova-docs pull request #212: Instructions about signing and releasing a p...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request #634: Update storage.md

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/634 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request #611: Lowercase Windows consistently through the d...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/611 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request #443: Update index.md

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/443 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request #649: If you want to record sound on ios10 permiss...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/649 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request #259: CB-7949 Added docs for cordova-local utility

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/259 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request #687: Documented that some files are auto-gen from...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/687 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request #669: Update spec.md

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/669 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request #676: Update images.md

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/676 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request #640: Make more comprehensible the french document...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/640 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request #636: Update the plugman test for android

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/636 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request #664: Update images.md

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/664 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs issue #212: Instructions about signing and releasing a phonegap...

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-docs/pull/212 closing this now very old pr. Thanks for contributing, if this is still valid and needed, please rebase and resend. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-docs issue #259: CB-7949 Added docs for cordova-local utility

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-docs/pull/259 closing, ... please resend/rebase if this is still valid. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-cli issue #267: CB: 11982 -Created new cordova config command

Github user audreyso commented on the issue: https://github.com/apache/cordova-cli/pull/267 @filmaj Thanks for your help! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs issue #402: Remove misleading reference to "publisherId" cause ...

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-docs/pull/402 Is this still an issue? Did you find a suitable solution @pke ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-docs issue #443: Update index.md

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-docs/pull/443 Pretty sure this has already been said in Russian ... Thanks for your contribution. The file you made the change in is actually a generated file that comes via a crowdin translation,

[GitHub] cordova-docs issue #611: Lowercase Windows consistently through the docs

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-docs/pull/611 look good, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-docs issue #634: Update storage.md

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-docs/pull/634 Also, the file you modified is build generated from crowdin. Plugin documentation lives with the plugins. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-docs issue #669: Update spec.md

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-docs/pull/669 Thanks for your contribution @p-w The file you made the change in is actually a generated file that comes via a crowdin translation, please have a look at README.md for details.

[GitHub] cordova-docs issue #664: Update images.md

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-docs/pull/664 closing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-cli issue #272: CB-12591 - added new config command to CLI reference...

Github user filmaj commented on the issue: https://github.com/apache/cordova-cli/pull/272 Thanks for pointing me in the right direction @audreyso ! Left some comments there, and if any changes arise from that PR, I would recommend reflecting the wording changes from that PR in this

[GitHub] cordova-cli pull request #267: CB: 11982 -Created new cordova config command

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/267#discussion_r107737934 --- Diff: doc/config.txt --- @@ -0,0 +1,22 @@ +Synopsis + +cordova-cli config [options] + + +The config command can be

[GitHub] cordova-cli pull request #267: CB: 11982 -Created new cordova config command

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/267#discussion_r107738404 --- Diff: doc/cordova.txt --- @@ -6,6 +6,8 @@ Global Commands create . Create a project help

[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView

Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/337 The Android System WebView (in Android 5.0+ anyhow) also fires `visibilitychange` when the app is focused/backgrounded, which might be an alternative (and is, arguably, the spec-compliant

[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/337 https://issues.apache.org/jira/browse/CB-12601 is the bug for this new issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/337 It's obviously a bug, and we should probably make sure the pause event fires before we pause the timers somehow, since it's clear there's a threading issue. That said, broken apps in the

[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView

Github user vinzscam commented on the issue: https://github.com/apache/cordova-android/pull/337 It makes sense :) I just want to point out that it is not just a broken API: it could affects the functionality of existing apps (in my case I was using it to connect/disconnect a

[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/337 Sorry, but this is more important than the pause event, this stays. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView

Github user vinzscam commented on the issue: https://github.com/apache/cordova-android/pull/337 The #337 has broken the firing of `pause` event. Now the `pause` event fires when the native platform pulls the application out from the background (just before firing the

[GitHub] cordova-cli issue #272: CB-12591 - added new config command to CLI reference...

Github user audreyso commented on the issue: https://github.com/apache/cordova-cli/pull/272 @filmaj Hmm this is the PR for the config command. https://github.com/apache/cordova-cli/pull/267 Not sure where else to put this information. --- If your project is set up for it, you can

[GitHub] cordova-cli issue #272: CB-12591 - added new config command to CLI reference...

Github user filmaj commented on the issue: https://github.com/apache/cordova-cli/pull/272 I'm confused about this command. Perhaps this is not the right place to discuss, and feel free to link me to relevant discussion or documentation about the command, but this command just sets

[GitHub] cordova-android issue #370: CB-12595: Fix Android Studio Detection (may need...

Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/370 Results of my testing with this. # Mac Side-by-side installations of Android Studio + Android Studio Preview: ``` ➔ l /Applications/Android*

[GitHub] cordova-cli pull request #272: CB-12591 - added new config command to CLI re...

GitHub user audreyso opened a pull request: https://github.com/apache/cordova-cli/pull/272 CB-12591 - added new config command to CLI reference page ### Platforms affected ### What does this PR do? Added new config command to CLI reference page

[GitHub] cordova-docs pull request #678: CB-12391 - doc - (android) Added nougat supp...

Github user victorsosa closed the pull request at: https://github.com/apache/cordova-docs/pull/678 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

Github user MeirBon commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/201 @Gorebar #ivanrb I had the same issue this week and merged both changes into a new branch 'download-permissions':

Re: [NIGHTLY BUILDS] Missing

yay! that seemed to have fixed it! On Tue, Mar 21, 2017 at 10:51 PM, Filip Maj wrote: > Just added apachebuilds as owner to both cordova-android and cordova-ios. > > On Tue, Mar 21, 2017 at 8:10 PM, Darryl Pogue wrote: >> Hey Vladimir, >> >> I noticed we