Github user feichngr commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/549#discussion_r113615881
--- Diff: cordova-lib/src/hooks/HooksRunner.js ---
@@ -178,7 +178,9 @@ function runScriptViaModuleLoader(script, context) {
}
var scri
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/696
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/698
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/695
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
The vote has now closed. The results are:
Positive Binding Votes: 3
Steven Gill
Jesse MacFadyen
Shazron Abdullah
The vote has passed.
On Tue, Apr 25, 2017 at 10:44 AM, Jesse wrote:
> I vote +1:
> * Ran coho verify-archive
> * Ran unit tests repo
> * unpacked, npm i, and npm tested
> * built a
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/549#discussion_r113586243
--- Diff: cordova-lib/src/hooks/HooksRunner.js ---
@@ -178,7 +178,9 @@ function runScriptViaModuleLoader(script, context) {
}
var sc
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/87#discussion_r113578907
--- Diff: src/ios/CDVLocation.m ---
@@ -94,61 +94,62 @@ - (BOOL)isLocationServicesEnabled
- (void)startLocation:(BOOL)enab
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/87
Okay, with that sample code of using the watch, I am able to reproduce one
warning of this on an iPhone 5S running iOS 10.2:
```
2017-04-26 17:14:37.015628 HelloCordova[
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/545
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user avishekcode commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/87
@shazron @filmaj
Hi!
I literally, just downloaded the current plugin, and without my
modification, I get these warnings constantly via Xcode, while testing on
iPh
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/87
Hmm not sure then :/
Regarding my line comments on this PR, I realize that we have another
instance not following the rules in the existing code ð±
https://github.com/
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/254
Sorry, Swift newbie here :) (waiting for it to be stable real soon now!).
This will be slated for cordova-ios@4.4.1, I'll see how to add Swift tests in
the current test project...
---
If your
Github user imhotep commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113567338
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https:/
Github user lucatorella commented on the issue:
https://github.com/apache/cordova-ios/pull/254
Sorry, I'm mistaken. The plain C enum is currently already available in
Swift. So yes, it'll be a breaking change in Swift as much as your proposal :)
---
If your project is set up for it,
Github user kerrishotts commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113565956
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: htt
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/87
@shazron I've been trying to reproduce these warnings on a pretty old iOS
device: iPhone 5S, running iOS 10.2. Haven't been able to repro anything that
looks weird in the device con
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113565342
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https:
Github user lucatorella commented on the issue:
https://github.com/apache/cordova-ios/pull/254
No, because now that enum is not accessible in Swift. So if we want to make
it accessible, it's better to make it accessible with proper name conventions
(`.noResult`, `.ok`, ...). If you ju
Github user dpogue commented on the issue:
https://github.com/apache/cordova-ios/pull/254
Yes, the breaking change is only on the Swift side
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/254
@dpogue Can you confirm what @lucatorella said?
In any case, we don't have any Swift tests yet, but that's easy to remedy
for next release.
---
If your project is set up for it, you c
GitHub user dpogue reopened a pull request:
https://github.com/apache/cordova-ios/pull/228
[CB-10916] Support display name for iOS
This is the iOS Platform API support side of
https://github.com/apache/cordova-lib/pull/453.
You can merge this pull request into a Git repository by
Github user dpogue closed the pull request at:
https://github.com/apache/cordova-ios/pull/228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/228
@dpogue looks like a Simulator timeout. Can you close and re-open the PR to
trigger the CI again
@fredgalvao ditto what @dpogue said
---
If your project is set up for it, you can reply to t
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/87
@avishekcode what device are you testing it on? @filmaj I believe if he is
using an older phone, it might affect timings
---
If your project is set up for it, you can reply to thi
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/87#discussion_r113561945
--- Diff: src/ios/CDVLocation.m ---
@@ -94,61 +94,62 @@ - (BOOL)isLocationServicesEnabled
- (void)startLocation:(BOOL)enableHig
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113560349
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: h
Github user imhotep commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113558490
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https:/
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113557148
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: http
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113556060
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https:
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113555718
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: http
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113554201
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https:
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/87
Hey @avishekcode, I'm trying to reproduce these warnings you mentioned:
> This stops iOS from giving warnings that the Plugin should be executing
in background mode, and als
I'm going to put a deadline of June 1st, 2017 to wrap up discussion of the
Roadmap, we need it to be finalized by then if not it will just be left in
the wind like previous proposals.
This gives us a month, more than enough I think, to nail this down -- also
since most of the Adobe team will be aw
We did some work this week and got a bunch of community PRs merged in
to many plugin repos.
Anyone have any reasons to not do a release? Anything outstanding
anyone wants to get merged in before moving ahead with a plugins
release? Any other comments on the topic?
Cheers,
Fil Maj
---
Github user kerrishotts commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113545976
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: htt
Github user kerrishotts commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113545528
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: htt
Github user kerrishotts commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113545395
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: htt
Github user Lemon-King commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/174
I believe I signed the ICLA on the main apache org jira site.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user kerrishotts commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113544594
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: htt
Github user kerrishotts commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113544467
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: htt
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113543204
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: h
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113540282
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https://
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113539917
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https://
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113539850
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https://
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
Per [CB-12542](https://issues.apache.org/jira/browse/CB-12542), I will
merge in the wav/m4a support, and we will look at the separate `getDuration`
issue @leopatras described in the JIRA
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-docs/pull/699
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113523749
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: h
Github user shazron commented on the issue:
https://github.com/apache/cordova-docs/pull/698
Depends upon: #695 and #696
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user shazron commented on the issue:
https://github.com/apache/cordova-docs/pull/695
Dependents: #698
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user shazron commented on the issue:
https://github.com/apache/cordova-docs/pull/696
Dependents: #698
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/690
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113513631
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https:/
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113512443
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https:/
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113513050
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https:/
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113513420
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https:/
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/696#discussion_r113506314
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -476,7 +476,7 @@ This tag installs resource files into your platform,
and is similar to the same
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-docs/pull/699
cordova7_post : cordova7 release post
Not ready to merge yet, but would like some advice/feedback early on!
### Platforms affected
### What does this PR do?
Blo
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
Here are the relevant bits of test code I am working with:
```
initialize: function() {
document.addEventListener('deviceready',
this.onDeviceReady.bind(this)
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
Actually, I spoke too soon. I think I will pull in everything but the last
commit - that seems like a new command being added.
I will retest with all commits but that last one th
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
OK, verified this works with both .wav and .m4a on an iPhone 5S running iOS
10.2. Hooray!
I will be rebasing and pulling this in shortly, and then will close this PR
separately.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
@leopatras while I verify this PR, do you have an [Apache
ICLA](https://www.apache.org/licenses/icla.pdf) signed and sent to
secret...@apache.org?
---
If your project is set up for it,
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/87
Just received the ICLA. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/134
I am taking a look at this today. Will rebase and run some tests locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/137
Hmm, looks like all three CI runs against Android (4.4, 5.1, and 6.0)
failed. Output for these three test runs:
- Android 4.4:
http://cordova-ci.cloudapp.net:8080/job/cordova-pl
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/215
Yeah, I think that's fine (for not writing an automated test) in this case.
It is a very difficult scenario to reproduce - as you mentioned, it may take 5
minutes. But, if we coul
Github user SrajanPathak commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/245
this issue is reproduced on Samsung S5, app crashes when we take the
picture from the camera
below is the screenshot of memory usage at the time of crash
 add setType() method to support input[type=file] on
4.4.2
### Platforms affected
android
### What does this PR do?
Add setType(
Github user dpogue commented on the issue:
https://github.com/apache/cordova-ios/pull/228
@fredgalvao Personally, I think your idea is the right way to go in terms
of project structure, and should definitely be brought up for discussion on the
dev list (because it probably has implica
Github user fredgalvao commented on the issue:
https://github.com/apache/cordova-ios/pull/228
Should my previous comment go into an issue dedicated to discussion? There
was no feedback on it, and it seems like there is a consensus into doing the
simple version, which imo doesn't actua
Github user fredgalvao commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/696#discussion_r113379709
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -476,7 +476,7 @@ This tag installs resource files into your platform,
and is similar to the sam
73 matches
Mail list logo
