Nightly build #323 for cordova has succeeded!

2017-04-27 Thread Apache Jenkins Server
Nightly build #323 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/323/consoleFull - Jenkins for Apache Cordova -

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

2017-04-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/699#discussion_r113840815 --- Diff: www/_posts/2017-04-21-cordova-7.md --- @@ -12,35 +12,37 @@ We are happy to announce that `Apache Cordova 7.0.0` has been released!

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

2017-04-27 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/699#discussion_r113837071 --- Diff: www/_posts/2017-04-21-cordova-7.md --- @@ -12,35 +12,37 @@ We are happy to announce that `Apache Cordova 7.0.0` has been released!

[GitHub] cordova-lib pull request #550: CB-11242

2017-04-27 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/550 CB-11242 Not ready for review yet. :) ### Platforms affected ### What does this PR do? The platform-specific code for platforms w/ PlatformApi implemented s

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @Lazza Which Samsung Devices would have this problem? Would a Samsung Galaxy S3 to S8 have this? --- If your project is set up for it, you can reply to this email and have your

Nightly build #322 for cordova has failed

2017-04-27 Thread Apache Jenkins Server
Nightly build #322 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/322/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/322/consoleFull - Jenkins for Apache Cordova

Re: [DISCUSS] Plugins Release

2017-04-27 Thread Filip Maj
Alright, the plugins release issue is here: https://issues.apache.org/jira/browse/CB-12736 For the plugins that warranted releases, I've got the RCs for them up on dist-dev: https://dist.apache.org/repos/dist/dev/cordova/CB-12736/ I probably won't have time to go through all of these and do the n

Re: Nightly build #321 for cordova has failed

2017-04-27 Thread Darryl Pogue
One of the indirect dependencies of cordova-coho (figures, via inquirer) is using ES6 `const` and the ancient version of node (v0.10.25) that Jenkins is running considers that to be a syntax error. Since we've dropped support for node 0.x from the user-facing tools, it probably makes sense to upgr

Re: [DISCUSS] Plugins Release

2017-04-27 Thread Steven Gill
do it! On Wed, Apr 26, 2017 at 12:51 PM, Filip Maj wrote: > We did some work this week and got a bunch of community PRs merged in > to many plugin repos. > > Anyone have any reasons to not do a release? Anything outstanding > anyone wants to get merged in before moving ahead with a plugins > rel

Nightly build #321 for cordova has failed

2017-04-27 Thread Apache Jenkins Server
Nightly build #321 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/321/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/321/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 Hmm, I cannot seem to reproduce the error with the latest master of cordova-android + cordova-plugin-splashscreen. I'm using a ~200kb .png file as a splash screen. Here's

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 I think I have a Samsung S5 that I can play with. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread Lazza
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 Yeah, but unfortunately... I am not even sure how I got that one to crash! 😅 Most of my tests in the emulators where either working or simply not showing the splash (but not cr

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 O nice, there is an emulator in there. OK, I will try to reproduce. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread Lazza
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @filmaj I see. 😄 Just to be clear, my PR is released under the Apache Version 2.0 license as anything else in this repo (it is also the license mentioned in the project and the

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 One more question: how would one go about reproducing the crash that this patch fixes? What device did you see the crash on? --- If your project is set up for it, you can reply t

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @Lazza nevermind, it is not completely required. Issuing a PR is enough to establish "intent to contribute" which is all Apache legal requires. --- If your project is set up for

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread Lazza
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @filmaj I don't think I have. Why? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi