Nightly build #441 for cordova has succeeded!

2017-07-28 Thread Apache Jenkins Server
Nightly build #441 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/441/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-lib pull request #579: CB-12361 : added tests for save.js

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/579 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [CORE PLUGINS][DISCUSS] Roadmap 2017

2017-07-28 Thread Filip Maj
Small update on this topic: - still need to clarify next steps on some of the INTEGRATE plugins - I think the Dialogs plugin's KEEP + UPDATE decision needs a bit of clarification as well - I am trying to work with the W3C's web platform tests [1] to validate latest spec adherance on the

[GitHub] cordova-windows issue #235: CB-11968: Add support for config-file in config....

2017-07-28 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-windows/pull/235 I'm not familiar with this changeset enough, but I think this probably needs unit tests :) Once more, ping @stevengill. --- If your project is set up for it, you can reply to this

[GitHub] cordova-lib pull request #580: CB-12895 : Replaced jshint with eslint

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/580 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #565: CB-12944: Platform's spec is ignored in config.xml i...

2017-07-28 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-lib/pull/565 OK, with the testing all cleaned up in lib now, we can come back to this PR. @matrosov-nikita let's add a unit test for this please. Ping @stevengill / @audreyso for review /

[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE

2017-07-28 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/399 @filmaj Another being this article https://medium.com/exploring-android/handling-android-runtime-permissions-in-ui-tests-981f9dc11a4e --- If your project is set up for it, you can reply

[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE

2017-07-28 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/399 One example: [this repo](https://github.com/Egorand/android-testing-runtime-permissions)'s [main test

[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE

2017-07-28 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/399 We should add some instrumentation native tests for this, but I have no idea how that would work, and would have to do more research into this. --- If your project is set up for it, you

[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE

2017-07-28 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/399 Well glad that cleared up the CI failures. Should we add unit, or instrumentation, native tests for this? Also ping @infil00p for review. --- If your project is set up for

[GitHub] cordova-lib pull request #578: CB-12361 : added unit-tests for getPlatformDe...

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/578 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE

2017-07-28 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/399 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/399?src=pr=h1) Report > Merging [#399](https://codecov.io/gh/apache/cordova-android/pull/399?src=pr=desc) into

[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE

2017-07-28 Thread macdonst
Github user macdonst commented on the issue: https://github.com/apache/cordova-android/pull/399 @filmaj rebased and pushed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-statusbar pull request #84: CB-13028 (CI) Browser builds on T...

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-android pull request #362: CB-12453: Remove unnecessary double quote...

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/362 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-statusbar pull request #84: CB-13028 (CI) Browser builds on T...

2017-07-28 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/84 CB-13028 (CI) Browser builds on Travis and AppVeyor ### Platforms affected Browser ### What does this PR do? Enables AppVeyor and Travis to run tests on browser

[GitHub] cordova-plugin-splashscreen pull request #131: CB-13028 (CI) Browser builds ...

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-screen-orientation pull request #22: CB-13028 (CI) Browser bu...

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-screen-orientation/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-splashscreen pull request #131: CB-13028 (CI) Browser builds ...

2017-07-28 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/131 CB-13028 (CI) Browser builds on Travis and AppVeyor ### Platforms affected Browser ### What does this PR do? Enables AppVeyor and Travis to run tests on

[GitHub] cordova-android pull request #397: CB-13031: Fix bug with case-sensitivity o...

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/397 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-screen-orientation pull request #22: CB-13028 (CI) Browser bu...

2017-07-28 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-screen-orientation/pull/22 CB-13028 (CI) Browser builds on Travis and AppVeyor ### Platforms affected Browser ### What does this PR do? Enables AppVeyor and Travis to run tests on

[GitHub] cordova-plugin-network-information pull request #57: CB-13028 (CI) Browser b...

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

2017-07-28 Thread SharUpOff
Github user SharUpOff commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 @filmaj, thank you for the prompt response! (: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-media-capture pull request #81: CB-13028 (CI) Browser builds ...

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/81 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-network-information pull request #57: CB-13028 (CI) Browser b...

2017-07-28 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/57 CB-13028 (CI) Browser builds on Travis and AppVeyor ### Platforms affected Browser ### What does this PR do? Enables AppVeyor and Travis to run tests on

[GitHub] cordova-plugin-media-capture pull request #81: CB-13028 (CI) Browser builds ...

2017-07-28 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/81 CB-13028 (CI) Browser builds on Travis and AppVeyor ### Platforms affected Browser ### What does this PR do? Enables AppVeyor and Travis to run tests on

[GitHub] cordova-android issue #397: CB-13031: Fix bug with case-sensitivity of andro...

2017-07-28 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/397 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/397?src=pr=h1) Report > Merging [#397](https://codecov.io/gh/apache/cordova-android/pull/397?src=pr=desc) into

[GitHub] cordova-plugin-media pull request #146: CB-13028 (CI) Browser builds on Trav...

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media pull request #146: CB-13028 (CI) Browser builds on Trav...

2017-07-28 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-media/pull/146 CB-13028 (CI) Browser builds on Travis and AppVeyor ### Platforms affected Browser ### What does this PR do? Enables AppVeyor and Travis to run tests on browser

[GitHub] cordova-plugin-inappbrowser pull request #231: CB-13028 (CI) Browser builds ...

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser issue #231: CB-13028 (CI) Browser builds on Trav...

2017-07-28 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/231 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and