Re: [DISCUSS] cordova-android 9.1.0 Minor Release

2021-03-30 Thread Jesse
+1 to moving ahead with 9.1.0, I think this is correctly identified as a minor. On Tue, Mar 30, 2021 at 2:51 PM wrote: > It would be great if we could include > https://github.com/apache/cordova-android/pull/1101 in this release. > > It is just a pure refactoring/non-functional change PR but

Re: [DISCUSS] cordova-android 9.1.0 Minor Release

2021-03-30 Thread raphinesse
It would be great if we could include https://github.com/apache/cordova-android/pull/1101 in this release. It is just a pure refactoring/non-functional change PR but it sure would be great to merge and release it before it gets stale. I would have no concerns merging it as is, even without

Re: [DISCUSS] cordova-android 9.1.0 Minor Release

2021-03-30 Thread julio cesar sanchez
Yeah, but 9.0.0 was a major release, and the PR that updated gradle had "major" on the title. So it was safer to bump versions. El mar, 30 mar 2021 a las 19:49, Chris Brody () escribió: > FYI the build seemed to be red due to a timeout; I just restarted the > build; hope it will be green. > > >

Re: [DISCUSS] cordova-android 9.1.0 Minor Release

2021-03-30 Thread Chris Brody
FYI the build seemed to be red due to a timeout; I just restarted the build; hope it will be green. On Tue, Mar 30, 2021 at 1:46 PM Norman Breau wrote: > 9.0 used the latest available release at the time of the release with no > issue. Gradle 6.5 is just the minimum required version according

Re: [DISCUSS] cordova-android 9.1.0 Minor Release

2021-03-30 Thread Norman Breau
9.0 used the latest available release at the time of the release with no issue. Gradle 6.5 is just the minimum required version according to the docs, they explicitly say 6.5+ is supported: https://developer.android.com/studio/releases/gradle-plugin Because we were already on >= 6.5, I think

Re: [DISCUSS] cordova-android 9.1.0 Minor Release

2021-03-30 Thread julio cesar sanchez
I'm a little concerned about https://github.com/apache/cordova-android/pull/1174 and the previous one that also bumped the gradle version to 6.6.1. If you open the project on latest Android Studio, Android Studio recommends using Gradle 6.5, so not sure how safe it is to use the latest bleeding

[DISCUSS] cordova-android 9.1.0 Minor Release

2021-03-30 Thread Bryan Ellis
Does anyone have any reason to delay a cordova-android minor release (9.1.0)? Any additional outstanding changes to land? If not, I will start the release process shortly. ==Changes== https://github.com/apache/cordova-android/compare/9.0.0...master