[GitHub] cordova-plugin-camera pull request: CB-10120 android: Camera permi...

2016-03-14 Thread MatthewBooth
Github user MatthewBooth commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-196420729 @ochakov mainly! :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-camera pull request: CB-10120 android: Camera permi...

2016-03-14 Thread MatthewBooth
Github user MatthewBooth commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-196225403 ICLA was filled out. Sorry for the delay, I hadn't been tracking these comments unfortunately. It's done now, though. --- If yo

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

2016-03-14 Thread MatthewBooth
Github user MatthewBooth commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-196224537 ```Dear Matt Booth, This message acknowledges receipt of your ICLA, which has been filed in the Apache Software Foundation records

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

2016-03-11 Thread MatthewBooth
Github user MatthewBooth commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-195320677 @riknoll Cheers, I've done that. Sent the ICLA signed with my GPG keys to the secretary, and signed up to JIRA. I only rebased @ocha

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

2016-02-21 Thread MatthewBooth
Github user MatthewBooth commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-186934876 Probably why Travis is failing. Beyond me, though. I prefer native Java to this. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

2016-02-19 Thread MatthewBooth
Github user MatthewBooth commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-186313033 This is in response to @infil00p's comments here: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186300094

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2016-02-19 Thread MatthewBooth
Github user MatthewBooth commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186312333 @infil00p I've rebased here: https://github.com/apache/cordova-plugin-camera/pull/174 --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

2016-02-19 Thread MatthewBooth
GitHub user MatthewBooth opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/174 Rebased ochakov's branch to the latest as of writing You can merge this pull request into a Git repository by running: $ git pull https://github.com/MatthewBooth/co

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

2016-02-19 Thread MatthewBooth
Github user MatthewBooth commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186290675 This should be merged ASAP. It fixes this very issue for a project I'm working on. You absolutely should be declaring the permissio