[ANNOUNCE] Plugins Release

2018-01-30 Thread Suraj Pindoria
Blog: https://cordova.apache.org/news/2018/01/29/plugins-release.html Tweet: https://twitter.com/apachecordova/status/958420617421668353

Re: [VOTE] Plugins Release

2018-01-29 Thread Suraj Pindoria
The vote has now closed. The results are: Positive Binding Votes: 3 Joe Bowser Simon MacDonald Suraj Pindoria The vote has passed. On Thu, Jan 25, 2018 at 1:50 PM, Simon MacDonald <simon.macdon...@gmail.com> wrote: > I vote +1: > * Ran coho audit-license-headers over the re

[VOTE] Plugins Release

2018-01-25 Thread Suraj Pindoria
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-13826 The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-13826/

Re: [VOTE] Cordova-browser@5.0.3 release

2017-12-20 Thread Suraj Pindoria
I vote +1: * ran coho audit-license-headers * ran coho check-license * added and ran platform on new project > On Dec 20, 2017, at 12:45, Steven Gill wrote: > > Please review and vote on this 5.0.3 Browser Release > by replying to this email (and keep discussion on the

Re: [Vote] Tools Release

2017-12-15 Thread Suraj Pindoria
I vote +1: - Ran npm test - Ran coho audit-license-headers - Ran coho check-license - Ran through https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#test On Fri, Dec 15, 2017 at 1:48 PM, Audrey So wrote: > > I vote +1: > * Ran npm test

[ANNOUNCE] Cordova-Android@7.0.0 Released

2017-12-04 Thread Suraj Pindoria
Here is the cordova-android@7.0.0 release: Blog: https://cordova.apache.org/announcements/2017/12/04/cordova-android-7.0.0.html Tweet: https://twitter.com/apachecordova/status/937809674975322112

Re: [Vote] 4.5.4 iOS Release

2017-11-20 Thread Suraj Pindoria
The vote has now closed. The results are: Positive Binding Votes: 3 Audrey So Steve Gill Suraj Pindoria The vote has passed. On Mon, Nov 20, 2017 at 4:37 PM, Steven Gill <stevengil...@gmail.com> wrote: > I vote +1 > > Ran hello world app > ran coho verify archive > &

[Vote] 4.5.4 iOS Release

2017-11-15 Thread Suraj Pindoria
Please review and vote on this 4.5.4 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-13579 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-13579 The package

Re: [DISCUSS] Cordova-iOS 4.5.4 Release

2017-11-14 Thread Suraj Pindoria
k.com/archives/C068FK885/p151064821514 > > > > 2017-11-13 23:14 GMT+01:00 Suraj Pindoria <pindoria.su...@gmail.com>: > > This release fixes an issue related to iPhone X launch storyboard > > constraints as well as a minor fix that removes an error when compiling &

[DISCUSS] Cordova-iOS 4.5.4 Release

2017-11-13 Thread Suraj Pindoria
This release fixes an issue related to iPhone X launch storyboard constraints as well as a minor fix that removes an error when compiling down to Objective-C code. Is anyone of aware of anything else that we should try to get in for this release? If not, I will continue with the release tomorrow.

Re: [Vote] 6.4.0 Android Release

2017-11-08 Thread Suraj Pindoria
I vote +1: * Ran npm test, all greens * Created hello-world and successfully deployed to emulator and device On Mon, Nov 6, 2017 at 3:44 PM, Joe Bowser wrote: > Please review and vote on this 6.4.0 Android Release > > by replying to this email (and keep discussion on the

[ANNOUNCE] Cordova-iOS@4.5.3 Released

2017-10-31 Thread Suraj Pindoria
Here is the cordova-ios@4.5.3 release. Blog: https://cordova.apache.org/announcements/2017/10/31/ios-release.html Tweet: https://twitter.com/apachecordova/status/925509203250126848

Re: [VOTE] 4.5.3 iOS Release

2017-10-30 Thread Suraj Pindoria
The vote has now closed. The results are: Positive Binding Votes: 3 Audrey So Steve Gill Suraj Pindoria The vote has passed. On Mon, Oct 30, 2017 at 10:32 AM, Steven Gill <stevengil...@gmail.com> wrote: > I vote +1: > * Ran coho verify-license > * Npm test > > On Thu, Oc

Re: [VOTE] Cordova-fetch@1.2.1 release (attempt 2)

2017-10-30 Thread Suraj Pindoria
+1 * npm test, all green * Ran coho-audit-license-headers * Ran coho check-license On Mon, Oct 30, 2017 at 10:33 AM, Steven Gill wrote: > I vote +1: > * Ran coho verify-license > * Npm test > > On Fri, Oct 27, 2017 at 4:59 PM, Audrey So wrote: >

[VOTE] 4.5.3 iOS Release

2017-10-25 Thread Suraj Pindoria
Please review and vote on this 4.5.3 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-13493 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-13493 The package

Re: [DISCUSS] cordova-ios@4.5.3 Release

2017-10-24 Thread Suraj Pindoria
I have just sent a PR for the splash screens. Once that has been reviewed and merged I will move on with the release. On Mon, Oct 23, 2017 at 3:18 PM, Darryl Pogue <dvpdin...@gmail.com> wrote: > CB-13290 I think > > On Mon, Oct 23, 2017 at 2:48 PM, Suraj Pindoria > <pin

Re: [DISCUSS] cordova-ios@4.5.3 Release

2017-10-23 Thread Suraj Pindoria
Good point Darryl, thanks for bringing this up! I agree that we might as well take care of it now rather than doing another release down the road. Do you know if there is already an existing issue for this? If not I will go ahead and file one. On Mon, Oct 23, 2017 at 2:09 PM, Darryl Pogue

[DISCUSS] cordova-ios@4.5.3 Release

2017-10-23 Thread Suraj Pindoria
While rearranging the icon mapping list to make it more readable I accidentally removed icon-40@2x, so this is a quick hotfix release to add it back in. If there is any reason to delay this release please let me know, otherwise I will continue on with the release process tomorrow.

Re: [Vote] 5.0.1 Browser Release

2017-10-19 Thread Suraj Pindoria
+1 * Ran npm test, all green * Ran coho audit-license-headers * Ran coho check-license * Created hello-world and launched in browser On Tue, Oct 17, 2017 at 9:53 AM, Audrey So wrote: > I vote +1: > * Ran npm test (passed) > * Created hello world app > * Ran coho

[ANNOUNCE] Cordova iOS Release

2017-10-18 Thread Suraj Pindoria
Tweet: https://twitter.com/apachecordova/status/920748921080594432 Blog: https://cordova.apache.org/announcements/2017/10/16/ios-release.html

Re: [DISCUSS] Cordova iOS 4.5.2 Release

2017-10-16 Thread Suraj Pindoria
Whenever someone has time, if you could please review the blog post for this release: https://github.com/apache/cordova-docs/pull/750 On Tue, Oct 3, 2017 at 7:55 PM, Suraj Pindoria <pindoria.su...@gmail.com> wrote: > We just did a release a few weeks ago but there were some oth

Re: [VOTE] 4.5.2 iOS Release

2017-10-13 Thread Suraj Pindoria
The vote has now closed. The results are: Positive Binding Votes: (# of PMC members that +1'ed) Audrey So Steve Gill Suraj Pindoria The vote has passed. On Thu, Oct 12, 2017 at 4:44 PM, Steven Gill <stevengil...@gmail.com> wrote: > > +1 > > * Ran coho audit-license-headers

[VOTE] 4.5.2 iOS Release

2017-10-09 Thread Suraj Pindoria
Please review and vote on this 4.5.2 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-13417 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-13417 The package

[DISCUSS] Cordova iOS 4.5.2 Release

2017-10-03 Thread Suraj Pindoria
We just did a release a few weeks ago but there were some other iOS 11 / Xcode 9 issues that came up shorty afterwards. That particular issue has been resolved and is already merged in to master. https://issues.apache.org/jira/browse/CB-13315 I'd also like to include another that updates the

[ANNOUNCE] cordova-ios@4.5.1 released

2017-10-02 Thread Suraj Pindoria
Blog: https://cordova.apache.org/announcements/2017/09/25/ios-release.html Tweet: https://twitter.com/apachecordova/status/913545377441136640

Re: [Vote] 4.5.1 iOS Release

2017-09-26 Thread Suraj Pindoria
I have sent a PR for the blog post for this release. If someone has time to review that would be great! https://github.com/apache/cordova-docs/pull/736 Thanks,Suraj. On Monday, September 25, 2017, 10:54:11 AM PDT, Suraj Pindoria <suraj.pindo...@yahoo.com.INVALID> wrote: Th

Re: [Vote] 4.5.1 iOS Release

2017-09-25 Thread Suraj Pindoria
ers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > > > Simon Mac Donald > http://simonmacdonald.com > > On Thu, Sep 21, 2017 at 8:06 PM, Suraj Pindoria < > suraj.pindo...@yahoo.com.inval

[Vote] 4.5.1 iOS Release

2017-09-21 Thread Suraj Pindoria
Please review and vote on this 4.5.1 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-13310 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-13310 The package

Re: [DISCUSS] Cordova iOS 4.5.1 release

2017-09-19 Thread Suraj Pindoria
I have just tested all the above issues with the official release versions of iOS 11 and Xcode 9 and can confirm that they are all fixed. We just need to merge in https://issues.apache.org/jira/browse/CB-13191, and then we should be good to release cordova-ios@4.5.1. Suraj.On Friday,

Re: [VOTE] 4.5.0 iOS Release

2017-09-07 Thread Suraj Pindoria
I vote +1:* Ran coho audit-license-headers* Ran npm test, all passing* Created hello world app and deployed to emulator/device On Wednesday, September 6, 2017, 2:25:49 AM PDT, Shazron wrote: Please review and vote on this 4.5.0 iOS Release by replying to this email

Re: proposal for new core plugin to control screen orientation

2016-05-11 Thread Suraj Pindoria
+1 I have been looking into this plugin for the last few days in order to add it to the PhoneGap Developer App. I think it would make a great addition to the core plugins and wouldn't mind volunteering to help bring it up to spec. Regards,Suraj. On Tuesday, May 10, 2016 8:56 AM, "Homer,

Re: File.spec.144 purpose

2015-08-21 Thread Suraj Pindoria
LGTM. On Friday, August 21, 2015 10:48 AM, Suraj Pindoria suraj.pindo...@yahoo.com.INVALID wrote: Was just replying when Ian responded. The reason I changed the test was because the plugin folders do not not exist when using browserify. I am running mobilespec now to see

Re: File.spec.144 purpose

2015-08-21 Thread Suraj Pindoria
Was just replying when Ian responded. The reason I changed the test was because the plugin folders do not not exist when using browserify. I am running mobilespec now to see if everything is still good with your new changes. Suraj. On Friday, August 21, 2015 10:34 AM, Ian Clelland

Introduction

2015-06-26 Thread Suraj Pindoria
Hi All, My name is Suraj Pindoria and I am a new hire with the Adobe Phonegap team. I spent last summer here as an intern and worked primarily with cordova-browser and tried to get browserify up and running. I am now back and excited to be contributing to the project once again. Looking

Re: cordova-browser plugin polyfills -- which projects already have work in this space?

2014-11-05 Thread Suraj Pindoria
Just an FYI that geolocation does work in the browser. I tested this over the summer and all the major browsers already have support for it. Suraj. On Nov 5, 2014, at 9:35 AM, Ray Camden rayca...@adobe.com wrote: Hmpth - let me look into that post lunch. On 11/5/14, 10:53 AM, Michal

Re: [echo] Adding platform: browser [exec] npm http GET https://registry.npmjs.org/cordova-browser [exec] npm http 200 h[exec] Unable to fetch platform browser: Error: No compatible version found: cor

2014-09-26 Thread Suraj Pindoria
You may just have to update your cordova-lib to the latest version. When I first submitted this code, I had the version set to ‘master’ in platforms.js but have subsequently changed it to match the npm version. This may help to solve your issue. Thanks, Suraj. On Sep 26, 2014, at 4:57 AM,

Cordova Browser

2014-09-10 Thread Suraj Pindoria
Hey, I have been working for the past few weeks on getting cordova-browser up and running, along with a few plugins to go with it. Everything is currently pushed and ready to be used. I have added support for the following plugins: - camera - device - device-motion - device-orientation -

Platform cache issue with browser

2014-09-08 Thread Suraj Pindoria
Hey, I am having an issue when trying to add the browser as a platform. It is downloading the browser module from the npm registry and saving into ~/.cordova/lib/npm_cache/ but it is installing the node_modules folder into a different folder than my source code. The source code is in

Re: Browserify support for cordova-lib/cordova-cli

2014-08-04 Thread Suraj Pindoria
Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Friday, 1 August, 2014 0:29 To: dev@cordova.apache.org; Suraj Pindoria Subject: Re: Browserify support for cordova-lib/cordova-cli This looks good to me. Anyone else want to test it before I merge it in? On Wed, Jul 30, 2014

Browserify support for cordova-lib/cordova-cli

2014-07-29 Thread Suraj Pindoria
Hi everyone, I have been working with Anis and Steve to add browserify support in cordova-lib and cordova-cli.  They way this is being done is through a flag in the CLI which then calls prepare-browserify versus the standard prepare, an example: cordova plugin --browserify add

Re: Cordova-lib Submodules

2014-07-18 Thread Suraj Pindoria
:12 PM, Suraj Pindoria suraj.pindo...@yahoo.com.INVALID wrote: Hi everyone, I have spent the last few weeks working with Anis on cordova-lib and trying to split up the src into smaller submodules based on functionality.  I just submitted a pull request with my changes.  It looks like a lot