Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-android/pull/273#issuecomment-197424352
@daserge Thanks! I will close this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dpolivy closed the pull request at:
https://github.com/apache/cordova-android/pull/273
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-android/pull/273#issuecomment-197005575
@daserge That makes sense; in the case where a release build is built, but
not automatically signed as part of the process, I can see that run would not
pick
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-android/pull/273
[CB-10600] 'cordova run --release' uses wrong apk
When doing `cordova run android --release`, the CLI attempts to use the
android-release-unsigned.apk, which naturally fails to install
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/86#issuecomment-194537453
@daserge Great, thanks for merging!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/154
[CB-10795] Exclude current app from external intent list
On Android, if the app defines an intent-filter for a given URL, and
then tries to use inappbrowser to launch
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/86#issuecomment-188543128
@daserge @infil00p Would you be able to review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/86
CB-10692 Don't fade when plugin is forced to close
The fading logic exposed a race condition in an edge case when the
plugin was repeatedly reinitialized, e.g. when
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69#issuecomment-186485912
@daserge Have you tested this and verified it's working? I have the
splashscreen plugin v3.2.0, and have manually converted my existing
`cordova
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-172130564
@daserge That PR looks reasonable to me. I might be able to work around
this bug by setting `AutoHideSplashScreen` to `false` when it is supported
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-171885860
@daserge Unfortunately I don't believe AutoHideSplashScreen is implemented
for Android. However, even if it were, I'm not sure it would address
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-171818850
@infil00p @stevengill Any possibility of getting a review on this? Thanks.
---
If your project is set up for it, you can reply to this email
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-150526428
@purplecabbage On Android, the strings were previously
[hardcoded](https://github.com/apache/cordova-plugin-camera/pull/104/files#diff
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149044779
@jcesarmobile Is this a quirk just because it's only implemented on iOS,
Android, and WP?
@infil00p Actually, it is consistent on Android
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-126746379
@infil00p @shazron @nikhilkh @stevengill Any thoughts on this discussion or
possibility of a CR?
---
If your project is set up for it, you can reply
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-119727865
@stevengill @infil00p Any possibility of reviewing this before the next
release?
---
If your project is set up for it, you can reply to this email
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-119015527
@muratsu Valid question, thanks for starting the discussion. The Android
implementation is more like the Messages/Slack experience you highlight above
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-113959822
@gregavola It sounds like you have a broader Cordova issue. Perhaps
[CB-7197](https://issues.apache.org/jira/browse/CB-7197)?
---
If your project
Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879192
--- Diff: src/android/CameraLauncher.java ---
@@ -124,16 +127,9 @@ public boolean execute(String action, JSONArray args,
CallbackContext
Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879022
--- Diff: README.md ---
@@ -456,3 +457,36 @@ after calling `camera.getPicture`. Applies only when
the value of
function onFail(message
Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879337
--- Diff: www/Camera.js ---
@@ -72,4 +72,28 @@ cameraExport.cleanup = function(successCallback,
errorCallback) {
exec(successCallback
Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879234
--- Diff: src/android/CameraLauncher.java ---
@@ -163,7 +159,19 @@ else if ((srcType == PHOTOLIBRARY) || (srcType ==
SAVEDPHOTOALBUM
Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879268
--- Diff: src/android/CameraLauncher.java ---
@@ -173,6 +181,20 @@ else if ((srcType == PHOTOLIBRARY) || (srcType ==
SAVEDPHOTOALBUM
Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879001
--- Diff: README.md ---
@@ -456,3 +457,36 @@ after calling `camera.getPicture`. Applies only when
the value of
function onFail(message
Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32879107
--- Diff: README.md ---
@@ -456,3 +457,36 @@ after calling `camera.getPicture`. Applies only when
the value of
function onFail(message
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-113683706
@thehuijb Thanks for quickly reworking based on my feedback! I ported
these into my fork and it seems to be working fine for me at the moment. I did
add
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-113321831
I am looking at porting this into my fork of the camera plugin, and have a
few suggestions/improvements to add (some I've addressed, some not yet). I'm
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/49
CB-9094: Smarter autohide logic on Android
When the plugin is initialized, the splash screen is shown with an
auto-hide delay. If a subsequent call to show() comes in while
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-106625709
@infil00p Would you be able to review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-101119417
As this is iOS specific, I'm not sure it makes sense as a JavaScript
parameter. Is there any provision for translating strings that are part
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/47
CB-3562: Disable screen rotation for iPhone when splash screen is shown
(updated)
This is an updated port of emarashliev's fix for CB-3562, as this bug still
exists
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-100047309
@shazron Any possibility of a review merge for the next plugin release?
---
If your project is set up for it, you can reply to this email and have your
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/46#issuecomment-100047179
@shazron Can you please review merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/46
CB-8988: Fix rotation on iOS/iPad
The viewController.interfaceOrientation passed to getImageName has not
yet been updated with the new orientation, even when the frame/bounds
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/74#issuecomment-96058947
@vladimir-kotikov Thanks for the comments! I addressed your feedback, and
pushed up a new diff. I squashed the changes into a single commit -- hope
Github user dpolivy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/74#discussion_r29088108
--- Diff: src/wp/FileTransfer.cs ---
@@ -210,6 +216,80 @@ public FileTransferProgress(long bTotal = 0, long
bLoaded = 0
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/73#issuecomment-94885204
@stevengill Is there someone who can review and merge this?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/41#issuecomment-94884712
@purplecabbage Is that strictly necessary, given the code is quite
straightforward and fairly common? I'd love to get this merged in if possible
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-94880942
@stevengill @shazron Is it possible to get a review on this and some
feedback on whether it is OK to merge?
---
If your project is set up for it, you can
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/42#issuecomment-94884271
@stevengill @purplecabbage @sgrebnov Is it possible to get someone to
review and merge this?
---
If your project is set up for it, you can reply
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/74#issuecomment-94885261
@stevengill Is there someone who can review and merge this?
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/73
CB-6313 [wp8]: Extra boundary in upload
When performing an upload on Windows Phone, an extra boundary is
included after any parameters, and before the file contents
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/74
CB-8761 [wp8]: Copy cookies from WebBrowser
On other platforms, the cookies from the browser that apply to the
request are automatically included. On WP8, that's
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/41#issuecomment-87015745
I should also point out that the ResolutionHelper.cs file is taken from
MSDN sample code:
https://msdn.microsoft.com/library/windows/apps/jj206974(v
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/41
CB-8750 [wp8]: Allow resolution-specific splashscreen images
There are two aspect ratios for Windows Phone devices: 15:9 and 16:9. At
the moment, though, there is only one
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/42
CB-8758 [wp8]: UnauthorizedAccessException on hide()
When calling hide() from JS, the attempt to access Popup could happen on
a background thread, which ends up throwing
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-82518530
@shazron I just re-merged master and rebased the changes so it's a clean
commit. Any chance of getting this pulled in to the next release?
---
If your
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-69861487
I cleaned up the merge conflict, and I believe it's now working again. I
had a bunch of issues upgrading my plugin (CDVCamera.m seemed to drop off
GitHub user dpolivy opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/49
CB-7667 iOS8: Handle case where camera is not authorized
In iOS 7+, when the app does not have access to the camera, show a
prompt notifying the user so they're not puzzled
49 matches
Mail list logo
