[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread dubeejw
Github user dubeejw commented on the pull request: https://github.com/apache/cordova-windows/pull/163#issuecomment-203582975 @rakatyal, I just copied the content from DummyProject to create the testProj. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread dubeejw
Github user dubeejw commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57907153 --- Diff: spec/unit/pluginHandler/windows.spec.js --- @@ -305,17 +306,25 @@ describe('windows project handler', function () {

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread dubeejw
Github user dubeejw commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57906698 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -85,12 +85,12 @@ var handlers = { var src = obj.src; var

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread dubeejw
Github user dubeejw commented on the pull request: https://github.com/apache/cordova-windows/pull/163#issuecomment-203483657 @rakatyal, the existing test fixtures could not be used because the paths to the framework references are no longer absolute, they are now relative to the

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread dubeejw
Github user dubeejw commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57905517 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -85,12 +85,12 @@ var handlers = { var src = obj.src; var

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread dubeejw
Github user dubeejw commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57905311 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -85,12 +85,12 @@ var handlers = { var src = obj.src; var

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread dubeejw
Github user dubeejw commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57904729 --- Diff: spec/unit/pluginHandler/windows.spec.js --- @@ -441,40 +451,47 @@ describe('windows project handler'

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread dubeejw
Github user dubeejw commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57904108 --- Diff: spec/unit/pluginHandler/windows.spec.js --- @@ -164,6 +164,7 @@ describe('windows project handler'

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-23 Thread dubeejw
Github user dubeejw commented on the pull request: https://github.com/apache/cordova-windows/pull/163#issuecomment-200555450 @csantanapr, @nikhilkh, @rakatyal, all tests are now passing. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-22 Thread dubeejw
GitHub user dubeejw opened a pull request: https://github.com/apache/cordova-windows/pull/163 CB-10927 - Framework references in plugin.xml file prevent Windows Universal projects from being used on other machines - Stop using a hardcoded path to framework references You

[GitHub] cordova-lib pull request: CB-10908 - Add a plugin with the --save ...

2016-03-19 Thread dubeejw
GitHub user dubeejw opened a pull request: https://github.com/apache/cordova-lib/pull/415 CB-10908 - Add a plugin with the --save flag clubbers data that is wr… - Reload the config.xml before writing the saved plugin You can merge this pull request into a Git repository by

[GitHub] cordova-plugin-globalization pull request: CB-10792 -Cannot instal...

2016-03-04 Thread dubeejw
GitHub user dubeejw opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/47 CB-10792 -Cannot install cordova-plugin-globalization with cordova-windows on Ubuntu - Make Windows lower-case in plugin.xml You can merge this pull request into a Git

[GitHub] cordova-lib pull request: CB-10499 - --template should pull the la...

2016-02-01 Thread dubeejw
GitHub user dubeejw opened a pull request: https://github.com/apache/cordova-lib/pull/372 CB-10499 - --template should pull the latest template from NPM when version isn't specified - Pull the latest template if no version is specified You can merge this pull request

[GitHub] cordova-cli pull request: Cb 9964

2015-12-03 Thread dubeejw
Github user dubeejw closed the pull request at: https://github.com/apache/cordova-cli/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: CB-9964 - Add --template to online docu...

2015-11-30 Thread dubeejw
GitHub user dubeejw opened a pull request: https://github.com/apache/cordova-docs/pull/432 CB-9964 - Add --template to online documentation - Information about --template is now in the CLI documentation You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-lib pull request: Cb 9964

2015-11-28 Thread dubeejw
Github user dubeejw commented on the pull request: https://github.com/apache/cordova-lib/pull/339#issuecomment-160341530 All test passing after pulling latest changes from Master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: Cb 9964

2015-11-15 Thread dubeejw
GitHub user dubeejw reopened a pull request: https://github.com/apache/cordova-lib/pull/339 Cb 9964 When providing a --template argument during project creation, users can use templates apps from a local directory, GitHub, or NPM. This makes sharing templates, and example

[GitHub] cordova-lib pull request: Cb 9964

2015-11-15 Thread dubeejw
Github user dubeejw commented on the pull request: https://github.com/apache/cordova-lib/pull/339#issuecomment-156909488 New unrelated tests failing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request: Cb 9964

2015-11-15 Thread dubeejw
Github user dubeejw closed the pull request at: https://github.com/apache/cordova-lib/pull/339 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: CB-9964 Make --copy-from use --template ...

2015-11-15 Thread dubeejw
GitHub user dubeejw opened a pull request: https://github.com/apache/cordova-cli/pull/227 CB-9964 Make --copy-from use --template behavior - Arguments are now handled for the --template parameter - --copy-from now uses the same behavior as --template You can merge this pull

[GitHub] cordova-lib pull request: Cb 9964

2015-11-11 Thread dubeejw
Github user dubeejw commented on the pull request: https://github.com/apache/cordova-lib/pull/339#issuecomment-155998408 Test failures are related to cordova-common, which was not modified in this code. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-lib pull request: Cb 9964

2015-11-05 Thread dubeejw
GitHub user dubeejw opened a pull request: https://github.com/apache/cordova-lib/pull/339 Cb 9964 When providing a --template argument during project creation, users can use templates apps from a local directory, GitHub, or NPM. This makes sharing templates, and example apps

[GitHub] cordova-cli pull request: Cb 9964

2015-11-05 Thread dubeejw
GitHub user dubeejw opened a pull request: https://github.com/apache/cordova-cli/pull/226 Cb 9964 When providing a --template argument during project creation, users can use templates apps from a local directory, GitHub, or NPM. This makes sharing templates, and example apps much

[GitHub] cordova-docs pull request: CB-8724 Added info about getting Cordov...

2015-03-23 Thread dubeejw
GitHub user dubeejw opened a pull request: https://github.com/apache/cordova-docs/pull/271 CB-8724 Added info about getting Cordova command-line to work - Added information about having to install the newest Visual Studio 2012 Update. Otherwise, Cordova command-line