[GitHub] cordova-lib pull request:

2015-11-18 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/commit/a7e71227d2157e677c3ce495341c83916f9b272f#commitcomment-14483903 It is documented in http://cordova.apache.org/docs/en/5.4.0/platform_plugin_versioning_ref/index.html --- If your project

Re: [DISCUSS] CLI Templates

2015-11-12 Thread Gorkem Ercan
How about adding support for some more dynamic generation. Can we add yeoman as an option something like $cordova create myApp --template=yo:m to invoke the generator m ? -- Gorkem On 10 Nov 2015, at 19:52, Carlos Santana wrote: Parashuram I would say that if they have "platforms

[GitHub] cordova-android pull request: CB-9844 Remove old .java after renam...

2015-10-27 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-android/pull/233#issuecomment-151513478 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-9736 - Extra main activity generated ...

2015-10-22 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/328#issuecomment-150394486 @stevengill Yes, created CB-9844 to follow up. This one is still valid for fixing older android engines though. --- If your project is set up for it, you can reply

[GitHub] cordova-lib pull request: CB-9736 - Extra main activity generated ...

2015-10-21 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/328 CB-9736 - Extra main activity generated when an android package name specified Removes the old package name after the new one is created. If the package name is different You can merge

[GitHub] cordova-cli pull request: CB-9784 Remove CLI logger levels prefixe...

2015-10-12 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-cli/pull/224#issuecomment-147553471 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Is CPR going offline

2015-10-09 Thread Gorkem Ercan
+1 I also observe that people has taken their time to update. I think it is helpful to keep CPR around until new year. We can then send CPR away with a countdown on new year's day, instead of the viking funeral. -- Gorkem On 9 Oct 2015, at 18:04, Nikhil Khandelwal wrote: I am in fav

Is CPR going offline

2015-10-09 Thread Gorkem Ercan
Hi, Our announced date Oct 15 is next week. Will CPR be go offline as planned or do we see that we should give it more time. -- Gorkem - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e

Re: Announcing Tools for Apache Cordova (TACO) v1.0.0!

2015-10-02 Thread Gorkem Ercan
if it was. Cordova already has too many names involved around itself (phonegap, cordova, cli, platforms, plugman, ionic, to name a few), too much confusion already lives in what does what. If TACO could live inside CLI, I think it should. 2015-10-02 17:56 GMT-03:00 Subhag Oak : Hey Gorkem,

Re: Announcing Tools for Apache Cordova (TACO) v1.0.0!

2015-10-02 Thread Gorkem Ercan
Congratulations on the release. Looks very useful. Since this is already open source and seems complimentary to CLI, What was your reason(s) for not doing this work as part of CLI. -- Gorkem On 1 Oct 2015, at 18:00, Subhag Oak wrote: Hey all, Today we releases the v1.0.0 of Tools for Apache

Re: Will CPR BD be down?

2015-07-03 Thread Gorkem Ercan
Yes, the plan is to shut it down on Oct 15th. See the announcement in http://cordova.apache.org/announcements/2015/04/21/plugins-release-and-move-to-npm.html On 3 Jul 2015, at 11:24, Victor Sosa wrote: With the move from CPR to NPM, will registry.cordova.io be down at some point? My gut feeli

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-06-08 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/224#issuecomment-110066248 @marcuspridham PR looks. Do you have Apache CLA signed? I can not seem to find it if you have. Before I can merge this one, you need to sign Apache’s Contributor

Re: "Best" place to browse plugins

2015-05-28 Thread Gorkem Ercan
we could simply publish on npm, but keep plugins.cordova.io as a mirror/redirector, based on the Cordova registry mapper. -Original Message- From: Gorkem Ercan [mailto:gorkem.er...@gmail.com] Sent: Friday, May 1, 2015 8:31 AM To: dev@cordova.apache.org Subject: Re: "Best" place to

Re: Also moving to a new team

2015-05-05 Thread Gorkem Ercan
Best of luck on your new project. -- Gorkem On 5 May 2015, at 11:15, Andrew Grieve wrote: > As with Michal, you'll be seeing less of me around. My new full-time > project will be on the Android port of Chrome. > > Just want to make it clear that us moving to new teams has nothi

Re: "Best" place to browse plugins

2015-05-01 Thread Gorkem Ercan
What is the plan for plugins.cordova.io for after the CPR is closed? Without knowing if there is a good way to retrieve the list/details of the cordova plugins from npm. I would love it if we could keep it as it is with the data from npm. -- Gorkem On 29 Apr 2015, at 10:57, Raymond Camden

Re: Apache Cordova 4 Programming book

2015-04-29 Thread Gorkem Ercan
Congratulations. Thank you for including Eclipse Thym. -- Gorkem On 29 Apr 2015, at 7:26, John M. Wargo wrote: Cordova Devs, I wanted to let everyone know that Apache Cordova 4 Programming has been released and is available online: http://www.informit.com/store/apache-cordova-4-programming

[GitHub] cordova-lib pull request: Save/Restore for plugins and platforms

2015-04-14 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/166#issuecomment-92777120 correct. `restore` command is removed and restoration happens during `prepare`. You can call `cordova prepare` explicitly to get the similar results to `restore

Re: Question about plugin/platform --save: src vs version?

2015-04-08 Thread Gorkem Ercan
I am OK with spec. I plan to review #202 today. -- Gorkem On 8 Apr 2015, at 5:12, Tim Barham wrote: @gorkem - are you ok for this to be merged, or do you feel strongly we should stick with 'version'? Thanks, Tim From: Tim Barham Sen

Re: Question about plugin/platform --save: src vs version?

2015-03-31 Thread Gorkem Ercan
Mon, Mar 30, 2015 at 4:04 PM, Edna Y Morales wrote: It could make sense to store both for the case where restoring from src fails. For example, if the path to a local folder no longer exists, what do you use to restore? In that case you could use the version as a fallback? Thanks, Edna Morales [ima

Re: Question about plugin/platform --save: src vs version?

2015-03-30 Thread Gorkem Ercan
On 29 Mar 2015, at 23:11, Tim Barham wrote: Hi - I'm looking for input on this issue: For the plugin/platform --save feature, there's currently an inconsistency between how we store the information in config.xml for platforms vs plugins. For platforms, we have a 'version' attribut

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Gorkem Ercan
uot;^1.2.3" notation on config.xml Gorkem - I'm currently doing some work in this area - I'm happy to make this change while I'm there. Sure, go ahead. I would not be able to get to it until next week. From: Steven Gill [stevengil...@gma

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Gorkem Ercan
I think the problem here is shrinkwrap behaviour is the expected because platforms behave that way. I guess we could just make shrinkwrap default and change the flag to --noshrinkwrap. -- Gorkem On 24 Mar 2015, at 13:58, Andrew Grieve wrote: On Tue, Mar 24, 2015 at 11:49 AM, Gorkem Ercan

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Gorkem Ercan
est possible version available if they are not explicitly shrinkwrapped. As for CB-8733, "cordova plugin save" command can not save the version information even if it had wanted to because fetch.json is missing that information. It is a bug. -- Gorkem On Tue, Mar 24, 2015 at 11:29 AM, Raymo

Re: App Hello World with default plugin (plus status update)

2015-03-23 Thread Gorkem Ercan
On 20 Mar 2015, at 14:46, Andrew Grieve wrote: First: just committed a change to add the whitelist plugin to the default app template: https://git1-us-west.apache.org/repos/asf?p=cordova-app-hello-world.git;a=commit;h=2e856b845a0134e7056bdc74f89cafcf483a379f Perhaps a bit strange if project

[GitHub] cordova-lib pull request: Deprecate the old feature syntax from co...

2015-03-12 Thread gorkem
Github user gorkem closed the pull request at: https://github.com/apache/cordova-lib/pull/182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: Deprecate the old feature syntax from co...

2015-03-11 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/182#issuecomment-78261223 merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: Deprecate the old feature syntax from co...

2015-03-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/182#issuecomment-77969729 @omefire see the changes on test-config.xml for examples of the new tag --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-lib pull request: CB-8636 Remove FEATURE_SPECIAL_PARAMS fr...

2015-03-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/181#issuecomment-77969339 Should we close this? #182 removes all this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: Deprecating the feature tag

2015-03-09 Thread Gorkem Ercan
PM To: dev Subject: Re: Deprecating the feature tag Haven't looked at a patch, but +1 to over On Mon, Mar 9, 2015 at 4:41 PM, Gorkem Ercan wrote: I am about to deprecate the old tag use for saving plugin information in favour of tag. I have a PR[1] that I hope to soon merge. The ch

[GitHub] cordova-lib pull request: CB-8521 `cordova plugin save` should sav...

2015-03-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/178#issuecomment-77956329 I was just testing com.ibm.mobile.cordova.ibmpush for something else which seems to pull in another large plugin --- If your project is set up for it, you can reply

[GitHub] cordova-lib pull request: CB-8521 `cordova plugin save` should sav...

2015-03-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/178#issuecomment-77955805 I think this saves **all** the installed plugins to config.xml. The dependency plugins ( those plugins that were installed as a dependency of another) should never

Deprecating the feature tag

2015-03-09 Thread Gorkem Ercan
/pull/182 -- Gorkem - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Deprecate the old feature syntax from co...

2015-03-09 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/182 Deprecate the old feature syntax from config.xml Deprecates the feature syntax and starts using the new plugin tags for defining plugins. Adjusts the tests for the new logic. The old feature

Re: Some thoughts/questions on the new --save feature

2015-03-05 Thread Gorkem Ercan
7;d still like to know where/if the settings for this file are documented? On Thu, Mar 5, 2015 at 10:24 AM, Michal Mocny wrote: Consensus is a strong word ;) On Thu, Mar 5, 2015 at 11:02 AM, Raymond Camden wrote: Hmm. Ok... so... is there a consensus to *not* promote it? On Thu, Mar 5, 201

Re: plugin install using old version with cordova 4.2

2015-03-05 Thread Gorkem Ercan
Do you have a version number specified on your config.xml for your plugin? Have you used the --save switch earlier for instance? -- Gorkem On 4 Mar 2015, at 23:22, Don Coleman wrote: I published a new version of my plugin <http://plugins.cordova.io/#/package/com.megster.cordova.ble>,

Re: Some thoughts/questions on the new --save feature

2015-03-05 Thread Gorkem Ercan
config.son is not created by CLI by default anymore. You need to do create the file and add the key. -- Gorkem On 5 Mar 2015, at 7:33, Raymond Camden wrote: Sorry - what file? I don't have that in my project. If you meant user root, I don't have it there either. On Tue, Mar 3, 201

Re: Some thoughts/questions on the new --save feature

2015-03-03 Thread Gorkem Ercan
You can enable auto save by adding auto_save_plugins to be true on the .cordova/config.json file. I think this helps with the case 1 -- Gorkem On 3 Mar 2015, at 9:27, Raymond Camden wrote: 1) Is there any reason why --save isn't true by default? It would seem that in a majority of

[GitHub] cordova-lib pull request: CB-8577 BugFix 'cordova plugin add

2015-03-01 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/174#issuecomment-76643012 I agree, but this is temporary. Special params are going away with the plugin tag. And ConfigParser's current implementation already does a special treatme

[GitHub] cordova-lib pull request: CB-8577 BugFix 'cordova plugin add

2015-03-01 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/174#issuecomment-76639381 Ahhh. I see what you mean now. I think we should fix this on the Config.getFeature(id) so that the existing information on config.xml files are not discarded

[GitHub] cordova-lib pull request: CB-8577 BugFix 'cordova plugin add

2015-02-28 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/174#issuecomment-76528103 Correct, let's do the change together with the change. My plan is to have some sort of migration logic with that as well to help old friends. At this moment,

[GitHub] cordova-lib pull request: CB-8577 BugFix 'cordova plugin add

2015-02-27 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/174#issuecomment-76510698 If we change this now it will just make the migration from to logic more complex. --- If your project is set up for it, you can reply to this email and have your

Re: [Vote] Tools Release February 27, 2015

2015-02-27 Thread Gorkem Ercan
On 27 Feb 2015, at 22:19, Mefire O. wrote: I've spent some time testing, found two bugs and I vote -1 until we address those : - https://issues.apache.org/jira/browse/CB-8577 I do not think this is a show stopper, probably not even a bug, I have not had time to change the old tags. Actual

Re: [REVIEW] Tools Release Blog Post

2015-02-27 Thread Gorkem Ercan
On 27 Feb 2015, at 21:16, Michal Mocny wrote: Looks good. Few comments: - "You can manage plugin and platform versions using the --save command" => "You can now save your list of installed plugins and platforms using the --save command". Should we also add "Saved platforms and plugins a

Re: [Discuss] Tools Release

2015-02-26 Thread Gorkem Ercan
On 25 Feb 2015, at 15:10, Steven Gill wrote: > Newly Pinned: > Android 3.7.1 > ios 3.8.0 > windows 3.8.0 > cordova platform/plugin --save and auto-restore for plugins and platforms are also in. > Pre-req: iOS and Windows need to be published to npm. > > Before voting finishes, iOS and Windows

[GitHub] cordova-lib pull request: Auto save restore for plugins

2015-02-23 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/143#issuecomment-75690753 closing as this is obsolete --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib pull request: Auto save restore for plugins

2015-02-23 Thread gorkem
Github user gorkem closed the pull request at: https://github.com/apache/cordova-lib/pull/143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-8482: Update engine syntax within con...

2015-02-23 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/168#issuecomment-75658796 @omefire this looks OK and would like to get it in. The dependencies have changed though save.js and restore.js are gone. I could not quickly spot anything on

[GitHub] cordova-lib pull request: Save/Restore for plugins and platforms

2015-02-23 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/166#issuecomment-75547919 I think I have addressed the concerns with the latest. If everyone is cool with it, we should go ahead and merge them in. --- If your project is set up for it, you

[GitHub] cordova-lib pull request: CB-8499 `cordova platform save` should s...

2015-02-20 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/170#issuecomment-75350562 Is platforms.json an existing file? Is it used anywhere else? I suspect that it is a new file and I am not sure if it is really needed --- If your project is set

[GitHub] cordova-lib pull request: CB-8482: Update engine syntax within con...

2015-02-19 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/168#issuecomment-75103410 I wonder if it is worth to do an auto convert from old syntax when we encounter it? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-lib pull request: Save/Restore for plugins and platforms

2015-02-13 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/166#issuecomment-74294685 sure... as long as there plugin install logic uses variables from config.xml, which does not. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-lib pull request: Save/Restore for plugins and platforms

2015-02-13 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/166#issuecomment-74284189 Save logic is a bit disorganized because I was expecting @omefire to implement it for plugins as well, so I have whipped up something. I will probably make another

[GitHub] cordova-cli pull request: Save/Restore for plugins and platforms C...

2015-02-12 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-cli/pull/209 Save/Restore for plugins and platforms CLI changes Also see https://github.com/apache/cordova-lib/pull/166 Remove save and restore command and updates docs for plugin save You can

[GitHub] cordova-lib pull request: Save/Restore for plugins and platforms

2015-02-12 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/166 Save/Restore for plugins and platforms I think this is a good point to merge these features.. It provides most of the functionality and frankly I am tired of rebasing/merging. Several

Re: Schedule for npm transition

2015-02-11 Thread Gorkem Ercan
rom npm instead of CPR. After 3 months, CPR plugins will start to become out of date compared to npm versions. Our next plugins release (after the one currently ongoing) will be published to npm as well as cpr. On Wed, Feb 11, 2015 at 9:10 AM, Gorkem Ercan wrote: Is there a determined ca

Re: Schedule for npm transition

2015-02-11 Thread Gorkem Ercan
f CPR. After 3 months, CPR plugins will start to become out of date compared to npm versions. Our next plugins release (after the one currently ongoing) will be published to npm as well as cpr. On Wed, Feb 11, 2015 at 9:10 AM, Gorkem Ercan wrote: Is there a determined calendar for the npm mo

Schedule for npm transition

2015-02-11 Thread Gorkem Ercan
Is there a determined calendar for the npm move of the plugins? I think the scheduling of the transition is crucial for those who are using the plugin registry directly. -- Gorkem - To unsubscribe, e-mail: dev-unsubscr

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73641308 Already done most of it un https://github.com/gorkem/cordova-lib/tree/save_restore_final and https://github.com/gorkem/cordova-cli/tree/save_restore_final

[GitHub] cordova-lib pull request: [ADD] GET attribute 'version' config.xml...

2015-02-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/161#issuecomment-73638976 There is a new implementation of restore cooking, which auto restores engines and also does handle the version. As part of that work restore command will vanish

[GitHub] cordova-lib pull request: CB-8420 'cordova plugin add' should retr...

2015-02-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/162#issuecomment-73638713 -1 since we agreed to have auto restore for plugins I do not think this feature will be used at all. --- If your project is set up for it, you can reply to this

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73527863 IMHO it is(or was) premature to drop this single PR by itself to master. This new flag --save flag should replace the save command, save command is not removed by

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-05 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73172414 @omefire I am integrating your changes to mine to implement the full circle. One thing that I have noticed this does not support the url based case for instance the

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-04 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-72903015 @omefire Squash this to a single one commit? It will be easier for me to take it into the rest of the save restore changes. --- If your project is set up for it

[GitHub] cordova-lib pull request: CB-8227 CB8237 CB-8238 Add --save option...

2015-02-02 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-72537095 No, just go ahead.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: CB-8227 CB8237 CB-8238 Add --save option...

2015-02-02 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-72536059 @omefire Do you have a corresponding PR for plugins? Do you plan to create one? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-lib pull request: CB-8227 CB8237 CB-8238 Add --save option...

2015-02-02 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-72534613 @omefire can we enhance this to do the save if config_json has an auto_save option on regardless of the --save flag on the command. I will remove the corresponding

Re: Plugin management ?

2015-02-02 Thread Gorkem Ercan
We have cordova save plugins and cordova restore plugins commmands that saves/restores from config.xml [1]. They are considered experimental but we are in the process of moving the functionality to their permanent locations. [1] http://www.gorkem-ercan.com/2014/06/sharing-cordova-projects-b

Re: platforms/plugins save and restore from config.xml

2015-01-15 Thread Gorkem Ercan
The proposal(s) seems to only cover the platforms. Although the behaviours are very similar there will be details that should be addressed. For instance how to handle the search path for plugins -- Gorkem On 15 Jan 2015, at 19:33, Mefire O. wrote: After some suggestions to instead move to

Re: platforms/plugins save and restore from config.xml

2015-01-12 Thread Gorkem Ercan
On 12 Jan 2015, at 22:09, Andrew Grieve wrote: Related to this, but maybe can be discussed outside of the doc just fine: https://issues.apache.org/jira/browse/CB-4275 Right now when we add a new platform, we do a for-each on directories within plugins/ and add them as well. This causes all

Re: anybody from phonegap build team here?

2015-01-12 Thread Gorkem Ercan
On 12 Jan 2015, at 4:15, julio cesar sanchez wrote: > Hi, > > I know this a cordova list, Actus Reus... and Mens Rea.. > but maybe there is somebody from phonegap build > team here and can answer. > > I have a doubt about contributing to phonegap build plugins, the docs say: > Submitting Your

Re: platforms/plugins save and restore from config.xml

2015-01-09 Thread Gorkem Ercan
On 9 Jan 2015, at 14:48, Josh Soref wrote: > Michal Mocny wrote: > >> Automatic restore could just happen on prepare. >> We do this for CCA and its worked very well. > > Sounds good to me. Already implemented on https://github.com/apache/cordova-lib/pull/143 ---

Re: platforms/plugins save and restore from config.xml

2015-01-09 Thread Gorkem Ercan
.com] On Behalf Of Michal Mocny Sent: Friday, January 09, 2015 10:35 AM To: dev Subject: Re: platforms/plugins save and restore from config.xml -1 on removing experimental. I love the concept behind this feature, and I applaud Gorkem for actually working on pushing it forward, but I'm

Re: platforms/plugins save and restore from config.xml

2015-01-09 Thread Gorkem Ercan
On 9 Jan 2015, at 13:35, Michal Mocny wrote: -1 on removing experimental. I love the concept behind this feature, and I applaud Gorkem for actually working on pushing it forward, Thanks just trying to help. but I'm still concerned the current design is not perfect. Just today we

Re: platforms/plugins save and restore from config.xml

2015-01-09 Thread Gorkem Ercan
the same lines but I am not sure if this would fit everyone. -- Gorkem On 8 Jan 2015, at 23:48, Josh Soref wrote: Until adding plugins saves the variables provided, we really shouldn't / can't make this non experimental. Sent from my BlackBerry 10 smartphone.

Re: platforms/plugins save and restore from config.xml

2015-01-09 Thread Gorkem Ercan
On 9 Jan 2015, at 10:41, Andrew Grieve wrote: Questions: Would ever not want to use --save? Why not just always update config.xml with what plugins you have? Eclipse Thym always updates the plugin & platform information to config.xml, and no one complained about it so far. Likewise, woul

Re: platforms/plugins save and restore from config.xml

2015-01-08 Thread Gorkem Ercan
cordova help has a section for "Experimental Commands" they are listed there. Once the save and restore is graduated that section will be empty though. -- Gorkem On 8 Jan 2015, at 21:32, Brian LeRoux wrote: Yes! Also quick q, are all experimental flags documented somewhere? (O

Re: platforms/plugins save and restore from config.xml

2015-01-08 Thread Gorkem Ercan
On 8 Jan 2015, at 17:29, Mefire O. wrote: Hi all, I am a big fan of the experimental "save" and "restore" features that are in the CLI and saw that Gorkem has also created another PR (https://github.com/apache/cordova-lib/pull/143 ) to have a setting to auto pe

[GitHub] cordova-lib pull request: Auto save restore for plugins

2015-01-08 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/143#issuecomment-69242088 @agrieve Good catch. It is dumb luck this was working correctly. Updated the PR --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-lib pull request: Auto save restore for plugins

2015-01-08 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/143#issuecomment-69240637 @omefire Correct did that because plugman has its own hooks, I think, it may be useful to keep the config.xml updated for them --- If your project is set up for it

[GitHub] cordova-lib pull request: Auto save restore for plugins

2015-01-08 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/143 Auto save restore for plugins uses .cordova/config.json to automatically save or restore plugins to/from config.xml on a project You can merge this pull request into a Git repository by

[GitHub] cordova-lib pull request: CB-6472 Merge dictionaries when updating...

2014-11-21 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/115#issuecomment-64043986 made some style changes and renamed underscore.. Perhaps we should move to use eslint instead of jshint, I think that still has the style checks. --- If

[GitHub] cordova-lib pull request: Support for searchpath option when resto...

2014-11-20 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/120#issuecomment-63835895 @kamrik this has a counterpart on CLI repo https://github.com/apache/cordova-cli/pull/197. Can you also take care of that? --- If your project is set up for it, you

[GitHub] cordova-lib pull request: Support for searchpath option when resto...

2014-11-14 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/120 Support for searchpath option when restoring plugins passes the searchpath option to plugin add You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-cli pull request: support for searchpath option to restore...

2014-11-14 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-cli/pull/197 support for searchpath option to restore plugins Correctly passes the searchpath option to restore command. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request: CB-6472 Merge dictionaries when updating...

2014-10-27 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/115 CB-6472 Merge dictionaries when updating plist files Merges the dictionaries on plist files if both plist and the value from plugin.xml are dictionaries. This makes it consistent with how it

Re: Plugins dependencies installation logic

2014-10-22 Thread Gorkem Ercan
Do you remember, whether a Jira was created for it? -- Gorkem On Wed, Oct 22, 2014 at 3:47 PM, Andrew Grieve wrote: > This was brought up (over a year ago at least), and was deemed a bug, but > one that's hairy to fix. > > On Wed, Oct 22, 2014 at 8:07 AM, Bryan Higgins >

[GitHub] cordova-lib pull request: [CB-7820] cordova platfrom restore stops...

2014-10-20 Thread gorkem
Github user gorkem commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/106#discussion_r19126554 --- Diff: cordova-lib/src/cordova/restore.js --- @@ -54,7 +54,22 @@ function installPlatformsFromConfigXML(cfg){ if(!targets || !targets.length

Re: adding push notifications to core plugins

2014-10-20 Thread Gorkem Ercan
On Thu, Oct 16, 2014 at 03:24:26PM -0700, Jesse wrote: > Core, or no core, the plugin already exists: > https://github.com/phonegap-build/PushPlugin/ > It works on iOS, Android, BB10, WP8, Windows8, and Amazon Fire OS. > > In my mind, the fact that every device uses it's own messaging service > mak

[GitHub] cordova-lib pull request: [CB-7820] cordova platfrom restore stops...

2014-10-18 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/106 [CB-7820] cordova platfrom restore stops if a platforms fails to restore handles restoration for each platform separately so that if one fails installation for others continues. Also makes

Re: Adding ability to add any platform on any OS

2014-10-18 Thread Gorkem Ercan
could be a useful feature but I do not think they are part of the main flow. Perhaps a --force flag can be added for this one? [1] https://issues.apache.org/jira/browse/CB-7820 -- Gorkem > -Original Message- > From: Josh Soref [mailto:jso...@blackberry.com] > Sent: Frida

Re: [GitHub] cordova-lib pull request: [CB-5989] - Default to $PROJECT_NAME-Inf...

2014-09-30 Thread Gorkem Ercan
Can you explain? This bug is not related to android, or use of project name Unless iOS name defaults to the lowest order character, there is a chance that a plist file brought in by a custom framework gets precedence and fails the configuration update for plist. On Mon, Sep 29, 2014 at 11:10 PM, J

[GitHub] cordova-lib pull request: [CB-5989] - Default to $PROJECT_NAME-Inf...

2014-09-29 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/95 [CB-5989] - Default to $PROJECT_NAME-Info.plist when searching for plist... If a Info.plist file is given with asterisk and there are multiple matches default to use the file for the project

PR for save/restore git & local

2014-09-29 Thread Gorkem Ercan
Hi, I have a PR[1] waiting for some love This one completes the save and restore for git urls and local directories. I would appreciate it if someone can take a look. Thanks, [1] https://github.com/apache/cordova-lib/pull/86

[GitHub] cordova-plugman pull request: update help for plugman info

2014-09-26 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-plugman/pull/79 update help for plugman info Make plugin id is needed clearer You can merge this pull request into a Git repository by running: $ git pull https://github.com/gorkem/cordova-plugman CB

[GitHub] cordova-lib pull request: [CB-4731] avoid duplicates when merging ...

2014-09-24 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/91 [CB-4731] avoid duplicates when merging arrays removes duplicate entries from arrays when modifying plist files You can merge this pull request into a Git repository by running: $ git

Re: Cordova-Create Module

2014-09-15 Thread Gorkem Ercan
] https://github.com/apache/cordova-lib/pull/86 -- Gorkem On Sun, Sep 14, 2014 at 10:00 AM, John M. Wargo wrote: > I recently created a node module called Cordova-create that takes care of > the typical developer new project workflow. > > It makes calls to create, then adds a set of platfor

[GitHub] cordova-lib pull request: url and local save/restore support

2014-09-14 Thread gorkem
GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/86 url and local save/restore support Implements save and restore for plugins that are coming from local file system or from a git repo. Also makes a change so that the dependency plugins are

Re: [DISCUSS] Plugins Release

2014-09-11 Thread Gorkem Ercan
Could you also take a look at this PR[1] and jira[2] for the contacts plugin it is a simple typo but it is ruining one of our demos. [1] https://github.com/apache/cordova-plugin-contacts/pull/45 [2] https://issues.apache.org/jira/browse/CB-7523 -- Gorkem On Wed, Sep 10, 2014 at 6:10 PM, Shazron

Re: Remove VERSION file from repos

2014-08-28 Thread Gorkem Ercan
Is there a JIRA to follow up on this change? -- Gorkem On Fri, Aug 29, 2014 at 3:16 AM, Steven Gill wrote: > Just a quick update to this. > > Coho now updates the version script for the following platforms: > Android > Amazon-fireos > Ubuntu > Firefoxos > Blackberry &

Re: cordova plugin save

2014-08-15 Thread Gorkem Ercan
of version requirements easily, these > are just suggestions to help simplify sharing, not rules. > - Ditto for platforms. > > Does that make sense? > > If we don't like the current app/local config, lets bring that up in a > different thread! > > -Michal >

  1   2   3   >