Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26214059
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26224327
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26214063
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26214642
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26213790
--- Diff: cordova-lib/src/PluginInfo.js ---
@@ -288,6 +293,19 @@ function PluginInfo(dirname) {
return ret
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26215219
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -293,58 +293,25 @@ function runUninstallPlatform(actions, platform,
project_dir, plugin_dir, plugin
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-lib/pull/175#issuecomment-76999272
Overall, impressed with the lack of significant impact.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25709236
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -238,7 +239,21 @@ module.exports = function plugin(command, targets,
opts
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25709825
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
return
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25709472
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -218,10 +205,18 @@ module.exports = {
/**
* @method initSettings
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25710017
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
return
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25722381
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
return
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25708820
--- Diff: cordova-lib/package.json ---
@@ -19,6 +19,7 @@
dependencies: {
bplist-parser: 0.0.6,
cordova-js: 3.8.0
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25709035
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -238,7 +239,21 @@ module.exports = function plugin(command, targets,
opts
Github user mmocny commented on commit fcf37d03d12301d26cb4bcbb0107b085325f40d6:
https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6#commitcomment-9663808
In cordova-lib/src/PluginInfo.js:
In cordova-lib/src/PluginInfo.js on line 317:
Nit
Github user mmocny commented on commit fcf37d03d12301d26cb4bcbb0107b085325f40d6:
https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6#commitcomment-9663850
In cordova-lib/src/plugman/createpackagejson.js:
In cordova-lib/src/plugman
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-browser/pull/6#issuecomment-71210975
I reviewed this in a previous iteration, and the latest changes look fine.
Since this feature does not exist yet anyway, and I'm not too concerned
about
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-browser/pull/6#issuecomment-71210993
..Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-browser/pull/6#issuecomment-71211172
(Josh I'll let you have the last word on landing, you have been running
this)
---
If your project is set up for it, you can reply to this email and have your
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22960109
--- Diff: node_modules/.bin/shjs ---
@@ -1 +1,15 @@
-../shelljs/bin/shjs
--- End diff --
For offline installs you still need to pre
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/6#discussion_r22968802
--- Diff: www/main.js ---
@@ -215,6 +237,12 @@ function createEnablerList() {
enablerList.appendChild(checkButtonBar
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/6#discussion_r22968690
--- Diff: www/main.js ---
@@ -225,6 +253,43 @@ function createEnablerList
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22957388
--- Diff: node_modules/.bin/shjs ---
@@ -1 +1,15 @@
-../shelljs/bin/shjs
--- End diff --
Why are node_modules even checked
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/4#discussion_r20823145
--- Diff: bin/templates/project/cordova/run ---
@@ -20,10 +20,33 @@
*/
var shell = require('shelljs'),
-spawn = require
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/4#discussion_r20823525
--- Diff: bin/templates/project/cordova/run ---
@@ -20,10 +20,33 @@
*/
var shell = require('shelljs'),
-spawn = require
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/4#discussion_r20823313
--- Diff: bin/templates/project/cordova/run ---
@@ -20,10 +20,33 @@
*/
var shell = require('shelljs'),
-spawn = require
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/4#discussion_r20823394
--- Diff: bin/templates/project/cordova/run ---
@@ -20,10 +20,33 @@
*/
var shell = require('shelljs'),
-spawn = require
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/4#discussion_r20823674
--- Diff: bin/templates/project/cordova/run ---
@@ -20,10 +20,33 @@
*/
var shell = require('shelljs'),
-spawn = require
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/4#discussion_r20839578
--- Diff: bin/templates/project/cordova/run ---
@@ -20,10 +20,33 @@
*/
var shell = require('shelljs'),
-spawn = require
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-lib/pull/62#issuecomment-61817080
Should we close this? Are we still hoping to make these changes? Did they
land with a different set of patches?
---
If your project is set up for it, you can reply
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/53#discussion_r18835133
--- Diff: docs/versioning-and-release-strategy.md ---
@@ -19,17 +19,100 @@
#
--
-# Versioning and Release Strategy
+# Versioning
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/53#discussion_r18836492
--- Diff: docs/versioning-and-release-strategy.md ---
@@ -19,17 +19,100 @@
#
--
-# Versioning and Release Strategy
+# Versioning
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/125#discussion_r18400602
--- Diff: framework/src/org/apache/cordova/PluginResult.java ---
@@ -80,6 +83,12 @@ public PluginResult(Status status, byte[] data, boolean
GitHub user mmocny opened a pull request:
https://github.com/apache/cordova-browser/pull/1
No longer need to kill Chrome to run
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmocny/cordova-browser update_chrome_run
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-browser/pull/1#issuecomment-56838479
..only tested on Mac.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/19#issuecomment-52340827
Was this PR not merged for a reason? Perhaps because it was missing a
subtask from https://issues.apache.org/jira/browse/CB-7086 ? I've modified
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/19#issuecomment-52341636
Wait, this was merged, it just didn't close itself, like
https://github.com/apache/cordova-plugin-device-motion/pull/16
---
If your project is set up
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/41#issuecomment-52351394
Looks good, but I didn't test on windows.
Additionally, we should write define/it helpers that accept a list of
platforms to include/exclude so
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-lib/pull/20#issuecomment-44489272
I haven't tested yet, but.. I like it!
@kamrik to also take a look, please.
---
If your project is set up for it, you can reply to this email and have your
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-cli/pull/176#issuecomment-43118417
May you please wrap this with a check for `--experimental` flag? I think
this is a useful feature, but I'm not convinced its in a form that we want to
keep forever
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-cli/pull/169#issuecomment-41454574
Looks great, lets ship it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41319318
Looks great. Will need to remember to update android's defaults.xml.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41320706
Awesome. One last tiny request: may we change the name of the preference
to AndroidLaunchMode?
---
If your project is set up for it, you can reply to this email
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41321647
The casing is actually insensitive, but the other preferences don't have
dashes, i.e. WebViewBounce
---
If your project is set up for it, you can reply
GitHub user mmocny opened a pull request:
https://github.com/apache/cordova-coho/pull/19
Update processing-pull-requests.md
Mention that coho list-pulls also provides commands to run
You can merge this pull request into a Git repository by running:
$ git pull https
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41326953
Thats simply an implicit API description that calls to `getPreference` must
pass in lowercase names ;) (Okay, so its probably just a bug).
---
If your project
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41327034
Shall I merge as is, or do you want to fix the ConfigParser?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41329099
Thanks! Pulled in (will take a few minutes for this PR to auto-close as
apache mirrors repo).
---
If your project is set up for it, you can reply to this email
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/169#discussion_r1194
--- Diff: src/create.js ---
@@ -124,9 +129,22 @@ module.exports = function create (dir, id, name, cfg) {
}
// Keep going
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/169#discussion_r11900183
--- Diff: src/create.js ---
@@ -146,11 +170,20 @@ module.exports = function create (dir, id, name, cfg)
{
} else
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/164#discussion_r11911266
--- Diff: src/metadata/android_parser.js ---
@@ -97,6 +108,29 @@ module.exports.prototype = {
}
}
+// Set
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/164#discussion_r11911288
--- Diff: src/metadata/android_parser.js ---
@@ -97,6 +108,29 @@ module.exports.prototype = {
}
}
+// Set
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/164#discussion_r11911345
--- Diff: src/metadata/android_parser.js ---
@@ -97,6 +108,29 @@ module.exports.prototype = {
}
}
+// Set
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/164#discussion_r11924705
--- Diff: src/metadata/android_parser.js ---
@@ -97,6 +108,29 @@ module.exports.prototype = {
}
}
+// Set
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/164#discussion_r11925400
--- Diff: src/metadata/android_parser.js ---
@@ -97,6 +108,29 @@ module.exports.prototype = {
}
}
+// Set
55 matches
Mail list logo
