Github user sgrebnov commented on the issue:
https://github.com/apache/cordova-windows/pull/194
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user sgrebnov commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/233
:+1: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user sgrebnov commented on the issue:
https://github.com/apache/cordova-docs/pull/625
:+1: lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user sgrebnov commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/223
Reviewed, LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sgrebnov commented on the issue:
https://github.com/apache/cordova-windows/pull/187
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user sgrebnov commented on the issue:
https://github.com/apache/cordova-docs/pull/621
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user sgrebnov commented on the issue:
https://github.com/apache/cordova-docs/pull/622
Reviewed :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/622#discussion_r70650575
--- Diff: www/_posts/2016-07-13-cordova-windows-4.4.1.md ---
@@ -0,0 +1,37 @@
+---
+layout: post
+author:
+name: Vladimir Kotikov
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/622#discussion_r70650375
--- Diff: www/_posts/2016-07-13-cordova-windows-4.4.1.md ---
@@ -0,0 +1,37 @@
+---
+layout: post
+author:
+name: Vladimir Kotikov
Github user sgrebnov commented on the issue:
https://github.com/apache/cordova-windows/pull/184
Reviewed, LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-ios/pull/213#issuecomment-211430445
:+1: lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59777381
--- Diff: lib/paramedic.js ---
@@ -105,10 +116,23 @@ ParamedicRunner.prototype.checkPlatformRequirements =
function() {
logger.normal
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59776906
--- Diff: main.js ---
@@ -25,7 +25,12 @@ var USAGE = "Error missing args. \n" +
"--useTunnel : (optional) use tunneling i
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59327252
--- Diff: lib/paramedic.js ---
@@ -0,0 +1,231 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59327011
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,162 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59326850
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,162 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/420#discussion_r59195085
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -157,6 +157,7 @@ module.exports = function plugin(command, targets,
opts
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59072232
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,141 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59005735
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,141 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59003845
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,141 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59003645
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,141 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59002757
--- Diff: paramedic-plugin/paramedic.js ---
@@ -0,0 +1,93 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59002202
--- Diff: paramedic-plugin/paramedic.js ---
@@ -0,0 +1,93 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59001110
--- Diff: lib/utils/execWrapper.js ---
@@ -0,0 +1,39 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59001026
--- Diff: lib/paramedic.js ---
@@ -0,0 +1,232 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58692210
--- Diff: lib/paramedic.js ---
@@ -0,0 +1,205 @@
+#!/usr/bin/env node
+
+var exec = require('./utils').exec,
+shell
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58692216
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,122 @@
+var Q = require('q'),
--- End diff --
Done
---
If your project is
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58688217
--- Diff: paramedic-plugin/paramedic.js ---
@@ -0,0 +1,74 @@
+var io = cordova.require('cordova-plugin-paramedic.socket.io');
--
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/159#issuecomment-202743738
Reviewed and verified on sample config/images :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-docs/pull/558#issuecomment-197379532
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-197526519
@dblotsky We don't have manual tests - we have buttons demonstrating api
calls (for both api classes - with and without user interaction), ther
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r56317001
--- Diff: appium-tests/helpers/contactsHelper.js ---
@@ -0,0 +1,222 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r56311100
--- Diff: appium-tests/helpers/contactsHelper.js ---
@@ -0,0 +1,222 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/400#issuecomment-188757069
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/148#issuecomment-184521979
Hey @andorman, the PR's source and destination branches are incorrect - you
can see there are many unrelated commits/changes here.
---
If your proje
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-183633182
Tested and merged, @biasmv Marco - thx for the patch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-182766890
I'll test new version and merge later today
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/101#issuecomment-181528137
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/126#issuecomment-181525114
I think we should close this PR as this won't work on other platforms and
you can also do the following:
```
ref.executeScript(
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/149
CB-10538 cordova-plugin-inappbrowser timeout issue
Switched to Apache Community home page as test page and increased timeout
just in case (looks like there are some scripts on
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/147#issuecomment-181266293
Thx for review - updated, tested and merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/147#issuecomment-180319788
pls review updated version
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/137#issuecomment-179900260
I see, merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/137#issuecomment-179896028
Is it still actual? - Looks like we have dropped iOS 7.0 support - see
CB-9726 Update minimum Deployment Target to iOS 8.0
(https
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-docs/pull/486#issuecomment-179835728
Updated, @csantanapr thx for review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-docs/pull/486
CB-10505 Adds cordova-plugin-inappbrowser 1.2.1 release blog post
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/377#issuecomment-179812613
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-docs/pull/485#issuecomment-179789660
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/147#issuecomment-179787521
@wolframkriesing please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/147
CB-10395 InAppBrowser's WebView not storing cookies reliable
https://issues.apache.org/jira/browse/CB-10395
You can merge this pull request into a Git repository by ru
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/71#issuecomment-179782033
@mysegfault Thank you for path - this has been fixed similar way w/ small
change by the following commit, pls close this PR.
https
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/131#issuecomment-179780091
@gaoyuan123 - thank you for the pach, I see that this change is already in
repo master, please close this PR
---
If your project is set up for
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/146
CB-7500 executeScript with callback kills/blurs inAppBrowser window
https://issues.apache.org/jira/browse/CB-7500
You can merge this pull request into a Git repository by
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-medic/pull/70#issuecomment-179332769
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/374#issuecomment-179263903
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/147#issuecomment-179031723
Reviewed changes, :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/132#issuecomment-179030795
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-176740857
Here is my +1, but it will be great if someone else can take a look on this
change as well.
---
If your project is set up for it, you can reply to this email
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-176733241
I've tried this approach and it seems to work very well. The only two
things I've noticed are:
1. Generated `Include` is absolute, this could be
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145#issuecomment-176320293
setTimeout is required to support the following scenario. On ios, android
and other platforms functionality creates InAppBrowser on native side
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145#issuecomment-176253919
Use the following url to review proposed changes w/o whitespace:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145/files?w=1
---
If
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145
InAppBrowser bugfixing on Windows: CB-10451, CB-10452, CB-10454
CB-10451 InAppBrowser: loadstart event is not triggered on Windows
CB-10452 InAppBrowser: 'exit'
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/144#issuecomment-176206237
This fix is similar to what @mysegfault proposed below. I've just
added logic to prevent the dialog for being dismissed twice.
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/144
CB-6702 InAppBrowser hangs when opening more than one instance
https://issues.apache.org/jira/browse/CB-6702
You can merge this pull request into a Git repository by running
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/143
CB-10456 InAppBrowser is not closed if I close it programmatically on
Android
https://issues.apache.org/jira/browse/CB-10456
This happens due to race condition: open
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-android/pull/254#issuecomment-176075769
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/127#issuecomment-176041352
@alexbuijs thank you for proposed patch, but we can't remove this line as
it is required for InAppBrowser to work correct when app is emu
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/142
CB-10441 Add auto tests for InAppBrowser plugin
https://issues.apache.org/jira/browse/CB-10441
Added the following unit tests:
1. `cordova.InAppBrowser.open
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-175442601
Hi @biasmv - I'll take a look and respond today or tomorrow, thank you for
clarification
---
If your project is set up for it, you can reply to this
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-android/pull/252#issuecomment-175033258
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/75#issuecomment-174954242
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/157#issuecomment-174944041
You can review PR w/o space changes using `?w=1` param:
https://github.com/apache/cordova-plugin-file/pull/157?w=1
---
If your project is set up for
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/157
CB-10419 cordova-plugin-file 4.0.0 error with browserify workflow
https://issues.apache.org/jira/browse/CB-10419
Fixed browserify for core platforms and browser
You can merge
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/141#issuecomment-174916119
Use `?w=1` param to ignore space changes:
https://github.com/apache/cordova-plugin-inappbrowser/pull/141/files?w=1
---
If your project is
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/141
CB-10428 Fix syntax error when browserifying inAppBrowser plugin
https://issues.apache.org/jira/browse/CB-10428
Wrapped module in anonymous function
You can merge
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-174454890
@nikhilkh - looks like the doc describing `target` support on windows and
corresponding example exist in dev version only.We should make it released.
---
If
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-174453773
I like the idea, but I think we will miss `target` attribute support as
resource-file will be always copied to root (pls correct me if I'm wrong). In
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/140#issuecomment-173476489
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/74#issuecomment-171911919
:+1: lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-windows/pull/138
CB-10234 Better error message when Windows10 requires 'arch' flag
This patch adds the following error message:
![image](https://cloud.githubusercontent.com/assets/98158
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-windows/pull/137
CB-10356 "npm install" fails for cordova-windows
https://issues.apache.org/jira/browse/CB-10356
You can merge this pull request into a Git repository by running:
$ git
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/136#issuecomment-171542813
looks great, thank you a lot - will merge after fixing core windows install
issue.
PS. Can you also take a look if we can auto test this case please
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171207462
PS. Kudos to @riknoll for very good code documentation
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171206449
Manual tests should be valid, I used them while testing (but I used only
real devices while testing).
The code looks good so I'm going to v
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/129#issuecomment-170513142
Re-based on top of master and merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/135#issuecomment-169325776
lgtm :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/134#issuecomment-168987357
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/39#issuecomment-168915147
:+1: lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/65#issuecomment-168904893
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/65#issuecomment-168607399
Actually, starting from Android M we now have Permissions prompt dialog so
those tests can't be run in silent mode so we should skip them as
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/65#issuecomment-168605706
:+1: lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/64#issuecomment-168605696
:+1: lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/42#issuecomment-167990042
lgtm!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/43#issuecomment-167989868
lgtm!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/62#discussion_r48600533
--- Diff: www/android/geolocation.js ---
@@ -52,7 +62,20 @@ module.exports = {
var geo =
cordova.require('co
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/63#discussion_r48600376
--- Diff: www/android/geolocation.js ---
@@ -38,21 +39,29 @@ module.exports = {
},
watchPosition: function
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/63
CB-10278 geolocation watchPosition doesn't return watchID string
https://issues.apache.org/jira/browse/CB-10278
You can merge this pull request into a Git repository by ru
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/57#issuecomment-167757946
@ochakov could you please create associated JIRA issue or post repro steps
here.
http://cordova.apache.org/contribute/issues.html
I
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/62
CB-10277 Error callback should be called w/ PositionError if deny location
access
https://issues.apache.org/jira/browse/CB-10277
You can merge this pull request into a Git
1 - 100 of 483 matches
Mail list logo
