Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-02 Thread Shazron
x them. The build will be broken > in the CI until it is fixed so probably marking them as pending is the > better option. > > > @purplecabbage > risingj.com > > On Tue, Dec 1, 2015 at 10:42 PM, Shazron <shaz...@gmail.com> wrote: > >> Couldn't wait. All fi

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-02 Thread Shazron
m into full urls, and they will have > file:// in the final path used? > This means that xhr "folder1/data.json" works, but xhr > "../someparent/data.json" doesn't? > > > On Wed, Dec 2, 2015 at 4:52 AM Shazron <shaz...@gmail.com> wrote: > >> Marked t

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-02 Thread Shazron
Regarding Platform API, Vladimir Kotikov and Sergey Grebnov agree in the PR comments that the changes can go in to cordova-ios-4.x: https://github.com/apache/cordova-ios/pull/176 On Wed, Dec 2, 2015 at 5:38 PM, Shazron <shaz...@gmail.com> wrote: > Also, check footnote 3 above. > &

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

2015-12-01 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-161124103 What do you guys think of merging this in for cordova-ios 4.0 release? I'm still working on CB-7287 mobile-spec failures (3) for WKWebView, but the platform

[DISCUSS] cordova-ios-4.x release (for real)

2015-12-01 Thread Shazron
The board is almost clear [1]. UIWebView mobile-spec passes, just waiting for INFRA-10831 [2] for the file-transfer tests. Ditto for WKWebView, it essentially just fails two tests, which are expected [3] (filed a feature request issue [4] for local xhr loading, if needed). Platform API [4] could

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-01 Thread Shazron
still? On Tue, Dec 1, 2015 at 9:49 PM, Shazron <shaz...@gmail.com> wrote: > Thanks! - yeah after I posted it, of course I realized it is all open > source (duh) and I can run a local server or throw it on a > digitalocean instance or something :) > I'll do that tomorrow... >

Re: [DISCUSS] cordova-ios-4.x release (for real)

2015-12-01 Thread Shazron
> > Oh by the way GREAT PROGRESS !!! and I cheers , I'm having a beer now. > > > > On Tue, Dec 1, 2015 at 8:38 PM Shazron <shaz...@gmail.com> wrote: > >> The board is almost clear [1]. >> >> UIWebView mobile-spec passes, just waiting for INFRA-108

Re: "target" attribute ignored on iOS when installing a Cordova plugin

2015-11-26 Thread Shazron
Please file an issue at: http://issues.apache.org/jira/browse/CB ... so it can be tracked and evaluated by the devs, and you can be notified. Sign up here: https://issues.apache.org/jira/secure/Signup!default.jspa Thanks! On Thu, Nov 26, 2015 at 12:29 PM, Maxime Alexandre

Re: [DISCUSS] Revert Cordova plugins to work with default pinned versions

2015-11-25 Thread Shazron
+1 what Steve said. Let's make sure all stakeholders take note of the discuss threads for plugins, not just platforms, in the future so we can nip this in the bud. "Cordova should not be backtracking releases due to downstreams" -> Steve's cli pinning proposal would solve the VS scenario in the

Re: [DISCUSS] cordova-ios 4.0.0 release

2015-11-18 Thread Shazron
The board is almost clear -- now to test this for a bit before it's ready for primetime. https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=76 On Mon, Oct 26, 2015 at 2:21 PM, Shazron <shaz...@gmail.com> wrote: > Thanks guys! > I've commented on the PR, there is one

Re: Create cordova app using Angular Js and Sql Lite

2015-11-18 Thread Shazron
Sign up for slack at slack.cordova.io On Wed, Nov 18, 2015 at 5:20 PM, Parashuram N wrote: > Hey Wil, > > While this is not a mailing list about developing apps using Cordova, but > about developing Cordova itself, I am sure you would find good responses to > your

Re: Intellisense and Debugging support for Cordova apps with VSCode

2015-11-18 Thread Shazron
Watched the video - this is great! Saw the debugging for Android, not sure if iOS debugging is on the radar? Having a spec for autocomplete for third-party plugins to implement would be sweet as well. On Wed, Nov 18, 2015 at 9:41 AM, Parashuram N wrote: > I have been

[GitHub] cordova-lib pull request: CB-9569 - Support and

2015-11-16 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/312#issuecomment-157084235 The default configuration is ``. The ideal way is to remove that tag, and it shouldn't alter any ATS entries, but right now it adds it if it is missing

[GitHub] cordova-plugin-whitelist pull request: Update whitelist version to...

2015-11-16 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/14#issuecomment-157020871 PR Not needed anymore since cordova-ios-4.x will have need of this plugin. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-labs pull request: CB-51 API: FileTransfer - Support PUT M...

2015-11-16 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-labs/pull/8#issuecomment-157138297 I'm on it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: File-transfer on cordova-vm & CB-51 API: FileTransfer - Support PUT Method

2015-11-16 Thread Shazron
Done On Mon, Nov 16, 2015 at 1:25 AM, Sergey Shakhnazarov (Akvelon) wrote: > Hello guys, > > Can anybody with corresponding access please publish the file-transfer test > server with these updates? > https://github.com/apache/cordova-labs/pull/8 > > The change is adding

Re: File-transfer on cordova-vm & CB-51 API: FileTransfer - Support PUT Method

2015-11-16 Thread Shazron
Sorry I thought it was still on nodejitsu per the README. Steve is publishing it on the actual On Mon, Nov 16, 2015 at 11:24 AM, Shazron <shaz...@gmail.com> wrote: > Done > > On Mon, Nov 16, 2015 at 1:25 AM, Sergey Shakhnazarov (Akvelon) > <v-ses...@microsoft.com> wrote:

[GitHub] cordova-labs pull request: CB-51 API: FileTransfer - Support PUT M...

2015-11-16 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-labs/pull/8#issuecomment-157142610 Nodejitsu updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: Plugin Audit 2015

2015-11-13 Thread Shazron
I don't agree with keyboard being in core. It's not "required" on ios, it's just a cosmetic change, and its pretty hacky to get right. With iPad and iPad Pro's new enhanced keyboards, this will be a bigger nightmare to maintain thus I am strongly against this. With iOS 7 and greater's flat UI,

Re: [DISCUSS] CLI Templates

2015-11-13 Thread Shazron
Well, we could deprecate --copy-from, and alias --template to it. But we shouldn't have both, it should just be one implementation. On Fri, Nov 13, 2015 at 10:45 AM, Carlos Santana wrote: > In some way we we are enhancing --copy-from > > I'm OK to the copy blindly even

Re: [DISCUSS] CLI Templates

2015-11-13 Thread Shazron
Not liking the idea to add another dependency like yeoman, definitely not :/ Cordova should be lean... Stepping back, since this is clearly an enhancement to --copy-from -- why not just update --copy-from's implementation? The proposal says "it copies everything from the template including

Re: Introduction per contribution guidelines

2015-11-11 Thread Shazron
Welcome Toni! If you need help, feel free to ping us also on http://slack.cordova.io On Wed, Nov 11, 2015 at 8:18 AM, Zombie protection wrote: > I assume I am just supposed to send a small introduction but this got > pretty long before I realized it, I hope that

[GitHub] cordova-ios pull request: CB-9972 - Remove iOS whitelist

2015-11-11 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/181 CB-9972 - Remove iOS whitelist You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios CB-9972 Alternatively you can review

[GitHub] cordova-plugin-whitelist pull request: CB-9972 - Remove iOS whitel...

2015-11-11 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-whitelist/pull/16 CB-9972 - Remove iOS whitelist You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-plugin-whitelist CB-9972

[GitHub] cordova-mobile-spec pull request: CB-9972 - Remove iOS whitelist

2015-11-11 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/133 CB-9972 - Remove iOS whitelist You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-mobile-spec CB-9972 Alternatively

Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

2015-11-11 Thread Shazron
sanchez <jcesarmob...@gmail.com> wrote: > Ahh, missed that, thanks Shazron! > > 2015-11-11 1:39 GMT+01:00 Shazron <shaz...@gmail.com>: > >> This is handled by this: >> >> https://github.com/apache/cordova-ios/tree/master/CordovaLib/Classes/Private/Plugi

[GitHub] cordova-ios pull request: CB-9883

2015-11-10 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/179#issuecomment-155613091 Good point, didn't think of that scenario. Ideally each WebView engine, when activated, should inject its own bridge. This would solve this scenario. We

Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

2015-11-10 Thread Shazron
sn't include that method, so I don't think removing > the plugin will break anything, but is it already broken? > > or we should use the inAppBrowser plugins with _system to open other apps > instead of the whitelist? > > > > > 2015-11-10 3:18 GMT+01:00 Shazron <shaz

Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

2015-11-09 Thread Shazron
looks like > CSP is the level of security it will get and that's fine. > > +1 to move forward > > - Carlos > @csantanapr > >> On Nov 9, 2015, at 8:13 PM, Shazron <shaz...@gmail.com> wrote: >> >> Any updates on your end Carlos? Anyone else have any conc

Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

2015-11-09 Thread Shazron
>> > >> > @purplecabbage >> > risingj.com >> > >> >> On Tue, Nov 3, 2015 at 5:35 PM, Shazron <shaz...@gmail.com> wrote: >> >> >> >> BUMP. This is important, and is causing a lot of pain for our users. >> >> For

Re: Native vs. File URIs

2015-11-09 Thread Shazron
t; type (i.e. >> always using content or always using file). >> >> Richard >> >> -Original Message- >> From: Shazron [mailto:shaz...@gmail.com] >> Sent: Friday, November 6, 2015 5:52 PM >> To: dev@cordova.apache.org >> Subject

[GitHub] cordova-ios pull request: CB-9883

2015-11-09 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/179#issuecomment-155253981 It's the Bridge of IFrame-Dûm! Good work Olórin of the Cabbages Purple --- If your project is set up for it, you can reply to this email and have your reply

Re: Native vs. File URIs

2015-11-06 Thread Shazron
I always thought a native URI was if the image was retrieved from the ALAssetsLibrary (Photos Album). https://developer.apple.com/library/ios/documentation/AssetsLibrary/Reference/ALAssetsLibrary_Class/ and the file URI was the image we dumped into tmp. On Fri, Nov 6, 2015 at 11:43 AM, Richard

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-11-05 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-154149943 Thanks. An update on this. I still want to get this in, but I will have to postpone it unless someone else wants to take this up right now. With the merge/rebase

Re: [DISCUSS] Removal of unused iOS bridges

2015-11-05 Thread Shazron
I will integrate this later today. On Wed, Nov 4, 2015 at 2:18 PM, Carlos Santana <csantan...@gmail.com> wrote: > LGTM left a question. > > On Tue, Nov 3, 2015 at 6:36 PM Shazron <shaz...@gmail.com> wrote: > >> Sent a PR https://github.com/apache/cordova-ios/pull/17

[GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges

2015-11-04 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/178#issuecomment-153908591 IFRAME_NAV has always worked from the beginning and has been the default, the other bridge modes are experimental to try to gain speed, but flakey -- like

Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

2015-11-04 Thread Shazron
Fixed deficiencies in the flowcharts, updated: https://github.com/shazron/cordova-discuss/blob/ios-remove-whitelist/proposals/ios-whitelist-removal.md On Wed, Nov 4, 2015 at 2:42 PM, Carlos Santana <csantan...@gmail.com> wrote: > currently evaluating with some other folks at work, wil

Re: Question about versioning

2015-11-04 Thread Shazron
When > I blog on this, I'm going to quote you so folks (hopefully) know that > things will be different later. > > On Wed, Nov 4, 2015 at 11:07 AM, Shazron <shaz...@gmail.com> wrote: >> Here's the [DISCUSS] thread for docs going forward: >> http://markmail.org/message/4

Re: Question about versioning

2015-11-04 Thread Shazron
1) cordova platform check (should be in the help) 2) don't think there is anything for plugins 3) The version has not been updated. There was talk at the F2F to better update it wrt versions and the dropdown On Wed, Nov 4, 2015 at 8:34 AM, Raymond Camden wrote: > I'm

Re: Question about versioning

2015-11-04 Thread Shazron
n cannot >> be determined >> ios @ 3.6.3; current did not install, and thus its version cannot be >> determined >> >> 3) Will it match the CLI version? >> >> On Wed, Nov 4, 2015 at 10:43 AM, Shazron <shaz...@gmail.com> wrote: >> > 1) cordova platform

Re: Question about versioning

2015-11-04 Thread Shazron
rent did not install, and thus its version cannot be > determined > > 3) Will it match the CLI version? > > On Wed, Nov 4, 2015 at 10:43 AM, Shazron <shaz...@gmail.com> wrote: >> 1) cordova platform check >> (should be in the help) >> >> 2) don'

[GitHub] cordova-ios pull request: CB-9836 Add .gitattributes to prevent CR...

2015-11-03 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/177#issuecomment-153459658 looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges

2015-11-03 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/178 CB-9883 - Remove unused iOS bridges Please review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios CB-9883

Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

2015-11-03 Thread Shazron
BUMP. This is important, and is causing a lot of pain for our users. For example: https://github.com/jessemonroy650/top-phonegap-mistakes/blob/master/the-whitelist-system.md On Mon, Nov 2, 2015 at 5:38 PM, Shazron <shaz...@gmail.com> wrote: > To view contents of the PR easily

Re: [DISCUSS] Removal of unused iOS bridges

2015-11-03 Thread Shazron
Barham <tim.bar...@microsoft.com> >> > wrote: >> > > +1 >> > > >> > > -Original Message- >> > > From: Steven Gill [mailto:stevengil...@gmail.com] >> > > Sent: Tuesday, October 27, 2015 5:11 PM >> > > To: de

Re: [REVIEW] Cordova-ios 3.9.2 blog post

2015-11-02 Thread Shazron
2 minor grammar issues, but besides that looks good to me. On Mon, Nov 2, 2015 at 4:15 AM, Vladimir Kotikov (Akvelon) wrote: > Please review and comment it here: > https://github.com/apache/cordova-docs/pull/408 > > - > Best regards, Vladimir >

[DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

2015-11-02 Thread Shazron
https://github.com/cordova/cordova-discuss/blob/master/proposals/ios-whitelist-removal.md Comment here or there, etc. I've included flowcharts... tldr; remove the whitelist in cordova-ios-4.x. we are not good at security, let the OS handle it.

Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

2015-11-02 Thread Shazron
PR sent: https://github.com/cordova/cordova-discuss/pull/27 On Mon, Nov 2, 2015 at 5:21 PM, Shazron <shaz...@gmail.com> wrote: > Sorry everyone -- I'm structuring it as a PR and will revert my > commits. Will be easier to comment that way > > On Mon, Nov 2, 2015 at 5:05

Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

2015-11-02 Thread Shazron
To view contents of the PR easily: https://github.com/shazron/cordova-discuss/blob/da7af6606848a1b7d96f4d5ee5402360bf5fd53c/proposals/ios-whitelist-removal.md On Mon, Nov 2, 2015 at 5:36 PM, Shazron <shaz...@gmail.com> wrote: > PR sent: https://github.com/cordova/cordova-discus

Re: [DISCUSS] Cordova-ios 3.9.2 release

2015-10-30 Thread Shazron
itself. On Fri, Oct 30, 2015 at 10:10 AM, Shazron <shaz...@gmail.com> wrote: > +1 > > On Fri, Oct 30, 2015 at 4:40 AM, Vladimir Kotikov (Akvelon) > <v-vlk...@microsoft.com> wrote: >> Created this thread to separate discussions for 3.9.2 and 4.0.0 releases >> I'

Re: [VOTE] iOS 3.9.2 release

2015-10-30 Thread Shazron
+1 On Fri, Oct 30, 2015 at 1:09 PM, Vladimir Kotikov (Akvelon) wrote: > Please review and vote on this 3.9.2 iOS Release by replying to this email > (and keep discussion on the DISCUSS thread) > > > > Release issue: https://issues.apache.org/jira/browse/CB-9912 > > > >

Re: [DISCUSS] Cordova-ios 3.9.2 release

2015-10-30 Thread Shazron
+1 On Fri, Oct 30, 2015 at 4:40 AM, Vladimir Kotikov (Akvelon) wrote: > Created this thread to separate discussions for 3.9.2 and 4.0.0 releases > I'm going to start 3.9.2 release today if no one have any objections. > > - > Best regards, Vladimir > >

[GitHub] cordova-lib pull request: CB-9902 - cordova run --list broken

2015-10-29 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/335 CB-9902 - cordova run --list broken You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-lib CB-9902 Alternatively you can

Re: [DISCUSS] Tools Release

2015-10-29 Thread Shazron
Breakage: https://issues.apache.org/jira/browse/CB-9902 Sent a PR: https://github.com/apache/cordova-lib/pull/335 On Thu, Oct 29, 2015 at 12:46 PM, Carlos Santana wrote: > Thanks Alex and Tim ! > > - Carlos > @csantanapr > >> On Oct 29, 2015, at 2:50 PM, Tim Barham

[GitHub] cordova-plugin-device-motion pull request: CB-9369 Return error wh...

2015-10-29 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/38#issuecomment-152372394 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios pull request: Prepare cordova-ios 3.9.2 release

2015-10-28 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/175#issuecomment-151940801 @vladimir-kotikov Sorry I had to update this, it was wrong: https://github.com/apache/cordova-ios/commit/29f10b475414e84121e2e77f79095b6bccdc6b35 --- If your

Re: [DISCUSS] Removing blog posts repo

2015-10-28 Thread Shazron
+1 On Wednesday, October 28, 2015, Steven Gill wrote: > Sounds good to me. > > For reference, we are going to shut down > https://github.com/cordova/apache-blog-posts in favor of > https://github.com/apache/cordova-docs. > > On Wed, Oct 28, 2015 at 5:25 PM, Dmitry

[GitHub] cordova-ios pull request: Prepare cordova-ios 3.9.2 release

2015-10-27 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/175#issuecomment-151607089 I think that's all that's needed. Thanks @vladimir-kotikov ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-10-27 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-151667700 Unfortunately even though the tests pass -- there are too many conflicts with the master branch. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-10-27 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-151667847 Try rebasing your branch with cordova-lib/master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

Re: [DISCUSS] Removal of unused iOS bridges

2015-10-27 Thread Shazron
Filed https://issues.apache.org/jira/browse/CB-9883 On Tue, Oct 27, 2015 at 5:00 PM, Shazron <shaz...@gmail.com> wrote: > ## DESCRIPTION > > We have 7 bridges in iOS: > https://github.com/apache/cordova-ios/blob/c0fe92d6c0b91efa2da0d5cec78e0baa95ce55c9/cordova-js-s

[GitHub] cordova-coho pull request: Adding docs around JIRA issue triage

2015-10-27 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-coho/pull/97#issuecomment-151675993 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Intro

2015-10-27 Thread Shazron
Welcome! Let us know if you need any help getting up to speed. On Tue, Oct 27, 2015 at 5:07 PM, Jason Ginchereau wrote: > Hello, > > I'm a developer at Microsoft, where I've recently started working with the > Cordova runtime team here. I have experience with Windows,

[GitHub] cordova-ios pull request: CB-9685 Enhanced the fix for the iOS9 lo...

2015-10-26 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/174#issuecomment-151308616 The only thing new is 371c136315b0c4f481ee479242dd769c4280b932 correct? --- If your project is set up for it, you can reply to this email and have your reply

Re: [DISCUSS] cordova-ios 4.0.0 release

2015-10-26 Thread Shazron
permissions to create a shared queries, so we just tagged issues with > label. You can find all tagged issues using a query [2]. > > --- > [1] https://github.com/apache/cordova-ios/pull/175 > [2] > https://issues.apache.org/jira/browse/CB-9729?jql=labels%20%3D%20cordova-ios-3.9.2

Re: [DISCUSS] CocoaPods dependencies for iOS plugins

2015-10-26 Thread Shazron
> that engine tag doesn't stop the whole plugin from being added on a > windows/linux machine. > > On Fri, Oct 23, 2015 at 8:33 PM Shazron <shaz...@gmail.com> wrote: > >> Send PR's or comment on a line in a commit. I think. >> >> Not sure what you mean -- th

[GitHub] cordova-ios pull request: Prepare cordova-ios 3.9.2 release

2015-10-26 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/175#issuecomment-151285278 This should make it in as well: https://issues.apache.org/jira/browse/CB-9721 --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-ios pull request: CB-9685 Enhanced the fix for the iOS9 lo...

2015-10-26 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/174#issuecomment-151310777 Pulled in. Can you add docs too, please? Thanks :) Here: https://github.com/apache/cordova-docs/blob/master/www/docs/en/edge/guide/platforms/ios/config.md

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-10-26 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-151321669 Unfortunately I can't take this patch in as is. The apple watch sample extension contains source files, which are not Apache Licensed: projects/ios-apple-watch

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-10-26 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-151323347 11 failing tests: ``` Failures: 1) ios project handler installation of elements should call into xcodeproj's addSourceFile appropriately

[GitHub] cordova-plugin-file-transfer pull request: Added note about iOS9 a...

2015-10-26 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/103#issuecomment-151282089 With the next CLI release when it comes out, this PR will not be relevant. --- If your project is set up for it, you can reply to this email

Re: [DISCUSS] Cordova-Android 5.0.x

2015-10-23 Thread Shazron
+1 On Thu, Oct 22, 2015 at 10:38 AM, Joe Bowser wrote: > BUMP! I'd like to start the vote thread on Monday! > > On Tue, Oct 20, 2015 at 10:01 AM, Joe Bowser wrote: > >> Hey >> >> I would like to release Cordova-Android 5.0.x soon so that I can then move >>

Re: [DISCUSS] Removing Tizen From Support Matrix

2015-10-23 Thread Shazron
+1 On Thu, Oct 22, 2015 at 1:39 PM, Dmitry Blotsky wrote: > Hey folks, > > A few weeks back I heard someone mention that we should strike Tizen from > this matrix: > http://cordova.apache.org/docs/en/5.1.1/guide/support/index.html. Should I > proceed with that? Should

Re: [DISCUSS] cordova-ios 4.0.0 release

2015-10-23 Thread Shazron
s9QZXYw%3d > [2] > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fstackoverflow.com%2fsearch%3fq%3d%2522XCODE%2b7%2522%2b%255Bcordova%255D=01%7c01%7cnikhilkh%40microsoft.com%7cea1259c06ea744fff37e08d2da213c72%7c72f988bf86f141af91ab2d7cd011db47%7c1=PBGhQ3sro1fE6Ft3ZOHBv3RkL

[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

2015-10-23 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42854285 --- Diff: src/ios/CDVFileTransfer.m --- @@ -552,6 +552,8 @@ - (void)connectionDidFinishLoading:(NSURLConnection*)connection

[GitHub] cordova-plugin-file-transfer pull request: Added note about iOS9 a...

2015-10-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/103#issuecomment-150545749 The next version of the CLI will automatically convert `access` and `allow-navigation` tags to the correct ATS directives. If you are using

Re: [DISCUSS] CocoaPods dependencies for iOS plugins

2015-10-23 Thread Shazron
but I >> assume the same. Vladimir would know about where that code will live after >> the refactor. >> >> Engine + framework tag looks good. Engine tag will have to be extended to >> actually fetch cocoapods + nuget I imagine. >> >> On Mon, Oc

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-150498299 Sounds good, can you get the code in a new pull request and reference the same CB-9685? I'll re-open it once you do so. --- If your project is set up for it, you

Re: [DISCUSS] cordova-ios 4.0.0 release

2015-10-20 Thread Shazron
ncerns > > IBM MobileFirst was affected only by the API change of using webviewengine > now but that's so far the only major change > > In the kaban board for 4.0 there are some issues I consider nice to have that > are not blockers to get a 4.0 out for iOS if we get closed to the ios9

Re: Windows platform and cordova-plugin-file

2015-10-19 Thread Shazron
Correction: cordova.slack.com (not cordova.slack.io) On Fri, Oct 16, 2015 at 10:00 AM, Steven Gill wrote: > Hey Alex! > > Welcome! > > I don't have a ton of experience with the file plugin but I can definitely > guide you and answer your questions + merge PRs you have

[GitHub] cordova-ios pull request: Allow about:blank to fix twitter embed

2015-10-19 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/172#issuecomment-149306917 This PR is unusable since it has conflicts. Please rebase against master, not the 3.9.x branch Note that it should be "clean" in that it should on

Re: [DISCUSS] Jira triage

2015-10-19 Thread Shazron
Thanks Steve. Three recommendations below. A. I recommend a "Platform" pre-fix for platform issues. ie rename "iOS", "Android" etc to "Platform iOS", "Platform Android" (like plugins have a prefix of "Plugin" already). This however would not prevent people from assigning these components to

Re: [DISCUSS] Curating Apps

2015-10-19 Thread Shazron
I like the idea of putting the onus on the developer to actually do some marketing and selling of their app to us :) We should have that minimum bar that they need to pass, I like Ryan's listed criteria. On Mon, Oct 19, 2015 at 11:11 AM, Ryan J. Salva wrote: > The original

Re: [DISCUSS] CocoaPods dependencies for iOS plugins

2015-10-19 Thread Shazron
This is not a platform specific issue, at least for cordova-ios, and is the domain of the cordova-lib/cli currently (I think the cordova-lib re-factor changes this?) There will be a cordova-discuss doc, but the gist of it is: The above use existing documented attributes for both

Re: [DISCUSS] CocoaPods dependencies for iOS plugins

2015-10-19 Thread Shazron
framework tag looks good. Engine tag will have to be extended to > actually fetch cocoapods + nuget I imagine. > > On Mon, Oct 19, 2015 at 4:23 PM, Shazron <shaz...@gmail.com> wrote: > >> This is not a platform specific issue, at least for cordova-ios, and >> i

Re: [iOS] Submitting Apps to Store built with XCode7 [ITMS-90474, ITMS-90475]

2015-10-13 Thread Shazron
I believe these situations have been handled: 1. https://issues.apache.org/jira/browse/CB-9729 2. https://issues.apache.org/jira/browse/CB-9679 On Tue, Oct 13, 2015 at 11:47 AM, Parashuram N wrote: > We recently ran into a problem where apps build with XCode 7 have

[GitHub] cordova-lib pull request: CB-9758 Mobilespec crashes adding plugin...

2015-10-12 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/318#issuecomment-147449612 Great, since you've identified the stuff that crashes, you should add tests for them in the jasmine tests (there are already tests for other cases). --- If your

[GitHub] cordova-lib pull request: CB-9758 Mobilespec crashes adding plugin...

2015-10-12 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/318#issuecomment-147454277 No, its correct. The two tags are different. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-lib pull request: CB-9758 Mobilespec crashes adding plugin...

2015-10-12 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/318#issuecomment-147457505 They do the same thing, almost. The only thing different is access tags do not handle wildcards in the schemes. I've opted to keep them separate for completeness

[GitHub] cordova-ios pull request: CB-9719 set allow_non_modular_includes t...

2015-10-12 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/171#issuecomment-147561614 I fixed the test failure above and ran the tests myself, they pass. --- If your project is set up for it, you can reply to this email and have your reply appear

Re: cordova platform

2015-10-12 Thread Shazron
Hi Joerg, Makes sense - users can add the ios platform on Windows even if not supported. Please file a feature request in issues.cordova.io, thanks! On Thu, Oct 8, 2015 at 1:08 PM, Joerg Holz wrote: > Hi, > > after calling cordova platform on my MacBook Pro I just get this list

[GitHub] cordova-cli pull request: CB-9784 Remove CLI logger levels prefixe...

2015-10-12 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-cli/pull/224#issuecomment-147543581 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: cordova-vm.apache.org http server issue

2015-10-12 Thread Shazron
Is this still an issue? I'm not quite sure who has access to this. I believe Steve might. On Mon, Oct 12, 2015 at 7:09 AM, Alexander Sorokin (Akvelon) wrote: > Hi guys, > > Currently many file-transfer plugin tests are failing on all platforms > because they try to

[GitHub] cordova-lib pull request: CB-9758 Mobilespec crashes adding plugin...

2015-10-12 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/318#issuecomment-147529842 looks good to me. Thanks @daserge! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: Question on Contributing

2015-10-12 Thread Shazron
Hi Michael, Regardless of the CCLA[1], you would need to file an iCLA[2] as well. Please read: http://www.apache.org/dev/new-committers-guide.html#cla [1] https://www.apache.org/licenses/cla-corporate.txt [2] https://www.apache.org/licenses/icla.txt On Thu, Oct 8, 2015 at 12:08 PM, Michael

[GitHub] cordova-ios pull request: CB-9500 Added no sign argument to iOS bu...

2015-10-12 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/152#issuecomment-147590435 @nikhilkh any objections to this getting pulled in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-ios pull request: CB-9500 Added no sign argument to iOS bu...

2015-10-12 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/152#issuecomment-147599790 Hi @njtman I couldn't find your name (from the patch's From: field) in the Apache CLA list: http://people.apache.org/committer-index.html Once you have

[GitHub] cordova-lib pull request: CB-9758 Mobilespec crashes adding plugin...

2015-10-09 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/318#issuecomment-146993120 Just a question, this is for the case for example: `http://*` or `https://*` correct? A failing test should be added to the existing tests. --- If your project

Re: [DOCS] doc or docs subfolder?

2015-10-05 Thread Shazron
entation files. On Mon, Oct 5, 2015 at 7:05 PM, Carlos Santana <csantan...@gmail.com> wrote: > It's docs > https://github.com/apache/cordova-docs/commit/89be0380ba2a80ccfde1d28387b4ed228e10a9f8 > > > On Mon, Oct 5, 2015 at 6:08 PM Shazron <shaz...@gmail.com> wrote: >

Re: [DISCUSS] cordova-serve 0.2.0 release

2015-10-05 Thread Shazron
Haha yeah - just ping the people in your company directory Carlos for some advice :) Maybe they can even update the licenses just for you ;) On Mon, Oct 5, 2015 at 7:43 PM, Carlos Santana wrote: > Also express is sponsored by StrongLoop which I heard recently got acquired >

<    8   9   10   11   12   13   14   15   16   17   >