product should fit with Cordova’s CoC, since it’s being
> > > featured
> > > > > on the front page.
> > > > > > * The app itself should:
> > > > > > * be visually appealing and well designed (this is
> subjective,
> > > bu
https://cordova.apache.org
Are we still accepting apps? How do we select?
Right now there are 12. This relates to the Xmind request to dev@
Thanks Fil!
I like this organization and consistency (especially for getting new
contributors up to speed).
As an example, this is what I've done with my existing boards. I have 3:
cordova-ios@4.4.1 (labelled ios-next, backlog)
cordova-ios@4.5.0 (labelled backlog)
cordova-ios@5.0.0 (labelled backl
jira/browse/CB-12708
> [2] https://issues.apache.org/jira/browse/CB-12709
> [3] https://issues.apache.org/jira/browse/CB-13045
> [4] https://issues.apache.org/jira/browse/CB-13046
> [5] https://issues.apache.org/jira/browse/CB-13052
> [6] https://issues.apache.org/jira/browse/CB-12903
>
This clarifies whether we can even *use* ReactJS, the answer is "No":
https://issues.apache.org/jira/browse/LEGAL-319
On Sat, Jul 15, 2017 at 11:19 AM, Shazron wrote:
> i.e. React
>
> See https://s.apache.org/upmi
> And https://www.apache.org/legal/resolved.html
>
&
i.e. React
See https://s.apache.org/upmi
And https://www.apache.org/legal/resolved.html
Note that even though we "use" React in plugins.cordova.io (through an npm
dependency), and not include it in our repo, I suggest we remove its usage
and use Preact, a drop-in replacement (untested).
I filed:
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/326
Not sure yet why the appveyor CI (Windows) is failing some tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/326
We had to pull in new code for the new linter using eslint. Consequently,
some files have changed. Can you try rebasing, then running npm run eslint to
make sure it's all kosher
---
If
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/168
This patch (pun, I know) needs a README update for `httpMethod` as well, to
be complete.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/324
We had to pull in new code for the new linter using eslint. Consequently,
some files have changed. Can you try rebasing, then running `npm run eslint` to
make sure it's all kosher
---
If
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/324
Not passing the linter:
```
bin\templates\scripts\cordova\lib\Podfile.js: line 93, col 51, Mixed double
and single quotes.
bin\templates\scripts\cordova\lib\Podfile.js: line 93, col
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/713#discussion_r126568456
--- Diff: www/docs/en/dev/guide/platforms/ios/webview.md ---
@@ -220,5 +222,16 @@ After using either of these two methods, continue with
the **"
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/145#discussion_r126538962
--- Diff: createmobilespec/createmobilespec.js ---
@@ -345,16 +345,13 @@ if (argv.global) {
console.log("To clone reposit
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/89
Please file feature request issues for the needed features at
issues.cordova.io
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/322
CB-12948 - Add a warning to updateProject for iOS
### Platforms affected
self
### What does this PR do?
Remove the `cordova platform update` functionality of this
In the interim, I filed: https://issues.apache.org/jira/browse/CB-12948 and
will send a PR for comment
On Fri, Dec 2, 2016 at 4:56 PM, Shazron wrote:
> This has not been resolved yet. We'll discuss more next week.
>
> Archive link to this thread just in case you don'
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
@ccorcos seems to be really flaky these past few days. Even the status
graph has given up: http://status.apache.org/ I eventually could get it to load
---
If your project is
Github user shazron commented on the issue:
https://github.com/apache/cordova-docs/pull/709
This will be in 4.4.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/321
Slated for cordova-ios@4.5.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/321#discussion_r123074679
--- Diff: CordovaLib/Classes/Public/CDVAppDelegate.m ---
@@ -78,9 +78,23 @@ - (BOOL)application:(UIApplication*)application
openURL:(NSURL*)url
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/321#discussion_r123074527
--- Diff: CordovaLib/Classes/Public/CDVPlugin.m ---
@@ -140,6 +142,36 @@ - (void)handleOpenURL:(NSNotification*)notification
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/321#discussion_r123073237
--- Diff: CordovaLib/Classes/Public/CDVAppDelegate.m ---
@@ -78,9 +78,23 @@ - (BOOL)application:(UIApplication*)application
openURL:(NSURL*)url
> > Apps on the Apple Store:
> > https://itunes.apple.com/us/artist/photokandy-studios-llc/
> id498577828
> >
> > Books:
> > http://www.packtpub.com/phonegap-2-mobile-application-
> hotshot/book
> > http://www.packtpub.com/phonegap-s
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/210#discussion_r122649041
--- Diff: src/ios/CDVInAppBrowser.m ---
@@ -539,115 +545,212 @@ -(void)dealloc {
- (void)createViews
{
// We create
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/210#discussion_r122648718
--- Diff: src/ios/CDVInAppBrowser.m ---
@@ -539,115 +545,212 @@ -(void)dealloc {
- (void)createViews
{
// We create
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/210
Thank you for the PR.
Since this is only adding a feature (tintcolor), and changing behaviour of
a feature (toolbarstyle), the version should be bumped a minor to 1.8.0. (we
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/320
Update bundled ios-sim to 6.0.0
### Platforms affected
self
### What does this PR do?
Updates the bundled ios-sim to v6.0.0
### What testing has been done on
Please review and comment if necessary.
I would like a couple of +1 or LGTM before I send it off on Monday
https://github.com/cordova/apache-board-reports/blob/master/2017/2017-06.md
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15
Please close this PR, I consider it abandoned and it does not seem to serve
any purpose for Cordova currently.
---
If your project is set up for it, you can reply to this
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
Two issues:
1. The checklist for PRs was not adhered to
2. This fails CI
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user shazron commented on the issue:
https://github.com/apache/cordova-docs/pull/708
@purplecabbage is the removal of win8 here ok?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/25
@ccorcos guide available here
https://github.com/apache/cordova-ios/blob/master/guides/Setting%20Delegates%2C%20Preferences%20and%20Script%20Message%20Handlers%20in%20the
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/270
CB-12912 - Incorrect 'Report Bugs' link in README
### What does this PR do?
Fix broken link.
### What testing has been done on this change?
Teste
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-docs/pull/712
CB-11373 - document config.xml widget attributes android-packageName,
android-activityName, ios-CFBundleIdentifier
### What testing has been done on this change?
Generated the docs
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/319
Same error.
Did:
```
$ git checkout -- .
$ npm test
```
and it shows the same two deleted files.
---
If your project is set up for it, you can reply to this email and
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/319
I cloned your fork and checked out the feature branch with all your commits.
Then:
```
$ npm install --dev
$ npm test
...
> cordova-ios@4.5.0-dev unit-tests /Users/shaz
I created this Discuss document regarding which platforms/plugins are
moving:
https://github.com/cordova/cordova-discuss/blob/master/proposals/GithubMove.md
On Tue, Jun 13, 2017 at 12:57 PM, Shazron wrote:
> Thanks Carlos.
>
> I just filed https://issues.apache.org/jira/browse/INFRA
> >>
> >> --Carlos
> >>
> >>
> >> On Tue, Jun 6, 2017 at 6:30 PM Steven Gill
> wrote:
> >>
> >> > Yay! Hope ASF allows us to finally do this!
> >> >
> >> > On Tue, Jun 6, 2017 at 3:28 PM, Filip Maj wrote:
&
Github user shazron commented on the issue:
https://github.com/apache/cordova-docs/pull/708
Thanks! Can you copy the file to the `dev` tree as well. This file:
`www/docs/en/dev/guide/support/index.md`
---
If your project is set up for it, you can reply to this email and have your
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-docs/pull/711
CB-12904 - Document in config.xml
### Platforms affected
All
### What does this PR do?
Document the feature in config.xml. The feature has been
there for a while
Github user shazron commented on the issue:
https://github.com/apache/cordova-docs/pull/697
Should be both in the 7.x and dev trees as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shazron commented on the issue:
https://github.com/apache/cordova-docs/pull/710
I'll update `gem install bundle` typo in this PR. I think we are good to go
now.
@filmaj yeah let's do that in another PR. Also I found that
`node_modules/.bin/gulp serve
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/710#discussion_r121526214
--- Diff: README.md ---
@@ -101,9 +101,9 @@ Verify the installation by running:
Once Ruby and JavaScript are installed, install Ruby dependencies
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/710#discussion_r121513970
--- Diff: README.md ---
@@ -101,9 +101,9 @@ Verify the installation by running:
Once Ruby and JavaScript are installed, install Ruby dependencies
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/708#discussion_r121511805
--- Diff: www/docs/en/7.x/guide/support/index.md ---
@@ -38,10 +38,9 @@ CLI's shorthand names.
an
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/708#discussion_r121511716
--- Diff: www/docs/en/7.x/guide/support/index.md ---
@@ -38,10 +38,9 @@ CLI's shorthand names.
an
Github user shazron commented on the issue:
https://github.com/apache/cordova-docs/pull/697
@piotrowski I don't speak German. Is this good to go?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37
We appreciate the PR, but ultimately we can't accept it. Please see this
thread for a similar PR that uses undocumented/private API:
https://github.com/apache/cordova-p
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-docs/pull/710
Added instruction to install Ruby Gems locally
### What does this PR do?
Modified instruction to install the required Ruby Gems locally in a
subfolder of the repo. Installing jekyll
+1
On Mon, Jun 12, 2017 at 8:38 AM, julio cesar sanchez wrote:
> Currently, Jellybean is 8.8%, so it's bellow the 10%. We can drop it.
>
>
> 2017-06-12 17:22 GMT+02:00 Filip Maj :
>
> > Reviving this thread! Sorry for the late reply.
> >
> > Regarding Trevor's question:
> > > Just for considerat
Github user shazron commented on the issue:
https://github.com/apache/cordova-docs/pull/709
This feature will be in cordova-ios@4.4.1 or 4.5.0 (confirm before pulling
in)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user shazron commented on the issue:
https://github.com/apache/cordova-android/pull/310
iOS, cordova-lib has this pulled in, and also docs has a PR. Just waiting
on this one to be pulled in.
---
If your project is set up for it, you can reply to this email and have your
reply
Contents of the email notice at the end of this email.
Monday June 12th 0100 UTC is Sunday June 11th 6pm PDT
For the estimate of 6 hrs downtime, JIRA should be back up Monday June
12th, midnight -- thus should be back up by Monday morning EDT/PDT business
hours.
For those committers in Australia,
Deadline has passed for:
https://issues.apache.org/jira/browse/CB-12708
I believe I captured consensus in the issues as best I could. If there was
no consensus, the status quo prevails (KEEP).
On Tue, May 30, 2017 at 12:58 PM, Shazron wrote:
> Good point, I can imagine that after June 5 t
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/99
From what I have read, it seems this is an Android problem -- so I'm not
sure why the code changes in iOS are needed?
---
If your project is set up for it, you can reply to
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/99#discussion_r121013734
--- Diff: src/ios/CDVInAppBrowser.m ---
@@ -783,6 +793,16 @@ - (void)showToolBar:(BOOL)show : (NSString *)
toolbarPosition
I will have to prep a new coho release as well.
Can we add coho as a nightly as well or is that too much work?
On Tue, Jun 6, 2017 at 11:16 PM, Steven Gill wrote:
> I have lifted the code freeze. Feel free to commit again in cordova-lib.
> The modules have officially been broken out. cordova-lib
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/228
@dpogue bah, same timeout error. Please do the close and re-open PR dance
again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120506321
--- Diff: src/ios/CDVCapture.m ---
@@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath
forCallbackId:(NSString
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/317
Thanks! One small thing to enable auto GH->JIRA tracking -- can you prefix
the PR title with "CB-12883"? Thanks! I would do it myself but I don't have the
karma (none o
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/318
CB-12887 - cordova run --list does not show virtual devices in iOS 11
### Platforms affected
self
### What does this PR do?
Fix 'cordova run --list' not s
The Apache Cordova Project Management Committee (PMC) has consensus that we
should move primary development of Apache Cordova to Github, from Apache's
servers (role would be reversed, Apache would then be the mirror now).
We are already processing pull requests through Github, although without
wri
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/317
This PR is missing a JIRA issue, as part of the Checklist. Please file an
issue at:
http://issues.apache.org/jira/browse/CB
... so it can be tracked and evaluated by the devs, and
; sort of thing?
> Simon Mac Donald
> http://simonmacdonald.com
>
>
> On Mon, Nov 7, 2016 at 8:24 PM, Shazron wrote:
> > See https://issues.apache.org/jira/browse/CB-12122
> >
> > Right now if a plugin fails an c
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-console/pull/22
Also, please change the title to have a prefix of "CB-12168" so it can be
auto-tracked in JIRA.
This was already covered in the Github Pull Request template that you
era
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/315
CB-12675 - Travis xcode 8.3. os-x image fails an e2e test
### Platforms affected
self
### What does this PR do?
Updates the os-x image on Travis to Xcode 8.3
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/314
CB-12869 - Update bundled ios-sim to 5.0.13
### Platforms affected
self
### What does this PR do?
Update ios-sim to 5.0.13 (new release has a bug fix
ore days before making
> the final decision?
> After a sneak peek into iOS 11 announcements maybe we can make a better
> decision
>
> 2017-05-22 18:47 GMT+02:00 Shazron :
>
> > Deadline of June 1st is in 11 days, so get your comments in.
> >
> > On Wed, Apr 26, 20
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/28
@kamendo You'll just have to download the plugin and install it by folder
path for now. Cordova@7 dropped support for sub-folders and the plugin has to
be migrated
---
If
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/313
CI all green, and my tests below all succeed. Squashing.
Tested on macOS Sierra 10.12.5 (node 4, 6): SUCCESS
- [X] CocoaPods not installed, should output error to install it
- [X
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/313
Array.includes failure on node 4 when on Windows. I will have to re-test
everything again -- this means also that the check_reqs is not covered in the
unit-tests (which do test on nodes 4 and 6
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/313
Tested using
```
cordova platform add https://github.com/shazron/cordova-ios.git#CB-12856
cordova plugin add https://github.com/phonegap/phonegap-plugin-push.git
--verbose
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/313
Tested on macOS Sierra 10.12.5:
- [X] CocoaPods not installed, should output error to install it
- [X] CocoaPods not synced, should output error to `pod sync`
- [X] Once installed
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/313
CB-12856 - Skip CocoaPods check_reqs if on non-darwin (macOS) platform
**WORK IN PROGRESS**
### Platforms affected
self
### What does this PR do?
Ignore
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/382#discussion_r118570607
--- Diff: README.md ---
@@ -62,3 +62,9 @@ These commands live in a generated Cordova Android
project. Any interactions wit
1. Create a
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/307
@qcgm1978 not sure why you commented here, it's not relevant to the issue.
Cordova was meant to be used through the CLI, not Xcode. `www` is for edits
when using the cordova cli, it
Deadline of June 1st is in 11 days, so get your comments in.
On Wed, Apr 26, 2017 at 1:01 PM, Shazron wrote:
> I'm going to put a deadline of June 1st, 2017 to wrap up discussion of the
> Roadmap, we need it to be finalized by then if not it will just be left in
> the wind
The vote has now closed. The results are:
Positive Binding Votes: 3
Steve Gill
Filip Maj
Shazron Abdullah
The vote has passed.
On Fri, May 12, 2017 at 1:39 PM, Filip Maj wrote:
> I vote +1
>
> * Ran coho audit-license-headers over the coho repo
> * Ran coho check-license to ens
Seems to be an `npm uninstall -g npm` error (can't remove man page)
On Thu, May 11, 2017 at 7:50 PM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:
> Nightly build #341 for cordova has failed.
>
> Please check failure details on build details page at
> https://builds.apache.org/job/cor
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/307
@leshik can you try with a new fresh project? perhaps in a new existing
project you need to `cordova platform rm ios` then `cordova platform add ios`
Confirm you are getting the latest
Please review and vote on this Tools Release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-12793
Coho has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-12793/
The package was published
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure the source in the repos have
Apache-compatible licenses
* Ensured CI is green for the tags mentioned for the respective repos
On Tue, May 9, 2017 at 12:10 PM, Steven Gill wrote:
> Please review
This will be the first release in 3 years. I doubt there are any concerns?
-- will start the vote thread soon.
We are also publishing these nightlies now:
cordova-common
cordova-fetch
cordova-create
Consequently, the cordova-cli nightly will use nightlies of all its
dependent libraries (includes the above):
https://libraries.io/npm/cordova
https://libraries.io/npm/cordova-lib
Thus from no
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/87#discussion_r115553911
--- Diff: src/ios/CDVLocation.m ---
@@ -94,61 +94,62 @@ - (BOOL)isLocationServicesEnabled
- (void)startLocation:(BOOL
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all repo sources have Apache-compatible
licenses
* verified signatures and hashes on tarballs
* on Android SDK Tools 26.0.1 and 26.0.2 I ran (all passed):
- bin/create
- cordova/build
- cord
I want to add cordova-fetch and cordova-common to the nightlies:
https://github.com/apache/cordova-coho/pull/148
Pulling in that PR should fix this as well:
https://issues.apache.org/jira/browse/CB-12759
But I think the nightlies are running on their own script somewhere. How
can I update them?
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-coho/pull/148
CB-12758 - Add cordova-fetch and cordova-common to the nightly build
### Platforms affected
Tools only, nightlies.
### What does this PR do?
Adds cordova-common and
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all repo sources have Apache-compatible
licenses
* verified signatures and hashes on tarballs
On Tue, May 2, 2017 at 5:49 AM, wrote:
> I vote +1.
>
> * Verified tags
> * Ability to install/un
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-js/pull/142
CB-12748 - Update CI to test node 4 and 6
### What does this PR do?
Updates AppVeyor and Travis CI tests to use node 4 and 6.
### What testing has been done on this change
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* All relevant repos are green on http://status.cordova.io
On Fri, Apr 28, 2017 at 11:23 AM, Filip Maj wrote:
> Please revie
I added Carthage to the iOS WebViews section of the docs for
cordova-ios@4.4.0, instead of replacing it:
http://cordova.apache.org/announcements/2017/04/26/ios-release.html
On Fri, Mar 24, 2017 at 11:26 PM, Shazron wrote:
> Thanks Corinne,
> That's the bet that Swift pm will be the
The vote has now closed. The results are:
Positive Binding Votes: 3
Steven Gill
Jesse MacFadyen
Shazron Abdullah
The vote has passed.
On Tue, Apr 25, 2017 at 10:44 AM, Jesse wrote:
> I vote +1:
> * Ran coho verify-archive
> * Ran unit tests repo
> * unpacked, npm i, and npm test
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/87
Hmm not sure then :/
Regarding my line comments on this PR, I realize that we have another
instance not following the rules in the existing code ð±
https://github.com
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/254
Sorry, Swift newbie here :) (waiting for it to be stable real soon now!).
This will be slated for cordova-ios@4.4.1, I'll see how to add Swift tests in
the current test project...
---
If
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/254
@dpogue Can you confirm what @lucatorella said?
In any case, we don't have any Swift tests yet, but that's easy to remedy
for next release.
---
If your project is set up f
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/228
@dpogue looks like a Simulator timeout. Can you close and re-open the PR to
trigger the CI again
@fredgalvao ditto what @dpogue said
---
If your project is set up for it, you can reply to
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/87
@avishekcode what device are you testing it on? @filmaj I believe if he is
using an older phone, it might affect timings
---
If your project is set up for it, you can reply to
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/87#discussion_r113561945
--- Diff: src/ios/CDVLocation.m ---
@@ -94,61 +94,62 @@ - (BOOL)isLocationServicesEnabled
- (void)startLocation:(BOOL
ll be away on conferences (like PhoneGap Day
EU 2017 http://pgday.phonegap.com/eu2017/ -- see you there if you are
going) so this extra time will help.
On Tue, Apr 25, 2017 at 7:11 PM, Shazron wrote:
> The PR for the Plugin Audit is originally here: https://github.com/
> cordova/cordova-d
201 - 300 of 3864 matches
Mail list logo
