Github user stevengill commented on the issue:
https://github.com/apache/cordova-cli/pull/266
Your cordova-cli PRs are ready to rebase now :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-lib/pull/529
CB-11346 Remove known platforms check
Building on top of the work by @purplecabbage and @shazron.
Still need to fix failing tests + add some new tests.
Also, need to run
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/517
@audreyso can you rebase this from master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/520
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/516
Thanks for sending the PR!
I think this would be better as a flag. `cordova serve --devtools`.
We can add it to opts as a boolean and pass that into getBrowser function
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/399
Thoughts on this @shazron? Something still needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/358
In the upcoming cordova@7 release, plugin variables will be saved in your
project's package.json. You should be able to require package.json in your hook
and have access to them
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/315
We are deleting android_parser.js for cordova@7 since that functionality
has all been moved into cordova-android platform now. This would only be useful
for older versions of cordova-android
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/261
Looks like the issue has been resolved in cordova-ios. Marked for closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/260
I believe we are deleting ios_parser.js for cordova@7 since that
functionality has all been moved into cordova-ios platform now. This would
only be useful for older versions of cordova-ios
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/51
I am going to close this. We have stepped away from jasmine-node. Now using
jasmine ^2.x
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/520
@audreyso can you add the engines element + enginestrict to cordova-common,
cordova-fetch & cordova-serve's package.json too?
---
If your project is set up for it, you can r
Github user stevengill commented on the issue:
https://github.com/apache/cordova-cli/pull/266
@audreyso can you add some docs about --nosave, remove --save & discuss
autosave to various files in
https://github.com/apache/cordova-cli/tree/master/doc. cordova.txt,
platform
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/525
@filmaj yup
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/525
LGTM. Just need to do a cordova-common release. Follow steps at
https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md
but only do cordova-common
---
If your
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/524
It was deprecated for a time but then got undeprecated. Great find!
https://github.com/nodejs/node/issues/1592
---
If your project is set up for it, you can reply to this email and have
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/685
CB-12519: added plugins release blog post
plugins release blog post. Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user stevengill commented on the issue:
https://github.com/apache/cordova-cli/pull/268
This is ready to go, just waiting for the cordova@7 ship
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/121
Hey @romedius
Can you rebase this? I'll merge it in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103528081
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -257,7 +237,7 @@ function checkID(expectedIdAndVersion, pinfo) {
var parsedSpec
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103361780
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -165,14 +165,7 @@ module.exports.uninstallPlugin = function(id,
plugins_dir, options
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103362278
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -342,13 +322,6 @@ function copyPlugin(pinfo, plugins_dir, link) {
var dest = path.join
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103360880
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -221,7 +221,7 @@ describe('install', function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/522#discussion_r103362438
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -257,7 +237,7 @@ function checkID(expectedIdAndVersion, pinfo) {
var parsedSpec
Github user stevengill commented on the issue:
https://github.com/apache/cordova-android/pull/361
Sweet! Feel free to ping me on the cordova slack too. slack.cordova.io to
signup.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user stevengill commented on the issue:
https://github.com/apache/cordova-android/pull/361
Thanks @bhariharan!! I'll merge this up and add it to the release process!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user stevengill commented on the issue:
https://github.com/apache/cordova-android/pull/361
Woo! https://bintray.com/cordova/maven/cordova-android/6.1.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user stevengill commented on the issue:
https://github.com/apache/cordova-android/pull/361
Yup. I think i'm using the wrong BINTRAY_USER value. Using my email login.
Looks like I need to use my account name? https://bintray.com/docs/api/
---
If your project is set up
Github user stevengill commented on the issue:
https://github.com/apache/cordova-android/pull/361
I did but looks like i added it incorrectly. I added them straight to my
terminal so echo $BINTRAY_USER and key worked but when i logged it in
build.gradle, it did not. I added them
Github user stevengill commented on the issue:
https://github.com/apache/cordova-android/pull/361
So it doesn't seem to be uploading for me but the output isn't helping.
I managed to add `gradlew` into cordova-android/framework by importing it
into android studio. Then I run
Github user stevengill commented on the issue:
https://github.com/apache/cordova-android/pull/361
Yes! Sorry I promise to test it locally today and merge it in if all goes
well!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-device/pull/58
hey @yamane-dsys!
Your PR is in great shape. I appreciate you adding tests too!
Unfortunately, I don't think I can accept this PR. We only add new
properties
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-device/pull/57
Agree with @pke. Close 57
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/19
As sinzianag mentioned, this needs to be updated to add support for the
permission helper. Tests would be nice too.
---
If your project is set up for it, you can reply
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-vibration/pull/48
Why do you want to add .csproj to the .gitignore? This plugin has a .csproj
it needs to commit. Just wondering what your usecase is.
---
If your project is set up for it, you
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/518
I think this is ready to merge in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r102321817
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -412,15 +412,26 @@ function determinePluginTarget(projectRoot, cfg,
target, fetchOptions
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101877578
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -414,13 +414,15 @@ function determinePluginTarget(projectRoot, cfg,
target, fetchOptions
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101877994
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -414,13 +414,15 @@ function determinePluginTarget(projectRoot, cfg,
target, fetchOptions
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101873081
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -353,4 +353,5 @@ describe('plugin add and rm end-to-end --fetch',
function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101872753
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -253,6 +275,7 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101873667
--- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
@@ -742,7 +742,7 @@ describe('update config.xml to use the variable found
in pkg.json
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101870795
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -388,26 +384,54 @@ module.exports = function plugin(command, targets,
opts) {
function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r101826675
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -69,7 +71,7 @@ function fetchPlugin(plugin_src, plugins_dir, options
Github user stevengill commented on the issue:
https://github.com/apache/cordova-android/pull/361
Hey! This is super cool. The artifact I posted is at
https://bintray.com/cordova/maven/cordova-android#files/org/apache/cordova/cordova-android/5.2.2-beta
It was more of a proof
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/680
CB-12403: added android release blog post
### Platforms affected
### What does this PR do?
### What testing has been done on this change
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/499
ya
On Wed, Jan 25, 2017 at 2:35 PM, Audrey <notificati...@github.com> wrote:
> *@audreyso* commented on this pul
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97894467
--- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
@@ -680,10 +681,10 @@ describe('update config.xml to include platforms in
pkg.json
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97894300
--- Diff: cordova-lib/spec-cordova/fixtures/basePkgJson4/package.json ---
@@ -5,7 +5,7 @@
"main": "index.js",
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97894545
--- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
@@ -697,18 +698,18 @@ describe('update config.xml to include platforms in
pkg.json
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97894565
--- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
@@ -697,18 +698,18 @@ describe('update config.xml to include platforms in
pkg.json
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/499#discussion_r97894506
--- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
@@ -697,18 +698,18 @@ describe('update config.xml to include platforms in
pkg.json
Github user stevengill commented on the issue:
https://github.com/apache/cordova-cli/pull/266
Here is the discussion for the proposal:
https://github.com/cordova/cordova-discuss/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user stevengill commented on the issue:
https://github.com/apache/cordova-docs/pull/677
I'll actually go ahead and add the colon for all of the issue numbers. I
think we want to switch to adding the colon when we commit by default now. I
myself forget to still.
---
If your
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/677
CB:12358: added tools release blog post
### Platforms affected
### What does this PR do?
### What testing has been done on this change
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/453
Hmm. `edit-config` still hasn't been implemented for `config.xml` and might
not for a while. I can see both sides of the argument.
One of the main goals for `edit-config
Github user stevengill commented on the issue:
https://github.com/apache/cordova-android/pull/321
Needs review with master cordova-common. Aka cordova-common@2 (releasing
soon)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/214
I've merged https://github.com/apache/cordova-lib/pull/468 in. @ktop can
you close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user stevengill commented on the issue:
https://github.com/apache/cordova-ios/pull/284
@shazron This looks ready to merge. Any feedback?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user stevengill commented on the issue:
https://github.com/apache/cordova-cli/pull/265
@vladimir-kotikov hey! You make a good point about it being annoying to add
tests later and have to update all the numbers. And I agree the stack trace is
more useful. We ran into issues
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500848
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
expect
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95501588
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -206,134 +178,136 @@ describe('install', function() {
beforeEach(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95502237
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -192,34 +203,39 @@ beforeEach(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500857
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
expect
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500726
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -145,30 +146,36 @@ describe('plugin end-to-end', function() {
expect
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95501387
--- Diff: cordova-lib/spec-plugman/create.spec.js ---
@@ -35,46 +35,42 @@ describe( 'create plugin', function() {
existsSync
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500893
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -309,10 +341,13 @@ describe('plugin end-to-end', function() {
.then(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500826
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
expect
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500649
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -83,6 +83,7 @@ function removePlugin(id) {
var errorHandler = {
errorCallback
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500805
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
expect
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95497591
--- Diff: cordova-common/spec/ActionStack.spec.js ---
@@ -59,19 +59,19 @@ describe('action-stack', function() {
stack.push
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500766
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
expect
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95502073
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -192,34 +203,39 @@ beforeEach(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500793
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
expect
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500754
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -199,11 +209,14 @@ describe('plugin end-to-end', function() {
.then(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95499196
--- Diff: cordova-common/spec/CordovaCheck.spec.js ---
@@ -30,71 +30,62 @@ describe('findProjectRoot method', function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500742
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -178,11 +185,14 @@ describe('plugin end-to-end', function() {
.then(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95501615
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -206,134 +178,136 @@ describe('install', function() {
beforeEach(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500695
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -145,30 +146,36 @@ describe('plugin end-to-end', function() {
expect
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95502042
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -121,7 +131,8 @@ beforeEach(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500869
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -216,91 +229,110 @@ describe('plugin end-to-end', function() {
expect
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/265#discussion_r95493028
--- Diff: spec/cli.spec.js ---
@@ -55,76 +55,76 @@ describe("cordova cli", function () {
});
describe("opt
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/265#discussion_r95493138
--- Diff: spec/cli.spec.js ---
@@ -134,11 +134,11 @@ describe("cordova cli", function () {
describe("cr
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/673
added android 6.1.1 release blog post
### Platforms affected
### What does this PR do?
### What testing has been done on this change
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93506823
--- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
@@ -301,14 +301,8 @@ describe('ios project handler', function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93490653
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93492375
--- Diff: cordova-lib/spec-plugman/platforms/wp8.spec.js ---
@@ -113,22 +113,21 @@ describe('wp8 project handler', function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93492132
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93490510
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93490083
--- Diff: cordova-lib/spec-plugman/platforms/ios.spec.js ---
@@ -301,14 +301,8 @@ describe('ios project handler', function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93492030
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93491307
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r93491264
--- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js ---
@@ -50,18 +50,30 @@ function copyArray(arr) {
}
beforeEach(function
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/511
yes, those are known issues in the CI right now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92901285
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -345,13 +344,14 @@ describe('install', function() {
it('should not check
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92901030
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -345,13 +344,14 @@ describe('install', function() {
it('should not check
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92756760
--- Diff: cordova-lib/spec-cordova/helpers.js ---
@@ -148,7 +148,7 @@ module.exports.writeConfigContent = function (appPath,
configContent
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92713582
--- Diff: cordova-lib/spec-cordova/HooksRunner.spec.js ---
@@ -472,7 +472,7 @@ describe('HooksRunner', function
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92707789
--- Diff: cordova-lib/package.json ---
@@ -20,15 +20,16 @@
"dependencies": {
"aliasify": "^1.7.2",
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92707699
--- Diff: cordova-common/package.json ---
@@ -28,6 +28,7 @@
"cordova-registry-mapper": "^1.1.8",
&q
201 - 300 of 779 matches
Mail list logo
