[GitHub] cordova-coho pull request #133: added create to tools release process

2016-08-23 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/133 added create to tools release process You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-55 Alternatively

[GitHub] cordova-docs pull request #630: Added android ios release blog post

2016-08-22 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/630#discussion_r75788312 --- Diff: www/_posts/2016-08-22-android-ios-release.md --- @@ -0,0 +1,48 @@ +--- +layout: post +author: +name: Steve Gill

[GitHub] cordova-docs issue #630: Added android ios release blog post

2016-08-22 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/630 I'm actually going to publish updated docs and point to https://github.com/apache/cordova-docs/commit/af2ede15180d202e59d576f8f44e967018a268d1 for the edit-config stuff --- If your

[GitHub] cordova-docs issue #628: Added info to enable remote debugging in Android

2016-08-22 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/628 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-docs issue #606: Minor typo fixes

2016-08-22 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/606 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-docs issue #613: CB-11477 Add a page about nightly builds

2016-08-22 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/613 LGTM. Want me to merge it in? Maybe make the change @dblotsky recommended. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-docs pull request #630: Added android ios release blog post

2016-08-22 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-docs/pull/630 Added android ios release blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-docs master Alternatively you

[GitHub] cordova-cli pull request #239: CB-9858 added --fetch option

2016-08-22 Thread stevengill
Github user stevengill closed the pull request at: https://github.com/apache/cordova-cli/pull/239 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-cli issue #239: CB-9858 added --fetch option

2016-08-22 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-cli/pull/239 This got merged in already. Don't know why it didn't close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

2016-08-08 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/468 So this is the first step in adding `resource-file`. Future updates to platform API's will use `getFileResources` to do the copying of these files `src`attribute to the `target` attribute

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

2016-08-01 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/474 @vladimir-kotikov any issues you see with us moving this from cordova-lib to cordova-common? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-lib issue #470: CB-11636 Handle attributes with quotes correctly

2016-08-01 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/470 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib pull request #473: CB-11645 added check to see if getEditConfig ...

2016-08-01 Thread stevengill
Github user stevengill closed the pull request at: https://github.com/apache/cordova-lib/pull/473 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib issue #473: CB-11645 added check to see if getEditConfig exists ...

2016-08-01 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/473 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

2016-08-01 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/474 Can you create a issue to remove the duplicate code + tests from cordova-lib. That can be a separate PR after cordova-common has been released. --- If your project is set up for it, you

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib

2016-08-01 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/474 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib issue #474: CB-11653 copied findProjectRoot from cordova-lib; To...

2016-08-01 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/474 Two things: 1) migrate the tests over and add them to this pr 2) add the apache license header comment to the top. You will notice every other file has this. Apache requirement

[GitHub] cordova-lib pull request #473: CB-11645 added check to see if getEditConfig ...

2016-07-29 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/473 CB-11645 added check to see if getEditConfig exists before trying to … …use it Please review @macdonst @vladimir-kotikov @ktop. I am not familiar enough with these new changes

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

2016-07-29 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-ios/pull/234 @blakgeek that is pretty cool! Looks like @juliascript PR handles most of it. (doesn't handle configuration yet) For android, you would add your plugin deps to your gradle

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

2016-07-28 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r72683673 --- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js --- @@ -91,18 +94,31 @@ var handlers

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72542674 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function

[GitHub] cordova-lib issue #467: CB-9825: tests for cocoapod integration for plugins

2016-07-27 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/467 This looks good! Aside from the minor comments I left, I think it might be good to go. Travis hasn't run yet. Queued up. @shazron any comments? --- If your project

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72538340 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72538273 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72538178 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72538082 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72537902 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72535870 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72528694 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/plugin.xml --- @@ -0,0 +1,16 @@ + +http

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72528666 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cordova-plugin-cocoapod-dependent/plugin.xml --- @@ -0,0 +1,15 @@ + +http

[GitHub] cordova-docs issue #623: CB-11621 Add windows@4.4.2 release blog post

2016-07-27 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/623 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-26 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72366794 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -33,326 +33,453 @@ var helpers = require('./helpers'), var projectRoot = 'C:\\Projects

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-26 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72366626 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/doc/de/index.md --- @@ -0,0 +1,206 @@ +

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-26 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72366592 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/RELEASENOTES.md --- @@ -0,0 +1,141 @@ +

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

2016-07-26 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-ios/pull/234 Tests for this are at https://github.com/apache/cordova-lib/pull/467 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-26 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72346220 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/README.md --- @@ -0,0 +1,309

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-26 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72346148 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/LICENSE --- @@ -0,0 +1,202 @@ + --- End

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-26 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72346180 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/NOTICE --- @@ -0,0 +1,5 @@ +Apache Cordova

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-26 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72346117 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/CONTRIBUTING.md --- @@ -0,0 +1,37 @@ +

[GitHub] cordova-docs issue #619: CB-11550 Add android@5.2.1 release blog post

2016-07-11 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/619 Can you also add a link to the 5.2.0 blog post since we never announced it. People might still want to see that changelog. http://cordova.apache.org/announcements/2016/07/02/android-5.2.0

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

2016-07-01 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r69364995 --- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js --- @@ -91,18 +93,29 @@ var handlers

[GitHub] cordova-lib issue #458: CB-11412 template support for www folders

2016-06-27 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/458 Failures on windows? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-cli issue #257: CB-11412 removed link-to, aliased copy-from to templ...

2016-06-27 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-cli/pull/257 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-cli pull request #257: CB-11412 removed link-to, aliased copy-from t...

2016-06-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/257#discussion_r68633959 --- Diff: src/cli.js --- @@ -456,10 +456,13 @@ function cli(inputArgs) { template: false

[GitHub] cordova-coho pull request #127: Update platforms-release-process.md

2016-06-24 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/127 Update platforms-release-process.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-54 Alternatively

[GitHub] cordova-docs issue #615: CB-11445 added ios release blog post

2016-06-23 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/615 @shazron, how does that look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request #615: CB-11445 added ios release blog post

2016-06-23 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-docs/pull/615 CB-11445 added ios release blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-docs master Alternatively you

[GitHub] cordova-app-hello-world issue #16: CB-11412 Update templates to designate te...

2016-06-15 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-app-hello-world/pull/16 LGTM otherwise :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-app-hello-world issue #16: CB-11412 Update templates to designate te...

2016-06-15 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-app-hello-world/pull/16 Lets not add a `package.json` to template_src for now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-app-hello-world issue #16: CB-11412 Update templates to designate te...

2016-06-15 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-app-hello-world/pull/16 Lets update version in the default config.xml to be 1.0.0 instead of 0.0.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

2016-06-14 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67084182 --- Diff: cordova-lib/src/cordova/create.js --- @@ -252,133 +249,116 @@ function create(dir, optionalId, optionalName, cfg, fetchOpt

[GitHub] cordova-lib issue #456: CB-11412 improve template implementation

2016-06-14 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/456 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

2016-06-14 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67077184 --- Diff: cordova-lib/src/cordova/create.js --- @@ -252,133 +249,116 @@ function create(dir, optionalId, optionalName, cfg, fetchOpt

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

2016-06-14 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67073107 --- Diff: cordova-lib/spec-cordova/fixtures/templates/withsubdirectory_package_json/template/blah.txt --- @@ -0,0 +1 @@ +blah --- End diff

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

2016-06-14 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67071311 --- Diff: cordova-lib/spec-cordova/create.spec.js --- @@ -121,6 +122,36 @@ describe('create end-to-end', function() { // expect

[GitHub] cordova-lib pull request #456: CB-11412 improve template implementation

2016-06-14 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/456#discussion_r67070160 --- Diff: cordova-lib/spec-cordova/create.spec.js --- @@ -38,15 +37,17 @@ var configNormal = { version: 'testCordovaCreate

[GitHub] cordova-lib issue #454: Fix failing cordova-fetch tests

2016-06-06 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/454 Thanks @dpogue! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-lib pull request #454: Fix failing cordova-fetch tests

2016-06-06 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/454#discussion_r65937033 --- Diff: cordova-fetch/index.js --- @@ -152,7 +152,7 @@ function trimID(target) { //also support scoped packages if(target.indexOf

[GitHub] cordova-lib pull request #452: commenting out some fetch tests due to appvey...

2016-06-03 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/452 commenting out some fetch tests due to appveyor failures You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-lib master

[GitHub] cordova-cli issue #256: CB-11349 passing --fetch to create

2016-06-03 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-cli/pull/256 @carynbear looks like you have a failing test! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib issue #450: CB-11252 Fix cordova fetch for scoped packages

2016-06-03 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/450 Nice find! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib issue #447: attempting to fix failing travis and appveyor tests

2016-06-03 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/447 I ended up removing the fetch tests from travis for now. Better to having passing travis tests than a weird node 6 module missing issue that I can't reproduce --- If your project is set up

[GitHub] cordova-docs issue #608: Update platform/plugin versioning

2016-06-02 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/608 @fredgalvao, I agree that there would be benefits to implementing it. Feel free to open a feature request issue at issues.cordova.io. Regardless, this PR is to fix the docs issue

[GitHub] cordova-docs issue #608: Update platform/plugin versioning

2016-06-02 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/608 Thanks @carynbear! I don't think we ever supported a plugin update command. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-lib issue #447: attempting to fix failing travis and appveyor tests

2016-06-01 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/447 cordova-fetch tests are failing due to missing modules for node 6. Works fine locally for me though. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request #447: attempting to fix failing travis and appveyor...

2016-06-01 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/447 attempting to fix failing travis and appveyor tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-lib master

[GitHub] cordova-lib pull request #442: Fixed issues with travis failing for node 6

2016-06-01 Thread stevengill
Github user stevengill closed the pull request at: https://github.com/apache/cordova-lib/pull/442 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib issue #446: CB-11349 added --fetch and cordova fetch to create -...

2016-06-01 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/446 Looks great! I'll merge this in! Thanks @carynbear!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-docs pull request: CB-11260 tools release blog post

2016-05-24 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-docs/pull/605 CB-11260 tools release blog post Any thoughts? You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-docs master

[GitHub] cordova-lib pull request: Fixed issues with travis failing for nod...

2016-05-18 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/442 Fixed issues with travis failing for node 6 You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-lib master

[GitHub] cordova-coho pull request: Added common, fetch and serve to tools ...

2016-05-13 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/119 Added common, fetch and serve to tools release process You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch

[GitHub] cordova-lib pull request: Improving prepare and build output

2016-05-12 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218910842 Passed! Lets merge this in @riknoll :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: Improving prepare and build output

2016-05-12 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218906307 Travis taking forever On Thu, May 12, 2016 at 2:34 PM, Richard Knoll <notificati...@github.com> wrote: > I'll merge whenever t

[GitHub] cordova-lib pull request: CB-10621 fix for amazon-fireos

2016-05-11 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/390#issuecomment-218649503 Amazon-fireos has actually been deprecated. It is recommended to target the android platform instead when releasing for amazon --- If your project is set up

[GitHub] cordova-lib pull request: Change cordova-lib to execute plugin hoo...

2016-05-11 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/236#issuecomment-218633214 I'd like to revive this PR. Hooks should run when using create scripts + plugman. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-lib pull request: Change cordova-lib to execute plugin hoo...

2016-05-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/236#discussion_r62952050 --- Diff: cordova-lib/src/plugman/uninstall.js --- @@ -283,7 +283,7 @@ function runUninstallPlatform(actions, platform, project_dir, plugin_dir

[GitHub] cordova-lib pull request: Improving prepare and build output

2016-05-11 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218624176 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: Improving prepare and build output

2016-05-11 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/439#discussion_r62946762 --- Diff: cordova-lib/src/hooks/HooksRunner.js --- @@ -141,6 +144,23 @@ function runScript(script, context) { // we assume we should use

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

2016-05-11 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-218623029 How close is this to being able to merge in? @macdonst --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-media-capture pull request: CB-11212 iOS: Explicitl...

2016-05-11 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/61#issuecomment-218560464 LGTM. Merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-medic pull request: CB-11237: linking cordova-fetch

2016-05-10 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-medic/pull/102#issuecomment-218068505 LGTM too! Sorry I forgot about medic :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-cli pull request: Telemetry

2016-05-09 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218025705 LGTM!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-09 Thread stevengill
Github user stevengill closed the pull request at: https://github.com/apache/cordova-lib/pull/407 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-09 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-21866 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-05 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-217087853 Made the changes. LMK. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-04 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r62101897 --- Diff: cordova-fetch/spec/package.json --- @@ -0,0 +1,11 @@ +{ --- End diff -- I just copy it into temporary tests folder so I can

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-04 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r62100822 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,234 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-04 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r62100600 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,234 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-05-03 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-216691951 Hey Everyone, I think the first implementation of this is ready to hit master behind the --fetch flag. It includes platform and plugin fetching

[GitHub] cordova-lib pull request: CB-11174 Resolve symlinked path before g...

2016-04-29 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/433#issuecomment-215922979 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-04-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r60995427 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,226 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-04-25 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r60995226 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,226 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-docs pull request: CB-11091 added plugins release blog pos...

2016-04-19 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-docs/pull/582 CB-11091 added plugins release blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-docs master Alternatively

[GitHub] cordova-lib pull request: CB-10981 Remove cordova-common from bund...

2016-04-18 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/419#issuecomment-211626986 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-coho pull request: CB-10315 Added apache permanent tag ste...

2016-03-23 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/115 CB-10315 Added apache permanent tag step to tools release process You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova

[GitHub] cordova-docs pull request: CB-10679: Adding docs for new plugin ve...

2016-03-22 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/559#issuecomment-11281 We don't have a strict policy for blog posts. I think one day is good enough. We can always update blog posts at a later date if the need arises. --- If your

[GitHub] cordova-docs pull request: CB-10679: Adding docs for new plugin ve...

2016-03-22 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/559#issuecomment-199960047 Lets merge and publish this! That way I can reference it in tools release blog post. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-03-22 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-199661470 Plugman PR adding --fetch flag support https://github.com/apache/cordova-plugman/pull/87 --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugman pull request: CB-9858 added --fetch option to plug...

2016-03-22 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-plugman/pull/87 CB-9858 added --fetch option to plugman You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-plugman CB-9858

[GitHub] cordova-lib pull request: CB-10694 - Platform-specific configurati...

2016-03-19 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/411#issuecomment-197549676 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

<    1   2   3   4   5   6   7   8   >