+1
-
Best regards, Vladimir
On Apr 13, 2017, at 02:10, Jesse wrote:
+1
This goes hand in hand with removing platformApiPoly from cordova-lib.
@purplecabbage
risingj.com
On Wed, Apr 12, 2017 at 4:04 PM, Shazron wrote:
> +1
> adieu WP8
>
> On Wed, Apr 12, 2017 at 1:58 PM, Audrey So wrote
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/531
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/214
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/228
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Hey Shazron and Fil
The thing with nightly builds is that they are running (or it’d better to say
they had been running until Dec, 9) on Apache infrastructure. More
specifically, this is a build job that is used to run ‘coho nightly’:
https://builds.apache.org/view/All/job/cordova-nightly
Ther
Check out blog at
https://cordova.apache.org/announcements/2017/02/13/cordova-windows-5.0.0.html
Retweet https://twitter.com/apachecordova/status/831064944208728065
-
Best regards, Vladimir
-
To unsubscribe, e-mail: dev-unsubsc
I vote +1
- Verified licenses and license headers
- Ran automates tests
- Verified archive
- Verified tag
-
Best regards, Vladimir
On 2/9/17, 09:57, "alsoro...@apache.org" wrote:
I vote +1.
* Verified archives via `coho verify-archive`
* Verified tags manually
* Verifie
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-docs/pull/681
Looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/224
:shipit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/213
@ktop, done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/222
Upgrade cordova-common to 2.0.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-windows master
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/515
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/515#discussion_r97743108
--- Diff: cordova-lib/src/plugman/browserify.js ---
@@ -157,8 +157,8 @@ module.exports = function doBrowserify (project,
platformApi
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/515#discussion_r97738068
--- Diff: cordova-lib/src/plugman/browserify.js ---
@@ -157,8 +157,8 @@ module.exports = function doBrowserify (project,
platformApi
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/171
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/208
@daserge, should we really remove windows8 section?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/123
Travis failure is unrelevant to this change, so merging. However I found
that native tests are passing with cordova-ios@4.3.0 and failing w/ 4.3.1
/cc @shazron
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/122
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/208
LGTM ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/220
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-docs/pull/674
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/468
LGTM ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-cli/pull/265
Yeah, not a big deal and probably not worth renaming all test cases back
now, It just reminded me file transfer tests where we have 'spec.11' then
`spec.9` then `spe
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-globalization/pull/54
ð¢ it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/265#discussion_r95522000
--- Diff: spec/cli.spec.js ---
@@ -55,76 +55,76 @@ describe("cordova cli", function () {
});
describ
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/265#discussion_r95521991
--- Diff: package.json ---
@@ -11,8 +11,8 @@
"cordova": "./bin/cordova"
},
"scripts&q
Hey, everybody!
I’d like to propose/discuss the idea of redistributing Typescript definitions
along with core plugins, so that users who write their apps in Typescript would
get the typings in their projects without additional mess with 'tsd'/'typings'
(these all are the package managers for ty
Here is another relevant proposal and discussion:
https://github.com/cordova/cordova-discuss/pull/30. I think we’ve agreed to
follow this way to “pin” specific plugins’ versions to specific cordova
versions.
Here are some examples:
1.
https://github.com/apache/cordova-plugin-inappbrowser/blob/
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/219
Rebased on top of master and force-pushed, will merge once tests pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
I vote +1
- Verified archive signature
- Verified license headers
- Verified dependencies have appropriate licenses
- Verified ‘cordova serve’ command and browser platform work with the version
being released
-
Best regards, Vladimir
On 12/22/16, 13:07, "Alexander Sorokin (Akvelon)"
wrote:
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/219
@daserge could you take a look please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
+1
We’re specifically interested in these three PRs:
- https://github.com/apache/cordova-lib/pull/505
- https://github.com/apache/cordova-lib/pull/509
- https://github.com/apache/cordova-lib/pull/513
Notice that the first one contains a change that might break plugins that use
to
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/219
Documentation update: https://github.com/apache/cordova-docs/pull/671
Change to support `implementation` attribute in `cordova-common`:
https://github.com/apache/cordova-lib
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/513
Travis build failures look irrelevant to this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-docs/pull/671
CB-12189 windows: Document `implementation` attribute
### Platforms affected
### What does this PR do?
### What testing has been done on this
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/513
CB-12189 windows: Add `implementation` attribute to frameworks
The attribute is windows-specific and allows to specify implementation for
WinMD components, written in C
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/218
Sure, ð¢ it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/216
Yep ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-docs/pull/668
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-docs/pull/668
This has been merged in
https://github.com/apache/cordova-docs/commit/bedbcc1f42a57fd1bd5f71c4dba9010faf1aae07
---
If your project is set up for it, you can reply to this email and
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/217
Cool! Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/217
@daserge, is this good to go?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/218#discussion_r92604767
--- Diff: cordova-js-src/splashscreen.js ---
@@ -203,10 +212,30 @@ function enableUserInteraction() {
document.body.style[
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/216#discussion_r92601539
--- Diff: cordova-js-src/splashscreen.js ---
@@ -30,7 +30,8 @@ var schema = (isHosted || isWin10UWP && isMsAppxWeb) ?
'ms-ap
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/216#discussion_r92603101
--- Diff: cordova-js-src/splashscreen.js ---
@@ -148,29 +152,27 @@ function init(config, manifest
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/216#discussion_r92602532
--- Diff: cordova-js-src/splashscreen.js ---
@@ -148,29 +152,27 @@ function init(config, manifest
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/216#discussion_r92601889
--- Diff: cordova-js-src/splashscreen.js ---
@@ -148,29 +152,27 @@ function init(config, manifest
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/213
Looks good ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/668#discussion_r92459442
--- Diff: www/docs/en/dev/guide/platforms/win8/index.md ---
@@ -287,6 +287,37 @@ powershell -Command " & {dir -path
cert:\LocalM
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/217#discussion_r92399420
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -46,11 +46,8 @@ MSBuildTools.prototype.buildProject = function(projFile,
buildType
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/217#discussion_r92399214
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -46,11 +46,8 @@ MSBuildTools.prototype.buildProject = function(projFile,
buildType
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/213#discussion_r92344562
--- Diff: template/cordova/lib/JsprojManager.js ---
@@ -121,7 +121,12 @@ jsprojManager.prototype = {
copyToOutputDirectory.text
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/213#discussion_r92345318
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -188,7 +207,7 @@ module.exports.getUninstaller = function(type
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/213#discussion_r92344997
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -53,18 +53,37 @@ var handlers = {
},
'resource
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/213#discussion_r92344993
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -53,18 +53,37 @@ var handlers = {
},
'resource
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/217
Pls also see corresponding documentation update here:
https://github.com/apache/cordova-docs/pull/668
---
If your project is set up for it, you can reply to this email and have
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-docs/pull/668
CB-12239 (windows) Add documentation about build flags for Windows
### Platforms affected
Windows
### What does this PR do?
Documents use of
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/217
@TimBarham, @alsorokin, @daserge, could you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/217
CB-12239 Add buildFlag option similar to iOS
### What does this PR do?
This PR adds `buildFlag` CLI argument and corresponding option for
`build.json` file
Hey all!
I’m +1 for killing Medic, since it hasn’t been used for months and I guess
hardly ever will be used in the future.
Though I have a bit different proposal about moving configs – IMO they are a
part of CI and should live somewhere inside a CI. I don’t think there is a need
to either exh
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/265#discussion_r92010506
--- Diff: package.json ---
@@ -31,6 +31,7 @@
"cordova-common": "1.5.x",
"cordova-lib": "
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/265#discussion_r92009821
--- Diff: package.json ---
@@ -11,7 +11,7 @@
"cordova": "./bin/cordova"
},
"scripts&q
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/46
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Hi Shazron
Gave you permissions to packages which I have access to.
-
Best regards, Vladimir
On 12/12/16, 01:37, "Shazron" wrote:
Hi Steve Gill and/or Carlos Santana -- please give me write access to these
npm modules below. Publishing is stalled until I get permissions.
cord
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/212
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89992916
--- Diff: template/cordova/lib/prepare.js ---
@@ -297,48 +305,80 @@ function applyNavigationWhitelist(config, manifest
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89994632
--- Diff: template/cordova/lib/prepare.js ---
@@ -439,6 +492,107 @@ function getUAPVersions(config
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89990562
--- Diff: cordova-js-src/splashscreen.js ---
@@ -58,8 +58,45 @@ function readBoolFromCfg(preferenceName, defaultValue,
cfg
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89991437
--- Diff: template/cordova/lib/prepare.js ---
@@ -297,48 +305,80 @@ function applyNavigationWhitelist(config, manifest
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89993606
--- Diff: template/cordova/lib/prepare.js ---
@@ -353,6 +391,13 @@ function mapImageResources(images, imagesDir
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89991151
--- Diff: template/cordova/lib/AppxManifest.js ---
@@ -416,6 +417,18 @@ AppxManifest.prototype.getVisualElements = function
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89991524
--- Diff: template/cordova/lib/prepare.js ---
@@ -297,48 +305,80 @@ function applyNavigationWhitelist(config, manifest
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89996388
--- Diff: template/cordova/lib/prepare.js ---
@@ -439,6 +490,109 @@ function getUAPVersions(config
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89729105
--- Diff: template/cordova/lib/prepare.js ---
@@ -353,6 +391,13 @@ function mapImageResources(images, imagesDir
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89726640
--- Diff: spec/unit/Prepare.Win10.spec.js ---
@@ -541,4 +541,165 @@ describe('copyIcons method', function () {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89726245
--- Diff: cordova-js-src/splashscreen.js ---
@@ -58,8 +58,45 @@ function readBoolFromCfg(preferenceName, defaultValue,
cfg
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89729119
--- Diff: template/cordova/lib/prepare.js ---
@@ -362,7 +407,13 @@ function mapImageResources(images, imagesDir) {
// find
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89729302
--- Diff: template/cordova/lib/prepare.js ---
@@ -439,6 +490,109 @@ function getUAPVersions(config
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89727836
--- Diff: template/cordova/lib/prepare.js ---
@@ -297,48 +305,78 @@ function applyNavigationWhitelist(config, manifest
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89726251
--- Diff: cordova-js-src/confighelper.js ---
@@ -22,16 +22,17 @@
// config.xml wrapper (non-node ConfigParser analogue)
var config
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89729637
--- Diff: template/cordova/lib/prepare.js ---
@@ -439,6 +490,109 @@ function getUAPVersions(config
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89739598
--- Diff: template/cordova/lib/prepare.js ---
@@ -439,6 +490,109 @@ function getUAPVersions(config
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89727040
--- Diff: template/CordovaApp.Phone.jsproj ---
@@ -79,7 +79,9 @@
Designer
-
+
--- End
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/212#discussion_r89739874
--- Diff: template/cordova/lib/prepare.js ---
@@ -439,6 +490,109 @@ function getUAPVersions(config
2016 at 6:30 AM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:
> Hey all
>
> Just FUI, we're done some refactoring that aims to move some
> windows-specific logic (in particular, applying changes to
> appxmanifests files) out of co
+1
-Original Message-
From: Filip Maj [mailto:maj@gmail.com]
Sent: Wednesday, November 23, 2016 9:12 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Split cordova-lib modules into their own repos
+1
On Tue, Nov 22, 2016 at 9:33 PM, Darryl Pogue wrote:
> On 22 November 2016 at
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/207
Looks good. Let's wait for tomorrow and merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Hey all
Just FUI, we're done some refactoring that aims to move some windows-specific
logic (in particular, applying changes to appxmanifests files)
out of cordova-common into cordova-windows. I hope this would simplify
maintenance of both cordova-common and cordova-windows in future
Just in
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-network-information/pull/51
Merging, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-network-information/pull/51
@shazron, could you take a look please? This PR just aligns curent
implementation for `CDVReachability` with latest Apple's changes. In particular
it re
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87808967
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,150 @@
+var semver = require('semver');
+var CommonPluginInfo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87807973
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,150 @@
+var semver = require('semver');
+var CommonPluginInfo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87810709
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,150 @@
+var semver = require('semver');
+var CommonPluginInfo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87810296
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,150 @@
+var semver = require('semver');
+var CommonPluginInfo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87809002
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,150 @@
+var semver = require('semver');
+var CommonPluginInfo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87809027
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,150 @@
+var semver = require('semver');
+var CommonPluginInfo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87751813
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,109 @@
+var semver = require('semver');
+var CommonPluginInfo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87752512
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,109 @@
+var semver = require('semver');
+var CommonPluginInfo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87752779
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,109 @@
+var semver = require('semver');
+var CommonPluginInfo
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87751321
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,109 @@
+var semver = require('semver');
+var CommonPluginInfo
1 - 100 of 1538 matches
Mail list logo
