Re: wp8 support (cordova@7)

+1 - Best regards, Vladimir On Apr 13, 2017, at 02:10, Jesse wrote: +1 This goes hand in hand with removing platformApiPoly from cordova-lib. @purplecabbage risingj.com On Wed, Apr 12, 2017 at 4:04 PM, Shazron wrote: > +1 > adieu WP8 > > On

[GitHub] cordova-lib issue #531: CB-12606 Fix plugin dependency installation

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/531 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-inappbrowser issue #214: CB-11248 InAppBrowser no focus on in...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/214 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-windows issue #228: CB-12499 UWP: Dependent external libraries speci...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/228 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

Re: [NIGHTLY BUILDS] Missing

Hey Shazron and Fil The thing with nightly builds is that they are running (or it’d better to say they had been running until Dec, 9) on Apache infrastructure. More specifically, this is a build job that is used to run ‘coho nightly’: https://builds.apache.org/view/All/job/cordova-nightly

[ANNOUNCE] Cordova-windows@5.0.0 released!

Check out blog at https://cordova.apache.org/announcements/2017/02/13/cordova-windows-5.0.0.html Retweet https://twitter.com/apachecordova/status/831064944208728065 - Best regards, Vladimir - To unsubscribe, e-mail:

Re: [Vote] 5.0.0 Windows Release

I vote +1 - Verified licenses and license headers - Ran automates tests - Verified archive - Verified tag - Best regards, Vladimir On 2/9/17, 09:57, "alsoro...@apache.org" wrote: I vote +1. * Verified archives via `coho verify-archive` * Verified tags

[GitHub] cordova-docs issue #681: CB-12404 Add windows@5.0.0 release blog post

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-docs/pull/681 Looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-windows issue #224: Added missing license to PluginInfo.js

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/224 :shipit: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-windows issue #213: CB-12163 Make resource-file copy files again

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/213 @ktop, done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-windows pull request #222: Upgrade cordova-common to 2.0.0

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/222 Upgrade cordova-common to 2.0.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/vladimir-kotikov/cordova-windows master

[GitHub] cordova-lib issue #515: CB-12383 Fix cordova_plugins metadata definition

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/515 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib pull request #515: CB-12383 Fix cordova_plugins metadata definit...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/515#discussion_r97743108 --- Diff: cordova-lib/src/plugman/browserify.js --- @@ -157,8 +157,8 @@ module.exports = function doBrowserify (project, platformApi

[GitHub] cordova-lib pull request #515: CB-12383 Fix cordova_plugins metadata definit...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/515#discussion_r97738068 --- Diff: cordova-lib/src/plugman/browserify.js --- @@ -157,8 +157,8 @@ module.exports = function doBrowserify (project, platformApi

[GitHub] cordova-plugin-file-transfer issue #171: CB-12336 (android) Do not call win ...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/171 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-inappbrowser issue #208: CB-12353 Corrected merges usage in p...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/208 @daserge, should we really remove windows8 section? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-splashscreen issue #123: CB-12369: Add plugin typings from De...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/123 Travis failure is unrelevant to this change, so merging. However I found that native tests are passing with cordova-ios@4.3.0 and failing w/ 4.3.1 /cc @shazron

[GitHub] cordova-plugin-splashscreen issue #122: CB-12353 Corrected merges usage in p...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/122 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-inappbrowser issue #208: CB-12353 Corrected merges usage in p...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/208 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-windows issue #220: CB-12298 [Windows] bundle.appxupload not generat...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/220 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-docs issue #674: CB-8486 Corrected the docs on signing

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-docs/pull/674 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/468 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-cli issue #265: CB-12018 : updated tests to function with jasmine in...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-cli/pull/265 Yeah, not a big deal and probably not worth renaming all test cases back now, It just reminded me file transfer tests where we have 'spec.11' then `spec.9` then `spec.10`, etc

[GitHub] cordova-plugin-globalization issue #54: CB-11154 (Windows) Return IANA timez...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-globalization/pull/54 🚢 it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-cli pull request #265: CB-12018 : updated tests to function with jas...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/265#discussion_r95522000 --- Diff: spec/cli.spec.js --- @@ -55,76 +55,76 @@ describe("cordova cli", function () { }); describ

[GitHub] cordova-cli pull request #265: CB-12018 : updated tests to function with jas...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/265#discussion_r95521991 --- Diff: package.json --- @@ -11,8 +11,8 @@ "cordova": "./bin/cordova" }, "scripts&q

[DISCUSS] Include TypeScript definitions in plugins

Hey, everybody! I’d like to propose/discuss the idea of redistributing Typescript definitions along with core plugins, so that users who write their apps in Typescript would get the typings in their projects without additional mess with 'tsd'/'typings' (these all are the package managers for

Re: plugins and engines

Here is another relevant proposal and discussion: https://github.com/cordova/cordova-discuss/pull/30. I think we’ve agreed to follow this way to “pin” specific plugins’ versions to specific cordova versions. Here are some examples: 1.

[GitHub] cordova-windows issue #219: CB-12189: Add support for WinMD and DLL combinat...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/219 Rebased on top of master and force-pushed, will merge once tests pass --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

Re: [VOTE] cordova-serve 1.0.1 release

I vote +1 - Verified archive signature - Verified license headers - Verified dependencies have appropriate licenses - Verified ‘cordova serve’ command and browser platform work with the version being released - Best regards, Vladimir On 12/22/16, 13:07, "Alexander Sorokin (Akvelon)"

[GitHub] cordova-windows issue #219: CB-12189: Add support for WinMD and DLL combinat...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/219 @daserge could you take a look please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-windows issue #219: Add support for WinMD and DLL combination

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/219 Documentation update: https://github.com/apache/cordova-docs/pull/671 Change to support `implementation` attribute in `cordova-common`: https://github.com/apache/cordova-lib

[GitHub] cordova-lib issue #513: CB-12189 windows: Add `implementation` attribute to ...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/513 Travis build failures look irrelevant to this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-docs pull request #671: CB-12189 windows: Document `implementation` ...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/671 CB-12189 windows: Document `implementation` attribute ### Platforms affected ### What does this PR do? ### What testing has been done

[GitHub] cordova-lib pull request #513: CB-12189 windows: Add `implementation` attrib...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/513 CB-12189 windows: Add `implementation` attribute to frameworks The attribute is windows-specific and allows to specify implementation for WinMD components, written in C

[GitHub] cordova-windows issue #218: CB-12238 [Windows] Colorize titlebar to match sp...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/218 Sure, 🚢 it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-windows issue #216: CB-11177 SplashScreen gets shifted on Windows de...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/216 Yep 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-docs pull request #668: CB-12239 (windows) Add documentation about b...

Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-docs/pull/668 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-docs issue #668: CB-12239 (windows) Add documentation about build fl...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-docs/pull/668 This has been merged in https://github.com/apache/cordova-docs/commit/bedbcc1f42a57fd1bd5f71c4dba9010faf1aae07 --- If your project is set up for it, you can reply to this email

[GitHub] cordova-windows issue #217: CB-12239 Add buildFlag option similar to iOS

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/217 Cool! Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-windows issue #217: CB-12239 Add buildFlag option similar to iOS

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/217 @daserge, is this good to go? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-windows pull request #218: CB-12238 [Windows] Colorize titlebar to m...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/218#discussion_r92604767 --- Diff: cordova-js-src/splashscreen.js --- @@ -203,10 +212,30 @@ function enableUserInteraction() { document.body.style['-ms

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/216#discussion_r92601539 --- Diff: cordova-js-src/splashscreen.js --- @@ -30,7 +30,8 @@ var schema = (isHosted || isWin10UWP && isMsAppxWeb) ? 'ms-appx-we

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/216#discussion_r92603101 --- Diff: cordova-js-src/splashscreen.js --- @@ -148,29 +152,27 @@ function init(config, manifest

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/216#discussion_r92602532 --- Diff: cordova-js-src/splashscreen.js --- @@ -148,29 +152,27 @@ function init(config, manifest

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/216#discussion_r92601889 --- Diff: cordova-js-src/splashscreen.js --- @@ -148,29 +152,27 @@ function init(config, manifest

[GitHub] cordova-windows issue #213: CB-12163 Make resource-file copy files again

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/213 Looks good 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-docs pull request #668: CB-12239 (windows) Add documentation about b...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/668#discussion_r92459442 --- Diff: www/docs/en/dev/guide/platforms/win8/index.md --- @@ -287,6 +287,37 @@ powershell -Command " & {dir -path cert:\LocalM

[GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/217#discussion_r92399420 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -46,11 +46,8 @@ MSBuildTools.prototype.buildProject = function(projFile, buildType

[GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/217#discussion_r92399214 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -46,11 +46,8 @@ MSBuildTools.prototype.buildProject = function(projFile, buildType

[GitHub] cordova-windows pull request #213: CB-12163 Make resource-file copy files ag...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/213#discussion_r92344562 --- Diff: template/cordova/lib/JsprojManager.js --- @@ -121,7 +121,12 @@ jsprojManager.prototype = { copyToOutputDirectory.text

[GitHub] cordova-windows pull request #213: CB-12163 Make resource-file copy files ag...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/213#discussion_r92345318 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -188,7 +207,7 @@ module.exports.getUninstaller = function(type

[GitHub] cordova-windows pull request #213: CB-12163 Make resource-file copy files ag...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/213#discussion_r92344997 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -53,18 +53,37 @@ var handlers = { }, 'resource-file

[GitHub] cordova-windows pull request #213: CB-12163 Make resource-file copy files ag...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/213#discussion_r92344993 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -53,18 +53,37 @@ var handlers = { }, 'resource-file

[GitHub] cordova-windows issue #217: CB-12239 Add buildFlag option similar to iOS

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/217 Pls also see corresponding documentation update here: https://github.com/apache/cordova-docs/pull/668 --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-docs pull request #668: CB-12239 (windows) Add documentation about b...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/668 CB-12239 (windows) Add documentation about build flags for Windows ### Platforms affected Windows ### What does this PR do? Documents use

[GitHub] cordova-windows issue #217: CB-12239 Add buildFlag option similar to iOS

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/217 @TimBarham, @alsorokin, @daserge, could you please take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-windows pull request #217: CB-12239 Add buildFlag option similar to ...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/217 CB-12239 Add buildFlag option similar to iOS ### What does this PR do? This PR adds `buildFlag` CLI argument and corresponding option for `build.json` file

Re: [DISCUSS] EOL cordova-medic

Hey all! I’m +1 for killing Medic, since it hasn’t been used for months and I guess hardly ever will be used in the future. Though I have a bit different proposal about moving configs – IMO they are a part of CI and should live somewhere inside a CI. I don’t think there is a need to either

[GitHub] cordova-cli pull request #265: CB-12018 : updated tests to function with jas...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/265#discussion_r92010506 --- Diff: package.json --- @@ -31,6 +31,7 @@ "cordova-common": "1.5.x", "cordova-lib": "

[GitHub] cordova-cli pull request #265: CB-12018 : updated tests to function with jas...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/265#discussion_r92009821 --- Diff: package.json --- @@ -11,7 +11,7 @@ "cordova": "./bin/cordova" }, "scripts&q

[GitHub] cordova-plugin-battery-status issue #46: CB-12227 (windows) Fixed Browserify...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/46 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: [DISCUSS] Plugins Release

Hi Shazron Gave you permissions to packages which I have access to. - Best regards, Vladimir On 12/12/16, 01:37, "Shazron" wrote: Hi Steve Gill and/or Carlos Santana -- please give me write access to these npm modules below. Publishing is stalled until I get

[GitHub] cordova-windows issue #212: CB-9287 Not enough Icons and Splashscreens for W...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/212 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89992916 --- Diff: template/cordova/lib/prepare.js --- @@ -297,48 +305,80 @@ function applyNavigationWhitelist(config, manifest

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89994632 --- Diff: template/cordova/lib/prepare.js --- @@ -439,6 +492,107 @@ function getUAPVersions(config

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89990562 --- Diff: cordova-js-src/splashscreen.js --- @@ -58,8 +58,45 @@ function readBoolFromCfg(preferenceName, defaultValue, cfg

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89991437 --- Diff: template/cordova/lib/prepare.js --- @@ -297,48 +305,80 @@ function applyNavigationWhitelist(config, manifest

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89993606 --- Diff: template/cordova/lib/prepare.js --- @@ -353,6 +391,13 @@ function mapImageResources(images, imagesDir

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89991151 --- Diff: template/cordova/lib/AppxManifest.js --- @@ -416,6 +417,18 @@ AppxManifest.prototype.getVisualElements = function

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89991524 --- Diff: template/cordova/lib/prepare.js --- @@ -297,48 +305,80 @@ function applyNavigationWhitelist(config, manifest

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89996388 --- Diff: template/cordova/lib/prepare.js --- @@ -439,6 +490,109 @@ function getUAPVersions(config

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89729105 --- Diff: template/cordova/lib/prepare.js --- @@ -353,6 +391,13 @@ function mapImageResources(images, imagesDir

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89726640 --- Diff: spec/unit/Prepare.Win10.spec.js --- @@ -541,4 +541,165 @@ describe('copyIcons method', function () { expect

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89726245 --- Diff: cordova-js-src/splashscreen.js --- @@ -58,8 +58,45 @@ function readBoolFromCfg(preferenceName, defaultValue, cfg

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89729119 --- Diff: template/cordova/lib/prepare.js --- @@ -362,7 +407,13 @@ function mapImageResources(images, imagesDir) { // find

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89729302 --- Diff: template/cordova/lib/prepare.js --- @@ -439,6 +490,109 @@ function getUAPVersions(config

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89727836 --- Diff: template/cordova/lib/prepare.js --- @@ -297,48 +305,78 @@ function applyNavigationWhitelist(config, manifest

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89726251 --- Diff: cordova-js-src/confighelper.js --- @@ -22,16 +22,17 @@ // config.xml wrapper (non-node ConfigParser analogue) var config

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89729637 --- Diff: template/cordova/lib/prepare.js --- @@ -439,6 +490,109 @@ function getUAPVersions(config

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89739598 --- Diff: template/cordova/lib/prepare.js --- @@ -439,6 +490,109 @@ function getUAPVersions(config

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89727040 --- Diff: template/CordovaApp.Phone.jsproj --- @@ -79,7 +79,9 @@ Designer - + --- End

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89739874 --- Diff: template/cordova/lib/prepare.js --- @@ -439,6 +490,109 @@ function getUAPVersions(config

Re: Windows platform refactoring

risingj.com On Thu, Nov 17, 2016 at 6:30 AM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > Hey all > > Just FUI, we're done some refactoring that aims to move some > windows-specific logic (in particular, applying changes to >

RE: [DISCUSS] Split cordova-lib modules into their own repos

+1 -Original Message- From: Filip Maj [mailto:maj@gmail.com] Sent: Wednesday, November 23, 2016 9:12 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Split cordova-lib modules into their own repos +1 On Tue, Nov 22, 2016 at 9:33 PM, Darryl Pogue wrote: > On

[GitHub] cordova-windows issue #207: CB-12142: Move windows-specific logic from cordo...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/207 Looks good. Let's wait for tomorrow and merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Windows platform refactoring

Hey all Just FUI, we're done some refactoring that aims to move some windows-specific logic (in particular, applying changes to appxmanifests files) out of cordova-common into cordova-windows. I hope this would simplify maintenance of both cordova-common and cordova-windows in future Just in

[GitHub] cordova-plugin-network-information issue #51: CB-11230 CB-11505 iOS: Add com...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-network-information/pull/51 Merging, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-network-information issue #51: CB-11230 CB-11505 iOS: Add com...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-network-information/pull/51 @shazron, could you take a look please? This PR just aligns curent implementation for `CDVReachability` with latest Apple's changes. In particular it removes

[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87808967 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,150 @@ +var semver = require('semver'); +var CommonPluginInfo = require

[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87807973 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,150 @@ +var semver = require('semver'); +var CommonPluginInfo = require

[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87810709 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,150 @@ +var semver = require('semver'); +var CommonPluginInfo = require

[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87809002 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,150 @@ +var semver = require('semver'); +var CommonPluginInfo = require

[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87810296 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,150 @@ +var semver = require('semver'); +var CommonPluginInfo = require

[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87809027 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,150 @@ +var semver = require('semver'); +var CommonPluginInfo = require

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87751813 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,109 @@ +var semver = require('semver'); +var CommonPluginInfo = require

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87752512 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,109 @@ +var semver = require('semver'); +var CommonPluginInfo = require

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87752779 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,109 @@ +var semver = require('semver'); +var CommonPluginInfo = require

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87751321 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,109 @@ +var semver = require('semver'); +var CommonPluginInfo = require

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87752877 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,109 @@ +var semver = require('semver'); +var CommonPluginInfo = require

  1   2   3   4   5   6   7   8   9   10   >