Done. Thanks for the feedback!
On Nov 13, 2013, at 2:59 PM, Joe Bowser wrote:
> Looks fine! Ship it!
Looks fine! Ship it!
On Wed, Nov 13, 2013 at 11:47 AM, Marcel Kinard wrote:
> Joe, how does this look?
> https://github.com/cmarcelk/cordova-android/commit/88cb3e8d2ea0bc38a8dfa1eb124e943cc225e335
>
> On Nov 13, 2013, at 1:57 PM, Joe Bowser wrote:
>
>> The removal should be just in JS. I'm OK w
Joe, how does this look?
https://github.com/cmarcelk/cordova-android/commit/88cb3e8d2ea0bc38a8dfa1eb124e943cc225e335
On Nov 13, 2013, at 1:57 PM, Joe Bowser wrote:
> The removal should be just in JS. I'm OK with that.
The removal should be just in JS. I'm OK with that.
On Wed, Nov 13, 2013 at 10:53 AM, Marcel Kinard wrote:
> Yes, manually invoking plugman locally to install the device plugin into the
> test app is a cleaner way of doing that, IMHO. But does that also mean that
> there should be a number of
Yes, manually invoking plugman locally to install the device plugin into the
test app is a cleaner way of doing that, IMHO. But does that also mean that
there should be a number of .gitignore entries in cordova-android/test so that
the after-effects of running plugman don't encourage folks to ch
How about we remove the reliance on Device from these tests?
On Tue, Nov 12, 2013 at 5:36 PM, Joe Bowser wrote:
> Hey
>
> I saw a recent commit on the Android repository removing what I left
> in the test directory. While I agree that this probably shouldn't
> have certain attributes because t
Hey
I saw a recent commit on the Android repository removing what I left
in the test directory. While I agree that this probably shouldn't
have certain attributes because they're stale, I think that we should
use plugman to install the plugins, because in this case I don't have
my plugins install
