Then I will start the release process without further changes or PRs merged
this evening (in about 12 hours).
> While it would be ideal to get this fixed, ideally by migrating to GitHub
actions, probably not worth holding up the release.
Good point. Let's get this release out and fix CI
To be clear, I would definitely not favor blocking this release. Thanks
again.
On Mon, Jun 8, 2020 at 8:12 AM Chris Brody wrote:
> While it would be ideal to get this fixed, ideally by migrating to GitHub
> actions, probably not worth holding up the release.
>
> Thanks for your work on this.
>
While it would be ideal to get this fixed, ideally by migrating to GitHub
actions, probably not worth holding up the release.
Thanks for your work on this.
On Mon, Jun 8, 2020 at 3:19 AM Niklas Merz wrote:
> The master branch is now ready for release.
>
> While trying to get another PR in, I
The master branch is now ready for release.
While trying to get another PR in, I noticed that Travis CI is using an
old version of cordova-ios (5.1.1) and Xcode 10. I tried to update that
with partial success:
https://github.com/apache/cordova-plugin-inappbrowser/pull/717 Has
anybody an idea how
As far as I know, the versions are the minimum required to work, not the
minimum supported by the plugin.
But yeah, ideally we could set all of them to recent versions to make sure
people don't use them in very old versions.
For the record, not all plugins have engines or some have but not for
The whole motivation behind adding the minimum Cordova engine version, in
the first place, seems to be here:
https://github.com/apache/cordova-plugin-inappbrowser/blob/master/plugin.xml#L33
It says "Needs cordova/urlutil".
I think we do not specify the minimum Cordova engine version on most of
Correct me if I am wrong, but I don't think we want to update the
dependency versions to the current ones. It's just another version we
have to track and update.
I must say I don't really know what they are for and would love to learn
about that.
The PR updates them to be consistent and working
I would favor updating the minimum Cordova requirement in both package.json
and plugin.xml, as I just commented in PR #685. I wish I would have seen it
before PR #685 was merged.
On Thu, Jun 4, 2020 at 10:59 AM Niklas Merz wrote:
> I merged two outstanding patches just now.
>
> If no reviews
I merged two outstanding patches just now.
If no reviews or concern come up, I will start the release in a few hours.
June 2, 2020 8:31 PM, "Niklas Merz" wrote:
> Hi all,
>
> since cordova-ios 6.0 was released recently the inappbrowser plugin does not
> work properly because
> of the
Hi all,
since cordova-ios 6.0 was released recently the inappbrowser plugin does not
work properly because of the removal of UIWebView. I would suggest we do a
plugin *release as soon as possible*.
Since we already merged some major changes (including the UIWebview removal)
this will be a
10 matches
Mail list logo
