Re: [DISCUSS] cordova-ios patch release

2023-04-12 Thread julio cesar sanchez
This fix should also be included https://github.com/apache/cordova-ios/pull/1255 And since it's going to be a minor release, we should probably include all the features too. I, as a user, would find it very confusing that issues that have been marked as "fixed" years ago, are not included in the

Re: [DISCUSS] cordova-ios patch release

2023-04-12 Thread Niklas Merz
Thank you all for the feedback. I agree that the small release should be 6.3.0 and I would prefer to keep this release small with the discussed changes cherry-picked: 1. feat: set webView.inspectable to true for Debug builds on iOS >= 16.4 2. (ios) fix: workaround for DisallowOverscroll on iOS

Re: [DISCUSS] cordova-ios patch release

2023-04-11 Thread Chris Brody
As a counterpoint I would propose just releasing what we have as 7.0.0. This would get all of our existing work into developer's hands and reduce the number of things that could be issues coming in from the field. I think this would be more agile and more consistent with the modern philosophy of

Re: [DISCUSS] cordova-ios patch release

2023-04-11 Thread Darryl Pogue
On Tue, Apr 11, 2023 at 10:08 AM Norman Breau wrote: > > I also want to point out (as we ran into issues cherry-picking and > testing locally against our apps) > that dpogue's PR for NodeJS 18 support won't be cherry-picked easily as > the function > being changed has been renamed at >

Re: [DISCUSS] cordova-ios patch release

2023-04-11 Thread Norman Breau
I also want to point out (as we ran into issues cherry-picking and testing locally against our apps) that dpogue's PR for NodeJS 18 support won't be cherry-picked easily as the function being changed has been renamed at

Re: [DISCUSS] cordova-ios patch release

2023-04-11 Thread Norman Breau
I agree that 7.0.0 isn't necessary ready yet. I think we have some plumbing to do and see if there are other issues that warrants introducing further breaking changes and such. I also think we should have a (separate) discussion on if minimum deployment target 11 should be kept around for 7.x

Re: [DISCUSS] cordova-ios patch release

2023-04-11 Thread Niklas Merz
I could also do this as a patch release, then. The goal of this release is to just get debugging possible again and fix NodeJS 18 with these two PRs. I think the major release is not quite ready. But correct me if I'm wrong. There is some stuff to do and review. What do you think? On April 11,

Re: [DISCUSS] cordova-ios patch release

2023-04-11 Thread julio cesar sanchez
Can’t we do a major release? Last release was over two years ago and I think we have a lot more fixes and features than just the inspector fix, that would benefit users. If not, it should be a minor release, not a patch release, since the inspector fix is actually a feature. El martes, 11 de

[DISCUSS] cordova-ios patch release

2023-04-11 Thread Niklas Merz
Does anyone have any reason to delay a path release with iOS and NodeJS related fixes release? Any outstanding patches to land? If not, I will start the in the upcoming days. I would merge this PR [1] and use the 6.2.x [2] branch with the WebView [3] inspect fix. [1]