[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

2016-03-19 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-android/pull/273#issuecomment-197348065 @dpolivy, I've sent #276 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

2016-03-19 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-android/pull/273#issuecomment-197424352 @daserge Thanks! I will close this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

2016-03-19 Thread dpolivy
Github user dpolivy closed the pull request at: https://github.com/apache/cordova-android/pull/273 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

2016-03-18 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/273#issuecomment-197413662 I like #276 better, can you guys pop over, give it a look and comment on that? Thanks! --- If your project is set up for it, you can reply to this email and h

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

2016-03-15 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-android/pull/273#issuecomment-197005575 @daserge That makes sense; in the case where a release build is built, but not automatically signed as part of the process, I can see that run would not pick up

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

2016-03-14 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-android/pull/273#issuecomment-196445988 I've tested this way: - `created project, added master android platform` - `λ cordova run android --release` -> ``` Built the following apk(s):

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

2016-03-14 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-android/pull/273#issuecomment-196426128 @daserge Thanks for looking at this. What's the exact cmd line you're using that generates that error? Is that due to the change I made? It seems like in that c

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

2016-03-12 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-android/pull/273#issuecomment-195769121 Tested - master version works with both `--buildConfig` and `-- --keystore`. With this PR the CLI outputs the following: ``` BUILD SUCCESSFUL

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

2016-03-10 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/273#issuecomment-195215718 @daserge Can you please review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

2016-03-10 Thread dpolivy
GitHub user dpolivy opened a pull request: https://github.com/apache/cordova-android/pull/273 [CB-10600] 'cordova run --release' uses wrong apk When doing `cordova run android --release`, the CLI attempts to use the android-release-unsigned.apk, which naturally fails to install o