Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-155621633
I am closing this PR and have submitted a new proposal that incorporates
feedback in #239
---
If your project is set up for it, you can reply to this email an
Github user riknoll closed the pull request at:
https://github.com/apache/cordova-android/pull/236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-154590431
After getting some feedback from @purplecabbage on the dev list and talking
this over with @jasongin, it sounds as though we should cut everything from
this res
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-154566865
So in terms of a common API across platforms, what part are we looking at
generalizing? Obviously we should ensure that each platform properly fires its
pause a
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-152049507
@riknoll As for cordova.js changes you can follow the instructions here:
https://github.com/apache/cordova-js to generate a cordova.js. We generate the
file a
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-152032481
Windows apps also have to deal with saving and restoring state like this in
at least some cases. See [MSDN - Guidelines for app suspend and
resume](https://msd
Github user imhotep commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-152031010
I believe iOS also has the same issue when transitioning from UIWebView to
other native views (although I don't believe app crashes) so I vote for having
a comm
chard
-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com]
Sent: Wednesday, October 28, 2015 2:49 PM
To: dev@cordova.apache.org
Subject: Re: [GitHub] cordova-android pull request: API for saving/restoring
plugin and ...
This sounds really good!
The only reservation I have
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-152026095
I am using a Nexus 6 with Marshmallow. Did you update cordova.js? I didn't
check it in to the PR because I was unsure of what the protocol was since it's
a bui
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-152024614
I turned on "Don't keep activities" on both a Moto E (Android 4.4.1) and a
Samsung Galaxy S6 Edge (Android 5.1) to test this, and I'm not able to actually
get
This sounds really good!
The only reservation I have is making a new non-standard way of saving
state in js.
Instead of providing navigator.app.saveState() I think we should be content
to simply raise the event, and allow the app developer to choose how they
wish to store it. The obvious choice w
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-151986714
Here's an example index.js and index.html:
https://gist.github.com/riknoll/94a40dc147040191fd3e
For anyone hoping to test it out, make sure you check "D
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-151975164
Camera code is here:
https://github.com/MSOpenTech/cordova-plugin-camera/tree/save-state
---
If your project is set up for it, you can reply to this email and
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-151972235
Sure, I'll push the camera branch and work on a good sample app
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Bnaya commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-151969621
Looks like good a solution,
I think you need to also guarantee that handlers registered before you
fired the resume event will get it, as it with device ready
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-151959575
Can we get an updated Camera plugin branch with the same branch name so
that we can work off the same code? Also, an example app for this may be a
good idea a
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-151959078
@infil00p @nikhilkh please review. I was also unsure of how to handle
cordova.js; do we commit that for every js change? I did not update it in my pr.
---
If y
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-android/pull/236
API for saving/restoring plugin and js state
Here is my proposal for dealing with Activity destruction in Android. The
code is still a little rough and might need to be finalized, but I wan
18 matches
Mail list logo
