Github user sarangan12 closed the pull request at:
https://github.com/apache/cordova-docs/pull/465
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/465#issuecomment-176604608
Closing the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/465#issuecomment-176529249
LGTM - merging this one. @sarangan12 for future - please consider squashing
commits before we attempt to merge. I will do the squashing now.
---
If your project
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/465#issuecomment-176550181
Merged with e7bfcca11b6e50368cd5ee4427e3d71131b99b10. Please close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/465#issuecomment-175877188
@dblotsky Addressed the previous comments. I have shortened as much
possible and removed irrelevant information. Once the other docs such as the
Tutorial/guide
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50899388
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -45,39 +43,56 @@ Use Apache Cordova if you are:
device-level APIs, or if you want to
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50899406
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -45,39 +43,56 @@ Use Apache Cordova if you are:
device-level APIs, or if you want to
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50899450
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -45,39 +43,56 @@ Use Apache Cordova if you are:
device-level APIs, or if you want to
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/465#issuecomment-175315549
LGTM. Though I'm not well versed with the CSS structure to comment on the
h2 change.
---
If your project is set up for it, you can reply to this email and have
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50927949
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -27,9 +27,7 @@ to use standard web technologies such as HTML5, CSS3, and
JavaScript
for
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50928062
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -27,9 +27,7 @@ to use standard web technologies such as HTML5, CSS3, and
JavaScript
for
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50928163
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -45,39 +43,55 @@ Use Apache Cordova if you are:
device-level APIs, or if you want to
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50928694
--- Diff: www/static/css-src/main.scss ---
@@ -149,7 +149,6 @@ h1 {
}
h2 {
color: $gray-50;
-font-size: 18px;
--- End
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/465#issuecomment-175325394
1. In general, should we be using first-person or third-person voice in the
docs? I realised halfway through the review that some pages use both, and it
would be
Github user RobPosener commented on the pull request:
https://github.com/apache/cordova-docs/pull/465#issuecomment-175359061
1. First-person is preferred.
2. What is the purpose of the Overview page?
a) Introduce new developers to Cordova?
b) Quick reference/TOC for
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50803037
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -45,39 +43,56 @@ Use Apache Cordova if you are:
device-level APIs, or if you want to
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50796924
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -45,39 +43,56 @@ Use Apache Cordova if you are:
device-level APIs, or if you want to
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50803345
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -45,39 +43,56 @@ Use Apache Cordova if you are:
device-level APIs, or if you want to
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50803151
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -45,39 +43,56 @@ Use Apache Cordova if you are:
device-level APIs, or if you want to
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/465#issuecomment-174881537
For future, consider splitting PRs - a PR should typically address 1
JIRA/issue
---
If your project is set up for it, you can reply to this email and have your
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50802820
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -45,39 +43,56 @@ Use Apache Cordova if you are:
device-level APIs, or if you want to
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50783365
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -45,39 +43,56 @@ Use Apache Cordova if you are:
device-level APIs, or if you want to
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50784016
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -45,39 +43,56 @@ Use Apache Cordova if you are:
device-level APIs, or if you want to
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50784050
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -45,39 +43,56 @@ Use Apache Cordova if you are:
device-level APIs, or if you want to
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50783262
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -45,39 +43,56 @@ Use Apache Cordova if you are:
device-level APIs, or if you want to
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50783200
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -45,39 +43,56 @@ Use Apache Cordova if you are:
device-level APIs, or if you want to
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-docs/pull/465
CB-10331 & CB-10436 - Improving Overview Page and fixing the Heading h2 size
This PR consists of changes for 2 JIRAs.
1. Improving the Overview page
2. h2 size is smaller than
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/465#discussion_r50783466
--- Diff: www/docs/en/dev/guide/overview/index.md ---
@@ -45,39 +43,56 @@ Use Apache Cordova if you are:
device-level APIs, or if you want to
28 matches
Mail list logo
