Github user khawkins commented on the issue:
https://github.com/apache/cordova-ios/pull/289
@shazron Is this something you could take a look at, and/or mention anyone
else who might be interested? Cc: @sgoldberg-sfdc @bhariharan
---
If your project is set up for it, you can reply to
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/289
This all seems sound (and seems parallel to any existing code) but I have a
few clarifying questions:
1) The current CocoaPods support is for integrating CocoaPods libraries
into an existing
Github user khawkins commented on the issue:
https://github.com/apache/cordova-ios/pull/289
You are correct: the support added here would only enable the consumption
of the Cordova iOS dependency itself from Carthage, at this point. Or maybe
more accurately, it's the first step in en
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/289
Thanks Kevin - this is a good building block anyways, in a bigger puzzle --
we'll punt that problem off for later. I'll pull this in after I get some time
to review it further.
---
If your pro
Github user khawkins commented on the issue:
https://github.com/apache/cordova-ios/pull/289
Thanks for the review, @shazron . I've made your suggested changes, and
all tests are passing through `npm test`.
---
If your project is set up for it, you can reply to this email and have yo
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/289
Thanks @khawkins - unfortunately when I pulled other PRs in, this has
caused some conflicts. Can you rebase and resolve? Sorry about this.
---
If your project is set up for it, you can reply t
Github user khawkins commented on the issue:
https://github.com/apache/cordova-ios/pull/289
No worries @shazron ! Question: I see that
2a323fad2156a434e928eb570e7f272921b75d6a moved the iOS deployment target up to
9.0. I presume I should amend the framework target to do the same? I
Github user khawkins commented on the issue:
https://github.com/apache/cordova-ios/pull/289
Actually, I end up seeing a ton of warnings now complaining about the fact
that I didn't otherwise do that, so that probably answers my question. ð
I'll have the update pushed shortly.
--
Github user khawkins commented on the issue:
https://github.com/apache/cordova-ios/pull/289
Okay @shazron , I've rebased and updated the deployment target of the
framework to 9.0. All tests are passing. Let me know if you'd like me to
squash these review commits down.
---
If your
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/289
Thanks @khawkins ! I'll let the CI run, then merge these in. No worries, I
can squash on my end
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
10 matches
Mail list logo
